Changesets: Import 2017-06-07 23:51:09

master eeb7c0ea

2015-10-30 10:03:51

jcfr

Details Diff
COMP: Fix WrapITK.pth path on windows

This error only happens with the option Slicer_USE_ITKPython enabled.

The WrapITK path isn't taking in consideration the multi-configuration
style for windows. Adding the CMAKE_CFG_INTDIR variable fixes this.

Since on other single configuration generators (like make) the variable
reduces to ".", we can simply interject it where needed.


Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Johan Andruejol <johan.andruejol@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24679 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_ITKv4.cmake Diff File

master 457e1182

2015-10-30 09:38:18

jcfr

Details Diff
COMP: Fix build "ambiguous call to abs()" error.

This commit fixes error reported on the Linux factory by reverting
r24671 (COMP: Consistently use std::abs to avoid implicit integer
truncations)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24678 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/ExtractSkeleton/SkelGraph.cxx Diff File
mod - Modules/Scripted/EditorLib/Logic/vtkImageFillROI.cxx Diff File
mod - Modules/Scripted/EditorLib/Logic/vtkImageSlicePaint.cxx Diff File

master f240d746

2015-10-29 18:23:28

jcfr

Details Diff
COMP: Fix DiffusionWeightedVolumeMaskingTest linker error

Changes in r24673 [1] cause a linker error when building
DiffusionWeightedVolumeMaskingTest in Visual Studio 2013:

1>------ Build started: Project: DiffusionWeightedVolumeMaskingTest, Configuration: Debug x64 ------
1>DiffusionWeightedVolumeMaskingTest.obj : error LNK2019: unresolved external symbol __imp_ModuleEntryPoint referenced in function "void __cdecl RegisterTests(void)" (?RegisterTests@@YAXXZ)
1>C:\dev\SD\Slicer-build\bin\Debug\DiffusionWeightedVolumeMaskingTest.exe : fatal error LNK1120: 1 unresolved externals

This commit reverts some of the changes to make the test build and run.

[1] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24673

From: Max Smolens <max.smolens@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24677 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/DiffusionWeightedVolumeMasking/Testing/CMakeLists.txt Diff File
mod - Modules/CLI/DiffusionWeightedVolumeMasking/Testing/DiffusionWeightedVolumeMaskingTest.cxx Diff File

master e2a13021

2015-10-29 03:13:19

jcfr

Details Diff
ENH: Add test for vtkMRMLDoubleArrayStorageNode reader/writer

Tests the new writer/reader as well as the reader given the
old writer convention which was assuming labels were always set.

From: Alexis Girault <alexis.girault@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24676 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/CMakeLists.txt Diff File
add - Libs/MRML/Core/Testing/TestData/vtkMRMLDoubleArrayNodeTest1_OldFile.mcsv Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDoubleArrayNodeTest1.cxx Diff File

master 48a19e80

2015-10-29 03:09:23

jcfr

Details Diff
BUG: Fix support for missing labels in vtkMRMLDoubleArrayStorage reader

The reader in vtkMRMLDoubleArrayStorage was always setting the
first line of values in the .mcsv file as labels. If the stored
vtkMRMLDoubleArray had not labels set, then the retrieved double
array labels would be set to the first line of numerical values,
associated with the first data point. This resulted in a missing
data point as well as shifted indices for all remaining points,
and incorrect labels.

The correction this commit offers is to write the line '# nolabels'
in the file if labels exist. If the reader finds this line, it will
set the first line of values as the first data point, instead of
setting it as label values.

Examples :

Here are four examples with (u,v,w) as labels, (12.1,425.577,-454)
for the first data point, and (8.79633e+09,0,-1) for the second one:

(1) New writer: vtkMRMLDoubleArrayNode with labels

# measurement file filename.mcsv
u,v,w
12.1,425.577,-454
8.79633e+09,0,-1

(2) New writer: vtkMRMLDoubleArrayNode with no labels set

# measurement file filename.mcsv
# nolabels
12.1,425.577,-454
8.79633e+09,0,-1

(3) Old writer: vtkMRMLDoubleArrayNode with labels

# measurement file filename.mcsv
# columns = x,y,yerr
u,v,w
12.1,425.577,-454
8.79633e+09,0,-1

(4) Old writer: vtkMRMLDoubleArrayNode with no labels set

# measurement file filename.mcsv
# columns = x,y,yerr
12.1,425.577,-454
8.79633e+09,0,-1

Observations :

The line '# columns = x,y,yerr' was hardcoded [1] in the former
writer and had no meaning related to the actual double array
node labels. The inspiration problably came from .mcsv or .acsv
writers/readers [2][3] but had no effect here.

[1] https://github.com/Slicer/Slicer/blob/6e63b4bf5dbc65a9973160de7397dfc47882e038/Libs/MRML/Core/vtkMRMLDoubleArrayStorageNode.cxx#L244
[2] https://github.com/Slicer/Slicer/blob/master/Modules/Loadable/Markups/MRML/vtkMRMLMarkupsFiducialStorageNode.cxx#L159-L185
[3] https://github.com/Slicer/Slicer/blob/master/Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationFiducialsStorageNode.cxx#L245-L268

From: Alexis Girault <alexis.girault@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24675 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDoubleArrayStorageNode.cxx Diff File

master 23851258

2015-10-29 02:53:27

jcfr

Details Diff
ENH: Update SimpleITK: Use SuperBuild scripts for additional dependencies.

Configure with SimpleITK's Superbuild CMake file, to allow additional
dependencies to be build. This is done by adding a second external
project just for the download step, so that the configuration can be
done in the Superbuild sub-directory as the source directory.

$ git shortlog --no-merges 4531702..6f184

Bradley Lowekamp (72):
Updating version for 0.10.0 development
Update SimpleITKExamples version
Adding SimpleITK 0.9.0 Download URLs to doxygen
Improve exception when unable to create ImageIO
GetGitRevisionDescription: Fix issue referencing project source
Replace tabs with spaces.
Adding ITK version information to the SimpleITK version info.
Update PCRE to 9.37 in Superbuild
WIP: Adding local transform fixes
Using local static for itk version string
Adding forbid download CMake option
Forbid downloading data with option
ADD SITK_PYTHON_USE_VIRTUAL_ENV option
Create separate source and data tar-balls for distribution.
Fix checking SimpleITK source directory for External data file
Add CMake find package module for the Lua interpreter.
Use SITK_LUA_EXECUTABLE for code generation
Use CMake find_package for finding Lua libraries and include
Add Lua Superbuild support
Pass all variable beginning with SITK_ to the SimpleITK build.
Removing integrated lua source code
Add Superbuild of GoogleTest
Use find_package for google test
Remove anonymous namespace for std::vector output operator.
Remove the GTest source code from testing
Adding ObjectCount measurement to ConnectedComponents filter
Use CMAKE_POSITION_INDEPENDENT_CODE property over compiler flag
Replace superbuild fPIC with CMake property for ITK.
Remove adding fPIC flag in language options.
Add CMake variable to specify additional lua libraries
Add unsigned int specifier
Mark GTest superbuild options as advanced
Mark additional Lua variables as advanced
Correct variable name SimpleITK_VARS
Adding CMake upstream FindGTest.cmake
Fix Superbuild variable
Install GTest with MSVC in expected directory
Install MSVC into lib directory with out prefix
Disable GTest using TR1::tuple with VS11
Fix CMake syntactical errors in GTest Superbuild
Remove quotes around ep_extra_args
Fix CMake equals syntax.
More CMake fixes
Add support to join 3d image series into 4d image
Update ITK superbuild version to 4.8 release
COMP: Fix JoinSeries with 4DImage test
Add support to extract 3d image from 4d.
Require libraries when a wrapping for a language is enabled
Update shape statistics to always use int64_t for labelmap type.
Fix finding lua executable when not explicitly set.
Adding wrapping for LabelIntensityStatisticsImageFilter
Change default of SimpleITK_PYTHON_THREADS to ON
Update SWIG to 3.0.7
Address warnings with signed integer comparison
Updating ITK v4.8 along release branch
Do not pass unneeded language arguments on the command line
add CastImageFilter to support output writing
Do not force CMAKE_INSTALL_PREFIX if already set.
Don't pass SITK_REQUIRED_ITK_MODULES in Superbuild
Move CMake file to CMake directory
WIP: Adding local transform fixes
Adding ObjectCount measurement to ConnectedComponents filter
Add unsigned int specifier
Require libraries when a wrapping for a language is enabled
Do not pass unneeded language arguments on the command line
Updating ITK superbuild towards v4.8.1 pending release
Add missing Java variables to the language options files
Update ITK superbuild to 4.8.1 release
Updating SimpleITK to 0.9.1 version for release
Add md5 to URL for check sum
Update Python download URLs to use https
Adding 0.9.1 release eggs to download page

Dave Chen (2):
Regenerated the .i files
Regenerated the .i files

David T. Chen (7):
Regenerate filters.csv for SimpleITK 0.9.0
Re-regenerated filters.csv
Fix leading space problem in doxy2swig.py
Updated space_parse with a noLeadingSpace flag
Rewrite Show to support Fiji
Fix leading space problem in doxy2swig.py
Updated space_parse with a noLeadingSpace flag

Ziv Yaniv (2):
STYLE: change SetOptimizerAsLBFGSB parameter name to match other
methods.
Modified example to match parameter name change in SetOptimizerAsLBFGSB.

Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24674 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_SimpleITK.cmake Diff File

master d65f2de9

2015-10-29 00:15:41

jcfr

Details Diff
BUG: Fix DiffusionWeightedVolumeMasking module and add test. See 0003855

The updated line calculates the magnitude of each gradient, and
determines that an image is "baseline" if the magnitude is smaller than
a threshold.

The use of "abs()" on double values caused the magnitude to
always be 0, and therefore all images were considered as "baseline" and
included in the average computed by the filter and presented as "Output
baseline volume" to the user.

This commit fixes the incorrect logic using "fabs()", simplifies the test
case removing the use of "--removeislands", updates the test harness to use
"compare" functions to validate the output of the module against baseline
images.

Note that the "--removeislands" should be tested in a separate test case.

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Orjan Bergmann <orjan.bergmann@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24673 3bd1e089-480b-0410-8dfb-8563597acbee
add - Modules/CLI/DiffusionWeightedVolumeMasking/Data/Baseline/DiffusionWeightedVolumeMaskingTest_EstimatedBaseline.nhdr Diff File
add - Modules/CLI/DiffusionWeightedVolumeMasking/Data/Baseline/DiffusionWeightedVolumeMaskingTest_EstimatedBaseline.raw.gz Diff File
add - Modules/CLI/DiffusionWeightedVolumeMasking/Data/Baseline/DiffusionWeightedVolumeMaskingTest_OtsuThresholdMask.nhdr Diff File
add - Modules/CLI/DiffusionWeightedVolumeMasking/Data/Baseline/DiffusionWeightedVolumeMaskingTest_OtsuThresholdMask.raw.gz Diff File
mod - Modules/CLI/DiffusionWeightedVolumeMasking/DiffusionWeightedVolumeMasking.cxx Diff File
mod - Modules/CLI/DiffusionWeightedVolumeMasking/Testing/CMakeLists.txt Diff File
mod - Modules/CLI/DiffusionWeightedVolumeMasking/Testing/DiffusionWeightedVolumeMaskingTest.cxx Diff File

master 482471ad

2015-10-28 21:54:52

jcfr

Details Diff
STYLE: Remove unused code related to now disabled ITKv3 compatibility mode

Reviewing changes introduced in r24669 (COMP: Add ITK_OVERRIDE
designations for C++11) also identified some now dead code that
was used to override a parent class method when ITKv3 compatibility
was enabled. Considering that ITKv3_COMPATIBILITY is disabled since
r23960 (ENH: Disable ITKv3 compatibility to enable 64-bit ids on
windows), this commit removes the code that was initially introduced
in r17784 (ENH: Transform classes compatible with ITKv[34])

Note that the code associated with itkAnisotropicSimilarity3DTransformTest
is now broken. Since it is not compiled and is associated with a module
in the legacy category, a comment has been added to provide hint.

Finally, note that all tests associated with ResampleDTI and
ExpertAutomatedRegistration modules are passing:

$ ctest -L ExpertAutomated
Test project /home/jcfr/Projects/Slicer-Debug/Slicer-build
Start 494: ExpertAutomatedRegistrationTestDataFixed
1/5 Test 0000494: ExpertAutomatedRegistrationTestDataFixed ....... Passed 0.17 sec
Start 495: ExpertAutomatedRegistrationTestDataRigidArgs
2/5 Test 0000495: ExpertAutomatedRegistrationTestDataRigidArgs ... Passed 0.15 sec
Start 496: ExpertAutomatedRegistrationTestDataRigid
3/5 Test 0000496: ExpertAutomatedRegistrationTestDataRigid ....... Passed 0.20 sec
Start 497: ExpertAutomatedRegistrationTestDataAffine
4/5 Test 0000497: ExpertAutomatedRegistrationTestDataAffine ...... Passed 0.19 sec
Start 498: ExpertAutomatedRegistrationTestDataBSpline
5/5 Test 0000498: ExpertAutomatedRegistrationTestDataBSpline ..... Passed 0.90 sec

100% tests passed, 0 tests failed out of 5

Label Time Summary:
ExpertAutomatedRegistration = 1.61 sec

Total Test time (real) = 1.67 sec

$ ctest -L ResampleDTI
Test project /home/jcfr/Projects/Slicer-Debug/Slicer-build
Start 470: ResampleDTIVolumeRotationNNTest
1/7 Test 0000470: ResampleDTIVolumeRotationNNTest ............... Passed 1.02 sec
Start 471: ResampleDTIVolume2RigidTransformsLinearTest
2/7 Test 0000471: ResampleDTIVolume2RigidTransformsLinearTest ... Passed 0.91 sec
Start 472: ResampleDTIVolumeBSplineWSInterpolationTest
3/7 Test 0000472: ResampleDTIVolumeBSplineWSInterpolationTest ... Passed 10.66 sec
Start 473: ResampleDTIVolumeBSplineInterpolationTest
4/7 Test 0000473: ResampleDTIVolumeBSplineInterpolationTest ..... Passed 1.90 sec
Start 474: ResampleDTIVolumeHFieldTest
5/7 Test 0000474: ResampleDTIVolumeHFieldTest ................... Passed 3.14 sec
Start 475: itkTestMainExtendedScalarTest
6/7 Test 0000475: itkTestMainExtendedScalarTest ................. Passed 1.24 sec
Start 476: itkTestMainExtendedFailedTest
7/7 Test 0000476: itkTestMainExtendedFailedTest ................. Passed 1.66 sec

100% tests passed, 0 tests failed out of 7

Label Time Summary:
ResampleDTIVolume = 20.54 sec

Total Test time (real) = 20.60 sec

Co-authored-by: Francois Budin <fbudin@unc.edu>
Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Hans Johnson <hans-johnson@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24672 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarity3DTransform.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarity3DTransform.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/itkAnisotropicSimilarity3DTransformTest.cxx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNonRigidTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNonRigidTransform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkWarpTransform3D.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkWarpTransform3D.txx Diff File

master 19c03077

2015-10-28 19:39:19

jcfr

Details Diff
COMP: Consistently use std::abs to avoid implicit integer truncations

Similarly to r24621 (BUG: Fix incorrect truncation to integer in
vtkSlicerTransformLogic), this commit applies the same fix to the entire
code base to avoid clang warnings of the following form:

Slicer/Base/Logic/vtkSlicerTransformLogic.cxx:718:59: warning: using integer absolute value function 'abs' when argument is of
floating point type [-Wabsolute-value]
rotateArrow->RotateX(vtkMath::DegreesFromRadians(acos(abs(sliceNormal_RAS[2]))));

Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Hans Johnson <hans-johnson@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24671 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/ExtractSkeleton/SkelGraph.cxx Diff File
mod - Modules/Scripted/EditorLib/Logic/vtkImageFillROI.cxx Diff File
mod - Modules/Scripted/EditorLib/Logic/vtkImageSlicePaint.cxx Diff File

master 104ef986

2015-10-28 19:12:35

jcfr

Details Diff
ENH: Generate high-resolution magnified screenshots for 3D view. See 0003885

See http://www.na-mic.org/Bug/view.php?id=3885

This commit updates the qMRMLScreenShotDialog to use the class
vtkRenderLargeImage now supporting gradient background since r24668
to do off screen magnified rendering (high resolution) of the 3D render
window when capturing screen shots.

A bug still remains for the 2D render windows in that they get tiled
by this method instead of scaled, so continue using the Qt after capture
scaling for the full view and the slice views.

Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Tested-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Nicole Aucoin <nicole@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24670 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Resources/UI/qMRMLScreenShotDialog.ui Diff File
mod - Libs/MRML/Widgets/qMRMLScreenShotDialog.cxx Diff File

master 3c57b78d

2015-10-28 17:27:32

jcfr

Details Diff
COMP: Add ITK_OVERRIDE designations for C++11

When supported (i.e. under C++11 compiler support),
use the override designation to ensure that virtual
functions have correct signature for overriding their
parent classes.

Reviewed-by: Matt McCormick <matt.mccormick@kitware.com>
Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Hans Johnson <hans-johnson@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24669 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkITKTransformInverse.h Diff File
mod - Libs/MRML/IDImageIO/itkMRMLIDImageIO.h Diff File
mod - Libs/MRML/IDImageIO/itkMRMLIDImageIOFactory.h Diff File
mod - Libs/vtkITK/itkGrowCutSegmentationImageFilter.h Diff File
mod - Libs/vtkITK/itkLevelTracingImageFilter.h Diff File
mod - Libs/vtkITK/itkLevelTracingImageFilter.txx Diff File
mod - Libs/vtkITK/itkNewOtsuThresholdImageCalculator.h Diff File
mod - Libs/vtkITK/itkNewOtsuThresholdImageFilter.h Diff File
mod - Libs/vtkITK/itkTimeSeriesDatabase.h Diff File
mod - Modules/CLI/CreateDICOMSeries/CreateDICOMSeries.cxx Diff File
mod - Modules/CLI/DWIJointRicianLMMSEFilter/itkComputeRestrictedHistogram.h Diff File
mod - Modules/CLI/DWIJointRicianLMMSEFilter/itkLMMSEVectorImageFilter.h Diff File
mod - Modules/CLI/DWIJointRicianLMMSEFilter/itkOtsuStatistics.h Diff File
mod - Modules/CLI/DWIJointRicianLMMSEFilter/itkOtsuThreshold.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkComputeRestrictedHistogram.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkComputeStatisticsWherePositiveFilter.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkExtractVolumeFilter.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkLMMSEVectorImageFilter.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkLMMSEVectorImageFilterStep.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkMaskedMeanImageFilter.h Diff File
mod - Modules/CLI/DWIUnbiasedNonLocalMeansFilter/itkComputeRestrictedHistogram.h Diff File
mod - Modules/CLI/DWIUnbiasedNonLocalMeansFilter/itkOtsuStatistics.h Diff File
mod - Modules/CLI/DWIUnbiasedNonLocalMeansFilter/itkOtsuThreshold.h Diff File
mod - Modules/CLI/DWIUnbiasedNonLocalMeansFilter/itkUNLMFilter.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAffineImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarity3DTransform.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarityLandmarkBasedTransformInitializer.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkBSplineImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkBSplineImageToImageRegistrationMethod.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageRegionMomentsCalculator.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageToImageRegistrationHelper.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkInitialImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkOptimizedImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkOptimizedImageToImageRegistrationMethod.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkRigidImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/N4ITKBiasFieldCorrection/N4ITKBiasFieldCorrection.cxx Diff File
mod - Modules/CLI/ResampleDTIVolume/Testing/itkDifferenceDiffusionTensor3DImageFilter.h Diff File
mod - Modules/CLI/ResampleDTIVolume/dtiprocessFiles/itkHFieldToDeformationFieldImageFilter.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DBSplineInterpolateImageFunction.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DFSAffineTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DLinearInterpolateFunction.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNearestNeighborInterpolateFunction.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNonRigidTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DPPDAffineTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DResample.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRigidTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DWindowedSincInterpolateImageFunction.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkSeparateComponentsOfADiffusionTensorImage.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkTransformDeformationFieldFilter.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkWarpTransform3D.h Diff File

master bf3f8506

2015-10-28 16:53:21

jcfr

Details Diff
BUG: Update VTK to fix snapshot scaling and VS2013 compilation warning

See http://www.na-mic.org/Bug/view.php?id=3885

$ git shortlog 716b0f5..d620f8f --no-merges
Max Smolens (2):
COMP: Fix HAVE_ROUND macro redefinition build warning on Visual Studio 2013
Fix rendering gradient background with vtkRenderLargeImage

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24668 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_VTKv6.cmake Diff File

master 03a598bb

2015-10-28 14:33:48

jcfr

Details Diff
BUG: ExtensionWizard: Fix "compare URL" generation

The extensionWizard now handles the creation of the "Compare URL" when someone
contributes an updated Extension Description File.

The issue appeared when using the ExtensionWizard as reported below:

$ bin/slicerExtensionWizard --contribute ~/src/Slicer-MyExtension/

The reported error was:

//------------
building compare URL for update failed to build
compare URL: 404 {u'documentation_url':
u'https://developer.github.com/v3/repos/commits/#compare-two-commits',
u'message': u'Not Found'}
//------------

Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Tested-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Jean-Baptiste VIMORT <jb.vimort@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24667 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Utilities/Scripts/SlicerWizard/ExtensionWizard.py Diff File

master d42d6c9e

2015-10-27 21:59:56

jcfr

Details Diff
BUG: Handle download/install error for extension dependencies.

The function downloadAndInstallExtension() did not handled the case of
downloadExtension() returning 0. This commit implements the same approach
as in scheduleExtensionForUpdate() to handle that case correctly in
downloadAndInstallExtension().

To avoid overwhelming the user with a lot of different messages when
some of all dependent extensions failed to download, error messages are
accumulated in a list and shown only outside the loop if it applies.

Reviewed-by: Andras Lasso <lasso@queensu.ca>
Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Francois Budin <fbudin@unc.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24666 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerExtensionsManagerModel.cxx Diff File
mod - Base/QTCore/qSlicerExtensionsManagerModel.h Diff File

master e2bd1ae5

2015-10-27 20:12:05

jcfr

Details Diff
BUG: Preserve custom color tables on scene view restore

Moving the color table information into files on disk created
a bug (analogous to the same situation with fiducials[1]) that when
a scene contains scene views that contain custom color tables
the scene view restore wipes out the colors in the color node
in the main scene. When a MRML file is read, the files on disk
are not reread to fill in scene view nodes, so the scene view
color table node is empty. This fix adds a check for if the
scene is currently restoring a scene view, and if so, don't
proceed with the copy as it will result in an color table
with the correct number of entries (as the number of colors is
saved in the MRML file) but all black and unamed.
Added a test to ensure that restoring scene views with changed
color table nodes doesn't result in a zeroed out color table,
nor a changed one (for this work around state)

[1] fiducials were fixed in this commit:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24376
https://github.com/Slicer/Slicer/commit/1440084bbdd9d11c1e9e1f195087f521a91af186

Issue 0003992

From: Nicole Aucoin <nicole@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24665 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLColorTableNode.cxx Diff File
mod - Modules/Loadable/Colors/Testing/Python/CMakeLists.txt Diff File
add - Modules/Loadable/Colors/Testing/Python/CustomColorTableSceneViewRestoreTestBug3992.py Diff File

master b304b93a

2015-10-27 11:40:32

fedorov

Details Diff
ENH: Update MultiVolumeImporter hash

* use logging for debug messages
* removed 'from __main__' from the plugin

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24664 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master a744cec3

2015-10-26 22:58:56

jcfr

Details Diff
BUG: Incorporate fix for failing MultiVolumeExplorer GUI test

Update the git tag for MultiVolumeExplorer to the version that
fixes the qSlicerMultiVolumeExplorerModuleWidgetGenericTest.

git shortlog c97e9d7b88abdd429b5410b5985d3fd03de851ec..9cd47306e7ee761072a07fef5ad1eaa7bb452816 --no-merges
Nicole Aucoin (1):
BUG: fix failing widget generic test due to size hint

From: Nicole Aucoin <nicole@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24663 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 35b96201

2015-10-25 21:52:20

jcfr

Details Diff
BUG: Fix CERTIFICATE_VERIFY_FAILED error using "urllib2.urlopen()" on MacOSX

See http://www.na-mic.org/Bug/view.php?id=4067

This commit ensures the "Slicer.crt" certificate is found when using
function like "urlib2.urlopen()" in the python interactor from an install
tree on MacOSX.

This is needed because on MacOSX the launcher is not used when the
application is installed.

Reported-by: Andriy Fedorov <fedorov@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24662 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerCoreApplication.cxx Diff File

master 09ddedda

2015-10-24 02:13:23

jcfr

Details Diff
ENH: Add python method cli.runSync(). See 0003600

See http://www.na-mic.org/Bug/view.php?id=3600

Suggested-by: Michael Halle <mhalle@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24661 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/cli.py Diff File

master 2b03bb51

2015-10-24 02:01:04

jcfr

Details Diff
COMP: Fix "enum-compare" warning in qMRMLTransformSliders. See 0004059

See http://www.na-mic.org/Bug/view.php?id=4059

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24660 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLTransformSliders.cxx Diff File

master c668f845

2015-10-23 15:53:45

pieper

Details Diff
BUG: 0004060 make package button perform a toggle (save dialog)

See:
http://www.na-mic.org/Bug/view.php?id=4060

From: Steve Pieper <pieper@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24659 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerSaveDataDialog.cxx Diff File

master d897bddf

2015-10-23 15:38:06

jcfr

Details Diff
BUG: Fix installation of Slicer.crt on MacOSX. Fixes 0004067

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24658 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/CMakeLists.txt Diff File

master 56643035

2015-10-23 15:24:42

jcfr

Details Diff
ENH: Update ITK to include latest backport to ITK release branche

It includes the following additional changes:

Bradley Lowekamp (3):
BUG: Avoid potential exception in itk::Object::UnRegister
BUG: Avoid null deference in PrintSelf with default construction
BUG: Use const pointer in Set method for constant ReferenceImage ivar

Davis Vigneault (2):
DOC: Expanded Canny Edge Detection Example
COMP: Warnings in FFTW Classes when compiling with c++11

Eugene Prilepin (1):
BUG: Fix a template name formation in python wrappings

Matthew McCormick (3):
COMP: Remove unused argument in ConditionVariableNoThreads.
DOC: Correct spelling of Continuous.
STYLE: Use prefix increment operator in ImageBase.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24657 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_ITKv4.cmake Diff File

master 64c075ae

2015-10-23 13:30:40

pieper

Details Diff
BUG: 0004066 Editor threshold paint should have inclusive range

See discussion here:
http://www.na-mic.org/Bug/view.php?id=4066

From: Steve Pieper <pieper@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24656 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/Logic/vtkImageSlicePaint.cxx Diff File

master 2241bfe9

2015-10-23 12:46:55

jcfr

Details Diff
ENH: Update ITK to backport ITKMGHIO tweaks

A branch named "MGHIO_Remote_SlicerSync-for-release" has also been proposed
to upstream ITK
See http://review.source.kitware.com/#/q/topic:MGHIO_Remote_SlicerSync-for-release

$ git shortlog 2eb422b..0786612 --no-merges
Hans Johnson (5):
ENH: Update Sphinx for ITK 4.8.0
COMP: Update to version for WikiExamples
STYLE: Minor code style issues for MGHIO
ENH: Update MGHIO to be shared lib
BUG: Fix MGHIO to fix write failures

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24655 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_ITKv4.cmake Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 53 54 55 56 57 58 59 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last