Changesets: Import 2017-06-07 23:51:09
|
master a1db81da 2014-06-09 13:02:01 mwoehlke Details Diff |
COMP: Remove gratuitous virtual Remove 'virtual' specifier of private classes in source files where said classes are not and (due to being in a source file) never will be derived. This avoids needing an explicit (virtual) dtor in order to avoid a -Wnon-virtual-dtor warning. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23317 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLDisplayNodeViewComboBox.cxx | Diff File | ||
| mod - Modules/Core/EventBroker/qSlicerEventBrokerModuleWidget.cxx | Diff File | ||
| mod - Modules/Loadable/Units/Widgets/qMRMLSettingsUnitWidget.cxx | Diff File | ||
| mod - Modules/Loadable/Units/Widgets/qMRMLUnitWidget.cxx | Diff File | ||
|
master e178a08d 2014-06-09 13:02:00 mwoehlke Details Diff |
COMP: Fix overloaded virtual warnings with VTKv6 Explicitly use base class implementations of transform overloads operating on 'float' (which cast and call the double overloads, and so will call the appropriate derived code) in order to avoid hiding the overloads in the derived class. (Fixes -Woverloaded-virtual warnings.) git-svn-id: http://svn.slicer.org/Slicer4/trunk@23316 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkOrientedGridTransform.h | Diff File | ||
|
master cc645bbf 2014-06-09 12:43:06 naucoin Details Diff |
BUG: Persist 'dont show message' selection when deleting markups This fix addresses Mantis item 0003663. The ctkMessageBox expects a ButtonRole of AcceptRole. Created a custom button for 2 reasons. First, it allows us to set the correct role and secondly a "Delete" and "Delete All" button more clearly aligns with the action being performed. From: David Stoup <david.stoup@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@23315 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx | Diff File | ||
|
master e26da411 2014-06-07 12:04:44 Details Diff |
COMP: Update EMSegment to fix narrowing and non virtual dtor warnings. Issue 0003419 ------------------------------------------------------------------------ r17052 | jcfr | 2014-06-06 21:29:01 -0400 (Fri, 06 Jun 2014) | 3 lines COMP: Avoid implicit narrowing casts Explicitly cast initializers in {} array initializer where the assigned type is smaller than the value type. This avoids implicit narrowing in a {} initializer, which is ill-formed in C++11. ------------------------------------------------------------------------ r17051 | jcfr | 2014-06-06 21:21:39 -0400 (Fri, 06 Jun 2014) | 3 lines COMP: Remove gratuitous virtual Remove 'virtual' specifier of private class in source file, where said class is not and (due to being in a source file) never will be derived. This avoids needing an explicit (virtual) dtor in order to avo id a -Wnon-virtual-dtor warning. From: Matthew Woehlke <matthew.woehlke@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@23314 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master 8c968e31 2014-06-06 15:41:16 Details Diff |
ENH: Add TestClearScene to vtkMRMLNodeTest1 This commit extends the test to check that the event invoked by either a referencing or referenced node when clearing a scene are the expected ones. Issue 0003708 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23313 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/Testing/vtkMRMLNodeTest1.cxx | Diff File | ||
|
master ea190c7d 2014-06-06 15:41:14 Details Diff |
ENH: Extend vtkMRMLNodeCallback API adding PrintSelf/GetReceivedEvents This commit add the GetReceivedEvents and PrintSelf functions. PrintSelf function displays the list of observed event that have been invoked. This will be used in tests to display more information in case the expected event count is different from the actual one. Issue 0003708 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23312 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.h | Diff File | ||
|
master e365f3a9 2014-06-06 11:54:17 mwoehlke Details Diff |
COMP: Make Python resources depend on qrcc.py Tweak the build rules for Python resource scripts to depend on the qrcc.py script that generates them. This should ensure that they are regenerated if the generation script changes. (In particular, it is hoped that this will help squash lingering issues in various folks' builds re: r23300.) git-svn-id: http://svn.slicer.org/Slicer4/trunk@23311 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerFunctionAddPythonQtResources.cmake | Diff File | ||
|
master 3a5882ba 2014-06-05 17:59:23 Details Diff |
BUG: N4ITKBiasFieldCorrection: Fix test updating the baseline This commit updates the baseline to match the default parameter value updated in r23306. From: Andrey Fedorov <fedorov@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@23310 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/N4ITKBiasFieldCorrection/Data/Baseline/he3biasfield.nii.gz | Diff File | ||
| mod - Modules/CLI/N4ITKBiasFieldCorrection/Data/Baseline/he3corrected.nii.gz | Diff File | ||
|
master 56dee89a 2014-06-05 17:33:31 Details Diff |
ENH: Simplify TestAddDelayedReferenceNode This commit refactors the function "CheckNthNodeReferenceID" to take an extra parameter named "expectedNodeReferenceID". This allows the function to test the reference ID independently of the node reference instance. It also update the test to use convenience function where possible. Issue 0003708 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23309 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/Testing/vtkMRMLNodeTest1.cxx | Diff File | ||
|
master cbbcba94 2014-06-05 17:33:29 Details Diff |
ENH: Simplify TestAddRefrencedNodeIDWithNoScene This commit extends "CheckNthNodeReferenceID()" function by introducing the extra parameter named "referencingNodeAddedToScene" and refactor the test to use it. Issue 0003708 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23308 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/Testing/vtkMRMLNodeTest1.cxx | Diff File | ||
|
master c8c4cd3b 2014-06-04 17:04:30 Details Diff |
ENH: Editor: paint using pixel mode if brush size is too small For volumes with anisotropic spacing the minimum brush size in the paint tool may be smaller than the pixel size. When a the brush size is smaller than the pixel size then no pixels are filled when the user clicks on the image, which is very confusing for the user. Implemented solution: added a check in the PaintEffect tool so that if the brush size is too small then pixels are painted using paintPixel mode. From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@23307 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/EditorLib/PaintEffect.py | Diff File | ||
|
master ccfee8a5 2014-06-04 14:42:44 Details Diff |
ENH: N4ITKBiasFieldCorrection: Restore original default for iteration number. This commit reverts the change added as part r21845 to resolve issue 0003034 To be compatible with code expecting the original default value, the value is changed back to to "50,40,30". From: Andrey Fedorov <fedorov@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@23306 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/N4ITKBiasFieldCorrection/N4ITKBiasFieldCorrection.xml | Diff File | ||
|
master cfb42778 2014-06-04 14:42:43 Details Diff |
ENH: Add Multi-sampling option This commits leverage the functionality already added in CTK [1] by adding "Views" settings panel allowing to enable/disable anti-aliasing. [1] https://github.com/commontk/CTK/commit/b39d95edd9be0965a85bcd9fbc12bb64edb9041a From: Eric Larson <larson.eric.d@gmail.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@23305 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx | Diff File | ||
| mod - Base/QTGUI/CMakeLists.txt | Diff File | ||
| add - Base/QTGUI/Resources/UI/qSlicerSettingsViewsPanel.ui | Diff File | ||
| mod - Base/QTGUI/qSlicerApplication.cxx | Diff File | ||
| add - Base/QTGUI/qSlicerSettingsViewsPanel.cxx | Diff File | ||
| add - Base/QTGUI/qSlicerSettingsViewsPanel.h | Diff File | ||
|
master 8eb610df 2014-06-04 10:51:03 Details Diff |
BUG: Update OpenIGTLinkIF Git Tag. Fixes 0003724 Transforms don't update after loading from saved scene. From: Junichi Tokuda <tokuda@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@23304 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master 81203284 2014-06-03 17:20:56 mwoehlke Details Diff |
BUG: Don't nuke external settings changes Update CTK to include recently added ctkSettingsDialog::reloadSettings method. Use this to force a reload of settings prior to showing the settings dialog. This is required in order for the dialog to show changes that have been made externally (e.g. by installing extensions) and, more importantly, to avoid overwriting the same when closing (even canceling!) the dialog. Issue 0003658 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23303 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx | Diff File | ||
| mod - SuperBuild/External_CTK.cmake | Diff File | ||
|
master d566755e 2014-06-03 17:20:12 mwoehlke Details Diff |
BUG: Fix (another) bug reading settings list Write a helper function to read a QSettings value explicitly as a list in Python, in order to work around PythonQt's implicit conversion of QVariant. Use this everywhere it is applicable in the Extension Wizard module. This allows us to simplify some places where we iterate over settings lists, and (more importantly) fixes (another) bug where we try to iterate over a list that might be empty. See also r23285. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23302 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/ExtensionWizard/ExtensionWizard.py | Diff File | ||
|
master 3947fff1 2014-06-03 15:07:41 mwoehlke Details Diff |
BUG: Reenable Extension Wizard module The previous commit should resolve the issue that was causing the Extension Wizard module to crash Slicer; therefore, revert r23297, making it enabled again. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23301 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/CMakeLists.txt | Diff File | ||
|
master 148a83da 2014-06-03 15:07:41 mwoehlke Details Diff |
BUG: Fix qrcc.py operation on Windows Change qrcc.py to use a temporary file to receive the raw binary rcc data on Windows, in order to work around what appears to be a bug in rcc where it is performing line ending (LF -> CRLF) conversion when writing to stdout, resulting in corrupt data which causes Qt to crash when trying to load the resources. See also https://bugreports.qt-project.org/browse/QTBUG-39422, r23297. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23300 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Utilities/Scripts/qrcc.py | Diff File | ||
|
master ae9c41f5 2014-06-03 15:07:40 mwoehlke Details Diff |
BUG: Avoid unneeded copy of resource bytes Modify qSlicerCoreApplication::[un]registerResource to use the QByteArray's constData() rather than mutable data() in order to avoid an unnecessary detach of the internally shared data. (Our usage does not require a mutable pointer at any time.) git-svn-id: http://svn.slicer.org/Slicer4/trunk@23299 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTCore/qSlicerCoreApplication.cxx | Diff File | ||
|
master 45bba063 2014-06-02 00:13:27 Details Diff |
BUG: Ensure Slicer ITKFactory plugins are loaded After the update of CTK in r23256, the instantiation of the ctkErrorLogModel was done before calling qSlicerCoreApplication::init(). This commit moves the instantiation after the call to init() where the ITK_AUTOLOAD_PATH was set. This will ensure the dynamic factories are discovered and loaded. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23298 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTGUI/qSlicerApplication.cxx | Diff File | ||
|
master ddc28d77 2014-06-01 14:42:10 Details Diff |
BUG: Disable ExtensionWizard to avoid crash on Windows Time the runtime crash happening on Windows is resolved. The module is disabled. Details about the crash are reported here: http://slicer-devel.65872.n3.nabble.com/Fwd-ctk-build-error-in-slicer-tt4031747.html To avoid the crash in existing build tree, the following two files will have to be removed from the build tree: lib/Slicer-4.3/qt-scripted-modules/ExtensionWizard.py lib/Slicer-4.3/qt-scripted-modules/ExtensionWizard.pyc git-svn-id: http://svn.slicer.org/Slicer4/trunk@23297 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/CMakeLists.txt | Diff File | ||
|
master c21bef8d 2014-05-30 18:44:48 mwoehlke Details Diff |
BUG: Also check for installed templates Modify SlicerWizard/ExtensionWizard.py to also look for the location to which templates are installed (relative to its own install location) as a default location for templates. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23296 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Utilities/Scripts/SlicerWizard/ExtensionWizard.py | Diff File | ||
|
master 4e2287e0 2014-05-30 18:44:47 mwoehlke Details Diff |
BUG: Pass template path to built wizard Modify the build tree wrapper script for running the CLI Extension Wizard to explicitly pass the template path for the built-in templates (in the source tree). Since this script is configured anyway and only used for the build tree, this is more straight forward than the trick we use in the Extension Wizard module of parsing the CMakeCache.txt to find the source directory. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23295 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Utilities/Scripts/slicerExtensionWizard.sh.in | Diff File | ||
|
master 7b1ada8d 2014-05-30 18:44:46 mwoehlke Details Diff |
ENH: Create CLI Extension Wizard 'launcher' Create a wrapper script to set up the environment (using the Slicer launcher's --launcher-show-set-environment-commands) and execute the CLI Extension Wizard via the appropriate Python interpreter. (Also, install the Python application launcher wrapper for the same.) This should provide a single, consistent mechanism for running the CLI Extension Wizard (from a bash shell) from both build and install trees, and regardless of whether system or Slicer-built Python is used. (On Windows, git-bash must be used.) git-svn-id: http://svn.slicer.org/Slicer4/trunk@23294 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMakeLists.txt | Diff File | ||
| add - Utilities/Scripts/CMakeLists.txt | Diff File | ||
| add - Utilities/Scripts/slicerExtensionWizard-install.sh.in | Diff File | ||
| add - Utilities/Scripts/slicerExtensionWizard.sh.in | Diff File | ||
|
master b5071de5 2014-05-30 18:43:30 mwoehlke Details Diff |
ENH: Also find templates in build (source) tree Add slicer.util.sourceDir() convenience method to retrieve the Slicer source directory, when running from a local build tree. Change Extension Wizard module to prefer to use templates from the same, if available. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23293 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Python/slicer/util.py | Diff File | ||
| mod - Modules/Scripted/ExtensionWizard/ExtensionWizardLib/TemplatePathUtilities.py | Diff File | ||
