View Issue Details

IDProjectCategoryView StatusLast Update
0000497Slicer3GUIpublic2010-04-21 14:05
Reporterinorton Assigned Tomillerjv  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Summary0000497: Resample Volume output needs Modified flag
Description

The module Filter->"Resample Scalar/Volume/DWI Volume" does not set the Modified flag for output volumes. Also, the output directory field is empty. Thus when the scene is saved, the output volumes are not saved (without intervention). This may be because the output is in a temp directory somewhere. This is obviously problematic for scene integrity.

TagsNo tags attached.

Activities

inorton

inorton

2009-03-13 10:51

developer   ~0000705

I'll take care of setting the modified flag.

pieper

pieper

2009-03-16 06:50

administrator   ~0000707

I've noticed this with other CLI code too - I think the issue is that the output of the module is read from a temp directory and thus it is considered 'unmodified' when it really is a new piece of data. I think the CommandLineModuleLogic should be setting the ModifiedSinceRead flag.

A possible complication is that the CommandLineModule only /requests/ the read, which is actually done by the ApplicationLogic so there may be some extra state that needs to get passed.

nicole

nicole

2010-04-21 14:05

administrator   ~0001617

Fixed in svn 12862.
(side note: the name of this CLI causes the Create New Volume volumes to be named "Resample Scalar/Vector/DWI Volume Volume", and when that's passed into the save data widget, the file name that's created from the node name is just DWI Volume Volume.nrrd because the slashes are read to be directory separators.)

Issue History

Date Modified Username Field Change
2009-03-08 12:26 inorton New Issue
2009-03-13 10:51 inorton Note Added: 0000705
2009-03-16 06:50 pieper Note Added: 0000707
2009-03-16 06:50 pieper Assigned To => millerjv
2009-03-16 06:50 pieper Status new => assigned
2010-03-23 10:34 pieper Tag Attached: 3.6 Targeted fix
2010-04-21 14:05 nicole Note Added: 0001617
2010-04-21 14:05 nicole Status assigned => closed
2010-04-21 14:05 nicole Resolution open => fixed
2013-01-27 12:21 jcfr Tag Detached: 3.6 Targeted fix