Changesets: Import 2017-06-07 23:51:09
|
master d1c01085 2015-10-06 08:55:27 Details Diff |
STYLE: Remove unused DICOMStudyBrowser/DICOMStudyTable/DICOMSeriesTable This commit removes part of experimental code added in r19454 (ENH: improvements to DICOM Module) that was illustrating possible implementation during the Slicer DICOM browser meeting of 2012-01-25. See https://www.assembla.com/spaces/slicerrt/wiki/20120125_Slicer_DICOM_browser_meeting Reviewed-by: Steve Pieper <pieper@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24604 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/DICOMLib/DICOMWidgets.py | Diff File | ||
|
master 85100635 2015-10-06 01:14:48 Details Diff |
STYLE: Update CTK to fix "QSqlQuery::exec: database not open" message This commit update CTK to fix message reported when opening DICOM module. $ git shortlog 6453c27..7ea654e --no-merges Jean-Christophe Fillion-Robin (1): Fix runtime warning in ctkDICOMTableView git-svn-id: http://svn.slicer.org/Slicer4/trunk@24603 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_CTK.cmake | Diff File | ||
|
master f942c9f5 2015-10-06 01:14:46 Details Diff |
STYLE: Fix layout warning in DICOMHeaderPopup This commit fixes the following warning reported when opening the DICOM module: //------------- QWidget::setLayout: Attempting to set QLayout "" on ctkDICOMObjectListWidget "ctkDICOMObjectListWidget", which already has a layout //------------- It removes the unneeded QGridLayout inadvertently added in r22689 (ENH: dicom header viewer added to DICOMLib using ctkDICOMObjectListWidget) git-svn-id: http://svn.slicer.org/Slicer4/trunk@24602 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/DICOMLib/DICOMWidgets.py | Diff File | ||
|
master 477e89f2 2015-10-05 21:35:45 Details Diff |
STYLE: Fix unused variable warning in qSlicerSimpleMarkupsWidget This commit fixes the following warning: /path/to/Slicer/Modules/Loadable/Markups/Widgets/qSlicerSimpleMarkupsWidget.cxx:691:6: warning: unused parameter ‘column’ [-Wunused-parameter] void qSlicerSimpleMarkupsWidget::onMarkupsFiducialSelected(int row, int column) ^ git-svn-id: http://svn.slicer.org/Slicer4/trunk@24601 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/Widgets/qSlicerSimpleMarkupsWidget.cxx | Diff File | ||
|
master 158ac9de 2015-10-05 21:28:58 Details Diff |
BUG: CR and LF replaced in URL when uploading extensions CMake string variables can contain new lines [1][2]. The Slicer extension mechanism uses string CMake to create extension description files and to create the URL containing meta-data and the package file name to upload extensions to the Midas server. New lines need to be handled correctly, otherwise the user will receive a message that the Midas server did not accept the submission of the extension. Carriage Return (CR) and Line Feed (LF) need to be replace by equivalent URL-encoding characters. [1] http://slicer-devel.65872.n3.nabble.com/Problem-with-the-factory-not-uploading-some-extensions-td4035069.html [2] https://github.com/Slicer/ExtensionsIndex/pull/1112#issuecomment-145706433 From: Francois Budin <fbudin@unc.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24600 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/MIDASAPILogin.cmake | Diff File | ||
|
master 2d8bbff3 2015-10-05 21:22:34 Details Diff |
COMP: Fix build error in app logic when extension support is disabled. In `vtkSlicerApplicationLogic::IsPluginBuiltIn` the variable `Slicer_EXTENSIONS_DIRBASENAME` is not defined if the `Slicer_BUILD_EXTENSIONMANAGER_SUPPORT` is false. Also fix a warning due to unused variable `slicerRevision` in `vtkSlicerApplicationLogic::IsEmbeddedModule` in the case where the Extension Manager was not build. Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> From: Alexis Girault <alexis.girault@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24599 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Logic/vtkSlicerApplicationLogic.cxx | Diff File | ||
|
master bf4fb459 2015-10-05 21:11:51 Details Diff |
COMP: Fix DCMTK build error llvm-gcc-4.2 on MacOSX. Updated version of DCMTK includes this commit: //-------------- commit commontk/DCMTK@545de87 Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Date: Mon Oct 5 21:06:36 2015 -0400 Fix dcmsr build error on llvm-gcc-4.2 on MacOSX. While maintaining the fix introduced in the previous commit, this commit also fixes the following error: Linking CXX shared library ../../lib/libdcmsr.dylib ld: duplicate symbol DSRTree<DSRDocumentTreeNode>::isEmpty() const in CMakeFiles/dcmsr.dir/dsrdocst.cc.o and CMakeFiles/dcmsr.dir/dsrdoc.cc.o for architecture x86_64 collect2: ld returned 1 exit status make[2]: *** [lib/libdcmsr.3.6.1.dylib] Error 1 make[1]: *** [dcmsr/libsrc/CMakeFiles/dcmsr.dir/all] Error 2 That was happening using the following compiler: i686-apple-darwin11-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00) See http://slicer-devel.65872.n3.nabble.com/dcmtk-compile-regression-td4035162.html Reported-by: Bill Lorensen <bill.lorensen@gmail.com> Tested-by: Bill Lorensen <bill.lorensen@gmail.com> //-------------- git-svn-id: http://svn.slicer.org/Slicer4/trunk@24598 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_DCMTK.cmake | Diff File | ||
|
master 3e3305fc 2015-10-04 23:49:36 Details Diff |
STYLE: Simplify code in ImportIDModelHierarchyConflictTest. See 0004040 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24597 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/Testing/vtkMRMLSceneImportIDModelHierarchyConflictTest.cxx | Diff File | ||
|
master 24c7cdb1 2015-10-04 23:49:34 Details Diff |
STYLE: Display line number in ImportIDModelHierarchyConflictTest error message See 0004040 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24596 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/Testing/vtkMRMLSceneImportIDModelHierarchyConflictTest.cxx | Diff File | ||
|
master f4fde9e1 2015-10-04 23:06:56 Details Diff |
BUG: Fix failing qSlicerUtilsTest1 on MacOSX Since on mac the canonical path associated with a tmp folder resolved to "/Private/tmp/...", this commit fixes the test by ensuring both paths are in the same form. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24595 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Logic/vtkSlicerApplicationLogic.cxx | Diff File | ||
|
master 8be913c8 2015-10-02 19:44:49 Details Diff |
ENH: Built-in module categories are listed separately in modules list Modules that are loaded from the Slicer build/install tree are marked as built-in, modules from different folders are not built-in. If a non-built-in module adds a category, then it is shown above the built-in categories, divided by a separator. Fixes 0003844 Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Reviewed-by: Andras Lasso <lasso@queensu.ca> Reviewed-by: Andriy Fedorov <fedorov@bwh.harvard.edu> Reviewed-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Reviewed-by: Sharp, Gregory C. <GCSHARP@mgh.harvard.edu> Reviewed-by: Nicole Aucoin <nicole@bwh.harvard.edu> Reviewed-by: Steve Pieper <pieper@isomics.com> From: Csaba Pinter <csaba.pinter@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24594 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Logic/vtkSlicerApplicationLogic.cxx | Diff File | ||
| mod - Base/Logic/vtkSlicerApplicationLogic.h | Diff File | ||
| mod - Base/QTCLI/qSlicerCLIExecutableModuleFactory.cxx | Diff File | ||
| mod - Base/QTCLI/qSlicerCLILoadableModuleFactory.cxx | Diff File | ||
| mod - Base/QTCLI/qSlicerCLIModuleFactoryHelper.cxx | Diff File | ||
| mod - Base/QTCLI/qSlicerCLIModuleFactoryHelper.h | Diff File | ||
| mod - Base/QTCore/Testing/Cxx/qSlicerUtilsTest1.cxx | Diff File | ||
| mod - Base/QTCore/qSlicerAbstractCoreModule.cxx | Diff File | ||
| mod - Base/QTCore/qSlicerAbstractCoreModule.h | Diff File | ||
| mod - Base/QTCore/qSlicerLoadableModuleFactory.cxx | Diff File | ||
| mod - Base/QTCore/qSlicerUtils.cxx | Diff File | ||
| mod - Base/QTCore/qSlicerUtils.h | Diff File | ||
| mod - Base/QTGUI/qSlicerModulesMenu.cxx | Diff File | ||
| mod - Base/QTGUI/qSlicerScriptedLoadableModuleFactory.cxx | Diff File | ||
|
master 8892af06 2015-10-02 18:29:23 Details Diff |
ENH: SlicerCPack: Introduce CPACK_NSIS_INSTALL_SUBDIRECTORY If Slicer is configured using -DSlicer_CPACK_NSIS_INSTALL_SUBDIRECTORY:STRING=Foo the application will be installed in "C:\Program Files\Foo\Slicer X.Y.Z" instead of "C:\Program Files\Slicer X.Y.Z" git-svn-id: http://svn.slicer.org/Slicer4/trunk@24593 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerCPack.cmake | Diff File | ||
|
master d8b1c090 2015-10-02 18:29:21 Details Diff |
STYLE: SlicerCPack: Set NSIS generator properties only if it applies git-svn-id: http://svn.slicer.org/Slicer4/trunk@24592 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerCPack.cmake | Diff File | ||
|
master 5098dea1 2015-10-02 18:29:20 Details Diff |
STYLE: SlicerCPack: Simplify code introducing slicer_verbose_set macro git-svn-id: http://svn.slicer.org/Slicer4/trunk@24591 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerCPack.cmake | Diff File | ||
|
master 5f3e5f73 2015-10-02 18:29:18 Details Diff |
STYLE: SlicerCPack: Move generator selection at the top of the file git-svn-id: http://svn.slicer.org/Slicer4/trunk@24590 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerCPack.cmake | Diff File | ||
|
master 62b1547e 2015-10-02 17:48:34 Details Diff |
ENH: always be case sensitive when matching node names with fnmatch when using fnmatch.fnmatch the case sensitivity depends on the filesystem [1]. For matching used when finding slicer nodes and qt widgets this variability does not make sense and may introduce cross-platform bugs. So we use fnmatch.fnmatchcase to ensure the same behavior across platfroms. https://docs.python.org/2/library/fnmatch.html http://slicer-users.65878.n3.nabble.com/Capturing-mouse-events-tt4029365.html#none From: Steve Pieper <pieper@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24589 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Python/slicer/util.py | Diff File | ||
| mod - Modules/Scripted/EditorLib/LabelStructureListWidget.py | Diff File | ||
|
master 40aca432 2015-10-01 18:07:12 Details Diff |
COMP: Update Slicer and CTK to fix DCMTK windows build error. This commit fixes windows build error and redefined warnings introduced by the commit r24586 (ENH: Update DMCTK to use version DCMTK-3.6.1_20150924) Related commits: * r24136 (STYLE: Update CTK to fix warning related to wrapping of CTKDICOM module) * r23955 (COMP: Workaround to fix HAVE_STAT redefined warning in SlicerDICOMExportDialog) * r23952 (COMP: Workaround to fix HAVE_STAT redefined warning in qSlicerCoreApplication) CTK updates: $ git shortlog 7199173..6453c27 --no-merges Jean-Christophe Fillion-Robin (2): Workaround refined macro warning when building CTKDICOMWidgetsPythonQt Fix CTKDICOMWidgetsPythonQt windows build error undefining HAVE_INT64_T Reported-by: Andriy Fedorov <fedorov@bwh.harvard.edu> Thanks: Andras Lasso <lasso@queensu.ca> Thanks: Jörg Riesmeier Thanks: Michael Onken git-svn-id: http://svn.slicer.org/Slicer4/trunk@24588 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTCore/qSlicerCoreApplication.cxx | Diff File | ||
| mod - Modules/Scripted/DICOMLib/Widgets/qSlicerDICOMExportDialog.cxx | Diff File | ||
| mod - SuperBuild/External_CTK.cmake | Diff File | ||
|
master d83b7edd 2015-09-30 15:47:34 Details Diff |
COMP: Fix DCMTK build error on Clang 3.1 on MacOSX This commit fixes build error introduced by previous commit by updating the version of DCMTK. Updated version of DCMTK includes this commit: //-------------- commit commontk/DCMTK@ade7e93 Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Date: Wed Sep 30 15:24:53 2015 -0400 Fix dcmsr build error on clang 3.1 on MacOSX. See Slicer/Slicer#359 This commit fixes the build error reported below by explicitly instantiating the DSRTree<DSRDocumentTreeNode>. Build error happening using Clang 3.1 downloaded from [1] on MacOSX SnowLeopard: //--------------- $ make cmr/fast VERBOSE=1 make -f dcmsr/libcmr/CMakeFiles/cmr.dir/build.make dcmsr/libcmr/CMakeFiles/cmr.dir/build Linking CXX shared library ../../lib/libcmr.dylib cd /Users/kitware/Dashboards/Continuous/Slicer-0-build/DCMTK-build/dcmsr/libcmr && "/Users/kitware/Dashboards/Support/CMake 3.0.1.app/Contents/bin/cmake" -E cmake_link_script CMakeFiles/cmr.dir/link.txt --verbose=1 "/Users/kitware/Dashboards/Support/CMake 3.0.1.app/Contents/bin/ctest" --launch --target-name cmr --build-dir /Users/kitware/Dashboards/Continuous/Slicer-0-build/DCMTK-build/dcmsr/libcmr --output ../../lib/libcmr.3.6.1.dylib --target-type SHARED_LIBRARY --language CXX -- /usr/bin/clang++ -fvisibility=hidden -D_XOPEN_SOURCE_EXTENDED -D_BSD_SOURCE -D_BSD_COMPAT -D_OSF_SOURCE -D_DARWIN_C_SOURCE -fPIC -O3 -DNDEBUG -arch x86_64 -isysroot /Developer/SDKs/MacOSX10.6.sdk -mmacosx-version-min=10.6 -dynamiclib -Wl,-headerpad_max_install_names -compatibility_version 7.0.0 -current_version 3.6.1 -o ../../lib/libcmr.3.6.1.dylib -install_name /Users/kitware/Dashboards/Continuous/Slicer-0-build/DCMTK-build/lib/libcmr.7.dylib CMakeFiles/cmr.dir/init.cc.o CMakeFiles/cmr.dir/logger.cc.o CMakeFiles/cmr.dir/srnumvl.cc.o CMakeFiles/cmr.dir/tid1001.cc.o CMakeFiles/cmr.dir/tid1204.cc.o CMakeFiles/cmr.dir/tid1600.cc.o CMakeFiles/cmr.dir/cid11.cc.o CMakeFiles/cmr.dir/cid29.cc.o CMakeFiles/cmr.dir/cid29e.cc.o CMakeFiles/cmr.dir/cid42.cc.o CMakeFiles/cmr.dir/cid100.cc.o CMakeFiles/cmr.dir/cid244.cc.o CMakeFiles/cmr.dir/cid244e.cc.o CMakeFiles/cmr.dir/cid4020.cc.o CMakeFiles/cmr.dir/cid4021.cc.o CMakeFiles/cmr.dir/cid4031.cc.o CMakeFiles/cmr.dir/cid4031e.cc.o CMakeFiles/cmr.dir/cid5000.cc.o CMakeFiles/cmr.dir/cid5001.cc.o CMakeFiles/cmr.dir/cid7021.cc.o CMakeFiles/cmr.dir/cid7445.cc.o CMakeFiles/cmr.dir/cid7452.cc.o CMakeFiles/cmr.dir/cid7453.cc.o CMakeFiles/cmr.dir/cid10013.cc.o CMakeFiles/cmr.dir/cid10013e.cc.o CMakeFiles/cmr.dir/cid10033.cc.o CMakeFiles/cmr.dir/cid10033e.cc.o ../../lib/libdcmsr.3.6.1.dylib ../../lib/libdcmimage.3.6.1.dylib ../../lib/libdcmimgle.3.6.1.dylib ../../lib/libdcmdata.3.6.1.dylib ../../lib/liboflog.3.6.1.dylib ../../lib/libofstd.3.6.1.dylib -lpthread Undefined symbols for architecture x86_64: "DSRTree<DSRDocumentTreeNode>::getRoot() const", referenced from: vtable for TID1001_ObservationContext in tid1001.cc.o vtable for TID1204_LanguageOfContentItemAndDescendants in tid1204.cc.o vtable for TID1600_ImageLibrary in tid1600.cc.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) make[1]: *** [lib/libcmr.3.6.1.dylib] Error 1 make: *** [cmr/fast] Error 2 //--------------- [1] http://llvm.org/releases/download.html#3.1 //-------------- git-svn-id: http://svn.slicer.org/Slicer4/trunk@24587 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_DCMTK.cmake | Diff File | ||
|
master 3c0c211a 2015-09-30 10:21:47 Details Diff |
ENH: Update DMCTK to use version DCMTK-3.6.1_20150924 The important improvements provided by the new version of DCMTK is the support for new API that in particular greatly simplify creation of and interaction with DICOM Segmentation image objects. More specifically, it introduces the dcmiod, dcmfg and dcmseg classes helpful in creating multiframe DICOM objects, such as segmentation and parametric map objects. Considering that standard and private dictionaries can now be embedded in DCMTK library, this commit partially reverts r24473 (ENH: Add support for DCMTK private dictionary). The test DCMTKPrivateDictTest.py was updated to not expect DCMDICTPATH environment variable that is no longer needed and is not initialized. List of DCMTK changes: $ git shortlog 3366181..DCMTK-3.6.1_20150924 --no-merges Andreas Thiel (1): Updated man pages for new development snapshot. Jan Schlamelcher (86): Some workarounds for VC6 compiler peculiarity. Introduced OFunique_ptr as a fallback if std::unique_ptr is not available. Make use of unique pointer (free memory if C-MOVE/C-FIND is canceled). Fixed dll build on windows. Correction of inconsistent previous commit. Fixed DcmSCPPool test case failing on older systems. Enabled shutdown functionality of DcmSCPPool. Fixed building with mingw-w64. Fixed most of the warnings in dcmjpeg. Fixed potential bug in dcmjpeg 12 and 16 bit variants. Marked SCPPool-Test (dcmnet_scp_pool) as exhaustive. Fixed most of the warnings in dcmdata. Fixed a mistake in CHANGES.361. Minor fixes in dcmdata. Added support for some C++11 types, literals and traits. Added documentation for the new macro "DOXYGEN". Fixed most of the warnings in ofstd and oflog. Added support for some additional C++11 traits. Introduced the new explicit boolean type OFExplicitBool. Fixed possibly wrong overload resolution in DSRCodedEntryValue. Minor fixes (whitespace and line ending errors). Modified DcmQuantColorHashTable to perform lazy initialization. Introduced OFoptional, implementing optional types. Renamed DoxygenLayout.xml to comply with filename conventions. Minor fixes and workarounds for Microsoft's compilers. Fixed ofstd_tatof error on older MSVC versions. Fixed DCMTK-Exports for custom module setups. Fixed and suppressed some warnings. Added 'DCMTK_USE_CXX11_STL' and 'DCMTK_CXX11_FLAGS'. Updated manpages. Updated DCMTK_ABI_VERSION for new development snapshot. Clarified an ambiguous configure message. Removed misleading comment in dcmjpeg. Fixed a wrong type-alias for OFintegral_constant. Introduced C++11-like alignment support. Fixed an alignment problem in OFoptional. Fixed building 32 bit targets with mingw-w64. Refined definition of numeric types and traits. Fixed a problem with Microsoft Safe CRT in oflog. Fixed a bug in dcmdata. Introduced DcmOutputBufferStream::filled() method. Fixed a problem in storescp. Modified some of OFoptional's comparison operators. Introduced OFtuple implementing generic tuples. Introduced move emulation for pre C++11 compilers. Small fixes for a previous commit about OFtuple. Several fixes and additions for yesterday's commits. Reintroduced bugfix-comment in dcmjpeg. Fixed autoconf install regarding ofstd variadic. Introduced OFnumeric_limits. Several fixes regarding OFnumeric_limits. Fixed possible arith.h generation problem on MinGW. Introduced basic support for assisted cross compiling. Fixed some problems regarding DCMTK's C++11 support. Added support for trusted client certificates. Adjusted DCMNET's default socket buffer length. Introduced cross compiling support for Android. Fixed a const correctness problem within DCMTLS. Introduced check-exhaustive targets to Autoconf. Corrections regarding recent commits. Modified CMake minimum version as required. Revised cleanup of temporary unit test files. Updated Autoconf dependencies. Updated man pages for new development snapshot. Updated DCMTK_ABI_VERSION for new development snapshot. Fixed a CMake problem with paths containing spaces. Moved some utility functions inside OFStandard. Modified fallback implementation of OFtuple. Added additional configuration methods for DCMTLS. Updated Makefile dependencies. Updated DCMTK_ABI_VERSION for new development snapshot. Moved CHANGES.361 to /docs. Updated Doxygen configuration files. Updated man pages. Updated default compiler flags. Refactored handling of some <cmath> functions. Fixed problems with previous commit. Fixed cross compiling via MinGW and Wine. Fixed building on FreeBSD. Fixed building on FreeBSD with C++11 enabled. Fixed inconsistent defines in CMake's osconfig.h. Fixed a problem in DcmAttributeFilter's unit test. Fixed building via GCC 4.2 on OpenBSD. Updated man pages for new development snapshot. Updated DCMTK_ABI_VERSION for new development snapshot. Updated CHANGES.361 for new development snapshot. Joerg Riesmeier (511): Added support for CP-1236 to data dictionary. Added support for CP-1236 to checkAndUpdateVR() method. Added support for Supplement 154 to the data dictionary. Added support for new SOP Class UIDs from Supplement 154. Added support for directory record type "SURFACE SCAN". Added new SOP Class UID from Supplement 162. Added missing assignment of member variable. Added full support for the new Comprehensive 3D SR IOD. Fixed various issues in syntax usage output. Minor fixes in comments, e.g. typos. Minor fixes in comments. Also made some input parameters "const". Use non-throwing new and delete operator. Fixed two possible memory leaks. Added comment to variable that is currently unused. Fixed issue with odd-length pixel data. Added missing sub-directory to "make install" target. Added some debug output to lookForXfer() method. Added some debug output to read() method. Added new print options for SOP class output. Added new command line options for print output. Fixed bug in checkSOPClassUID() method. Added note on support for shared libraries. Added support for CP-1246 and CP-1249 to data dictionary. Fixed some tag key constants of recently retired attributes. Fixed issue with unnecessary call to clearNodeCursorStack(). Added missing support for the new print options. Enhanced output to trace logger. Fixed inconsistencies introduced with last commit. Various fixes to comments. Removed trailing spaces. Added support for recently approved Correction Items. Enhanced documentation of complete flag methods. Added support for Supplement 157 to data dictionary. Added SOP Class UIDs from Supplement 157. Minor fixes to comments on VOI-related methods. Fixed bug in getTimeZoneFromString() method. Fixed issue with misplaced log output. Replaced "OFString::length() == 0" by "OFString::empty()". Replaced "OFString::length() != 0" by "!OFString::empty()". Replaced "OFString::length() > 0" by "!OFString::empty()". Added support for new VR "Other Double String" (OD) Added private tags for AGFA IMPACS 6.5.x Solution. Fixed wrong VR for private AGFA IMPAX tag. Updated version number of snapshot compilers. Added comment on inappropriate use of EC_IllegalCall. Fixed various oddities and inconsistencies: Replaced tabulator by space characters. Fixed various oddities and inconsistencies. Really call shouldStopAfterCurrentSOPInstance(): Fixed further documentation issues. Removed trailing space characters. Fixed various typos. Added releaseAssociation() and abortAssociation() Fixed various typos and other Doxygen issues. Enable WITH_THREADS for thread-related classes. Added new condition constants. Fixed various typos. Use optional fields in sendSTOREResponse(). Reimplemented sendSTOREResponse() method. Modified log output in loadAssociationCfgFile(). Fixed issues with optional message fields. Removed unused fields from sendACTIONResponse(). Added file missing for last commit :( Added progress notification to DcmSCP. Removed trailing spaces. Added global helper function createDirectory(). Fixed some minor Doxygen issues. Added new class DcmStorageSCP. Added new command line tool "dcmrecv". Added comments to unused exit codes. Rebuilt Makefile dependencies. Updated man pages. Function createDirectory() also works on Windows: Updated CMake version. Fixed various typos. Deprecated closeAssociation() method. Added support for Supplement 163 to data dictionary. Added meta header to stored DICOM files. Fixed various typos in comments. Pass existing dataset to handleSTORERequest(). Fixed various inconsistencies in comments. Do not copy received dataset in memory. Removed class name from derived method calls. Removed "&" from constant integer parameters. Fixed wrong log message in handleMOVERequest(). Fixed various typos in comments. Restructured implementation of handleSTORERequest(). Introduced dataset storage mode. Fixed various typos in comments. Receive C-STORE request dataset directly to file. Added new dataset storage mode. dded new storage mode options. Updated copyright dates (where appropriate). Added support for generating a Doxygen tag file. Fixed wrong Doxygen reference to a method. Minor fixes, e.g. added Doxygen markup. Fixed issue with CP-246 files and private tags. Slightly changed output of print() method. Added new print flag for showing invalid codes. Added new option for printing invalid codes. Added missing references to closed DCMTK features. Fixed typos. Added support for <InlineBinary> XML element. Clarified use of writeXML() flags. Fixed typo copied from Supplement 163. Output a warning message if the VR is unknown. Output currently processed line of input file. Removed superfluous footnote symbol "(*)". Fixed various coding style issues. Added trace log message on VR replacement. Added two new global flags for VR generation. Made use of new global flags for VR generation: Updated our email address for bug reports. Updated to autoconf 2.69. Added definition of DCMTK_PACKAGE_URL. Added Doxygen tag file to .gitignore. Added *.patch files to .gitignore. Also updated autoconf support files. Updated automake script to version 1.14. Fixed typos. Fixed various typos. Fixed various typos in comments. Added method to determine SpecificCharacterSet. Added 'charset' parameter to checkStringValue(). Added new variant of checkElementValue(). Avoid unnecessary copies of sequence elements. Enhanced implementation of checkCode() method. Report warning on unsupported character set. Use helper function findAndGetSequence(). Updated comment on current character set issue. Fixed memory leak in log4cplus code. Minor fixes in comments. Minor changes to comments. Updated Doxygen configuration files. Removed outdated custom CSS file. Updated URL of DCMTK's home page. Fixed timeout issue in handleAssociation(). Fixed source code formatting and various comments. Fixed wrong content type of XML element in DTD. Do not output group length in Native DICOM Model. Fixed outdated comment on 1st PN component group. Removed redundant API comment. Added support for CP-1268 to data dictionary. Added support for Supplement 168 to data dictionary. Added support for new UID from Supplement 168. Never output NULL bytes to markup string/stream. Adapted test cases for markup conversion. Iterate more efficiently over sequence items. Use helper method for deleting data elements. Added comments on missing features. Fixed small typos in comments. Added support for Real World Value Mapping objects. Added comment on getFrameList() method. Moved checkCurrentValue() to "protected" section. Slightly enhanced comments. Check return value of write() methods. Added support for Referenced Segment Number. Updated CMake version. Fixed small issue reported by CMake 2.8.12. Added Corneal Topography Map Storage SOP Class. Fixed bug that could cause a crash. Fixed doubled output of XML start tag for VR=OD. Added comment on wrong color model for icon images. Fixed issue with color icon images. Removed trailing white spaces from man pages files. Fixed build issue with shared libraries (Win32). Avoid CMake warning on non-installable files. Added missing break statements to switch cases. Removed redundant and outdated Word document. Added global flag for disabling the VR checker. Added new option for disabling the VR checker. Fixed minor Doxygen-related issue in documentation. Fixed name of PN component in Native DICOM Model. Fixed minor Doxygen-related issue in documentation. Fixed issue with test "ofstd_markup_6" (Win32). Fixed various typos in man pages. Fixed output of AT values in Native DICOM Model. Do not check valueLoaded() for Native DICOM Model. Completed support for <InlineBinary> XML element. Second try to fix the issue with "ofstd_markup_6". Fixed typos, comments and coding style. Replaced deprecated DcmSCU::closeAssociation(). Removed check on number of command line arguments. Cleaned up source code in various aspects. Again, fixed comments to be consistent with code. Fixed comments and documented default values. Added support for recently approved CPs. Added support for Supplement 165 to data dictionary. Added support for new UIDs from Supplement 165. Fixed wrong/missing comment on method parameter. Fixed various minor documentation issues. Added missing module dcmrt to include directories. Removed comment on UID_HangingProtocolStorage. Added support for approved but still missing CPs. Added comments on some ACR/NEMA attributes. Fixed timeout issue in DIMSE_moveUser(). Fixed typos in comments. Moved ACR/NEMA data dictionary to a separate file. Fixed issue with wrong check on stream compression. Fixed wrong VR for some retired command fields. Consistently use upper case letters for DICOM tags. Added new test cases for testing helper functions. Fixed typo and added comment. Added OFFilename versions to some helper functions. Added new helper function for renaming files. Added function for appending filename extension. Added wide character support to this tool. Added new helper function for copying files. Changed file mode bits back from "0755" to "0644". Fixed typo in comment. Added new command line option --create-backup. Avoid passing invalid values to rename(). Avoid passing NULL to OFString, which is deprecated. Added support for wide chars to DICOMDIR code. Fixed issue when compiled with wide char support. Added new condition constant and fixed typo. Fixed issue with missing terminating NULL byte. Always use OFFilename() instead of "" as a default. Use printError() instead of OFLOG_FATAL(). Fixed further issues with wide char support. Allow empty file-set ID in DICOMDIR (type 2). Fixed some comments. Fixed wrong tag in CodingSchemeIdentificationSequence. Made installation of tag file optional. Added another addContentItem() method. Replaced tabs by spaces and fixed indention. Fixed various issues in Doxygen comments. Fixed various minor issues in new helper class. Rebuilt Makefile dependencies. Added missing data elements to BD profiles. Added check for Shared Functional Groups Sequence. DIMSE_createFilestream() now uses an OFFilename. Fixed various typo. Pass OFString to DIMSE_createFilestream(). Added support for CP-1090 to the data dictionary. Fixed issue with automatically generated classes. Removed superfluous quotations marks. Fixed small typos in comments. Added readPatientData() and readStudyData(). Updated outdated comments on "log stream". Made sure that header file is parsed by Doxygen. Made sure that "Files" section is available. Added further header files to Doxygen documentation. Added support for recently approved CPs. Fixed some issues with wide character support. Added test for OFStandard::appendFilenameExtension(). Fixed issue with untyped NULL reported by MSVC++. Fixed various typos in comments. Enhanced removeRootDirFromPathname() function. Enhanced createDirectory() function. Use non-throwing new and delete operator. Fixed typo in comment. Output to debug logger if memory allocation fails. Simplified creation of temporary DICOMDIR file. Optionally disable isFilenameValid() check. Added support for new UIDs from Supplement 124. Added support for Supplement 124 to data dictionary. Removed superfluous member initialization. Fixed typo in comments. Added support for determining the FrameTime. Access the (total) number of frames in an image. Fixed inconsistent parameter type. Added explicit type casts to avoid warnings. Fixed inconsistent parameter type. Updated data dictionary for DICOM 2013 edition. Fixed typos in comments. Added further error handling options. Fixed typos in comments. Fixed typos, added missing documentation, etc. Various minor fixes for development version. Fixed typos in comments. Made sure that the move originator is cleared. Fixed issue with text alignment in PatternLayout. Fixed some Doxygen related issues (and a typo). Consistently use "presInfo" for variables/parameters. Added support for Supplement 159 to data dictionary. Added support for new UID from Supplement 159. Added support for new SR IOD from Supplement 159. Added DcmSCP::abortAssociation() method. Fixed typo and updated copyright date. Removed meaningless layout file setting. Renamed Doxygen's layout file again. Made sure that header file is parsed by Doxygen. Group condition constants in Doxygen output. Avoid full directory path in Doxygen footer. Replaced CMake variable in Doxygen config file. Removed outdated comment on DICOM 2008 standard. Added missing empty line. Fixed typos and other minor issues. Updated reference to DICOM standard edition. Updated DCMTK's copyright date. Added support for CP-1125 to SR implementation. Fixed incomplete #include comment. Added support for recently approved CPs. Updated comment based on CP-1335. Added support for new Colon CAD SR constraints. Fixed various typos and minor Doxygen issues. Updated data dictionary for DICOM 2014a edition. Removed year component from version field. Minor fixes to file's comment header. Updated copyright date and other minor changes. Implemented copy constructors and added clone(). Added explaining comment on new copy constructor. Removed outdated CMake exclude pattern. Excluded "*.md5" files from installation. Made sure that all top-level nodes are deleted. Added method counting the number of nodes. Added two new convenience functions. Fixed issue with tests run in different order. Fixed various Doxygen-related issues. Introduced new class DSRDocumentSubTree. Implemented copy constructors for tree classes. Added getPreviousNode() and getChildNode(). Added further checking methods to cursor class. Added gotoFirst() and gotoLast() methods. Minor fixes on "const" declaration of pointers. Added cloneSubTree() method to tree classes. Changed return type of addContentItem(node*). Reimplemented various getXXX() methods. Cleaned up handling of "unknown" relationships. Restructured classes for nodes and trees. Fixed a bug in convertNewlineCharacters(). Added insertSubTree() method to subtree class. Added checking of IOD-specific constraints. Fixed two memory leaks in recently added code. Clarified use of template identification. Removed DLL specifier from template classes. Slightly enhanced layout of Doxygen documentation. Added public method to change SR document type. Fixed wrong term in Doxygen documentation. Added removeSubTree() method to subtree class. Added extractSubTree() method to tree classes. Enhanced support for by-reference relationships. Further enhanced by-reference relationships. Insert a subtree into an empty document tree. Added dcmIsImageStorageSOPClassUID() function. Added check on valid "IMAGE" SOP Classes. Added support for optional JPEG fill byte. Removed misleading comment from checkStringValue(). Fixed typos in comments and other minor issues. Added support for new value representation "UR". Updated data dictionary for DICOM 2014b edition. Added functions to enable/disable post-1993 VRs. Enhanced rewriting rules in DcmVR::getValidEVR(). Use new VR "UR" for Pixel Data Provider URL. Fixed typo in method name. RLE images should not use multiple fragments. Added missing documentation for --propose-deflated. Attribute (0040,4005) has not been retired. Fixed wrong term "Device Driving Level". Updated "dcmrt" classes based on DICOM 2014b. Added "data correction" options to findscu. Fixed issue when scaling certain images. Removed unneeded header include. Fixed typo in comment. Fixed wrong validation of PN, LO and SH values. Added check for requirements clarified by CP-1401. Updated data dictionary for DICOM 2014c edition. Added support for new UIDs from DICOM 2014c. Fixed typo in comment. Added new temporarily generates files. Use "try and catch" block around new[]. Fixed error handling in detachValueField(). Fixed error handling in changeValue(). Added new test case for VR=FD. Changed attribute used for the "FD" test. Added support for new value representation "UC". Added support for recently approved CPs. Added Mapping Resource UID from CP-1417. Removed outdated name suffix from EXS_xxx constant. Added missing standard include for assert(). Fixed another CMake 3.1.x quotation issue. Updated latest tested CMake version. Fixed documentation of default TCP buffer length. Updated data dictionary for DICOM 2015a edition. Fixed typos in comments and other minor issues. Updated Makefile dependencies again. Updated outdated API documentation. Output message to logger on wrong pixel data class. Enhanced use of DSRCodingSchemeIdentificationList. Added support for recently approved CPs. Added support for Supplement 173 to dictionary. Added support for new UIDs from Supplement 173. Added support for recently approved CP-1425. Fixed test after after implementing CP-1425. Added further test cases for VR checker. Added read flag to all readXXX() methods. Optionally accept invalid content item values. Distinguish b/w invalid content items and values. Enhanced output to debug logger. Fixed wrong position counter in tree node. Added regression test for DSRTree::getPosition(). Added method for counting number of child nodes. Fixed issue with VR checker for PN values. Fixed warning C4800 reported by Visual Studio. Updated data dictionary for DICOM 2015b edition. Ignore empty value for XML element 'charset'. Added support for optional Mapping Resource UID. Pass OFList parameter by-reference not by-value. Fixed issue with interpolation algorithm. Added hasTemplateIdentification() method. Replace the document tree of an SR document. Added initial support for SR templates. Added helpers for setting a value from dataset. Set observation date/time from dataset. Moved various methods to protected section. Added helpers for setting a value from element. Set observation date/time from element. Avoid using "check" parameter of SR code class. Introduced new error code "Unknow VR". Fixed source code and/or comment formatting. Do not check invalid UID values for IMAGE node. Added support for long code values (CP-1031). New class for "Basic Coded Entry Attributes". Fixed bug in time normalization code. Added missing empty() method to OFMap. Added new option for print() method. Added new comparison method to DSRCodedEntryValue. Made getAndRemoveRootNode() public. Fixed issue with addNode() in basic tree class. Added new and enhanced existing swap() function. Check whether a template is extensible. Added initial support for Supplement 186. Added initial support for Supplement 180. Made constructor and destructor "protected". Removed explicit name of base class from call. Added mechanism for remembering node positions. Added base class for context groups. Added initial version of DCM code definitions. Added first specific Templates and Context Groups. Updated "DCM" codes for DICOM 2015c edition. Updated data dictionary for DICOM 2015c edition. Fixed issue with wrong quotation marks. Added static initialization function (MT-safe). Fixed issue in OFStandard::combineDirAndFilename(). Enhanced check on empty dataset. Improved documentation of disableXXXCheck(). Consistently use "file-set" and "file format". Allow for disabling check on "DICOM file format". Renamed ANNOUNCE file (removed version suffix). Enhanced documentation of createNewSOPInstance(). Added conversion operator to context group class. Added support for CID 42 (Numeric Value Qualifier). Added function that initializes all context groups. Updated copyright date. Fixed wrong documentation of return value. Removed superfluous OFStringStream_ends statement. Fixed wrong exit code on invalid input file. Added support for further Context Groups. Fixed various typos in comments. Enhanced handling of empty Measured Value Sequence. Added check for CID 42 to NUM values. Added support for Context Group CID 29. Added general information on coding scheme "DCM". Added easier method to set a composite reference. Fixed issue reported by Clang 3.5 on OpenBSD. Introduced condition constant EC_NotYetImplemented. Do not set empty concept name codes. Added missing DCMTK_DCMDATA_EXPORT macro. Added new helper method gotoEntryFromNodeList(). Added method to look up a context group entry Added new mode for adding nodes to the tree. Fixed typos in comment. Added comment on reserved error codes (for "cmr"). Fixed wrong comment. Introduced new flag to customize the print output. Added new command line options to dsrdump. Added specific logger for submodule "dcmsr/cmr". Added parameter "pos" to getStringValueFromDataset. Added static method setEnhancedEncodingMode(). Clarified use of invalid coded entries. Added support for Context Group CID 244. Made sure that IOD constraint checker is used. Added "Extensible SR" to known document types. Added enhanced versions of CID 29, 244 and 4031. Added cleanup() function to context group classes. Fixed typo and other minor issues in comments. Added name prefix to class ContentMappingResource. Fixed copyright header in module "dcmsr". Added new optional parameter "vm" to readSequence. Added methods to read/write to/from sequence items. Fixed inconsistencies regarding the use of OFMap. Updated Makefile dependencies. Added enhanced versions of CID 10013 and 10033. Added initial version of SRT and UCUM codes. Introduced type for list of CID 7445 values. Updated Makefile dependencies. Added initial version of TID 1600 (Image Library). Slightly changed conversion operator. Extracted general information from template. Avoid seperator if time component is empty. Added support for annotating content items. Added support for Context Group CID 100 and 7021. Added support for clearing tree node annotations. Made sure that tree node annotations are copied. Made sure that "dicom.dic" is loaded for tests. Fixed various issues in test case. Fixed "cardinality" for SQ elements in comments. Added comment that "Big Endian" is retired. Removed version suffix "3" from dictionary entries. Check logger for debug output of template tree. Introduced global definitions for certain tags. Added CREDITS file. Added "YXLON" to the new CREDITS file. Added support for recently approved CPs. Added support for Supplement 156 to dictionary. Added support for new UIDs from Supplement 156. Check for recently approved multi-frame images. Updated currently supported compiler versions. Fixed various minor issues in module descriptions. Fixed order of modules in main HTML file. Added three new DCMTK modules to README. Marco Eichelberg (5): Introduced OFStandard::dropPrivileges(). Tools now use OFStandard::dropPrivileges(). Fixed minor bug in DICOM upper layer FSM. Always use current dicom.dic for dcmdata unit tests. Removed unsupported wwwapps and perl scripts from module dcmwlm. Michael Onken (84): Added (optional) originating C-MOVE AE title and message ID to C-STORE message. Make DcmStorageSCU make use of new MoveOriginator feature. Added optional status detail when sending C-MOVE response. Make sure memcpy does not copy to NULL destination. Thanks to Francesco Gigante for the report. Added option to discard illegal characters when converting between DICOM character sets. Add "Discard illegal character" support to dcmconv and classes like DcmItem. Make sure SCU and SCP request/response data structures are initially zeroed. Fixed typo (coersion -> coercion) in DIMSE status constant. Added missing kudos. Fixed too small buffer for UID in Q/R server. Fixed issues where JPEG marker map was not cleared if more than one JPEG was converted using the same plugin instance. Fixed possible doubled destruction of association. Make sure oflog also compiles if threads are disabled. Always write meta header when receiving files. Removed Winsock comment. Added missing CHANGES entry. Warning to re-create index.dat after 20130705: Create DcmFileFormat from DcmDataset w/o copying. Do not copy DcmDataset during C-GET receive. Worklist SCP support for Responsible Person/Role. Replaced tabs with spaces. Support explicit item length denoting too many bytes. Corrected misleading transfer syntax error message. Fixed Comments. Described movescu storage SCP timeout problem. Make sure CMAKE_BUILD_TYPE has a default value. Fixed doubled tag output in XML output of VR OF. Avoid second OpenSSL initialization in constructor. Documentation for CMAKE_BUILD_TYPE default value. Fixed typo. Fixed CHANGES entries. Fixed some inconsistencies in documentation. Make sure to handle setuid() return code properly. Add libjpeg dependency for libtiff and minor changes. Fixed shared library build under Unix (configure). Enhanced DCMTK CMake exports for external projects. Capitalized all CMake key words for consistency. Ensure CMake v2.6 still writes DCMTKConfig.cmake. DCMTK.cmake and DCMTKTargets.cmake documentation. Added helpers to copy common modules between items. Fixed Makefile.dep for new files from last comit. Switched windows line endings to unix line endings. Added further module helpers and fixed small issues. Fixed comments and error message. Updated module helpers to latest DICOM 2013 draft. Fixed wrong ifdef syntax. Add connection timeout setting to SCU class. Fixed possible memory leak. Specific error if no presentation context proposed. Reverted false retirement status of some SOP Classes. Fix last commit by including implementation file. New compare() function for dcmdata object values. Make sure dcmdata tests compile with autoconf. Make new compare() method more reliable. Fixed conversion of color to palette color mode. Documented DCMTK's C++ cast macros. Fixed installation and added CHANGES file. Disable built-in dictionary for CMake Unix builds. Make sure presentation contexts do not interfer. Fixed iterator type. Introduced new modules dcmiod, dcmfg and dcmseg. Removed accidentially checked in test files. Removed more accidentially checked in test files. Fixed iterator dereference. Fixed iterator constness. Fixed possible DICOM VR problems. Removed unused method. Fixed mostly constness for some compilers. Fixed various doxygen formatting issues. Fixed compilers errors (mostly STL-specific). Removed unused link libraries. Made copyright header consistent in new modules. Build flags for internal and external dictionary. Updated dictionary build and code documentation. Added shared library export maro to IODModule. Added more files to be ignored by git. Added mising "check-exhaustive" targets. Replaced tab characters with spaces. Use static_cast instead of dynamic_cast. Renamed dictionary configuration build options. Simplified builtin dictionary infrastructure. Fixed typo in CMake script that can cause warnings. Fixed typo and made documentation more consistent. Fixed another typo. Enable private tags in builtin dictionary on CMake. Nikolas Goldhammer (1): Replaced deprecated CMake expressions. Uli Schlachter (13): Fixed wrong definition of Value Representation Person Name (PN) Removed unused local variable which shadowed a variable with the same name. Use ".NOTPARALLEL:" to make parallel builds (e.g. -j4) possible. Update rootconf for changes which were done directly to generated files. Fixed various issues found via cppcheck. Use DcmTagKey's output operator where possible. Don't include intrin.h on Visual Studio 2005 because of build errors. Fixed bug in OFString::copy() and improved unit tests. Fixed compiler warnings in ConvertIntegerToString with unsigned integers. Worked around compiler warnings on 32bit systems for too large shifts. Fixed crash if less than four transfer syntaxes are enabled. Silence some more compiler warnings about implicit casts. Don't set the defines for thread local storage support incorrectly. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24586 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/Testing/Python/DCMTKPrivateDictTest.py | Diff File | ||
| mod - Base/QTCore/qSlicerCoreApplication.cxx | Diff File | ||
| rm - CMake/SlicerBlockInstallDCMTKResources.cmake | Diff File | ||
| mod - CMake/SlicerCPack.cmake | Diff File | ||
| mod - SuperBuild/External_DCMTK.cmake | Diff File | ||
|
master 59b0f874 2015-09-29 18:33:16 naucoin Details Diff |
BUG: update the baseline mrml file for singleton changes Add the singleton tag to the baseline mrml file for the camera displayable manager test. Issue 0004006 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24585 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/DisplayableManager/Testing/Data/vtkMRMLCameraDisplayableManagerTest1.mrml | Diff File | ||
|
master c44f73b3 2015-09-29 17:48:06 naucoin Details Diff |
ENH: remove doubled extenions before saving Some nodes when they are read in by the node readers end up with names that include the extension, such as vol.vp. This change ensures that the known extension will not be added to the end of the name to create a file name with a doubled extension, such as vol.vp.vp. Fixed a typo in a variable name. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24584 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTGUI/qSlicerSaveDataDialog.cxx | Diff File | ||
|
master 4f65338f 2015-09-29 17:48:02 naucoin Details Diff |
BUG: fix volume property file extensions for saving When fixing the repeated file extensions problem, the volume property files were missed. The problem came up when loading in a volume property file via add data (rather than a scene file) then trying to save it again. The node was named with the .vp file extension and then the file name was adjusted to add another .vp to the end. This fix changes the the name of the node to exclude the extension so it will save correctly. Added testing for the AddVolumePropertyFromFile method and added some checks to it for missing scene and file names. Added the supported write types as well. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24583 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/VolumeRendering/Logic/Testing/Cxx/CMakeLists.txt | Diff File | ||
| add - Modules/Loadable/VolumeRendering/Logic/Testing/Cxx/vtkSlicerVolumeRenderingLogicAddFromFileTest.cxx | Diff File | ||
| mod - Modules/Loadable/VolumeRendering/Logic/vtkSlicerVolumeRenderingLogic.cxx | Diff File | ||
| mod - Modules/Loadable/VolumeRendering/MRML/vtkMRMLVolumePropertyStorageNode.cxx | Diff File | ||
| mod - Modules/Loadable/VolumeRendering/MRML/vtkMRMLVolumePropertyStorageNode.h | Diff File | ||
|
master 808c8e68 2015-09-29 16:55:06 naucoin Details Diff |
ENH: serialise singleton tags Singleton nodes were not having their singleton tag serialised to MRML, so on loading a scene back in, two nodes would be present in the scene if the node logic is relying on the tag to update the originally in the scene node. This fix serialised the singleton tag to MRML, adds a utility method to uniformly turn the property on or off, adds a test, and expands the node documentation to note that the hack in the scene to get untagged singleton nodes is needed for legacy scene files. Also gave examples for the conventions for singleton tag strings in the mrml node header file. Issue 0004006 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24582 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.h | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLNode.h | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLScene.cxx | Diff File | ||
|
master 0698939f 2015-09-27 14:42:00 Details Diff |
BUG: update MultiVolume hash This update fixes the crash when no labels were specified and volume rendering was requested. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24581 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master 97b5d308 2015-09-27 13:48:16 Details Diff |
BUG: fix crash in volume rendering due to bad node type (multivolume) The volume rendering node combobox allows child classes except for ones known not to work. This fix adds the MultiVolumeNode to that list in order to avoid a crash in the internals of the volume rendering due to invalid number of components. A better solution would be for the volume rendering internals to gracefully refuse to render volumes that aren't suited. It would be good if the volume rendering provided a method like ValidateInput that would allow the application to let the user know that the selected configuration won't work. From: Steve Pieper <pieper@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24580 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/VolumeRendering/Resources/UI/qSlicerVolumeRenderingModuleWidget.ui | Diff File | ||
