Changesets: Import 2017-06-07 23:51:09
|
master 9fccc8bd 2013-11-03 18:07:34 Details Diff |
COMP: Simplify MRML Scene API removing SceneModifiedTime methods. Along with the methods "GetSceneModifiedTime" and "IncrementSceneModifiedTime", the ivar SceneModifiedTime has been introduced in r5772. Considering the Modified time of the scene is in fact returned by the method "vtkMRMLScene::GetMTime()", having an other method named "GetSceneModifiedTime" is rather confusing. Since internally the method "GetSceneModifiedTime" was using the MTime of the underlying node collection, the existing call to the method have been changed into "GetNodes()->GetMTime()". This commit is a follow-up of r18562 where the method "GetCurrentScene()" has been renamed into "GetNodes()". For reference, the method "GetCurrentScene()" has itself been introduced in r8315. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22673 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLHierarchyNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLScene.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLScene.h | Diff File | ||
| mod - Libs/MRML/Logic/vtkMRMLModelHierarchyLogic.cxx | Diff File | ||
|
master a1956645 2013-10-31 13:03:51 Details Diff |
BUG: Prevent LevelTracingEffect crash when the user clicks on a pixel at the edge of the image (http://na-mic.org/Mantis/view.php?id=3470) git-svn-id: http://svn.slicer.org/Slicer4/trunk@22671 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/EditorLib/LevelTracingEffect.py | Diff File | ||
|
master c9f4958b 2013-10-31 00:51:14 Details Diff |
STYLE: Move vtkMRMLScene method definitions into implementation file. From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22670 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLScene.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLScene.h | Diff File | ||
|
master 121af10b 2013-10-31 00:51:11 Details Diff |
ENH: Optimized performance of observations management in vtkMRMLScene Use a std::map< std::string, std::set<std::string> > instead of two separate ReferencedIDs and ReferencingNodes vectors to make lookup, insertion, and deletion much faster (especially scene close takes much shorter time now). Store both referenced and referring nodes by ID. It is simpler, safer, and most of the time the node pointers were validated anyway using scene->GetNodeFromID(node->GetID(). Also, use set instead of vector for storing unique IDs for improving performance of scene loading (especially when the same scene is loaded twice and a lot of IDs have to be generated). Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22669 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeStoreSceneTest.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLScene.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLScene.h | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx | Diff File | ||
| mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.cxx | Diff File | ||
| mod - Modules/Loadable/VolumeRendering/Logic/vtkSlicerVolumeRenderingLogic.cxx | Diff File | ||
|
master 6b31883f 2013-10-31 00:51:06 Details Diff |
STYLE: Simplify code using vtkNew to register node with MRML scene From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22668 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLScene.cxx | Diff File | ||
|
master 6439e288 2013-10-31 00:51:03 Details Diff |
ENH: Improved performance of qMRMLSceneModel The indexFromNode method is called millions of times when there are a few hundred nodes and it browses through the whole model to find the requested node. Add a cache that stores the last search result and use it as a search hint. New rows are always added to the cache, so the cache alone can be used to determine if a node is not yet in the model. From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22667 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLSceneModel.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLSceneModel_p.h | Diff File | ||
|
master 54645f97 2013-10-31 00:51:00 Details Diff |
ENH: Optimized qMRMLSceneModel::nodeIndex performance qMRMLSceneModel::nodeIndex is called tens of millions of times, therefore it's optimum performance is critical. Find MRML nodes by object pointer instead of ID comparison to improve the performance. Also, always do lazyupdate for qMRMLSceneModel if scene is closing to unsubscribe from all events at once the scene is closed. From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22666 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLSceneModel.cxx | Diff File | ||
|
master 35060e47 2013-10-31 00:50:56 Details Diff |
ENH: vtkEventBroker performance improvement Use a set instead of a vector to allow faster finding and deletion of observations From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22665 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkEventBroker.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkEventBroker.h | Diff File | ||
| mod - Libs/MRML/Core/vtkObserverManager.cxx | Diff File | ||
| mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx | Diff File | ||
| mod - Libs/MRML/DisplayableManager/vtkMRMLModelSliceDisplayableManager.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLEventBrokerWidget.cxx | Diff File | ||
|
master 2123ad72 2013-10-31 00:50:52 Details Diff |
BUG: Fixed references to nodes in qSlicerTractographyDisplayWidget Crash happened at the end of SceneClose in py_test_tractography_display test because old (invalid) display node was still used. From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22664 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/TractographyDisplay/Widgets/qSlicerTractographyDisplayWidget.cxx | Diff File | ||
|
master 8d37eaf3 2013-10-31 00:50:49 Details Diff |
ENH: Add BatchUpdateThreshold to Model hierarchy logic Only use batch processing for show/hide of model hierarchies if the total number of nodes in the selected branch is larger than a given threshold. From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22663 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Logic/vtkMRMLModelHierarchyLogic.cxx | Diff File | ||
| mod - Libs/MRML/Logic/vtkMRMLModelHierarchyLogic.h | Diff File | ||
|
master c0a0b502 2013-10-31 00:50:46 Details Diff |
ENH: Don't batch process when show/hide only a few child nodes When there are many child nodes in a hierarchy then show/hide is much more efficient if batch processing is enabled. However, if there are few nodes only then a full refresh at the end of a batch processing takes longer than doing the update on each node separately. Count the number of child nodes and if there are less than 30 then update each node separately. From: Andras Lasso <lasso@queensu.ca> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22662 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLTreeView.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLTreeView_p.h | Diff File | ||
|
master 1d35a855 2013-10-31 00:50:42 Details Diff |
ENH: Update CTK to integrate Andras Lasso VTK connection optimization. Andras Lasso (3): ENH: Use a hashmap to avoid linear search for existing vtk connections BUG: Fixed ctkVTKObjectEventsObserverPrivate::findConnection behavior for wildcards ENH: qvtkConnect and qvtkDisconnect performance improvement Jean-Christophe Fillion-Robin (1): Merge branch 'vtkconnect-performance-improvement-consolidated' From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22661 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_CTK.cmake | Diff File | ||
|
master 63f9877f 2013-10-31 00:50:40 Details Diff |
ENH: Update vtkMRMLNodeTest1 to display error on standard error. From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22660 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/Testing/vtkMRMLNodeTest1.cxx | Diff File | ||
|
master 2080e019 2013-10-30 16:25:31 naucoin Details Diff |
BUG: update link to LiverData.mrb Fixed the scene file to show the model hierarchies and uploaded a new mrb file to midas at http://slicer.kitware.com/midas3/download?items=117033 Issue 0003469 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22659 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/Testing/Python/RSNA2012Vis.py | Diff File | ||
|
master 8dfa1ac4 2013-10-30 14:52:27 Details Diff |
BUG: Ensure python script argument are not loaded as image. Fixes 0003463 Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> From: Felix Veysseyre <felix.veysseyre@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22658 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTCore/qSlicerCoreApplication.cxx | Diff File | ||
|
master ff5f5a86 2013-10-30 12:59:30 Details Diff |
COMP: Fix MacOSX build issue when building against Qt 4.7.4. Fixes 0003471 Since "QSysInfo::MV_10_8" has been first introduced in Qt 4.8.3, exclude the fix for issue 0003460 introduced in commit r22641. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22657 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/Main.cxx | Diff File | ||
