Changesets: Import 2017-06-07 23:51:09

Search Browse Back to Index

master 0bce7460

2013-12-05 09:45:26

jcfr

Details Diff 		BUG: Fix EMSegment test by completely removing python wrapping of RemoteIO

This will fix EMSegment tests that broke following commit r22745.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22765 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/CMakeLists.txt Diff File
rm - Base/Python/remoteio.py Diff File
mod - Base/Python/slicer/slicerqt-with-tcl.py Diff File

master 698ce7fb

2013-12-04 19:05:06

jcfr

Details Diff 		COMP: Fix windows MRMLApplicationLogicTest1 build error (introduced by r22759)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22764 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLApplicationLogicTest1.cxx Diff File

master eb861eb8

2013-12-04 17:26:21

jcfr

Details Diff 		ENH: Consolidate qSlicerAppMainWindow

qSlicerAppMainWindowCore brings confusion to the code. It is now merged
with qSlicerAppMainWindow.
The custom macro is replaced by the automatic signal/slot connection of Qt
i.e. on_<SENDER_NAME>_<SENDER_SIGNAL>())
The objects had to be renamed to support the feature.

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Julien Finet <julien.finet@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22763 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/CMakeLists.txt Diff File
mod - Applications/SlicerApp/Data/Input/NeurosurgicalPlanningTutorial.xml Diff File
mod - Applications/SlicerApp/Resources/UI/qSlicerAppMainWindow.ui Diff File
mod - Applications/SlicerApp/Testing/Cpp/CMakeLists.txt Diff File
rm - Applications/SlicerApp/Testing/Cpp/qSlicerAppMainWindowCoreTest1.cxx Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.h Diff File
rm - Applications/SlicerApp/qSlicerAppMainWindowCore.cxx Diff File
rm - Applications/SlicerApp/qSlicerAppMainWindowCore.h Diff File
rm - Applications/SlicerApp/qSlicerAppMainWindowCore_p.h Diff File
add - Applications/SlicerApp/qSlicerAppMainWindow_p.h Diff File
mod - Modules/Scripted/DICOM/DICOM.py Diff File
mod - Modules/Scripted/SampleData/SampleData.py Diff File

master 4522991c

2013-12-04 15:29:48

jcfr

Details Diff 		COMP: For consistency, rename qSlicer.*IO classes into qSlicer.*Reader

Since the classes derive from qSlicerFileReader, change their suffixes
into "Reader" to prevent confusion.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22762 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/CMakeLists.txt Diff File
mod - Modules/Loadable/Annotations/CMakeLists.txt Diff File
mod - Modules/Loadable/Annotations/qSlicerAnnotationsModule.cxx Diff File
mod - Modules/Loadable/Colors/CMakeLists.txt Diff File
mod - Modules/Loadable/Colors/qSlicerColorsModule.cxx Diff File
mod - Modules/Loadable/Data/CMakeLists.txt Diff File
mod - Modules/Loadable/Data/qSlicerDataModule.cxx Diff File
mod - Modules/Loadable/DoubleArrays/CMakeLists.txt Diff File
mod - Modules/Loadable/DoubleArrays/qSlicerDoubleArraysModule.cxx Diff File
mod - Modules/Loadable/Markups/CMakeLists.txt Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModule.cxx Diff File
mod - Modules/Loadable/Models/CMakeLists.txt Diff File
mod - Modules/Loadable/Models/qSlicerModelsModule.cxx Diff File
mod - Modules/Loadable/TractographyDisplay/CMakeLists.txt Diff File
mod - Modules/Loadable/TractographyDisplay/qSlicerTractographyDisplayModule.cxx Diff File
mod - Modules/Loadable/Transforms/CMakeLists.txt Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModule.cxx Diff File
mod - Modules/Loadable/VolumeRendering/CMakeLists.txt Diff File
mod - Modules/Loadable/VolumeRendering/qSlicerVolumeRenderingModule.cxx Diff File
mod - Modules/Loadable/Volumes/CMakeLists.txt Diff File
mod - Modules/Loadable/Volumes/qSlicerVolumesModule.cxx Diff File

master 0bac5b68

2013-12-04 10:25:14

jcfr

Details Diff 		COMP: Fix windows build error due to missing include (introduced by r22759)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22761 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLDisplayableManagerFactory.cxx Diff File

master 8ddbb43c

2013-12-03 18:03:32

jcfr

Details Diff 		COMP: Remove unnecessary includes in vtkMRMLAbstractLogic header

This has the side effect of having a faster compilation

External module OpenIGTLinkIF and MultiVolumeExplorer have already been
updated according to change in vtkMRMLAbstractLogic header.
See 0003493 / r22712 and 0003494 / r22693

On the other hand, no test build have been done for the extension. Issue
will be resolved on case by case following the dashboard results.

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Julien <julien.finet@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22759 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Base/Logic/Testing/vtkSlicerTransformLogicTest1.cxx Diff File
mod - Base/Logic/vtkDataIOManagerLogic.cxx Diff File
mod - Base/Logic/vtkSlicerApplicationLogic.cxx Diff File
mod - Base/Logic/vtkSlicerFiducialsLogic.cxx Diff File
mod - Base/Logic/vtkSlicerModuleLogic.cxx Diff File
mod - Base/Logic/vtkSlicerScriptedLoadableModuleLogic.cxx Diff File
mod - Base/Logic/vtkSlicerTask.cxx Diff File
mod - Base/Logic/vtkSlicerTransformLogic.cxx Diff File
mod - Base/QTCLI/vtkSlicerCLIModuleLogic.cxx Diff File
mod - Base/QTCore/qSlicerAbstractCoreModule.cxx Diff File
mod - Base/QTCore/qSlicerCoreApplication.cxx Diff File
mod - Base/QTCore/qSlicerSlicer2SceneReader.cxx Diff File
mod - Base/QTCore/qSlicerXcedeCatalogIO.cxx Diff File
mod - Base/QTGUI/Testing/Cxx/qSlicerWidgetTest2.cxx Diff File
mod - Base/QTGUI/qSlicerApplication.cxx Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLCameraDisplayableManagerTest1.cxx Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLDisplayableManagerFactoriesTest1.cxx Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLModelDisplayableManagerTest.cxx Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLModelSliceDisplayableManagerTest.cxx Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLSliceViewDisplayableManagerFactoryTest.cxx Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLTestCustomDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLTestSliceViewDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLTestThreeDViewDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLThreeDReformatDisplayableManagerTest1.cxx Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLThreeDViewDisplayableManagerFactoryTest1.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLAbstractSliceViewDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLAbstractThreeDViewDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLCameraDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLCrosshairDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLLightBoxRendererManagerProxy.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelSliceDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLScriptedDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLThreeDReformatDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLViewDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLVolumeGlyphSliceDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkSliceViewInteractorStyle.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkThreeDViewInteractorStyle.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLColorLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLDisplayableHierarchyLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLLayoutLogicCompareTest.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLLayoutLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLLayoutLogicTest2.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLModelHierarchyLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest2.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest3.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest5.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLAbstractLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLAbstractLogic.h Diff File
mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.h Diff File
mod - Libs/MRML/Logic/vtkMRMLColorLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLColorLogic.h Diff File
mod - Libs/MRML/Logic/vtkMRMLDisplayableHierarchyLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLDisplayableHierarchyLogic.h Diff File
mod - Libs/MRML/Logic/vtkMRMLLayoutLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLLayoutLogic.h Diff File
mod - Libs/MRML/Logic/vtkMRMLModelHierarchyLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLModelHierarchyLogic.h Diff File
mod - Libs/MRML/Logic/vtkMRMLRemoteIOLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLayerLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLinkLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLogic.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorPickerWidgetTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest3.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest4.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetTest2.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLColorPickerWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLLayoutManager.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceView.cxx Diff File
mod - Modules/Loadable/Annotations/GUI/qSlicerAnnotationModulePropertyDialog.cxx Diff File
mod - Modules/Loadable/Annotations/GUI/qSlicerAnnotationModuleReportDialog.cxx Diff File
mod - Modules/Loadable/Annotations/GUI/qSlicerAnnotationModuleSnapShotDialog.cxx Diff File
mod - Modules/Loadable/Annotations/GUI/qSlicerAnnotationModuleWidget.cxx Diff File
mod - Modules/Loadable/Annotations/Logic/vtkSlicerAnnotationModuleLogic.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationBidimensionalDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationFiducialDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationROIDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationTextDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationDisplayableManagerTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkSlicerAnnotationModuleLogicTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Widgets/qMRMLAnnotationTreeView.cxx Diff File
mod - Modules/Loadable/Annotations/qSlicerAnnotationsIO.cxx Diff File
mod - Modules/Loadable/AtlasCreator/Logic/vtkAtlasCreatorLogic.cxx Diff File
mod - Modules/Loadable/Cameras/Logic/vtkSlicerCamerasModuleLogic.cxx Diff File
mod - Modules/Loadable/Cameras/Testing/Cxx/vtkSlicerCamerasModuleLogicCopyImportedCamerasTest.cxx Diff File
mod - Modules/Loadable/Colors/Logic/Testing/Cxx/vtkSlicerColorLogicTest1.cxx Diff File
mod - Modules/Loadable/Colors/Logic/vtkSlicerColorLogic.cxx Diff File
mod - Modules/Loadable/Colors/Testing/Cxx/qSlicerColorsModuleWidgetTest1.cxx Diff File
mod - Modules/Loadable/Colors/qSlicerColorsModuleWidget.cxx Diff File
mod - Modules/Loadable/CropVolume/Logic/vtkSlicerCropVolumeLogic.cxx Diff File
mod - Modules/Loadable/Data/Logic/vtkSlicerDataModuleLogic.cxx Diff File
mod - Modules/Loadable/Data/qSlicerDataModuleWidget.cxx Diff File
mod - Modules/Loadable/DoubleArrays/Logic/vtkSlicerDoubleArraysLogic.cxx Diff File
mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager2D.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager3D.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsFiducialDisplayableManager2D.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsFiducialDisplayableManager3D.cxx Diff File
mod - Modules/Loadable/ModelMirror/Logic/vtkModelMirrorLogic.cxx Diff File
mod - Modules/Loadable/ModelTransform/Logic/vtkModelTransformLogic.cxx Diff File
mod - Modules/Loadable/Models/Logic/vtkSlicerModelsLogic.cxx Diff File
mod - Modules/Loadable/Models/Testing/Cxx/qSlicerModelsModuleWidgetTest1.cxx Diff File
mod - Modules/Loadable/Models/Testing/Cxx/qSlicerModelsModuleWidgetTestScene.cxx Diff File
mod - Modules/Loadable/Models/qSlicerModelsIO.cxx Diff File
mod - Modules/Loadable/Models/qSlicerScalarOverlayIO.cxx Diff File
mod - Modules/Loadable/Reformat/Logic/vtkSlicerReformatLogic.cxx Diff File
mod - Modules/Loadable/Reformat/qSlicerReformatModuleWidget.cxx Diff File
mod - Modules/Loadable/SceneViews/GUI/qMRMLSceneViewsTreeView.cxx Diff File
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleDialog.cxx Diff File
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.cxx Diff File
mod - Modules/Loadable/SceneViews/Logic/vtkSlicerSceneViewsModuleLogic.cxx Diff File
mod - Modules/Loadable/SceneViews/Logic/vtkSlicerSceneViewsModuleLogic.h Diff File
mod - Modules/Loadable/SceneViews/Testing/Cxx/vtkSlicerSceneViewsModuleLogicTest1.cxx Diff File
mod - Modules/Loadable/TractographyDisplay/Logic/vtkSlicerFiberBundleLogic.cxx Diff File
mod - Modules/Loadable/TractographyDisplay/MRMLDM/vtkMRMLTractographyDisplayDisplayableManager.cxx Diff File
mod - Modules/Loadable/TractographyDisplay/MRMLDM/vtkMRMLTractographyDisplayDisplayableManager.h Diff File
mod - Modules/Loadable/TractographyDisplay/qSlicerFiberBundleIO.cxx Diff File
mod - Modules/Loadable/TractographyInteractiveSeeding/Logic/vtkSlicerTractographyInteractiveSeedingLogic.cxx Diff File
mod - Modules/Loadable/TractographyInteractiveSeeding/qSlicerTractographyInteractiveSeedingModuleWidget.cxx Diff File
mod - Modules/Loadable/Units/Logic/vtkSlicerUnitsLogic.cxx Diff File
mod - Modules/Loadable/ViewControllers/qSlicerViewControllersModuleWidget.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Logic/Testing/Cxx/vtkSlicerVolumeRenderingLogicTest.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Logic/vtkSlicerVolumeRenderingLogic.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Logic/vtkSlicerVolumeRenderingLogic.h Diff File
mod - Modules/Loadable/VolumeRendering/MRMLDM/vtkMRMLVolumeRenderingDisplayableManager.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Testing/Cxx/vtkMRMLVolumeRenderingDisplayableManagerTest1.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Testing/Cxx/vtkMRMLVolumeRenderingMultiVolumeTest.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Widgets/qSlicerVolumeRenderingModuleWidget.cxx Diff File
mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx Diff File
mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.h Diff File
mod - Modules/Loadable/Volumes/qSlicerVolumesModule.cxx Diff File

master 8db1a60d

2013-12-03 17:50:27

jcfr

Details Diff 		COMP: Remove CMake code that was updating now unused QTLIBLIST variable

Following commit r22756, the use of QTLIBLIST has been superseded by
the Slicer_REQUIRED_QT_MODULES variable.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22758 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master 9d6bb1d0

2013-12-03 17:50:25

jcfr

Details Diff 		COMP: Fix configuration by expecting phonon Qt component only on windows

This commit fix configuration issue introduced by r22756

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22757 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

master 03f2bac4

2013-12-03 17:09:36

jcfr

Details Diff 		COMP: Add Slicer_ADDITIONAL_REQUIRED_QT_MODULES to add QT modules

* Manually prefix the modules because some modules (e.g. PHONON) may not
have the "QT" prefix.
* Synchronize the required modules with the packaged modules

From: Julien Finet <julien.finet@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22756 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerBlockFindQtAndCheckVersion.cmake Diff File
mod - CMake/SlicerBlockInstallQt.cmake Diff File
mod - CMakeLists.txt Diff File
mod - SuperBuild.cmake Diff File

master 0a8f8639

2013-12-03 16:59:41

jcfr

Details Diff 		COMP: Update ITKv4/SimpleITK/BRAINSTools to use latest ITK release candidate

ITKv4: b95e6a0c835 # v4.5rc02 with one patch

SimpleITK: 83c344feff4b085 # Patched v0.7.1

BRAINSTools: bd755e2d82b7b

For more details, consider reading:

"ITK 4.5 Release Candidate 1 has been tagged!"
See http://public.kitware.com/pipermail/community/2013-November/000453.html

"ITK 4.5 Release Candidate 2 has been tagged!"
See http://public.kitware.com/pipermail/community/2013-December/000531.html

https://github.com/BRAINSia/BRAINSTools/compare/8c2fb34b1f80ed0a68219292010087033fee8a4b...bd755e2d82b7b8b8454fcb579d416e39b16dff80

https://github.com/SimpleITK/SimpleITK/compare/e2ec6bbfd7a68b9881f699513627ee9971dedeb9...83c344feff4b085df0879fd259337740f3f38c5d

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22755 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_BRAINSTools.cmake Diff File
mod - SuperBuild/External_ITKv4.cmake Diff File
mod - SuperBuild/External_SimpleITK.cmake Diff File

master 5619805f

2013-12-02 19:13:02

jcfr

Details Diff 		BUG: Fixed scene view node memory leak. Fixes 0003515

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22754 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File
mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx Diff File
mod - Modules/Loadable/SceneViews/Logic/vtkSlicerSceneViewsModuleLogic.cxx Diff File

master 1e2c0cae

2013-12-02 16:52:56

jcfr

Details Diff 		BUG: Made file extension comparisons case-insensitive. Fixes 0003511

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22753 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/vtkSlicerCLIModuleLogic.cxx Diff File
mod - Base/QTGUI/qSlicerSaveDataDialog.cxx Diff File
mod - Libs/MGHImageIO/itkMGHImageIO.cxx Diff File
mod - Libs/MRML/Core/vtkDataFileFormatHelper.cxx Diff File
mod - Libs/MRML/Core/vtkDataFileFormatHelper.h Diff File
mod - Libs/MRML/Core/vtkMRMLFreeSurferModelOverlayStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLFreeSurferModelStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLModelStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSceneViewStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLStorageNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLUnstructuredGridStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeArchetypeStorageNode.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.cxx Diff File
mod - Libs/vtkITK/vtkITKImageWriter.cxx Diff File
mod - Libs/vtkTeem/vtkNRRDReader.cxx Diff File
mod - Modules/CLI/DicomToNrrdConverter/DicomToNrrdConverter.cxx Diff File
mod - Modules/CLI/MergeModels/MergeModels.cxx Diff File
mod - Modules/CLI/ModelToLabelMap/ModelToLabelMap.cxx Diff File
mod - Modules/CLI/TractographyLabelMapSeeding/TractographyLabelMapSeeding.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationSnapshotStorageNode.cxx Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsFiducialStorageNode.cxx Diff File
mod - Modules/Loadable/Models/Logic/vtkSlicerModelsLogic.cxx Diff File
mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx Diff File

master a15b2d78

2013-12-02 16:52:50

jcfr

Details Diff 		COMP: Update CTK external project

$ git shortlog 46a1d6605..36fb628b1
Andreas Fetzer (11):
Adding possibility to dynamically change the layout of the dicomTableManager
ctkDicomBrowser uses dynamic table layout now
Children of the QSplitter of the tablemanager are no longer collapsible
Fixed missing update if new data is added
Fixed bug where filter textfield's background remained black
m_dynamic layout is now in pimpl and has read accessor. Some code cleaning
Improved behaviour of dynamic layout: between 800 and 1024px window size use vertical layout. If the window is bigger than 1024 switch to horizontal layout
Renaming method for setting dicom database
Not using const references when declaring a connection
Setting dynamic table layout in ui file
Proper naming of property with const read method

Jean-Christophe Fillion-Robin (3):
Rename macro "ctk_include_once" into "superbuild_include_once"
Ensure 'superbuild_include_once' works independently of the caller scope.
Merge branch '418-support-use-system-option'

Julien Finet (1):
Merge pull request 0000422 from AndreasFetzer/allow-dynamic-table-layout-for-dicombrowser-final

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22752 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master 992d5073

2013-12-02 16:52:48

jcfr

Details Diff 		COMP: Ensure 'superbuild_include_once' works independently of caller scope.

By using GLOBAL property instead of a local variable, the file will
be properly "include guarded" even if included from within a function.

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22751 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerMacroCheckExternalProjectDependency.cmake Diff File

master 4cc495bb

2013-12-02 16:52:46

jcfr

Details Diff 		STYLE: Rename macro "slicer_include_once" into "superbuild_include_once"

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22750 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerMacroCheckExternalProjectDependency.cmake Diff File
mod - SuperBuild/External_BRAINSTools.cmake Diff File
mod - SuperBuild/External_BatchMake.cmake Diff File
mod - SuperBuild/External_CTK.cmake Diff File
mod - SuperBuild/External_CTKAPPLAUNCHER.cmake Diff File
mod - SuperBuild/External_DCMTK.cmake Diff File
mod - SuperBuild/External_EMSegment.cmake Diff File
mod - SuperBuild/External_ITKv3.cmake Diff File
mod - SuperBuild/External_ITKv4.cmake Diff File
mod - SuperBuild/External_LibArchive.cmake Diff File
mod - SuperBuild/External_MultiVolumeExplorer.cmake Diff File
mod - SuperBuild/External_MultiVolumeImporter.cmake Diff File
mod - SuperBuild/External_NUMPY.cmake Diff File
mod - SuperBuild/External_OpenIGTLink.cmake Diff File
mod - SuperBuild/External_OpenIGTLinkIF.cmake Diff File
mod - SuperBuild/External_OpenSSL.cmake Diff File
mod - SuperBuild/External_PCRE.cmake Diff File
mod - SuperBuild/External_SciPy.cmake Diff File
mod - SuperBuild/External_SimpleFilters.cmake Diff File
mod - SuperBuild/External_SimpleITK.cmake Diff File
mod - SuperBuild/External_SlicerExecutionModel.cmake Diff File
mod - SuperBuild/External_Swig.cmake Diff File
mod - SuperBuild/External_VTK.cmake Diff File
mod - SuperBuild/External_curl.cmake Diff File
mod - SuperBuild/External_incrTcl.cmake Diff File
mod - SuperBuild/External_jqPlot.cmake Diff File
mod - SuperBuild/External_python.cmake Diff File
mod - SuperBuild/External_qRestAPI.cmake Diff File
mod - SuperBuild/External_tcl.cmake Diff File
mod - SuperBuild/External_teem.cmake Diff File
mod - SuperBuild/External_tk.cmake Diff File
mod - SuperBuild/External_zlib.cmake Diff File

master 857f0c20

2013-12-02 16:35:17

naucoin

Details Diff 		ENH: bring Markups jump slices default in line with slice node

Jumping slices default reset to offset as per current vtkMRMLSliceNode
JumpMode.
Slice node and radio button settings are compared and updated on GUI
start up.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22749 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Resources/UI/qSlicerMarkupsModule.ui Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File

master d37d50f0

2013-11-29 01:10:29

jcfr

Details Diff 		COMP: For consistency rename OpenSSL_* variables into OPENSSL_*

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22747 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerBlockCTKAppLauncherSettings.cmake Diff File
mod - CMake/SlicerBlockInstallOpenSSL.cmake Diff File
mod - CMake/SlicerCPackBundleFixup.cmake.in Diff File
mod - SuperBuild.cmake Diff File
mod - SuperBuild/External_OpenSSL.cmake Diff File
mod - SuperBuild/External_python.cmake Diff File
mod - SuperBuild/python_customPythonLauncherSettings.ini.in Diff File

master 59ef5cc6

2013-11-29 01:10:26

jcfr

Details Diff 		COMP: Fix OpenSSL install rules

Commit r22724 updated the External_* project files to support
Slicer_USE_SYSTEM_* variables. For sake of consistency, it also
changed variable "EP_OpenSSL_LIBRARIES" into "OPENSSL_LIBRARIES".
Since not all variables have been updated, this commit updates
the remaining variables to fix the OpenSSL install rules.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22746 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerBlockInstallOpenSSL.cmake Diff File
mod - SuperBuild.cmake Diff File

master afe0dd61

2013-11-29 01:10:23

jcfr

Details Diff 		COMP: Do not python wrap RemoteIO library.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22745 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/CMakeLists.txt Diff File
mod - Libs/RemoteIO/CMakeLists.txt Diff File

master 9461240b

2013-11-26 18:20:11

jcfr

Details Diff 		COMP: Removed unused/unmaintained RemoteIO classes and FetchMI module logic

For future references, the corresponding code has been added to
the Slicer attic. See Slicer/Attic@53262c8

From discussion with Steve and Andras:

// --------------------
(1) Jc - Nov 26, 2013

I notice that the only reason we depend on curl is for existence
of RemoteIO library that has been "replaced" by SampleData
and DataStore.

I really like the concept of registering URI that could be
downloaded that is why we should keep the infrastructure in place.

That said, I was thinking to get remove the following classes:

vtkHIDHandler.h
vtkHIDTagTable.h
vtkSRBHandler.h
vtkXNATHandler.h
vtkXNDHandler.h
vtkXNDTagTable.h

Then, we could implement a Qt based vtkHTTPHandler handler, that
way we could simply remove the curl dependency.

In the mean time, I would also remove the FetchMI logic which is
not maintained or used at that point.

Let me know what you think,

// --------------------
(2) Andras - Nov 26, 2013

It’s always a good idea to make the core smaller and simpler, so
I support the idea of getting rid of unused classes and unnecessary
dependencies.

We planned to use curl for uploading training results in a .zip
file to Moodle, but I guess we can add curl to our module then.

// --------------------
(3) Jc - Nov 26, 2013

Thanks for commenting.

If your module is a loadable or a scripted module, all "curl"
functionality can be provided by Qt. Would that work for you ?

// --------------------
(4) Andras - Nov 26, 2013

We would need quite complex curl functionalities for uploading data,
see the scripts below:

https://gist.github.com/Joshkunz/4516316

https://github.com/proyectoeduhub/moodle-cli/blob/master/moodle-file-upload-curl.sh

Would it be feasible to implement these?

// --------------------
(5) Jc - Nov 26, 2013

Good point. The plan would then be to:

(1) remove dependency of Slicer core against curl

(2) Only, build both the Curl library and the curl executable, keeping
them in the package.

That way, it would provide great flexibility with minimum overhead.

// --------------------
(6) Steve - Nov 26, 2013

Sounds like an excellent plan.

Yes, I like the design of the remote IO support in MRML, but it's not
being used and is great to simplify wherever possible. FetchMI can
go away for now, with the hope that we'll reproduce and improve on
it in the future (someday).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22744 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkMRMLRemoteIOLogic.cxx Diff File
mod - Libs/RemoteIO/CMakeLists.txt Diff File
rm - Libs/RemoteIO/vtkHIDHandler.cxx Diff File
rm - Libs/RemoteIO/vtkHIDHandler.h Diff File
rm - Libs/RemoteIO/vtkHIDTagTable.cxx Diff File
rm - Libs/RemoteIO/vtkHIDTagTable.h Diff File
rm - Libs/RemoteIO/vtkSRBHandler.cxx Diff File
rm - Libs/RemoteIO/vtkSRBHandler.h Diff File
rm - Libs/RemoteIO/vtkXNATHandler.cxx Diff File
rm - Libs/RemoteIO/vtkXNATHandler.h Diff File
rm - Libs/RemoteIO/vtkXNDHandler.cxx Diff File
rm - Libs/RemoteIO/vtkXNDHandler.h Diff File
rm - Libs/RemoteIO/vtkXNDTagTable.cxx Diff File
rm - Libs/RemoteIO/vtkXNDTagTable.h Diff File
mod - Modules/Loadable/CMakeLists.txt Diff File
rm - Modules/Loadable/FetchMI/CMakeLists.txt Diff File
rm - Modules/Loadable/FetchMI/Logic/CMakeLists.txt Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMILogic.cxx Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMILogic.h Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIParser.cxx Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIParser.h Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIParserHID.cxx Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIParserHID.h Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIParserXND.cxx Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIParserXND.h Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIServer.cxx Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIServer.h Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIServerCollection.cxx Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIServerCollection.h Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIWebServicesClient.cxx Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIWebServicesClient.h Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIWebServicesClientXND.cxx Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIWebServicesClientXND.h Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIWriter.cxx Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIWriter.h Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIWriterXND.cxx Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkFetchMIWriterXND.h Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkMRMLFetchMINode.cxx Diff File
rm - Modules/Loadable/FetchMI/Logic/vtkMRMLFetchMINode.h Diff File

master ddbe711c

2013-11-26 17:35:38

naucoin

Details Diff 		BUG: adding a test for closing the scene with volume rendering + cropping

Crashes on linux.

Issue 0003513



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22743 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/VolumeRendering/Testing/CMakeLists.txt Diff File
mod - Modules/Loadable/VolumeRendering/Testing/Python/CMakeLists.txt Diff File
add - Modules/Loadable/VolumeRendering/Testing/Python/VolumeRenderingSceneClose.py Diff File

master 730fafe3

2013-11-26 17:25:00

naucoin

Details Diff 		ENH: update RSNA Vis tutorial for 2013

Ported changes from 4.3.1:
Rename to more generic test name as updating the tutorial for RSNA 2013
Use new data sets from Sonia.
Add screen shot GUI elements and flags and method, capture screen shots at tutorial steps.
Added the volume rendering in part 1.
Tweaked all parts to match up to tutorial.

Updated test to work with new DICOM widget on the trunk.

Issue 0003507



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22742 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File

master c8a9fd1f

2013-11-26 11:34:28

naucoin

Details Diff 		ENH: Updating RSNA Quant tutorial for 2013

Rename to more generic test name so it's not tied to a year.
Use new data sets from Sonia
Add screen shot GUI elements and flags and method, capture screen shots at tutorial steps.
Tweaked all parts to match up to tutorial (first part was already tested
in the Vis tutorial, swapped it out for the Ruler)
Updated CMakeLists.txt so that this commit is independent of the Vis tutorial commit.

Issue 0003507

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22741 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File

master 3efb418d

2013-11-26 00:37:17

jcfr

Details Diff 		COMP: Optionally configure Slicer inner project with OpenSSL options.

This is needed because following commit r22734 RemoteIO library is
linked against OpenSSL.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22740 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/RemoteIO/CMakeLists.txt Diff File
mod - SuperBuild.cmake Diff File

master 4073be88

2013-11-25 20:05:59

jcfr

Details Diff 		COMP: External_curl: Fix build issue + Build against patched 7.34.0 release

This commit install the project so that all needed headers are all
in the same folder.

It also change the version of curl to 7.34.0 with an additional patch
adding CURL_STATICLIB to curlbuild.h to fix build issue on windows
and unix system.

Finally, it reverts r22728 which was incorrectly addressing the build
error described in the corresponding commit message.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22739 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File
mod - Libs/RemoteIO/CMakeLists.txt Diff File
mod - SuperBuild.cmake Diff File
mod - SuperBuild/External_curl.cmake Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 129 130 131 132 133 134 135  Next  Last