View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003493Slicer4Module OpenIGTLinkIFpublic2013-11-11 05:002017-06-10 08:51
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003493: OpenIGTLinkIF - Anticipated compile issue
Description

Hi,

Soon we will integrate commit reported in [1], after trying to compile including commit [2] into Slicer trunk. Your module doesn't compile. See error reported below.

The solution is to add "#include <vtkObjectFactory.h>" to "Logic/vtkSlicerOpenIGTLinkIFLogic.cxx"

[1] http://www.slicer.org/slicerWiki/index.php/Roadmap#Staged

[2] https://github.com/finetjul/Slicer/commit/95ed7d18a81b17f58362b61fbf143e09af1da017

In file included from /home/jchris/Projects/Slicer-SuperBuild-Debug-Qt485/VTK/Common/vtkObject.h:42:0,
from /home/jchris/Projects/Slicer/Libs/MRML/Core/vtkObserverManager.h:22,
from /home/jchris/Projects/Slicer/Libs/MRML/Logic/vtkMRMLAbstractLogic.h:22,
from /home/jchris/Projects/Slicer/Libs/MRML/Logic/vtkMRMLColorLogic.h:19,
from /home/jchris/Projects/Slicer/Modules/Loadable/Colors/Logic/vtkSlicerColorLogic.h:19,
from /home/jchris/Projects/Slicer-SuperBuild-Debug-Qt485/OpenIGTLinkIF/Logic/vtkSlicerOpenIGTLinkIFLogic.cxx:16:
/home/jchris/Projects/Slicer-SuperBuild-Debug-Qt485/OpenIGTLinkIF/Logic/vtkSlicerOpenIGTLinkIFLogic.cxx: In static member function ‘static vtkSlicerOpenIGTLinkIFLogic vtkSlicerOpenIGTLinkIFLogic::New()’:
/home/jchris/Projects/Slicer-SuperBuild-Debug-Qt485/VTK/Common/vtkSetGet.h:644:22: error: ‘vtkObjectFactory’ has not been declared
vtkObject ret = vtkObjectFactory::CreateInstance(#thisClass); \
^
/home/jchris/Projects/Slicer-SuperBuild-Debug-Qt485/OpenIGTLinkIF/Logic/vtkSlicerOpenIGTLinkIFLogic.cxx:44:1: note: in expansion of macro ‘vtkStandardNewMacro’
vtkStandardNewMacro(vtkSlicerOpenIGTLinkIFLogic);
^
make[2]: [Modules/Remote/OpenIGTLinkIF/Logic/CMakeFiles/vtkSlicerOpenIGTLinkIFModuleLogic.dir/vtkSlicerOpenIGTLinkIFLogic.cxx.o] Error 1
make[1]: [Modules/Remote/OpenIGTLinkIF/Logic/CMakeFiles/vtkSlicerOpenIGTLinkIFModuleLogic.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

TagsNo tags attached.

Relationships

related to 0003494 closedjcfr MultiVolumeExplorer - Anticipated compile issue 

Activities

tokuda

tokuda

2013-11-16 06:56

developer   ~0010320

The fixed code is committed to:

https://github.com/tokjun/OpenIGTLinkIF/tree/3493-include-vtkObjectFactory-h
tokuda

tokuda

2013-11-16 10:22

developer   ~0010321

The branch is merged into the main repository 48384b24570ea5f8fee52fb9e3d56512d2e05837

https://github.com/openigtlink/OpenIGTLinkIF/pull/15
jcfr

jcfr

2013-11-18 07:07

administrator   ~0010328

Thanks.

Fixed in r22712
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=22712
jcfr

jcfr

2017-06-07 23:27

administrator   ~0014568

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 0abff65c

2013-11-18 12:07:13

jcfr

Details Diff 		COMP: OpenIGTLinkIF - Anticipate logic headers reorganization.

Soon, as a compilation speedup, the base class "vtkMRMLAbstractLogic"
will forward declared classes in its definition file.

This commit fix compilation issue that would have occurred following
integration of the topic "finetjul/Slicer@vtkmrmlabstractlogic-clean-includes-trunk"

Fixes 0003493

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Junichi Tokuda <tokuda@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22712 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_OpenIGTLinkIF.cmake Diff File

Import 2017-06-07 23:51:09: master 0abff65c

2013-11-18 12:07:13

jcfr

Details Diff 		COMP: OpenIGTLinkIF - Anticipate logic headers reorganization.

Soon, as a compilation speedup, the base class "vtkMRMLAbstractLogic"
will forward declared classes in its definition file.

This commit fix compilation issue that would have occurred following
integration of the topic "finetjul/Slicer@vtkmrmlabstractlogic-clean-includes-trunk"

Fixes 0003493

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Junichi Tokuda <tokuda@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22712 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_OpenIGTLinkIF.cmake Diff File

Issue History

Date Modified Username Field Change
2013-11-11 05:00 jcfr New Issue
2013-11-11 05:00 jcfr Status new => assigned
2013-11-11 05:00 jcfr Assigned To => tokuda
2013-11-11 05:04 jcfr Relationship added related to 0003494
2013-11-11 05:05 jcfr Target Version => Slicer 4.4.0
2013-11-16 06:56 tokuda Note Added: 0010320
2013-11-16 06:56 tokuda Status assigned => resolved
2013-11-16 06:56 tokuda Resolution open => fixed
2013-11-16 10:22 tokuda Note Added: 0010321
2013-11-18 07:07 jcfr Note Added: 0010328
2013-11-18 07:07 jcfr Status resolved => closed
2013-11-18 07:07 jcfr Fixed in Version => Slicer 4.4.0
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 0abff65c
2017-06-07 23:27 jcfr Note Added: 0014568
2017-06-07 23:27 jcfr Assigned To tokuda => jcfr
2017-06-10 08:51 jcfr Changeset attached => Slicer master 0abff65c