View Issue Details

IDProjectCategoryView StatusLast Update
0003494Slicer4Module MultiVolume Exporter/Importerpublic2017-06-10 08:51
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003494: MultiVolumeExplorer - Anticipated compile issue
Description

Hi,

Soon we will integrate commit reported in [1], after trying to compile including commit [2] into Slicer trunk. Your module doesn't compile. See error reported below.

The solution is to add "#include <vtkObjectFactory.h>" to "Logic/vtkSlicerMultiVolumeExplorerLogic.cxx"

[1] http://www.slicer.org/slicerWiki/index.php/Roadmap#Staged

[2] https://github.com/finetjul/Slicer/commit/95ed7d18a81b17f58362b61fbf143e09af1da017

In file included from /home/jchris/Projects/Slicer-SuperBuild-Debug-Qt485/VTK/Common/vtkObject.h:42:0,
from /home/jchris/Projects/Slicer/Libs/MRML/Core/vtkObserverManager.h:22,
from /home/jchris/Projects/Slicer/Libs/MRML/Logic/vtkMRMLAbstractLogic.h:22,
from /home/jchris/Projects/Slicer/Libs/MRML/Logic/vtkMRMLColorLogic.h:19,
from /home/jchris/Projects/Slicer/Modules/Loadable/Colors/Logic/vtkSlicerColorLogic.h:19,
from /home/jchris/Projects/Slicer-SuperBuild-Debug-Qt485/MultiVolumeExplorer/Logic/vtkSlicerMultiVolumeExplorerLogic.cxx:19:
/home/jchris/Projects/Slicer-SuperBuild-Debug-Qt485/MultiVolumeExplorer/Logic/vtkSlicerMultiVolumeExplorerLogic.cxx: In static member function ‘static vtkSlicerMultiVolumeExplorerLogic vtkSlicerMultiVolumeExplorerLogic::New()’:
/home/jchris/Projects/Slicer-SuperBuild-Debug-Qt485/VTK/Common/vtkSetGet.h:644:22: error: ‘vtkObjectFactory’ has not been declared
vtkObject
ret = vtkObjectFactory::CreateInstance(#thisClass); \
^
/home/jchris/Projects/Slicer-SuperBuild-Debug-Qt485/MultiVolumeExplorer/Logic/vtkSlicerMultiVolumeExplorerLogic.cxx:68:1: note: in expansion of macro ‘vtkStandardNewMacro’
vtkStandardNewMacro(vtkSlicerMultiVolumeExplorerLogic);

TagsNo tags attached.

Relationships

related to 0003493 closedjcfr OpenIGTLinkIF - Anticipated compile issue 

Activities

fedorov

fedorov

2013-11-11 05:15

developer   ~0010299

pull request submitted

https://github.com/Slicer/Slicer/pull/78

jcfr

jcfr

2013-11-11 08:05

administrator   ~0010305

Fixed in r22693
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=22693

jcfr

jcfr

2017-06-07 23:27

administrator   ~0014569

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 922bb212

2013-11-11 13:04:20

jcfr

Details Diff
COMP: MultiVolumeExplorer - Anticipate logic headers reorganization.

Soon, as a compilation speedup, the base class "vtkMRMLAbstractLogic"
will forward declared classes in its definition file.

This commit fix compilation issue that would have occurred following
integration of the topic "finetjul/Slicer@vtkmrmlabstractlogic-clean-includes-trunk"

Fixes 0003494

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Andrey Fedorov <fedorov@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22693 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_MultiVolumeExplorer.cmake Diff File

Import 2017-06-07 23:51:09: master 922bb212

2013-11-11 13:04:20

jcfr

Details Diff
COMP: MultiVolumeExplorer - Anticipate logic headers reorganization.

Soon, as a compilation speedup, the base class "vtkMRMLAbstractLogic"
will forward declared classes in its definition file.

This commit fix compilation issue that would have occurred following
integration of the topic "finetjul/Slicer@vtkmrmlabstractlogic-clean-includes-trunk"

Fixes 0003494

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Andrey Fedorov <fedorov@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22693 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_MultiVolumeExplorer.cmake Diff File

Issue History

Date Modified Username Field Change
2013-11-11 05:04 jcfr New Issue
2013-11-11 05:04 jcfr Status new => assigned
2013-11-11 05:04 jcfr Assigned To => fedorov
2013-11-11 05:04 jcfr Target Version => Slicer 4.4.0
2013-11-11 05:04 jcfr Relationship added related to 0003493
2013-11-11 05:15 fedorov Note Added: 0010299
2013-11-11 08:05 jcfr Note Added: 0010305
2013-11-11 08:05 jcfr Status assigned => resolved
2013-11-11 08:05 jcfr Fixed in Version => Slicer 4.4.0
2013-11-11 08:05 jcfr Resolution open => fixed
2013-11-11 08:05 jcfr Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 922bb212
2017-06-07 23:27 jcfr Note Added: 0014569
2017-06-07 23:27 jcfr Assigned To fedorov => jcfr
2017-06-10 08:51 jcfr Changeset attached => Slicer master 922bb212