View Issue Details

IDProjectCategoryView StatusLast Update
0003471Slicer4Core: GUIpublic2017-06-10 08:51
Reportertokuda Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003471: r22641 cannot be built with Qt 4.7.4 on Mac
Description

The change in r22641 caused error on my Mac with Qt 4.7.4.

Applications/SlicerApp/Main.cxx line 103 refers QSysInfo::MV_10_8, but this value seems not available in Qt-4.7.4. (The Slicer build instruction still mentions "Qt >= 4.7.4. " ... this might confuse some developers.)

TagsToBeBackported

Relationships

related to 0003460 closedjcfr Fix wekit performance issue on MacOSX 10.9 

Activities

jcfr

jcfr

2013-10-30 09:01

administrator   ~0010240

Fixed in r22657
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22657

jcfr

jcfr

2014-03-06 05:00

administrator   ~0010883

Closing resolved issues that have not been updated in more than 3 months

jcfr

jcfr

2014-07-03 17:44

administrator   ~0012140

Last edited: 2014-07-03 17:45

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23413

// ------------------------
COMP: Move most of find_package calls into each Slicer sub-project.

To help address issue 0003741 [1], call to find_package associated to CTK,
DCMTK, ITK and SlicerExecutionModel have been moved in every Slicer
sub project, library or module expecting it.

This allows to reduce both the number of include directories and
the number of libraries passed to the compiler.

Moving forward, every Slicer sub project, library or module will be
responsible to call find_package (optionally specifying a list of
components) and (if it applies) include the associated "use file".

Note that call to find_package(VTK) is still done at the top-level, before
moving the call to the expected sub-directories, the CTKConfig.cmake
will have to be updated to call find_package(VTK) specifying the required
components where it is needed.
// ------------------------

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23412

// ------------------------

COMP: Disable VTK find_package/use_file_include in sub directory.

Calling "find_package(VTK)/include(${VTK_USE_FILE})" in both the top-level
directory and sub-directories is undefined. Indeed, If we include
VTK_USE_FILE (UseVTK.cmake) in the top level then it is probably adding
the autoinit definitions to the COMPILE_DEFINITIONS directory property.
Then that inherits to the sub-directory and could conflict with any such
property defined there. Thanks to Brad King for his insight.
// ------------------------

jcfr

jcfr

2017-06-07 23:27

administrator   ~0014572

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file ff5f5a86

2013-10-30 12:59:30

jcfr

Details Diff
COMP: Fix MacOSX build issue when building against Qt 4.7.4. Fixes 0003471

Since "QSysInfo::MV_10_8" has been first introduced in Qt 4.8.3,
exclude the fix for issue 0003460 introduced in commit r22641.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22657 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Main.cxx Diff File

Import 2017-06-07 23:51:09: master ff5f5a86

2013-10-30 12:59:30

jcfr

Details Diff
COMP: Fix MacOSX build issue when building against Qt 4.7.4. Fixes 0003471

Since "QSysInfo::MV_10_8" has been first introduced in Qt 4.8.3,
exclude the fix for issue 0003460 introduced in commit r22641.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22657 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Main.cxx Diff File

Issue History

Date Modified Username Field Change
2013-10-30 08:14 tokuda New Issue
2013-10-30 08:14 tokuda Status new => assigned
2013-10-30 08:14 tokuda Assigned To => kikinis
2013-10-30 08:15 tokuda Relationship added related to 0003460
2013-10-30 08:17 kikinis Assigned To kikinis => jcfr
2013-10-30 09:00 jcfr Target Version => Slicer 4.3.2
2013-10-30 09:00 jcfr Tag Attached: ToBeBackported
2013-10-30 09:01 jcfr Note Added: 0010240
2013-10-30 09:01 jcfr Status assigned => resolved
2013-10-30 09:01 jcfr Fixed in Version => Slicer 4.3.2
2013-10-30 09:01 jcfr Resolution open => fixed
2014-03-06 05:00 jcfr Note Added: 0010883
2014-03-06 05:01 jcfr Status resolved => closed
2014-03-06 10:16 nicole Target Version Slicer 4.3.2 => Slicer 4.4.0
2014-03-06 10:17 nicole Fixed in Version Slicer 4.3.2 => Slicer 4.4.0
2014-07-03 17:44 jcfr Note Added: 0012140
2014-07-03 17:45 jcfr Note Edited: 0012140
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file ff5f5a86
2017-06-07 23:27 jcfr Note Added: 0014572
2017-06-10 08:51 jcfr Changeset attached => Slicer master ff5f5a86