0004066: Threshold paint don't work with values of 0

ID	Project	Category	View Status	Date Submitted	Last Update

0004066	Slicer4	Module Editor	public	2015-10-22 15:42	2018-03-02 11:06

Reporter	alejcs	Assigned To	pieper
Priority	normal	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	Slicer 4.4.0
Target Version	Slicer 4.5.0-1	Fixed in Version	Slicer 4.5.0-1

Summary	0004066: Threshold paint don't work with values of 0
Description	From Steve: The issue is that the threshold is exclusive, meaning that the min (zero in this case) is not included in the range at this line [1]. I'm thinking that since the available range for threshold is the lowest and highest pixel in the volume it would make more sense for that operation to be value >= range[0] && value <= range[1].
Tags	No tags attached.

2015-10-22 15:42	test1.nrrd (2,436,912 bytes)

pieper 2015-10-23 10:08 administrator ~0013393	Fixed as of r24656. http://massmail.spl.harvard.edu/public-archives/slicer-users/2015/009681.html

pieper 2015-10-23 10:10 administrator ~0013394	Please give it a try with tomorrow's nightly build. It seems to work fine for me on your data. http://www.slicer.org/slicerWiki/index.php?title=Documentation%2FNightly%2FModules%2FEditor&diff=43077&oldid=36644

Import 2017-06-07 23:51:09: master 64c075ae 2015-10-23 13:30:40 pieper Details Diff	BUG: 0004066 Editor threshold paint should have inclusive range See discussion here: http://www.na-mic.org/Bug/view.php?id=4066 From: Steve Pieper <pieper@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24656 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - Modules/Scripted/EditorLib/Logic/vtkImageSlicePaint.cxx		Diff File

Date Modified	Username	Field	Change
2015-10-22 15:42	alejcs	New Issue
2015-10-22 15:42	alejcs	Status	new => assigned
2015-10-22 15:42	alejcs	Assigned To	=> jcfr
2015-10-22 15:42	alejcs	File Added: test1.nrrd
2015-10-23 09:56	pieper	Assigned To	jcfr => pieper
2015-10-23 09:56	pieper	Status	assigned => acknowledged
2015-10-23 09:56	pieper	Category	Core: Base Code => Module Editor
2015-10-23 09:56	pieper	Target Version	=> Slicer 4.5.0-1
2015-10-23 10:08	pieper	Note Added: 0013393
2015-10-23 10:10	pieper	Note Added: 0013394
2015-10-23 10:10	pieper	Status	acknowledged => resolved
2015-10-23 10:10	pieper	Fixed in Version	=> Slicer 4.5.0-1
2015-10-23 10:10	pieper	Resolution	open => fixed
2015-11-02 05:58	jcfr	Relationship added	related to 0001994
2017-06-10 08:51	pieper	Changeset attached	=> Slicer master 64c075ae
2018-03-02 11:06	jcfr	Status	resolved => closed