Changesets: Import 2017-06-07 23:51:09

master c829548a

2014-03-03 09:38:14

jcfr

Details Diff
ENH: Adding SimpleITK Python threading, and progress/abort to SimpleFilters

Enabling SimpleITK Python threading. This unlock the Python GIL while
inside C++ code in ITK, while still having safe commands on events.

Updated SimpleFilters with support for SimpleITK 0.8rc1, and adding a
progress bar and abort button.

$ git log --oneline 3bc2fdc5ca5c72b3fbfc596213eecf89cec31b32..
c939ce0 Update to use namespace KernelEnum types for morphology
34e55c9 Verify the update-sitk update branch does not exist before json update
5cb03ef Merge branch 'sitk-upstream'
f46c414 SimpleITK 9f758175 Filter descriptions (reduced)
18db32e Adding Cancel button to abort filter processing.
757d0fe Adding ProgressBar and SimpleITK events

From: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22917 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File
mod - SuperBuild/External_SimpleITK.cmake Diff File

master 9bab455e

2014-03-02 21:51:57

jcfr

Details Diff
BUG: Fixed various errors in the save scene dialog for mrb format

There were 3 problems:
1. When the save scene dialog is shown first, the file format selector is empty
2. When a scene is saved as .mrb and then the save dialog is opened again the format is still .mrb, but the populated items are not disabled
3. When a scene is saved as .mrb and then the save dialog is opened again the target directory is not the same (it’s the parent directory of the directory where the scene was saved the last time)

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22916 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerSaveDataDialog.cxx Diff File

master 4a6ca48f

2014-03-02 19:08:33

jcfr

Details Diff
COMP: C++11 convertsion of types

error: no viable conversion from 'DiffusionTensor3DExtended<float>' to 'DiffusionTensor3DExtended<double>'

By preferring initialization to assignment this error is avoided.

From: Hans Johnson <hans-johnson@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22915 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DAbsCorrection.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNearestCorrection.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DPPDAffineTransform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DZeroCorrection.h Diff File

master 7f23baf3

2014-03-02 19:08:31

jcfr

Details Diff
COMP: C++11 compiler warning convert NULL to bool

warning: implicit conversion of NULL constant to 'bool' [-Wnull-conversion]

From: Hans Johnson <hans-johnson@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22914 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.cxx Diff File

master ec4b62ea

2014-03-02 19:08:28

jcfr

Details Diff
COMP: C++11 conformance for static initialization

error: non-constant-expression cannot be narrowed from type 'unsigned long' to 'IndexValueType' (aka 'long') in initializer list [-Wc++11-narrowing]
as identifiied by the clang compiler.

From: Hans Johnson <hans-johnson@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22913 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLVolumeNode.cxx Diff File
mod - Libs/vtkITK/itkTimeSeriesDatabase.txx Diff File
mod - Modules/Loadable/CropVolume/Logic/vtkSlicerCropVolumeLogic.cxx Diff File

master c8c39f43

2014-02-27 18:43:52

naucoin

Details Diff
BUG: reset table range for label map volumes

Label map volumes need to be mapped to colors in the color
look up table. For editing, don't allow procedurally defined
color nodes to be chosen.

Issue 0003586



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22912 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLLabelMapVolumeDisplayNode.cxx Diff File
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File

master da5665a8

2014-02-27 18:07:59

jcfr

Details Diff
COMP: Update VTK project to re-add support for additional call data types

Following r22898, the version of VTK has been changed to use the
branch named "slicer-release-5.10_2014-01-20". When initially created,
it didn't include the improvement to the CallDataType support. This commit
fixes this by including the following to commit into the SlicerVTK fork:

$ git shortlog e7464be93..4e0ca68
Jean-Christophe Fillion-Robin (2):
vtkPythonCommand - Add support for additional call data types
vtkPythonCommand - Fix indent and variable names

Note that this commit have already been contributed and integrated
into VTK6.
See http://review.source.kitware.com/#/t/3966
and https://github.com/Kitware/VTK/commit/3a2a3ce595daab0bc2a9f858ef593905fd77a9ce

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22911 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_VTK.cmake Diff File

master 3c31ef5a

2014-02-27 09:19:13

jcfr

Details Diff
ENH: Associated hierarchy node with ChildNode(Added/Removed)Event

It will now be easier to know which node has been added or removed
from a given hierarchy.

Still need to figure out which node to associated with the event
'ChildNodeRemovedEvent' invoked in function 'vtkMRMLHierarchyNode::RemoveHierarchyChildrenNodes'

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22910 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLHierarchyNode.cxx Diff File

master 0dc6eab3

2014-02-26 19:28:55

jcfr

Details Diff
COMP: ExternalProject_Add_Source - Do not create build directory

Specify the 'BUILD_IN_SOURCE' argument to skip the creation of
unwanted build directory.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22909 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/ExternalProjectAddSource.cmake Diff File

master 19b2f99d

2014-02-26 16:37:40

pieper

Details Diff
ENH: update the versions of CompareVolumes and LandmarkRegistration

Improved plugin support for plastimatch (SlicerRT) and also improved
visualization via the RevealCursor and Rock modes.

Also fix the tests by selecting the module at the start of the
test (when running as a self test slicer starts with the default
module).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22908 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 2bd7dc49

2014-02-26 14:25:38

jcfr

Details Diff
COMP: Simplify how BRAINSTools project options are specified

Source repository, revision and associated CMake options are not
all set in a single location.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22907 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Remote/CMakeLists.txt Diff File
mod - SuperBuild.cmake Diff File

master 6e1a3b46

2014-02-26 14:25:36

jcfr

Details Diff
ENH: Extend 'Slicer_RemoteModule_Add' to accept list of cache options

When the VARS argument is set to a list of variable of the form:

<name1>:<type1>=<value1> [<name2>:<type2>=<value2> [...]]

For more details, see inlined documentation.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22906 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/ExternalProjectAddSource.cmake Diff File

master 18137e11

2014-02-26 14:25:35

jcfr

Details Diff
COMP: Do not force BRAINSTools options to ensure they can overwritten

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22905 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Remote/CMakeLists.txt Diff File

master 54c55be0

2014-02-26 14:25:33

jcfr

Details Diff
COMP: Remove now obsolete patching of BRAINSTools ExternalData module

Considering both projects now use the same version of the module, it is
not required anymore to copy it.
See the associated BRAINStools issue for more details: https://github.com/BRAINSia/BRAINSTools/issues/3

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22904 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Remote/CMakeLists.txt Diff File

master 27df19da

2014-02-25 18:10:55

naucoin

Details Diff
BUG: get CLI module logic temp dir from application

Resetting the temporary directory at the application settings level
wasn't propagated to the CLI module logic. This change has the CLI
module logic getting the temporary directory from the application
as necessary.

Issue 0003587



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22903 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/qSlicerCLIModule.cxx Diff File
mod - Base/QTCLI/vtkSlicerCLIModuleLogic.cxx Diff File
mod - Base/QTCLI/vtkSlicerCLIModuleLogic.h Diff File

master 0495d368

2014-02-25 17:53:02

jcfr

Details Diff
ENH: Update tag for OpenIGTLinkIF in response to issue 0003596.

From: Junichi Tokuda <tokuda@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22902 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 7425a1b6

2014-02-25 11:45:26

alexy

Details Diff
BUG: fixed qSlicerTransformModuleWidget::Invert method and qSlicerTransformModuleWidget test.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22901 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Transforms/Testing/Cxx/qSlicerTransformsModuleWidgetTest.cxx Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.cxx Diff File

master 8b3ab5b2

2014-02-25 11:43:23

jcfr

Details Diff
BUG: fixed improper importing a series of dicom images.

Fixes 0003386

From: Kevin Wang <kevin.wang@rmp.uhn.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22900 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/vtkITKArchetypeImageSeriesReader.cxx Diff File

master 538411a6

2014-02-25 09:51:07

jcfr

Details Diff
COMP: Updating SimpleITK to 0.8rc1 and SWIG to 2.0.12

This version of SimpleITK addresses compilation issue with clang 5.0
on OSX with libc++. SimpleITK will now automatically be compiled with
"-std=c++11".

From: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22899 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_SimpleITK.cmake Diff File
mod - SuperBuild/External_Swig.cmake Diff File

master 3378d288

2014-02-25 09:51:05

jcfr

Details Diff
COMP: Update VTK external project to fix clang compilation issue

A new branch named "slicer-release-5.10_2014-01-20" has been pushed
to the Slicer VTK fork. It contains all the Slicer VTK specific commits
rebased on top of the HEAD of the vtk 5.10 release branch available
when this commit has done.

The difference between the v5.10.1 and the head of the vtk 5.10 release
branch are reported below.

$ git shortlog d3b66526624ba8e55addcddb0ec28c40982473ac...v5.10.1 --no-merges
David Cole (1):
Rendering: Use AdjustWindowRect to ensure pixel perfect client size

Goodwin Lawlor (6):
Backport using Tcl_GetErrorLine with Tcl8.6
Let macro find TclTk version 8.6
Update the TclTk internal files for 8.6
Backport using Tcl_GetErrorLine with Tcl8.6
Let macro find TclTk version 8.6
Update the TclTk internal files for 8.6

Hans Johnson (1):
COMP: Fix compiler error on clang c++11

Sean McBride (5):
Conditionalize insane "#define inline" in libtiff
COMP: fixed compilation error using llvm's libc++
COMP: fixed llvm libc++ build error by removing invalid 'operator<<'
Fixed compile error with llvm libcxx
added missing #include, fixing compiler error with llvm's libc++

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22898 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_VTK.cmake Diff File

master 7c4fb9b3

2014-02-24 17:28:45

jcfr

Details Diff
COMP: Fix unused variable warnings.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22897 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLNonlinearTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTransformStorageNode.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLayerLogic.cxx Diff File

master 706b4835

2014-02-24 17:28:42

jcfr

Details Diff
ENH: Improve readability using vtkNew where possible

In addition to be shorter, it simply conveys the idea of locally
instantiating an object.

Indeed, vtkNew allow to instantiate an object on the heap and deleting it
when it goes out of scope if its reference count has not been incremented by
either assigning the object to a smart pointer or calling Register.

This commit continues the work initiated in commit r22539

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22896 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/vtkDataIOManagerLogic.cxx Diff File
mod - Base/Logic/vtkSlicerTransformLogic.cxx Diff File
mod - Base/QTCore/qSlicerSlicer2SceneReader.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeNode.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLColorLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLayerLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLogic.cxx Diff File

master f05415af

2014-02-21 12:48:39

jcfr

Details Diff
ENH: Disable slice view reset (volume propagation) if CLI Autorun is enabled.

Disable slice view reset (volume propagation) is important, because when
we change a CLI parameter we want to keep all the carefully chosen slice
view settings (background/foreground volume selection, slice selection,
transparency, zoom, etc.). Before this change all the slice view settings
had to be set again after each parameter change, which basically rendered
the Autorun feature useless for modules with volume output.

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22895 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/vtkSlicerCLIModuleLogic.cxx Diff File

master fea51229

2014-02-21 10:58:08

jcfr

Details Diff
COMP: Remove redundant Error/Warning Ctest custom match expression.

As of kitware/CMake@b2634b6aaor for any version of CMake >= v2.8.3, these
expressions are already included in the default CTest list
implemented in cmCTestBuildHandler.cxx

See [1], [2] and [3]

Co-authored-by: Christopher Mullins <christopher.mullins@kitware.com>
Co-authored-by: Matt McCormick <matt.mccormick@kitware.com>

[1] http://cmake.org/gitweb?p=cmake.git;a=commit;h=b2634b6aa3a0203e3a97060cf9e3206245a85080
[2] http://cmake.org/gitweb?p=cmake.git;a=blob;f=Source/CTest/cmCTestBuildHandler.cxx;h=c5deb964a38fe7ed37c08562112800b961788269;hb=HEAD#l70
[3] http://cmake.org/gitweb?p=cmake.git;a=blob;f=Source/CTest/cmCTestBuildHandler.cxx;h=c5deb964a38fe7ed37c08562112800b961788269;hb=HEAD#l136

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22894 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/CTestCustom.cmake.in Diff File

master a0fed207

2014-02-20 20:36:25

jcfr

Details Diff
ENH: Implemented GetMarkupIndexByID and GetMarkupByID methods

From: Laurent Chauvin <lchauvin@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22893 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.h Diff File
mod - Modules/Loadable/Markups/Testing/Cxx/vtkMRMLMarkupsNodeTest2.cxx Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 123 124 125 126 127 128 129 130 ... 133 134 135  Next  Last