Hi Jc and Matt,

I have pushed a topic to https://github.com/kevinwangcanada/Slicer/tree/3386-Import-of-certain-dicom-image-series-results-in-incorrect-scalar-type.

Please let me know if you have any questions.

Thanks,

Kevin

Hi Matt,

I changed the ticket assignment to you as you are probably more familiar with this issue and have the time to take a quick check on my code.

Thanks,

Kevin

Hi Kevin,

Very good work. I did a code review on the patch and only made minor comments.

Did you want to test/commit, or should I?

Thanks,
Matt

Thanks Matt for the quick review. I have modified the code according and tested/committed to my own topic.

I changed int to unsigned int instead of size_t just to be consistent with all other for loops. if you feel the need then I can change them all to size_t.

do you want me to submit a pull request so that you can integrate this topic into slicer trunk?

Kevin

Great, thanks. Yes, if you submit a pull request, I'll test/merge it with git-svn.

I have submit a pull request.

Thanks.

Fixed in r22900
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22900

Please, close the issue after testing it works as expected. Thanks

thanks Jc, I will test it and close the issue once the testing is done.

Tested and closed.