0003587: Resetting the temporary directory doesn't prompt a restart, CLI logic uses old value

ID	Project	Category	View Status	Date Submitted	Last Update

0003587	Slicer4	Core: CLI infrastructure	public	2014-02-12 10:58	2017-06-10 08:51

Reporter	nicole	Assigned To	millerjv
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	fixed
Platform	Mac	OS	OSx	OS Version
Product Version	Slicer 4.3.1
Target Version	Slicer 4.4.0	Fixed in Version	Slicer 4.4.0

Summary	0003587: Resetting the temporary directory doesn't prompt a restart, CLI logic uses old value
Description	A user had problems with a temporary directory path that didn't exist, changed it, and was still having the same error message. When she ran Model Maker from the command line it worked, and Model Maker worked from Slicer after restarting it, but there was no prompt to resetart after resetting the Temporary Directory.
Steps To Reproduce	Start Slicer Edit -> Application Settings -> Modules Change the Temporary Directory Click Okay (no prompt for restarting appeared for me) Run Model Maker On the Model Maker command line, the old temporary directory is still being used.
Tags	No tags attached.

nicole 2014-02-14 07:31 administrator ~0010592	Digging into this a bit, the CLI module logic keeps an internal copy of the temporary directory path, but it's not listening for modified events on the application logic where the GUI sets the new path. So the CLI module logic could respond to that modified event (or an added a specific temp path modified event) or we could set the temporary dir as a setting that requires restart in the module settings panel. I'm leaning toward the second option as it would require less code changes and ensure that the temp path was reset throughout Slicer. Though grepping through the .h files, it looks like the CLI module logic is the only one keeping an internal copy, so the bigger question is does it need to? Why can't it get the temp path from the application logic as needed?

nicole 2014-02-26 05:54 administrator ~0010645	Updated the CLI module logic to always get the temp directory from the application logic, svn 22903: http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22903

pieper 2014-03-06 09:37 administrator ~0011242	Nicole fixed it for you Jim!

Import 2017-06-07 23:51:09: master 27df19da 2014-02-25 18:10:55 naucoin Details Diff	BUG: get CLI module logic temp dir from application Resetting the temporary directory at the application settings level wasn't propagated to the CLI module logic. This change has the CLI module logic getting the temporary directory from the application as necessary. Issue 0003587 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22903 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - Base/QTCLI/qSlicerCLIModule.cxx	Diff File
	mod - Base/QTCLI/vtkSlicerCLIModuleLogic.cxx	Diff File
	mod - Base/QTCLI/vtkSlicerCLIModuleLogic.h	Diff File

Date Modified	Username	Field	Change
2014-02-12 10:58	nicole	New Issue
2014-02-12 10:58	nicole	Status	new => assigned
2014-02-12 10:58	nicole	Assigned To	=> millerjv
2014-02-12 10:59	nicole	Relationship added	child of 0003180
2014-02-14 07:31	nicole	Note Added: 0010592
2014-02-26 05:54	nicole	Note Added: 0010645
2014-02-26 05:54	nicole	Status	assigned => resolved
2014-02-26 05:54	nicole	Fixed in Version	=> Slicer 4.3.2
2014-02-26 05:54	nicole	Resolution	open => fixed
2014-03-06 09:37	pieper	Note Added: 0011242
2014-03-06 09:37	pieper	Status	resolved => closed
2014-03-06 10:17	nicole	Fixed in Version	Slicer 4.3.2 => Slicer 4.4.0
2017-06-10 08:51		Changeset attached	=> Slicer master 27df19da