0003596: OpenIGTLinkIF to MRML, default to STATE_OFF

ID	Project	Category	View Status	Date Submitted	Last Update

0003596	Slicer4	Module OpenIGTLinkIF	public	2014-02-24 13:53	2017-06-10 08:51

Reporter	tokuda	Assigned To	tokuda
Priority	normal	Severity	feature	Reproducibility	N/A
Status	closed	Resolution	fixed
Product Version	Slicer 4.3.1-2
Target Version	Slicer 4.4.0	Fixed in Version	Slicer 4.4.0

Summary	0003596: OpenIGTLinkIF to MRML, default to STATE_OFF
Description	Isaiah reported: I propose here: https://github.com/openigtlink/OpenIGTLinkIF/pull/24 to make the OpenIGTLinkIF connection state always save to STATE_OFF. My immediate justification is that we don't want users who review archived scenes while on the Partners network to unwittingly make connection requests to BrainLab during a case. But it also seems a good idea that in general an external connection request should not be made without the user intention.
Tags	No tags attached.

tokuda 2014-02-24 13:55 developer ~0010628	After some discussion among Isaiah, Andras, Tamas, and Junichi, we decided to add "persistent" check box next to "Active" If "Persistent" is checked then the current behavior is kept (automatic activate if the connection was active at the time of scene save). If "Persistent" is unchecked then "Active" is turned off when the scene is loaded/imported. Andras

tokuda 2014-02-24 13:55 developer ~0010629	https://github.com/openigtlink/OpenIGTLinkIF/pull/24#issuecomment-35944250

tokuda 2014-02-25 10:05 developer ~0010635	Isaiah modified the OpenIGTLinkIF in: https://github.com/openigtlink/OpenIGTLinkIF/pull/24

tokuda 2014-02-25 12:22 developer ~0010639	The code has been tested locally with the latest Slicer. GIT_TAG for OpenIGTLinkIF has been updated: https://github.com/tokjun/Slicer/compare/3596-OpenIGTLinkIF-persistent-mode

tokuda 2014-02-25 12:23 developer ~0010640	Pull request has been created

jcfr 2014-02-25 12:54 administrator ~0010641	For reference: Fixed in r22902 See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22902

jcfr 2014-09-17 23:01 administrator ~0012573	Closing resolved issues that have not been updated in more than 3 months.

Import 2017-06-07 23:51:09: master 0495d368 2014-02-25 17:53:02 jcfr Details Diff	ENH: Update tag for OpenIGTLinkIF in response to issue 0003596. From: Junichi Tokuda <tokuda@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22902 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - SuperBuild.cmake		Diff File

Date Modified	Username	Field	Change
2014-02-24 13:53	tokuda	New Issue
2014-02-24 13:53	tokuda	Status	new => assigned
2014-02-24 13:53	tokuda	Assigned To	=> tokuda
2014-02-24 13:55	tokuda	Note Added: 0010628
2014-02-24 13:55	tokuda	Note Added: 0010629
2014-02-25 10:05	tokuda	Note Added: 0010635
2014-02-25 12:22	tokuda	Note Added: 0010639
2014-02-25 12:23	tokuda	Note Added: 0010640
2014-02-25 12:23	tokuda	Status	assigned => resolved
2014-02-25 12:23	tokuda	Resolution	open => fixed
2014-02-25 12:54	jcfr	Note Added: 0010641
2014-02-25 12:55	jcfr	Fixed in Version	=> Slicer 4.4.0
2014-02-25 12:55	jcfr	Target Version	=> Slicer 4.4.0
2014-09-17 22:59	jcfr	Status	resolved => closed
2014-09-17 23:01	jcfr	Note Added: 0012573
2017-06-10 08:51	jcfr	Changeset attached	=> Slicer master 0495d368