Changesets: Import 2017-06-07 23:51:09

master 2cdce7e8

2014-02-20 20:11:21

jcfr

Details Diff
COMP: Update OpenIGTLinkIF to fix TDATA segfault

For reference, see:

https://github.com/openigtlink/OpenIGTLinkIF/pull/23

and

https://github.com/SlicerIGT/OpenIGTLinkRemote/issues/18

From: Isaiah Norton <inorton@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22892 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 4a06a8a1

2014-02-20 12:28:39

inorton

Details Diff
BUG: Fix 0003585. Python bool('string') == True for any non-empty string

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22891 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOM/DICOM.py Diff File

master 747a1a6c

2014-02-20 03:06:35

jcfr

Details Diff
COMP: Fix loadable module template build error (introduced by r22759)

Thanks to "Zian Fanti" for reporting the error.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22890 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/Testing/LoadableExtensionTemplate/LoadableModuleTemplate/Logic/vtkSlicerLoadableModuleTemplateLogic.cxx Diff File
mod - Extensions/Testing/SuperBuildExtensionTemplate/SuperLoadableModuleTemplate/Logic/vtkSlicerSuperLoadableModuleTemplateLogic.cxx Diff File

master 8e326873

2014-02-19 15:02:31

jcfr

Details Diff
COMP: Tweak msvc9compiler patch to also use with older installation of SDK

While this version allow to compile on modern version of Visual Studio,
it broke the build on older version.

For example, on the dashboard District9, with the following version
installed:
Microsoft Visual Studio 2008
Version 9.0.30729.1 SP
Microsoft .NET Framework
Version 3.5 SP1

It will ensure the following paths are also returned:

include:
C:\\Program Files\\Microsoft SDKs\\Windows\\v6.0A\\include;
lib:
C:\\Program Files\\Microsoft SDKs\\Windows\\v6.0A\\lib;
libpath:
c:\\WINDOWS\\Microsoft.NET\\Framework\\v3.5;
c:\\WINDOWS\\Microsoft.NET\\Framework\\v2.0.50727;
path:
c:\\WINDOWS\\Microsoft.NET\\Framework\\v3.5;
c:\\WINDOWS\\Microsoft.NET\\Framework\\v2.0.50727;
C:\\Program Files\\Microsoft SDKs\\Windows\\v6.0A\\bin;

Instead of tweaking the updated "query_vcvarsall", a "dumb" approach
as been considered. The unpatched version of the function has been re-added
as "query_vcvarsall_default" and path discovered by new and original approach
are merged into the same dictionary.

Note that the "query_vcvarsall_default" doesn't raise an exception anymore
if no interesting path are found.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22889 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/python_patched_msvc9compiler.py Diff File

master 9ea13d8a

2014-02-18 19:25:18

jcfr

Details Diff
COMP: Support Numpy building using VS Express and Windows SDK

See inline comments added to "python_patch.cmake" for more details.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22888 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_python.cmake Diff File
mod - SuperBuild/python_patch.cmake Diff File
add - SuperBuild/python_patched_msvc9compiler.py Diff File

master 6121b790

2014-02-18 11:56:16

alexy

Details Diff
ENH: Added tests for BSpline and Grid transforms and corresponding MRML nodes.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22887 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/CMakeLists.txt Diff File
add - Libs/MRML/Core/Testing/NonLinearTransformScene.mrml Diff File
add - Libs/MRML/Core/Testing/TestData/Bspline-f-m.tfm Diff File
add - Libs/MRML/Core/Testing/TestData/deform2x2x2_ras.nrrd Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLNonlinearTransformNodeTest1.cxx Diff File

master c8d58cb1

2014-02-16 21:19:54

alexy

Details Diff
ENH: Added new vtkMRMLTransformNode attribute: readWriteAsTransformToParent

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22886 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Testing/Data/Input/ExecutionModelTourTest.mrml Diff File

master 718ada0d

2014-02-16 15:51:57

jcfr

Details Diff
STYLE: Rename DiffusionTensorScalarMeasurements option name

The original option name was misleading, it has been renamed to better
guide the user.

Fixes 0003591

Co-authored-by: Sonia Pujol <spujol@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22885 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/DiffusionTensorScalarMeasurements/DiffusionTensorScalarMeasurements.xml Diff File

master e20534f4

2014-02-15 16:47:25

alexy

Details Diff
BUG: Fixed usage of GetXYToIJKTransform in Editor tools

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22884 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/LevelTracingEffect.py Diff File
mod - Modules/Scripted/EditorLib/PaintEffect.py Diff File

master 6b7a2623

2014-02-15 16:31:27

jcfr

Details Diff
ENH: Add second pimpl constructor to qMRMLTreeView

Adding a second protected constructor that takes the pimpl instance as argument allows subclassing and using qMRMLTreeViewPrivate from a subclass of the tree view.

Export qMRMLWidgets_INCLUDE_DIRS CMake variable from SlicerConfig to be able to include those directories without CMake path construction magic.

From: Csaba Pinter <csaba.pinter@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22883 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerConfig.cmake.in Diff File
mod - CMake/SlicerGenerateSlicerConfig.cmake Diff File
mod - Libs/MRML/Widgets/qMRMLTreeView.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLTreeView.h Diff File
mod - Libs/MRML/Widgets/qMRMLTreeView_p.h Diff File

master 06f3c06e

2014-02-15 16:18:59

alexy

Details Diff
BUG: Fix BSpline transform reducing "event thrashing"

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22882 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLBSplineTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLBSplineTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLGridTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLGridTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLNonlinearTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNonlinearTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTransformStorageNode.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File
mod - Libs/vtkITK/vtkITKBSplineTransform.cxx Diff File
mod - Libs/vtkITK/vtkITKBSplineTransform.h Diff File

master 8c978e98

2014-02-14 19:03:53

naucoin

Details Diff
BUG: back out table range for LUTs from file

Painting in the editor is not showing the correct
colors when the table range is set to 0-255, go back
to using the maxID as the upper range for now.

Issue 0003586



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22881 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLColorTableStorageNode.cxx Diff File

master 9d414cdd

2014-02-14 18:44:04

alexy

Details Diff
BUG: Fixed usage of GetXYToIJKTransform in Editor tools

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22880 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/ChangeIslandEffect.py Diff File
mod - Modules/Scripted/EditorLib/Effect.py Diff File
mod - Modules/Scripted/EditorLib/LabelEffect.py Diff File
mod - Modules/Scripted/EditorLib/LevelTracingEffect.py Diff File
mod - Modules/Scripted/EditorLib/PaintEffect.py Diff File
mod - Modules/Scripted/EditorLib/SaveIslandEffect.py Diff File
mod - Modules/Scripted/EditorLib/WandEffect.py Diff File

master 6c4e5c47

2014-02-14 17:40:40

alexy

Details Diff
BUG: Fixed usage of GetXYToIJKTransform in Editor PaintEffectTool

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22879 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/PaintEffect.py Diff File

master 718e12e9

2014-02-14 14:48:51

naucoin

Details Diff
BUG: fix table range on color nodes

Color table range values were being set to the number of entries
in the look up table, rather than the range of scalar values that
are to be mapped through the table. This restricts that mapping (especially
when using them with volumes) to for example scalar values from 0-43
in the fMRI table, rather than allowing mapping of 0-255, the default
that is input to the map scalars to colors filter in the
slice pipeline.

Reset the table ranges on the fMRI, fMRIPA, Iron nodes, as well as
the default range for Copy and the color table storage node, to
allow mapping 0-255 rather than 0-number of colors.

Issue 0003586



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22878 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLColorTableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLColorTableStorageNode.cxx Diff File

master 1e69a36f

2014-02-14 11:11:06

alexy

Details Diff
BUG: fixed DataProbe module to work with non-linear transform

From: Alex Yarmarkovich <alexy@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22877 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DataProbe/DataProbe.py Diff File

master 8b9f560d

2014-02-14 11:10:58

alexy

Details Diff
ENH: rebased svn, fixed fiducials under nonlinear transform

From: Alex Yarmarkovich <alexy@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22876 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager2D.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager3D.cxx Diff File

master 6568a2a6

2014-02-14 11:10:47

alexy

Details Diff
ENH: Made Markup and Annotation work with non-linear transforms

From: Alex Yarmarkovich <alexy@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22875 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLModelDisplayNode.h Diff File
mod - Libs/MRML/Widgets/qMRMLSceneModel.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSceneTransformModel.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationNode.h Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationROINode.cxx Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager2D.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager3D.cxx Diff File

master 40f74cdf

2014-02-14 11:10:27

alexy

Details Diff
ENH: changes to support non-linear transforms

From: Alex Yarmarkovich <alexy@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22874 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLBSplineTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLBSplineTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLGridTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLGridTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLLinearTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLLinearTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLNonlinearTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNonlinearTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLROINode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTransformStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeNode.h Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLayerLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLayerLogic.h Diff File
mod - Libs/MRML/Widgets/qMRMLLinearTransformSlider.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLMatrixWidget.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationROINode.cxx Diff File
mod - Modules/Loadable/ModelMirror/Logic/vtkModelMirrorLogic.cxx Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.cxx Diff File

master 89d6e7af

2014-02-14 11:09:59

alexy

Details Diff
COMP: Move vtkImageResliceMask from MRML/Logic to MRML/Core

This is done anticipating the implementation of the
non-linear transform support that will expect MRML node to depend on the
functionality of the vtkImageResliceMask filter.

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22873 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/CMakeLists.txt Diff File
mod - Libs/MRML/Logic/CMakeLists.txt Diff File

master 33b2d91f

2014-02-14 11:09:48

alexy

Details Diff
STYLE: Remove trailing white space from vtkImageResliceMask files

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22872 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkImageResliceMask.cxx Diff File
mod - Libs/MRML/Logic/vtkImageResliceMask.h Diff File

master c5a39acf

2014-02-12 18:04:30

jcfr

Details Diff
ENH: Update VTK - Add support for additional observer CallDataType

//--------------
vtkPythonCommand - Add support for additional call data types

This commit extends the mechanism added in 9366ca67 to support additional
data types.

Supported types now includes 'string0', 'vtkobject', 'int', 'long',
'double' and 'float'.

Also added convenience decorator 'set_call_data_type'

See inlined comments for more details.

The integration in VTK proper has been proposed here:
http://review.source.kitware.com/#/t/3966/
//--------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22871 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_VTK.cmake Diff File

master a913ea9a

2014-02-11 11:51:38

jcfr

Details Diff
COMP: Adding support for Apple's Retina display for fonts

Enable improved rendering of fonts on Apple's retina displays by
adding a custom bundle plist file with the following additional
elements:

<key>NSPrincipalClass</key>
<string>NSApplication</string>
<key>NSHighResolutionCapable</key>
<string>True</string>

The remainder of the input plist file is based on the current in file
from CMake.

For reference: https://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-os-ios-and-x11/

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22870 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/CMakeLists.txt Diff File
add - CMake/MacOSXBundleInfo.plist.in Diff File

master 18ea9641

2014-02-11 11:51:34

jcfr

Details Diff
ENH: Add support for user-defined stereo-viewing options

This will make it easier to implement support new stereoscopic 3D devices.

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22869 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLViewNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLViewNode.h Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLViewDisplayableManager.cxx Diff File
mod - Libs/MRML/Widgets/Resources/UI/qMRMLThreeDViewControllerWidget.ui Diff File
mod - Libs/MRML/Widgets/qMRMLThreeDViewControllerWidget.cxx Diff File

master e9e9f120

2014-02-09 15:14:14

pieper

Details Diff
BUG: add missing return statements when read fails - led to crash

ReadDataInternal is meant to return a status code indicating success
or failure, however some branches that generated error messages
neglected to return 0 meaning that the calling code interpreted
this as a success condition. In some cases this led to a crash, for
example when importing RGB dicom files.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22868 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLVolumeArchetypeStorageNode.cxx Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 124 125 126 127 128 129 130 ... 133 134 135  Next  Last