Changesets: Import 2017-06-07 23:51:09

Search Browse Back to Index

master 5d085ba0

2017-03-20 12:58:37

jcfr

Details Diff 		ENH: Add external project step allowing to keep track of project version.

This commit adds a module named "ExternalProjectGenerateProjectDescription"
providing a convenient function allowing to add a step generating
a project description file containing the name of the project and
its version.

For each project instrumented with this function, a file named
"version-<projectnmame>.txt" is generated in ${CMAKE_BINARY_DIR}.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25847 3bd1e089-480b-0410-8dfb-8563597acbee
add - CMake/ExternalProjectGenerateProjectDescription.cmake Diff File
mod - CMakeLists.txt Diff File
mod - SuperBuild/External_CTK.cmake Diff File
mod - SuperBuild/External_CTKAPPLAUNCHER.cmake Diff File
mod - SuperBuild/External_CTKResEdit.cmake Diff File
mod - SuperBuild/External_DCMTK.cmake Diff File
mod - SuperBuild/External_ITKv4.cmake Diff File
mod - SuperBuild/External_LibArchive.cmake Diff File
mod - SuperBuild/External_NUMPY.cmake Diff File
mod - SuperBuild/External_OpenIGTLink.cmake Diff File
mod - SuperBuild/External_OpenSSL.cmake Diff File
mod - SuperBuild/External_PCRE.cmake Diff File
mod - SuperBuild/External_SimpleITK.cmake Diff File
mod - SuperBuild/External_SlicerExecutionModel.cmake Diff File
mod - SuperBuild/External_Swig.cmake Diff File
mod - SuperBuild/External_VTKv7.cmake Diff File
mod - SuperBuild/External_curl.cmake Diff File
mod - SuperBuild/External_python-GitPython.cmake Diff File
mod - SuperBuild/External_python-PyGithub.cmake Diff File
mod - SuperBuild/External_python-chardet.cmake Diff File
mod - SuperBuild/External_python-couchdb.cmake Diff File
mod - SuperBuild/External_python-gitdb.cmake Diff File
mod - SuperBuild/External_python-nose.cmake Diff File
mod - SuperBuild/External_python-pydicom.cmake Diff File
mod - SuperBuild/External_python-setuptools.cmake Diff File
mod - SuperBuild/External_python-smmap.cmake Diff File
mod - SuperBuild/External_qRestAPI.cmake Diff File
mod - SuperBuild/External_tcl.cmake Diff File
mod - SuperBuild/External_teem.cmake Diff File
mod - SuperBuild/External_zlib.cmake Diff File

master 6fe601ef

2017-03-20 11:07:14

jcfr

Details Diff 		ENH: Support configuration of external project GIT tag and repository

For any given project checkout using Git, setting cache or environment
variables of the form:

Slicer_<proj>_GIT_REPOSITORY
Slicer_<proj>_GIT_TAG

allows to override the default values set within each External_* files.

Fixes 0004148

Co-authored-by: "T.J. Corona" <tj.corona@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25846 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File
mod - SuperBuild/External_DCMTK.cmake Diff File
mod - SuperBuild/External_ITKv4.cmake Diff File
mod - SuperBuild/External_JsonCpp.cmake Diff File
mod - SuperBuild/External_LibArchive.cmake Diff File
mod - SuperBuild/External_OpenIGTLink.cmake Diff File
mod - SuperBuild/External_ParameterSerializer.cmake Diff File
mod - SuperBuild/External_RapidJSON.cmake Diff File
mod - SuperBuild/External_SimpleITK.cmake Diff File
mod - SuperBuild/External_SlicerExecutionModel.cmake Diff File
mod - SuperBuild/External_VTKv7.cmake Diff File
mod - SuperBuild/External_curl.cmake Diff File
mod - SuperBuild/External_python.cmake Diff File
mod - SuperBuild/External_qRestAPI.cmake Diff File
mod - SuperBuild/External_teem.cmake Diff File
mod - SuperBuild/External_zlib.cmake Diff File

master 744d8dfa

2017-03-20 11:07:07

jcfr

Details Diff 		COMP: Update ExternalProjectDependency based on commontk/Artichoke@35c64c7

$ git shortlog f3359ad..35c64c7 --no-merges
Jean-Christophe Fillion-Robin (5):
Add support for specifying a different CMAKE_GENERATOR for each project
Add support for specifying different toolset/platform for each project
Teach mark_as_superbuild how to handle variables with double-quotes
Add ExternalProject_SetIfNotDefined macro
ExternalProject_SetIfNotDefined: Add support for QUIET argument

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25845 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/ExternalProjectDependency.cmake Diff File

master 9fba9356

2017-03-17 16:02:18

pinter

Details Diff 		BUG: Restored storable criteria in parse local data plugin

The parse local data plugin by design can only work with storable nodes, because it builds the hierarchy based on the file locations found in the storage nodes. As non-storable nodes have no storage nodes, those nodes are not usable by the plugin

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25844 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyParseLocalDataPlugin.cxx Diff File

master a27bb850

2017-03-16 22:44:09

jcfr

Details Diff 		COMP: Update JsonCpp to fix GCC 6 build error. See 0004268

See http://slicer-devel.65872.n3.nabble.com/Slicer-gcc-6-tt4038282.html
and http://na-mic.org/Mantis/view.php?id=4268

$ git shortlog f4afa75..73b8e17 --no-merges
Gregory C. Sharp (1):
COMP: Update json_(reader|writer).cpp to fix gcc6 build error

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25843 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_JsonCpp.cmake Diff File

master d2cae240

2017-03-15 23:01:11

jcfr

Details Diff 		BUG: Update qRestAPI to fix regression causing extension installation failure

$ git shortlog 9d3cfb6..d1b07cc --no-merges
Jean-Christophe Fillion-Robin (1):
qMidasAPI: synchronousQuery: Fix regression and ensure query is sent

Reported-by: Andriy Fedorov <fedorov@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25842 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_qRestAPI.cmake Diff File

master dd6f18fa

2017-03-14 18:49:02

jcfr

Details Diff 		ENH: Update OpenIGTLink (Misc. fixes)

$ git shortlog 96233c8..ba56464 --no-merges
Jean-Christophe Fillion-Robin (2):
igtlMessageBase: Fix -Wsign-compare warning
igtlTrajectoryMessage: Fix -Wunused-parameter warning

Longquan Chen (6):
EHN: protocal file added in the library to synchonrize the source and protocol
BUG: The example network should be updated regarding the new meta data format
BUG: NDArray bug, private member called by child class
EHN: the same message won't repack its contents multiple times, as its m_bodyispack flag is set to true. SetDeviceName() function reset the m_bodyIsPacked flag. So the same message is able to repack its content
EHN: float value comparison error fixed
BUG: unpack byte order error is fixed

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25841 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_OpenIGTLink.cmake Diff File

master c7d2d4d2

2017-03-14 18:49:00

jcfr

Details Diff 		ENH: Update qRestAPI (Adds Qt5 support, Fix misc issues)

$ git shortlog 5a81c92..9d3cfb6 --no-merges
Andreas Fetzer (16):
Added support for sending HEAD request
Moved deletion of qRestResult outside the if/else in order to prevent leakage.
head request is now asynchronous.
Removed unused parameter, adapted documentation
Started to fix file upload
Remove duplicate connections. These ones are already created in the upload and download functions
Refactored upload function analogous to download
Removed unused slot
Emitting signal if upload is finished
Removed debug message
Pass rawheaders again
Added proper error handling in case the file could not be read. Also deleted input in case of an error.
Set parent for QFile in case of upload or download is called to assure that the file is always deleted.
Removed unnecessary uploadFinished signal
Added possibility to set a http network proxy
Use correct indent

Jean-Christophe Fillion-Robin (1):
Fix unused variable warnings

Miklos Espak (4):
Exporting qRestAPI_LIBRARY_DIRS for use by client code
No data is not regarded as error in XNAT queries
XNAT specific code removed
Return 0 if result has already been taken

Sascha Zelzer (16):
Added error reporting to qRestAPI.
Don't take result object before calling waitForDone().
Fixed inverted logic for returning true on success.
Clean-up query results.
Added error code for authentication errors.
Fixed wrong error code assignment.
Properly convert Qt network error codes to string.
Only parse the response if no network error occurred.
Added raw headers from the http response to qRestResult.
Create result objects based on a string id using the Qt meta type system.
Removed the "result" methods which instantiate objects.
Removed template method declarations for already removed implementations.
Deleting the QNetworkManager instance too early may lead to crashes.
Restore Qt 4.6.2 compatibility.
Added Qt5 compatibility.
The Result map can be empty on connection errors. Check that.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25840 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_qRestAPI.cmake Diff File

master 721be1ba

2017-03-14 00:54:02

jcfr

Details Diff 		ENH: Add optional checkable column in qMRMLColorModel

* Remove LabelInColorColumn to be more consistent with qMRMLSceneModel
columns.
* Fix updateColorFromItem() that was always forcing the color opacity to be
1.0 because QColor rgba was always opaque.

From: Julien Finet <julien.finet@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25839 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLCheckableNodeComboBox.h Diff File
mod - Libs/MRML/Widgets/qMRMLColorListView.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLColorModel.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLColorModel.h Diff File
mod - Libs/MRML/Widgets/qMRMLColorModel_p.h Diff File
mod - Libs/MRML/Widgets/qMRMLColorTableView.cxx Diff File

master 82d08ce1

2017-03-14 00:36:01

jcfr

Details Diff 		ENH: Add Contributing.md

Initial version of this document has adapted from Girder contribution
process document [1] by @jcfr and was updated during the Slicer weekly
hangouts to incorporate feedback from the community.

It includes the following sections:

* The PR Process, Circle CI, and Related Gotchas
* How to submit a PR ?
* How to efficiently contribute ?
* How to integrate a PR ?
* Automatic testing of pull requests
* Nightly tests
* Decision-making process
* Benevolent dictators for life

[1] https://github.com/girder/girder/blob/master/CONTRIBUTING.md

[ci skip]

Co-authored-by: Johan Andruejol <johan.andruejol@kitware.com>
Co-authored-by: Andriy Fedorov <fedorov@bwh.harvard.edu>
Co-authored-by: Alexis Girault <alexis.girault@kitware.com>
Co-authored-by: Michael Halle <mhalle@bwh.harvard.edu>
Co-authored-by: Ron Kikinis <kikinis@bwh.harvard.edu>
Co-authored-by: Andras Lasso <lasso@queensu.ca>
Co-authored-by: Matt McCormick <matt.mccormick@kitware.com>
Co-authored-by: Isaiah Norton <inorton@bwh.harvard.edu>
Co-authored-by: Steve Pieper <pieper@isomics.com>
Co-authored-by: Csaba Pinter <csaba.pinter@queensu.ca>
Co-authored-by: Hina Shah <hina.shah@kitware.com>
Co-authored-by: Dzenan Zukic <dzenan.zukic@kitware.com>

Alphabetically ordered by last name.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25838 3bd1e089-480b-0410-8dfb-8563597acbee
add - CONTRIBUTING.md Diff File

master 6b4b4e1a

2017-03-14 00:10:43

jcfr

Details Diff 		COMP: qMRMLSegmentEditorWidget: Remove unused BINARY_LABELMAP_VOXEL_FULL const

Reviewed-by: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25837 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.cxx Diff File

master 18e5c211

2017-03-14 00:07:11

jcfr

Details Diff 		COMP: vtkMRMLCropVolumeParametersNode: Fix -Wunused-variable

This commit fixes the following warning:

/path/to/Slicer/Modules/Loadable/CropVolume/MRML/vtkMRMLCropVolumeParametersNode.cxx:35:20: warning: unused variable 'ROIAlignmentTransformNodeReferenceMRMLAttributeName' [-Wunused-variable]
static const char* ROIAlignmentTransformNodeReferenceMRMLAttributeName = "ROIAlignmentTransformNodeID";
^

From Andras: the unused ROIAlignmentTransformNodeReferenceMRMLAttributeName
can be removed (other node references have custom node attributes defined
for backward compatibility with old scenes when node references were not
supported yet).


Reviewed-by: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25836 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/CropVolume/MRML/vtkMRMLCropVolumeParametersNode.cxx Diff File

master 468f26fd

2017-03-13 23:18:40

lassoan

Details Diff 		ENH: Allow using all nodes in subject hierarchy

At some places it was assumed that subject hierarchy can only contain nodes derived from vtkMRMLStorableNode.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25835 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyParseLocalDataPlugin.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.cxx Diff File

master b37fe1e3

2017-03-13 23:18:36

lassoan

Details Diff 		BUG: Fixed SubjectHierarchy for nodes with SaveWithScene disabled

For nodes SaveWithScene=False, SH still contained a node ID reference in the scene. This caused incorrectly associating the SH node with an unrelated node existing in the scene with (accidentally) the same node ID.

When scene was loaded that contained invalid DataNode ID (because the node itself was missing from the scene) then the log message tried to print the DataNode pointer that was NULL, causing hang of the scene load (interestingly, the scene loading did not crash, probably some exception handler prevented that).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25834 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File

master 0f8ee7f1

2017-03-13 17:33:19

pinter

Details Diff 		STYLE: Clarification of messages in subject hierarchy folder plugin

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25833 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyFolderPlugin.cxx Diff File

master 5d1fd01c

2017-03-13 10:00:32

jcfr

Details Diff 		COMP: qSlicerTerminologyNavigatorWidget: Fix -Wunused-parameter warnings

This commit fixes the following warnings:

/path/to/Slicer/Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx:1601:63: warning: unused parameter 'name' [-Wunused-parameter]
void qSlicerTerminologyNavigatorWidget::onNameChanged(QString name)
^
/path/to/Slicer/Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx:1617:63: warning: unused parameter 'color' [-Wunused-parameter]
void qSlicerTerminologyNavigatorWidget::onColorChanged(QColor color)
^

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25832 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx Diff File

master 2ab50702

2017-03-13 09:58:49

jcfr

Details Diff 		COMP: qSlicerSubjectHierarchyPluginLogic: Fix -Wnull-conversion

This commit fixes the following warning:

/path/to/Slicer/Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.cxx:355:102: warning: implicit conversion of NULL constant to 'vtkIdType' (aka 'long long')
[-Wnull-conversion]
qSlicerSubjectHierarchyPluginHandler::instance()->pluginsForAddingNodeToSubjectHierarchy(node, NULL);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~
0

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25831 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.cxx Diff File

master ff6f4d57

2017-03-13 09:58:48

jcfr

Details Diff 		COMP: qSlicerSubjectHierarchyPluginLogic: Fix -Wunused-variable

This commit fixes the following warning:

/path/to/Slicer/Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyTreeView.cxx:849:42: warning: unused variable 'mostSuitablePluginByConfidenceNumbers' [-Wunused-variable]
qSlicerSubjectHierarchyAbstractPlugin* mostSuitablePluginByConfidenceNumbers =
^
/path/to/Slicer/Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.cxx:296:32: warning: unused variable 'shNode' [-Wunused-variable]
vtkMRMLSubjectHierarchyNode* shNode = vtkMRMLSubjectHierarchyNode::GetSubjectHierarchyNode(scene);
^

Reviewed-by: Csaba Pinter <csaba.pinter@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25830 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyTreeView.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.cxx Diff File

master f741008a

2017-03-13 09:00:11

jcfr

Details Diff 		STYLE: Fix style of ITK classes using KWStyle

This commit introduced the style Utilities/KWStyle/ITK.kws.xml based of
the official ITK Style.

Style was checked using the following command:

for file in $(find . | ack-grep "\/itk.+(h|cpp|txx|cxx)$"); do
KWStyle -gcc -xml ./Utilities/KWStyle/ITK.kws.xml $file;
done

KWStyle was built from source: https://github.com/Kitware/KWStyle

The following errors remain:

./Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarity3DTransform.h:109: error: Internal variable (itk::Rigid3DTransform<TScalarType>::SetMatrix) doesn't match regular expression (m_[A-Z])
./Modules/CLI/ResampleDTIVolume/Testing/itkTestMainExtended.h:17: error: namespace not defined

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25829 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/CLI/itkPluginFilterWatcher.h Diff File
mod - Libs/ITKFactoryRegistration/itkFactoryRegistration.cxx Diff File
mod - Libs/ITKFactoryRegistration/itkFactoryRegistration.h Diff File
mod - Libs/MRML/IDImageIO/itkMRMLIDImageIO.cxx Diff File
mod - Libs/MRML/IDImageIO/itkMRMLIDImageIO.h Diff File
mod - Libs/MRML/IDImageIO/itkMRMLIDImageIOFactory.cxx Diff File
mod - Libs/MRML/IDImageIO/itkMRMLIDImageIOFactory.h Diff File
mod - Libs/vtkITK/itkGrowCutSegmentationImageFilter.h Diff File
mod - Libs/vtkITK/itkGrowCutSegmentationImageFilter.txx Diff File
mod - Libs/vtkITK/itkLevelTracingImageFilter.h Diff File
mod - Libs/vtkITK/itkLevelTracingImageFilter.txx Diff File
mod - Libs/vtkITK/itkNewOtsuThresholdImageCalculator.h Diff File
mod - Libs/vtkITK/itkNewOtsuThresholdImageCalculator.txx Diff File
mod - Libs/vtkITK/itkNewOtsuThresholdImageFilter.h Diff File
mod - Libs/vtkITK/itkNewOtsuThresholdImageFilter.txx Diff File
mod - Libs/vtkITK/itkTimeSeriesDatabase.h Diff File
mod - Libs/vtkITK/itkTimeSeriesDatabase.txx Diff File
mod - Libs/vtkITK/itkTimeSeriesDatabaseHelper.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAffineImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAffineImageToImageRegistrationMethod.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarity3DTransform.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarity3DTransform.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarityLandmarkBasedTransformInitializer.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkBSplineImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkBSplineImageToImageRegistrationMethod.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageRegionMomentsCalculator.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageToImageRegistrationHelper.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageToImageRegistrationHelper.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageToImageRegistrationMethod.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkInitialImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkInitialImageToImageRegistrationMethod.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkOptimizedImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkOptimizedImageToImageRegistrationMethod.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkRigidImageToImageRegistrationMethod.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkRigidImageToImageRegistrationMethod.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/itkImageToImageRegistrationMethodTestingHelper.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/itkImageToImageRegistrationMethodTestingHelper.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/Testing/itkDifferenceDiffusionTensor3DImageFilter.h Diff File
mod - Modules/CLI/ResampleDTIVolume/Testing/itkDifferenceDiffusionTensor3DImageFilter.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/Testing/itkTestMainExtended.h Diff File
mod - Modules/CLI/ResampleDTIVolume/dtiprocessFiles/itkHFieldToDeformationFieldImageFilter.h Diff File
mod - Modules/CLI/ResampleDTIVolume/dtiprocessFiles/itkHFieldToDeformationFieldImageFilter.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DAbsCorrection.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DConstants.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DFSAffineTransform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DInterpolateImageFunction.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DInterpolateImageFunction.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DInterpolateImageFunctionReimplementation.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DMatrix3x3Transform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DMatrix3x3Transform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNearestCorrection.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNonRigidTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DPPDAffineTransform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRead.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRead.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DResample.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRigidTransform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DWindowedSincInterpolateImageFunction.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DWrite.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DZeroCorrection.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkSeparateComponentsOfADiffusionTensorImage.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkTransformDeformationFieldFilter.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkTransformDeformationFieldFilter.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkWarpTransform3D.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkWarpTransform3D.txx Diff File
add - Utilities/KWStyle/ITK.kws.xml Diff File

master 103190d6

2017-03-13 09:00:02

jcfr

Details Diff 		STYLE: vtkITK/itkTimeSeriesDatabaseHelper: Remove unused code

Remove code that was added only if NO_MEMBER_TEMPLATES was *NOT* defined.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25828 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/itkTimeSeriesDatabaseHelper.h Diff File

master 6cdd1998

2017-03-13 09:00:00

jcfr

Details Diff 		STYLE: Remove double underscore in header guards (.txx & __itk*_txx form)

Used the following command:

find . \( -iname *.txx -and -type f \) -exec perl -pi -w -e 's/__itk(.*)_txx/itk$1_txx/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

Adapted from scripts created by Sean McBride <sean@rogue-research.com> to
update ITK and VTK code base.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25827 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/itkLevelTracingImageFilter.txx Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarityLandmarkBasedTransformInitializer.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/Testing/itkDifferenceDiffusionTensor3DImageFilter.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DAffineTransform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DBSplineInterpolateImageFunction.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DExtended.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DFSAffineTransform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DInterpolateImageFunction.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DLinearInterpolateFunction.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DMatrix3x3Transform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNearestNeighborInterpolateFunction.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNonRigidTransform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DPPDAffineTransform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRead.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DResample.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRigidTransform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DTransform.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DWindowedSincInterpolateImageFunction.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DWrite.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkMatrixExtended.txx Diff File
mod - Modules/CLI/ResampleDTIVolume/itkSeparateComponentsOfADiffusionTensorImage.txx Diff File

master 88191362

2017-03-13 08:59:55

jcfr

Details Diff 		STYLE: Remove double underscore in header guards (.h & __itk*_h form)

Used the following command:

find . \( -iname *.h -and -type f \) -exec perl -pi -w -e 's/__itk(.*)_h/itk$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

Adapted from scripts created by Sean McBride <sean@rogue-research.com> to
update ITK and VTK code base.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25826 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/CLI/Testing/itkTestMain.h Diff File
mod - Base/CLI/itkPluginFilterWatcher.h Diff File
mod - Base/CLI/itkPluginUtilities.h Diff File
mod - Libs/ITKFactoryRegistration/itkFactoryRegistration.h Diff File
mod - Libs/MRML/IDImageIO/itkMRMLIDIOPlugin.h Diff File
mod - Libs/MRML/IDImageIO/itkMRMLIDIOWin32Header.h Diff File
mod - Libs/MRML/IDImageIO/itkMRMLIDImageIO.h Diff File
mod - Libs/MRML/IDImageIO/itkMRMLIDImageIOFactory.h Diff File
mod - Libs/vtkITK/itkConstrainedValueMultiplicationImageFilter.h Diff File
mod - Libs/vtkITK/itkGrowCutSegmentationImageFilter.h Diff File
mod - Libs/vtkITK/itkLevelTracingImageFilter.h Diff File
mod - Libs/vtkITK/itkNewOtsuThresholdImageCalculator.h Diff File
mod - Libs/vtkITK/itkNewOtsuThresholdImageFilter.h Diff File
mod - Libs/vtkITK/itkTimeSeriesDatabase.h Diff File
mod - Libs/vtkITK/itkTimeSeriesDatabaseHelper.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarity3DTransform.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarityLandmarkBasedTransformInitializer.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageRegionMomentsCalculator.h Diff File
mod - Modules/CLI/PETStandardUptakeValueComputation/itkDCMTKFileReader.h Diff File
mod - Modules/CLI/ResampleDTIVolume/Testing/itkDifferenceDiffusionTensor3DImageFilter.h Diff File
mod - Modules/CLI/ResampleDTIVolume/Testing/itkTestMainExtended.h Diff File
mod - Modules/CLI/ResampleDTIVolume/dtiprocessFiles/itkHFieldToDeformationFieldImageFilter.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DAbsCorrection.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DAffineTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DBSplineInterpolateImageFunction.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DExtended.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DFSAffineTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DInterpolateImageFunction.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DInterpolateImageFunctionReimplementation.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DLinearInterpolateFunction.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DMatrix3x3Transform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNearestCorrection.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNearestNeighborInterpolateFunction.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DNonRigidTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DPPDAffineTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRead.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DResample.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DRigidTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DTransform.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DWindowedSincInterpolateImageFunction.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DWrite.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DZeroCorrection.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkMatrixExtended.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkSeparateComponentsOfADiffusionTensorImage.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkTransformDeformationFieldFilter.h Diff File
mod - Modules/CLI/ResampleDTIVolume/itkWarpTransform3D.h Diff File

master 6f28690d

2017-03-13 00:05:06

jcfr

Details Diff 		COMP: N4ITKBiasFieldCorrection: Fix -Wunused-variable

This commit fixes the following warning:

/path/to/Modules/CLI/N4ITKBiasFieldCorrection/N4ITKBiasFieldCorrection.cxx:172:24: warning: unused variable 'maskImageIndex' [-Wunused-variable]
ImageType::IndexType maskImageIndex =
^

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25825 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/N4ITKBiasFieldCorrection/N4ITKBiasFieldCorrection.cxx Diff File

master 243ea840

2017-03-13 00:05:04

jcfr

Details Diff 		BUG: vtkMRMLAnnotationNode: Fix -Wfor-loop-analysis

This commit fixes the following warning:

/path/to/Slicer/Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationNode.cxx:530:20: warning: variables 'id' and 'n' used in loop condition not modified in loop body [-Wfor-loop-analysis]
for (int i = id; id < n-1; i++ )
^~ ~

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25824 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationNode.cxx Diff File

master 94aa8db0

2017-03-13 00:05:02

jcfr

Details Diff 		STYLE: qSlicerExtensionsManagerModel: Remove unused function appendToPathList

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25823 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerExtensionsManagerModel.cxx Diff File
 First  Prev  1 2 3 ... 7 8 9 10 11 12 13 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last