Changesets: Import 2017-06-07 23:51:09

Search Browse Back to Index

master 04e9f3ea

2017-03-11 09:35:24

lassoan

Details Diff 		BUG: Fixed SegmentationsModuleTest1 test error

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25797 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/Testing/Python/SegmentationsModuleTest1.py Diff File

master faa8929d

2017-03-11 09:34:57

lassoan

Details Diff 		ENH: Use VTK bounding box functions

Using vtkBoundingBox for adding points or bounds to a bounding box makes the code a bit simpler than adding custom methods.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25796 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkSegmentationCore/vtkOrientedImageData.h Diff File
mod - Libs/vtkSegmentationCore/vtkOrientedImageDataResample.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegment.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegment.h Diff File
mod - Libs/vtkSegmentationCore/vtkSegmentation.cxx Diff File

master 1a605116

2017-03-11 02:10:11

jcfr

Details Diff 		COMP: vtkSubjectHierarchyItem: Fix sign-compare warning

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25795 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File

master 3a1fe185

2017-03-11 02:10:09

jcfr

Details Diff 		COMP: vtkSubjectHierarchyItem: Fix reorder warning

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25794 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File

master c89c18ad

2017-03-11 02:10:07

jcfr

Details Diff 		COMP: vtkSlicerSubjectHierarchyModuleLogic: Fix conversion-null warning

/home/jcfr/Projects/Slicer/Modules/Loadable/SubjectHierarchy/Logic/vtkSlicerSubjectHierarchyModuleLogic.cxx:129:12: warning: converting to non-pointer type ‘vtkIdType {aka long long int}’ from NULL [-Wconversion-null]
return NULL;
^

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25793 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Logic/vtkSlicerSubjectHierarchyModuleLogic.cxx Diff File

master 7c2c82fc

2017-03-11 02:10:05

jcfr

Details Diff 		BUG: vtkSlicerAnnotationModuleLogic: Fix incorrect call to JumpAllSlices

This issue was discovered while fixing the following warning:

/path/to/Slicer/Modules/Loadable/Annotations/Logic/vtkSlicerAnnotationModuleLogic.cxx:2613:72: warning: passing NULL to non-pointer argument 2 of ‘static void vtkMRMLSliceNode::JumpAllSlices(vtkMRMLScene*, double, double, double, int, int, vtkMRMLSliceNode*)’ [-Wconversion-null]
vtkMRMLSliceNode::JumpAllSlices(this->GetMRMLScene(), NULL, r, a, s);
^

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25792 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/Logic/vtkSlicerAnnotationModuleLogic.cxx Diff File

master f7846b4e

2017-03-11 02:10:03

jcfr

Details Diff 		COMP: qMRMLModelDisplayNodeWidget.ui: Fix "already in use name" warning

/path/to/Slicer/Modules/Loadable/Models/Widgets/Resources/UI/qMRMLModelDisplayNodeWidget.ui: Warning: The name 'DisplayedScalarRangeLabel' (QLabel) is already in use, defaulting to 'DisplayedScalarRangeLabel1'.

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25791 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Models/Widgets/Resources/UI/qMRMLModelDisplayNodeWidget.ui Diff File

master c764a114

2017-03-11 02:10:01

jcfr

Details Diff 		COMP: qSlicerSubjectHierarchyPluginHandler: Fix reorder warning

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25790 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginHandler.cxx Diff File

master e23629ce

2017-03-11 02:09:59

jcfr

Details Diff 		COMP: qSlicerSubjectHierarchyFolderPlugin: Fix conversion-null warning

/path/to/Slicer/Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyFolderPlugin.cxx:477:12: warning: converting ‘false’ to pointer type ‘vtkMRMLHierarchyNode*’ [-Wconversion-null]
return false;
^

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25789 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyFolderPlugin.cxx Diff File

master ef211087

2017-03-11 02:09:57

jcfr

Details Diff 		COMP: vtkImageGrowCutSegment: Fix unused variable warnings

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25788 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/Logic/vtkImageGrowCutSegment.cxx Diff File

master d586bece

2017-03-11 02:09:55

jcfr

Details Diff 		COMP: qSlicerSegmentEditorPaintEffect_p.h: Fix reorder warning

/path/to/Projects/Slicer/Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect_p.h:152:16: warning: ‘qMRMLWidget* qSlicerSegmentEditorPaintEffectPrivate::ActiveViewWidget’ [-Wreorder]
qMRMLWidget* ActiveViewWidget;
^

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25787 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect.cxx Diff File

master 77187f70

2017-03-11 02:09:54

jcfr

Details Diff 		COMP: qSlicerSegmentEditorPaintEffect: Fix unused-variable warning

/path/to/Slicer/Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect.cxx:573:25: warning: unused variable ‘modifierLabelmap’ [-Wunused-variable]
vtkOrientedImageData* modifierLabelmap = q->modifierLabelmap();
^

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25786 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect.cxx Diff File

master e8c09fe7

2017-03-11 02:09:52

jcfr

Details Diff 		COMP: qMRMLSegmentEditorWidget: Fix sign-compare warning

/path/to/Slicer/Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.cxx: In member function ‘void qMRMLSegmentEditorWidget::onSelectSegmentShortcut()’:
/path/to/Projects/Slicer/Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.cxx:2505:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int segmentIndex = 0; segmentIndex < segmentIDs.size(); segmentIndex++)
^

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25785 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.cxx Diff File

master 34210136

2017-03-11 02:09:50

jcfr

Details Diff 		COMP: vtkMRMLSubjectHierarchyNode: Fix ignored-qualifier warning

In file included from /path/to/Slicer/Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyAbstractPlugin.h:33:0,
from /path/to/Projects/Slicer/Modules/Loadable/Segmentations/qSlicerSegmentationsModuleWidget.cxx:35:
/path/to/Projects/Slicer/Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.h:164:43: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
static const vtkIdType GetInvalidItemID() { return INVALID_ITEM_ID; };
^

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25784 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.h Diff File

master 36fad5de

2017-03-11 02:09:48

jcfr

Details Diff 		BUG: Teach 'slicer_add_python_unittest' to add module search paths

This commit allows scripted module test within extension to successfully
load dependent modules.

Fixes http://www.na-mic.org/Bug/view.php?id=4242

From: Isaiah Norton <inorton@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25783 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerMacroPythonTesting.cmake Diff File
mod - Modules/Scripted/SegmentEditor/CMakeLists.txt Diff File

master 6df62774

2017-03-11 02:09:46

jcfr

Details Diff 		STYLE: Update Slicer function and macro name to lower case

For search-ability, case of the function is now consistent with the
lower case usage of the function.

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Isaiah Norton <inorton@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25782 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerFunctionToday.cmake Diff File
mod - CMake/SlicerMacroParseArguments.cmake Diff File
mod - CMake/SlicerMacroPythonTesting.cmake Diff File
mod - CMake/SlicerMacroSimpleTest.cmake Diff File

master e301db00

2017-03-10 19:00:40

jcfr

Details Diff 		COMP: Fix CMake extension build issue. See 0004311

This commit reverts r25552 (BUG: ExtensionBuildSystem: Ensure GIT_EXECUTABLE
set in SliceConfig is used) and implements a more robust workaround
for CMake issue #15448 [1] and fix Slicer issue 0004311

[1] https://gitlab.kitware.com/cmake/cmake/issues/15448
[2] https://www.na-mic.org/Bug/view.php?id=4311

Reviewed-by: Steve Pieper <pieper@bwh.harvard.edu>
Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Isaiah Norton <inorton@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25781 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/FindGit.cmake Diff File
mod - Extensions/CMake/CMakeLists.txt Diff File

master 2591d972

2017-03-10 16:50:47

pinter

Details Diff 		BUG: Fixed segmentation bounds computation

This is a partial revert of rev25718. Using vtkMath::UninitializeBounds was incorrect, see comment in vtkOrientedImageData.h

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25780 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkSegmentationCore/vtkOrientedImageData.h Diff File
mod - Libs/vtkSegmentationCore/vtkOrientedImageDataResample.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegment.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegmentation.cxx Diff File

master 3a05dea2

2017-03-10 15:07:05

pinter

Details Diff 		BUG: Fixed bug preventing from saving subject hierarchy attributes

This caused problems in subject hierarchy when saving/loading segmentations

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25779 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File

master a01cd32b

2017-03-10 13:00:46

pinter

Details Diff 		ENH: Add item cache in subject hierarchy node for increased speed in case of large scenes

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25778 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File

master b1c384e4

2017-03-10 11:46:19

pinter

Details Diff 		ENH: Changed invalid subject hierarchy item ID to 0 for easier checking

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25777 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/SubjectHierarchyCorePluginsSelfTest.py Diff File
mod - Applications/SlicerApp/Testing/Python/SubjectHierarchyGenericSelfTest.py Diff File
mod - Base/QTCLI/vtkSlicerCLIModuleLogic.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSegmentationNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.h Diff File
mod - Modules/Loadable/Segmentations/Testing/Python/SegmentationsModuleTest1.py Diff File
mod - Modules/Loadable/SubjectHierarchy/Logic/vtkSlicerSubjectHierarchyModuleLogic.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSortFilterSubjectHierarchyProxyModel.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyModel.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyTreeView.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyAbstractPlugin.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyChartsPlugin.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyCloneNodePlugin.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyFolderPlugin.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyParseLocalDataPlugin.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyRegisterPlugin.cxx Diff File
mod - Modules/Scripted/DICOMLib/DICOMPlugin.py Diff File
mod - Modules/Scripted/DICOMPlugins/DICOMScalarVolumePlugin.py Diff File
mod - Modules/Scripted/SegmentEditor/SubjectHierarchyPlugins/SegmentEditorSubjectHierarchyPlugin.py Diff File
mod - Modules/Scripted/SegmentStatistics/SubjectHierarchyPlugins/SegmentStatisticsSubjectHierarchyPlugin.py Diff File

master 2d7781b9

2017-03-09 17:22:34

pinter

Details Diff 		BUG: Fixed middle item deletion in subject hierarchy

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25776 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File

master 0fb06407

2017-03-09 17:21:20

cpinter

Details Diff 		ENH: Fixed subject hierarchy generic test on Mac/Linux

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25775 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/SubjectHierarchyGenericSelfTest.py Diff File

master 08e90df3

2017-03-09 16:23:18

pinter

Details Diff 		BUG: Fixed issues around subject hierarchy DICOM UID references

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25774 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File
mod - Modules/Loadable/Segmentations/Logic/vtkSlicerSegmentationsModuleLogic.cxx Diff File

master 56fb1ef3

2017-03-09 16:01:12

pinter

Details Diff 		BUG: Fixed RemoveAllChildren method in subject hierarchy

It deleted the scene's immediate children, but in course of deletion, ReparentChildrenToParent was called (which is a feature to prevent such deletions to result dangling orphan items in memory), so the children of the top-level node's children were added under the scene, which were then not deleted. This caused a memory leak

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25773 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File
 First  Prev  1 2 3 ... 9 10 11 12 13 14 15 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last