Changesets: Import 2017-06-07 23:51:09

Search Browse Back to Index

master 61be170e

2017-03-25 15:54:57

lassoan

Details Diff 		ENH: Reduced segmentations widget size

Hide effect options and masking section if no effect is selected.
Paint options (sphere brush, color smudge, pixel mode) are laid out horizontally instead of vertically.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25872 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect.cxx Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.cxx Diff File

master bcc3e5d8

2017-03-25 15:54:53

lassoan

Details Diff 		COMP: Move projects to correct folder in solution explorer

vtkSegmentationCoreCxxTests and qSlicerModulesCoreCxxTests projects were moved to the correct folders in solution explorer
(now they are in the same folder as the projects that they test).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25871 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkSegmentationCore/Testing/CMakeLists.txt Diff File
mod - Modules/Core/Testing/CMakeLists.txt Diff File

master 4e0a67e3

2017-03-24 13:05:10

pinter

Details Diff 		STYLE: Indentation related changes

1. vtkMRMLNode::Indent member seemed unused in the core, except from the also unused ROI list node, so the member was removed

2. In WriteXML functions, the increasing indentation was added between the XML attributes, which did not have major effect on the top level, but for example in the scene view section, where indentation was increased, it made the nodes look like this:

<Selection
id="vtkMRMLSelectionNodeSingleton" name="Selection" hideFromEditors="true" selectable="true" selected="false" singletonTag="Singleton"

As the purpose of indentation is to add space in front of the _lines_, adding that space between the XML attributes seems unnecessary. With these changes, the same entry now looks like this:

<Selection
id="vtkMRMLSelectionNodeSingleton" name="Selection" hideFromEditors="true" selectable="true" selected="false"

History:

In the first implementation of `WriteXML()`, the name of the node (e.g vtkMRMLModelNode.cxx) was explicitly serialized and indented in the function by explicitly using `nIndent`.
See r40 (COMP: added vtkITK and MRML libs). Code like this was used:

vtkIndent i1(nIndent);
of << i1 << "<Model";

of << " id='" << this->ID << "'";
if (this->Name && strcmp(this->Name, ""))
{
of << " name='" << this->Name << "'";
}
[...]
if (this->Color && strcmp(this->Color, ""))
{
of << " color='" << this->Color << "'";
}

Then, this approach was reviewed in r133 (ENH: more transform functionality) by systematically calling the base class implementation of WriteXML() function.

Code above was then updated like this:

Superclass::WriteXML(of, nIndent);
vtkIndent indent(nIndent);

if (this->Color && strcmp(this->Color, ""))
{
of << indent << " color='" << this->Color << "'";
}

This commit simplifies the XML serialization and explicitly mark `indent` parameter as deprecated.


git-svn-id: http://svn.slicer.org/Slicer4/trunk@25870 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLNodeTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLAbstractViewNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLCameraNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLChartNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLChartViewNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLClipModelsNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLColorNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLColorTableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLCrosshairNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDiffusionImageVolumeNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDiffusionTensorDisplayPropertiesNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDiffusionTensorVolumeDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDiffusionTensorVolumeSliceDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDiffusionWeightedVolumeDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDiffusionWeightedVolumeNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayableHierarchyNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLFiducialListNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLFreeSurferProceduralColorNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLGlyphableVolumeDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLGlyphableVolumeSliceDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLHierarchyNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLInteractionNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLLayoutNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLLinearTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLMarkupsStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNRRDStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLROIListNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLROINode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScalarVolumeDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScriptedModuleNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSegmentationDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSegmentationStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSelectionNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSliceCompositeNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSliceNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSnapshotClipNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLStorableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyLegacyNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTableViewNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTensorVolumeNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLUnitNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVectorVolumeDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVectorVolumeNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLViewNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeArchetypeStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeHeaderlessStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeNode.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegment.cxx Diff File
mod - Libs/vtkSegmentationCore/vtkSegmentation.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationAngleNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationBidimensionalNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationControlPointsNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationLineDisplayNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationLinesNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationPointDisplayNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationROINode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationRulerNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationSnapshotNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationSplineNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationTextDisplayNode.cxx Diff File
mod - Modules/Loadable/AtlasCreator/Logic/vtkMRMLAtlasCreatorNode.cxx Diff File
mod - Modules/Loadable/CropVolume/MRML/vtkMRMLCropVolumeParametersNode.cxx Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsFiducialNode.cxx Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File
mod - Modules/Loadable/MultiVolumeRendering/MRML/vtkMRMLMultiVolumeRenderingDisplayNode.cxx Diff File
mod - Modules/Loadable/Segmentations/MRML/vtkMRMLSegmentEditorNode.cxx Diff File
mod - Modules/Loadable/VolumeRendering/MRML/vtkMRMLCPURayCastVolumeRenderingDisplayNode.cxx Diff File
mod - Modules/Loadable/VolumeRendering/MRML/vtkMRMLGPURayCastVolumeRenderingDisplayNode.cxx Diff File
mod - Modules/Loadable/VolumeRendering/MRML/vtkMRMLVolumePropertyNode.cxx Diff File
mod - Modules/Loadable/VolumeRendering/MRML/vtkMRMLVolumeRenderingDisplayNode.cxx Diff File
mod - Modules/Loadable/VolumeRendering/MRML/vtkMRMLVolumeRenderingScenarioNode.cxx Diff File

master 9613ba22

2017-03-24 11:08:12

pinter

Details Diff 		ENH: Terminology default contexts selection and validator link in messages

1. Last terminology and anatomic context selections are now saved in application settings, and are selected in case terminology navigator is opened for a new segment. Thus the default segment terminology is now empty (instead of Tissue/Tissue), so that new segment can be detected.
2. Link to the context validator web app is now included in the error message that is popped up when loading user terminology or anatomic context fails

Related to https://github.com/QIICR/QuantitativeReporting/issues/150

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25869 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkSegmentationCore/vtkSegment.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx Diff File

master 676a386f

2017-03-23 21:53:22

lassoan

Details Diff 		ENH: Updated to latest CTK version

New feature: ctkFittedTextBrowser has a collapsible option now. It allows showing a single-line message with a 'More...' link that the user can click to see the full message.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25868 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

master be52952c

2017-03-23 21:53:16

lassoan

Details Diff 		ENH: Added option in ScreenCapture module for capturing all views

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25867 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLThreeDWidget.h Diff File
mod - Modules/Scripted/ScreenCapture/ScreenCapture.py Diff File

master a7d78d4f

2017-03-23 17:59:22

pinter

Details Diff 		ENH: Improved and simplified volume and labelmap visibility from subject hierarchy

Instead of the apparently hard-to-grasp way volumes and labelmaps were shown and hidden from subject hierarchy, a new and simplified way was implemented. Now if a non-labelmap volume is shown or hidden, then it is simply shown in the background layer of all slice views, replacing any background volume shown previously. Labelmaps work the same way, except on the label layer. This, besides the simplified and more robust operation, has a few advantages: 1) It doesn't use the selection node any more, meaning that its inconsistencies (http://www.na-mic.org/Bug/view.php?id=3551) are now irrelevant from this use case, 2) It was reported that show/hide changed the position of the slice views, which is now preserved, 3) Complete synchronization of actual volume visibility and visibility icon states in subject hierarchy is now achieved

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25866 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyLabelMapsPlugin.cxx Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyLabelMapsPlugin.h Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyVolumesPlugin.cxx Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyVolumesPlugin.h Diff File

master 3b8c77f6

2017-03-23 16:48:18

lassoan

Details Diff 		ENH: Made screencapture rotation axis configurable

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25865 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/ScreenCapture/ScreenCapture.py Diff File

master 4113009c

2017-03-23 15:36:58

pinter

Details Diff 		BUG: Fixed segment visibility indicator bug in subject hierarchy

When a segment was shown/hidden from somewhere else than SH, then the visibility icon in SH was not updated. By emitting modified event on the shown/hidden segment's SH item, the update is triggered.

Also, minor issues were fixed in SHNode::GetDisplayVisibilityForBranch. The new implementation of GetDataNodesInBranch includes the given node's data node itself in the returned collection, so no need to add that explicitly. Also, the exception about segmentation nodes were removed, as it was a workaround in the past when segmentation node was not registered in the scene. Further, the warning about partial visibility for leaf nodes was removed, because it can happen if a data node has more than one display node (e.g. annotations, fiber bundles)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25864 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSegmentationDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File

master a3591b05

2017-03-23 13:52:04

pinter

Details Diff 		ENH: Added DTI volume subject hierarchy plugin

Context menu action for interactive seeding allows users to start tractography from subject hierarchy. A second action for lablemap seeding also is created, but not shown until CLI support for segmentations is added.


git-svn-id: http://svn.slicer.org/Slicer4/trunk@25863 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/CMakeLists.txt Diff File
add - Modules/Loadable/Volumes/SubjectHierarchyPlugins/Resources/Icons/DiffusionTensorVolume.png Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/Resources/qSlicerVolumesSubjectHierarchyPlugins.qrc Diff File
add - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyDiffusionTensorVolumesPlugin.cxx Diff File
add - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyDiffusionTensorVolumesPlugin.h Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyLabelMapsPlugin.cxx Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyLabelMapsPlugin.h Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyVolumesPlugin.cxx Diff File
mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyVolumesPlugin.h Diff File
mod - Modules/Loadable/Volumes/qSlicerVolumesModule.cxx Diff File

master abd8faf1

2017-03-22 16:19:33

lassoan

Details Diff 		ENH: Made segment editor effects list customizable

editorWidget.setEffectNameOrder defines the order of effects.
If editorWidget.unorderedEffectsVisible is set to False then only those effects will be shown
that are listed in editorWidget.setEffectNameOrder.

editorWidget = slicer.modules.segmenteditor.widgetRepresentation().self().editor
editorWidget.setEffectNameOrder(['Draw', 'Scissors', 'Islands'])
editorWidget.unorderedEffectsVisible = False

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25862 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorEffectFactory.cxx Diff File
mod - Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorEffectFactory.h Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.cxx Diff File
mod - Modules/Loadable/Segmentations/Widgets/qMRMLSegmentEditorWidget.h Diff File

master 14e5b76d

2017-03-22 13:09:07

pinter

Details Diff 		ENH: Added option to load custom anatomical contexts for terminologies

Schema information from the json files is now also used to determine the type of the loaded context. In case of an unrecognized or missing schema, loading fails and error is logged.
Json files updated based on changes in the dcmqi repository.

Fixes https://github.com/QIICR/QuantitativeReporting/issues/150

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25861 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Terminologies/Logic/CMakeLists.txt Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologiesModuleLogic.cxx Diff File
mod - Modules/Loadable/Terminologies/Logic/vtkSlicerTerminologiesModuleLogic.h Diff File
mod - Modules/Loadable/Terminologies/Resources/SegmentationCategoryTypeModifier-DICOM-Master.json Diff File
mod - Modules/Loadable/Terminologies/Resources/SegmentationCategoryTypeModifier-SlicerGeneralAnatomy.json Diff File
mod - Modules/Loadable/Terminologies/Resources/UI/qSlicerTerminologiesModule.ui Diff File
mod - Modules/Loadable/Terminologies/Widgets/Resources/UI/qSlicerTerminologyNavigatorWidget.ui Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.cxx Diff File
mod - Modules/Loadable/Terminologies/Widgets/qSlicerTerminologyNavigatorWidget.h Diff File
mod - Modules/Loadable/Terminologies/qSlicerTerminologiesModule.cxx Diff File

master 1a14a65a

2017-03-22 12:13:03

jcfr

Details Diff 		STYLE: EditorExtensionTemplate: Fix docstring typo

Changed "be come" to "become".

From: Tammy DiPrima <tammy.diprima@stonybrook.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25860 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/Testing/EditorExtensionTemplate/EditorEffectTemplate/EditorEffectTemplate.py Diff File
mod - Modules/Scripted/EditorLib/FastMarchingEffect.py Diff File
mod - Modules/Scripted/EditorLib/WandEffect.py Diff File
mod - Modules/Scripted/EditorLib/WatershedFromMarkerEffect.py Diff File

master 718d78d8

2017-03-21 16:49:13

lassoan

Details Diff 		ENH: Added scripted segment editor effect template

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25859 3bd1e089-480b-0410-8dfb-8563597acbee
add - Utilities/Templates/Modules/ScriptedSegmentEditorEffect/CMakeLists.txt Diff File
add - Utilities/Templates/Modules/ScriptedSegmentEditorEffect/SegmentEditorTemplateKey.py Diff File
add - Utilities/Templates/Modules/ScriptedSegmentEditorEffect/SegmentEditorTemplateKeyLib/CMakeLists.txt Diff File
add - Utilities/Templates/Modules/ScriptedSegmentEditorEffect/SegmentEditorTemplateKeyLib/SegmentEditorEffect.png Diff File
add - Utilities/Templates/Modules/ScriptedSegmentEditorEffect/SegmentEditorTemplateKeyLib/SegmentEditorEffect.py Diff File
add - Utilities/Templates/Modules/ScriptedSegmentEditorEffect/SegmentEditorTemplateKeyLib/__init__.py Diff File
add - Utilities/Templates/Modules/ScriptedSegmentEditorEffect/Testing/CMakeLists.txt Diff File
add - Utilities/Templates/Modules/ScriptedSegmentEditorEffect/Testing/Python/CMakeLists.txt Diff File

master f083977e

2017-03-21 14:33:49

pinter

Details Diff 		STYLE: Removed unnecessary error messages that clutter the log

These error messages appeared when creating charts and tables when the SH item was created, because it tried to get their visibility, but there was no chart or table view node, because no layout containing either has been used.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25858 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyChartsPlugin.cxx Diff File
mod - Modules/Loadable/Tables/SubjectHierarchyPlugins/qSlicerSubjectHierarchyTablesPlugin.cxx Diff File

master 548bb413

2017-03-21 14:26:45

lassoan

Details Diff 		ENH: Added helper functions to vtkSlicerSegmentationsModuleLogic

CopyOrientedImageDataToVolumeNode: create volume node from oriented image data easily
ImportLabelmapToSegmentationNode: update existing segments based on a labelmap node

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25857 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Segmentations/Logic/vtkSlicerSegmentationsModuleLogic.cxx Diff File
mod - Modules/Loadable/Segmentations/Logic/vtkSlicerSegmentationsModuleLogic.h Diff File

master f82602e8

2017-03-21 11:46:16

pinter

Details Diff 		BUG: Fixed SH node clone bug

Some data role plugins rely on node attributes and/or place in branch to determine whether the data node can be claimed. In such cases, the SH item created by the SH plugin logic could be claimed by a more generic plugin (e.g. RTDose vs Volumes) when adding the cloned node to the scene, but before attributes were copied, or item was placed in branch. By requesting plugin search after these operations, the proper plugin claims the cloned data node

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25856 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Logic/vtkSlicerSubjectHierarchyModuleLogic.cxx Diff File

master f7566061

2017-03-21 11:42:08

pieper

Details Diff 		BUG: the sense of the test was inverted, leading to crash in Qt5

This code is supposed to create a new quantity ui when
a new one is discovered, but had a missing not operator
so quantities weren't added until they later found via the
selection node. On Qt4 this was not a problem but did
cause a crash in Qt5.

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25855 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Units/qSlicerUnitsSettingsPanel.cxx Diff File

master 4a7e6b0e

2017-03-21 11:10:11

pinter

Details Diff 		BUG: Fixed crash when setting root item to SH tree before showing it

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25854 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyTreeView.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyTreeView.h Diff File

master f2102412

2017-03-21 10:44:03

pinter

Details Diff 		BUG: Fixed scene views with subject hierarchy 2.0

Some explanation besides the subject hierarchy node and scene view node changes:
1. vtkMRMLScene.cxx:1140 and 1175:
1/A) the ReferencedIDChanges map contained an invalid entry in every case, namely it associated the last created node's ID with empty string.
1/B) In the case of loading a volume, the test scene created by vtkSlicerVolumesLogic::AddArchetypeVolume assigned ID with number 1 to the volume. Then, when adding it to the main MRML scene, the old ID with number 1 was found, and the ID change was stored always from 1 to the number of the last loaded volume. This is also an invalid ID change, as no ID was changed in the scene that stored this change. First approach was to clear node ID when removing from scene, but it caused tests failing in EMSegment (due to the specific way it creates sub-scenes), and it is expected to cause problems elsewhere too. So as an alternative solution, IDs are only added to ReferencedIDChanges, when a scene is being imported or a scene view restored. It seems to be reasonable, as these are the only two use cases where the IDs of other complete scenes need to be merged to the main Slicer scene.
2. vtkMRMLSegmentationNode.cxx: This is basically reverting commit rev25625 that introduced display node copying and creation in the data node's copy. In the case of restoring the scene view, it caused a problem like this: if the segmentation node was before its display node in the snapshot scene, a new display node was created when copying the segmentation node, and so after restoring, two display nodes were present instead of one. So the segmentation was not visible. I checked other data nodes and none of the ones I looked at copy display properties in the copy function of the data node. I suggest taking care of this at the higher level, where the data node's copy is called (for example as it is done in the clone node SH plugin)


git-svn-id: http://svn.slicer.org/Slicer4/trunk@25853 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLSceneTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneTest2.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDiffusionTensorVolumeSliceDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSegmentationNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSubjectHierarchyNode.h Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLinkLogic.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyPluginLogic.h Diff File

master 2d1112cb

2017-03-20 15:34:08

ihnorton

Details Diff 		BUG: hide DMRIInstall properly, avoid assert in debug build

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25852 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DMRIInstall/DMRIInstall.py Diff File

master c4c6702a

2017-03-20 13:01:32

ihnorton

Details Diff 		STYLE: rename functions to match slicer/pr/647 rework

From: Isaiah Norton <inorton@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25851 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDiffusionTensorVolumeSliceDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDiffusionTensorVolumeSliceDisplayNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLGlyphableVolumeSliceDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLGlyphableVolumeSliceDisplayNode.h Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLVolumeGlyphSliceDisplayableManager.cxx Diff File

master f5751afb

2017-03-20 13:00:42

ihnorton

Details Diff 		ENH: change default DT glyph type to line, faster & clearer for normal use

From: Isaiah Norton <inorton@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25850 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDiffusionTensorDisplayPropertiesNode.cxx Diff File

master 7a168d8c

2017-03-20 13:00:37

ihnorton

Details Diff 		BUG: fix DT glyph display

Fixes issues related to slicer/pr/647 changes in model display pipeline.
- crash due to potential null node, needs null check.
- rendering problems (inactive by default) due to missing pipeline update call after event propagation was changed

From: Isaiah Norton <inorton@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25849 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDiffusionTensorVolumeSliceDisplayNode.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File

master e6800b1d

2017-03-20 13:00:29

ihnorton

Details Diff 		ENH: use wildcard filter in Data module

This allows to match any part of the name rather than requiring to type
exact phrase. So "Tens" matches "vtkMRMLDiffusionTensorVolumeNode" whereas
currently it would not match.

From: Isaiah Norton <inorton@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25848 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Data/qSlicerDataModuleWidget.cxx Diff File
 First  Prev  1 2 3 ... 6 7 8 9 10 11 12 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last