View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004148Slicer4Core: Building (CMake, Superbuild)public2016-02-05 17:062018-03-02 11:02
Reporteruser731Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.5.0-1 
Target VersionFixed in VersionSlicer 4.7.0 
Summary0004148: Slicer dependent project repository and tag should be configurable by outside projects
Description

Right now, it isn't possible to give Slicer a different repository for its dependencies.
https://github.com/Slicer/Slicer/pull/454 is a clumsy way to solve this but it highlights the problem.

Additional Information

A path to resolution would probably be something like this:

get_property(other_repository CACHE Slicer_DEPENCY-PROJ_REPOSITORY SET DEFINED)
if (NOT other_repository)
set(other_repository SLICER_DEPENCY-PROJ_DEFAULT_REPOSITORY "git://Slicer/DEPENCY-PROJ.git)
endif()

...

ExternalProject_Add(DEPENDENCY-PROJ
...
GIT_REPOSITORY ${other_repository}
...
)

TagsNo tags attached.

Activities

jcfr

jcfr

2017-03-20 10:06

administrator   ~0014379

See https://github.com/Slicer/Slicer/pull/684/
jcfr

jcfr

2017-03-20 11:27

administrator   ~0014380

Fixed in r25846
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=25846
jcfr

jcfr

2017-06-10 08:51

administrator   ~0014730

Fix committed to master branch.

Related Changesets

Import 2017-06-07 23:51:09: master 6fe601ef

2017-03-20 11:07:14

jcfr

Details Diff 		ENH: Support configuration of external project GIT tag and repository

For any given project checkout using Git, setting cache or environment
variables of the form:

Slicer_<proj>_GIT_REPOSITORY
Slicer_<proj>_GIT_TAG

allows to override the default values set within each External_* files.

Fixes 0004148

Co-authored-by: "T.J. Corona" <tj.corona@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25846 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File
mod - SuperBuild/External_DCMTK.cmake Diff File
mod - SuperBuild/External_ITKv4.cmake Diff File
mod - SuperBuild/External_JsonCpp.cmake Diff File
mod - SuperBuild/External_LibArchive.cmake Diff File
mod - SuperBuild/External_OpenIGTLink.cmake Diff File
mod - SuperBuild/External_ParameterSerializer.cmake Diff File
mod - SuperBuild/External_RapidJSON.cmake Diff File
mod - SuperBuild/External_SimpleITK.cmake Diff File
mod - SuperBuild/External_SlicerExecutionModel.cmake Diff File
mod - SuperBuild/External_VTKv7.cmake Diff File
mod - SuperBuild/External_curl.cmake Diff File
mod - SuperBuild/External_python.cmake Diff File
mod - SuperBuild/External_qRestAPI.cmake Diff File
mod - SuperBuild/External_teem.cmake Diff File
mod - SuperBuild/External_zlib.cmake Diff File

Issue History

Date Modified Username Field Change
2016-02-05 17:06 user731 New Issue
2016-02-05 17:06 user731 Status new => assigned
2016-02-05 17:06 user731 Assigned To => jcfr
2017-03-20 10:06 jcfr Note Added: 0014379
2017-03-20 11:27 jcfr Note Added: 0014380
2017-03-20 11:27 jcfr Status assigned => resolved
2017-03-20 11:27 jcfr Fixed in Version => Slicer 4.7.0
2017-03-20 11:27 jcfr Resolution open => fixed
2017-06-10 08:51 jcfr Changeset attached => Slicer master 6fe601ef
2017-06-10 08:51 jcfr Note Added: 0014730
2018-03-02 11:02 jcfr Status resolved => closed