Changesets: Slicer

2145-support-for-installing-extension-from-file 03108897

2013-06-09 19:31:00

pieper

Details Diff
COMP: Add install SimpleITK library to fixup into bundle

_SimpleITK*.so has been added to the list of libraries to be fixed up
in fixup_bundle_with_plugins method. It is also added to
gp_item_default_embedded_path_override method, because ?

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22092 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerCPackBundleFixup.cmake.in Diff File

2145-support-for-installing-extension-from-file fcf8db81

2013-06-07 17:53:45

pieper

Details Diff
BUG: fix fiducials display to preserve screenspace size

This change compensates for the size of the slice view
when displaying fiducial glyphs and text. Without this change,
switching to a layout showing only a single slice would lead
to humerously large fiducials being displayed. The base size can
still be controlled via the display nodes.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22091 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationFiducialDisplayableManager.cxx Diff File

2145-support-for-installing-extension-from-file 2ae9ee91

2013-06-07 14:18:32

alexy

Details Diff
BUG: fixed module labels

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22090 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/FiberBundleLabelSelect/FiberBundleLabelSelect.xml Diff File

2145-support-for-installing-extension-from-file f5df71d4

2013-06-07 12:35:01

alexy

Details Diff
BUG: 3148. Fixed crash on transform node reparenting

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22089 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLModelSliceDisplayableManager.cxx Diff File

2145-support-for-installing-extension-from-file 866bcb15

2013-06-07 12:32:08

alexy

Details Diff
BUG: 3133. invoke TransformModifiedEvent when new TransformNode is set

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22088 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLTransformableNode.cxx Diff File

2145-support-for-installing-extension-from-file 799630a4

2013-06-07 10:56:35

pieper

Details Diff
ENH: 0003081 support drag-and-drop of dicom directories

Use Julien's nice scripted file dialog code to support adding
directories to the dicom database.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22087 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DICOM/DICOM.py Diff File

2145-support-for-installing-extension-from-file 21696191

2013-06-06 16:59:58

pieper

Details Diff
BUG: RSS label image type bug fixed

previously char pixel type is used for input/output label images.
but that is not enough for larger label values. this causes crash.
I changed it to short type to hold more label values.
Tested on previous fail cases and works now. Linux 64

From: Yi Gao <yi.gao@gatech.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22086 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/RobustStatisticsSegmenter/SFLSRobustStatSegmentor3DLabelMap_single.h Diff File
mod - Modules/CLI/RobustStatisticsSegmenter/SFLSSegmentor3D.h Diff File

2145-support-for-installing-extension-from-file 93063c62

2013-06-06 16:36:29

pieper

Details Diff
COMP: fix swig executable path

Conform to cmake script syntax limitations.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22085 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_Swig.cmake Diff File

2145-support-for-installing-extension-from-file 8155b29a

2013-06-06 13:12:48

pieper

Details Diff
COMP: fix swig build to match SimpleITK

Use the same version and url that are known to work in SimpleITK's
superbuild.

Note: also remove "${${PROJECT_NAME}_EP_DISABLED_UPDATE}" and replace
it with UPDATE_COMMAND "" as I believe this gives the same effect and
avoids confusion about the intent. More importantly, on windows
the empty cmake argument led to the addition of a semicolon to the
directory name (so it became "swigwin-2.0.9;") which was ugly and
confusing.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22084 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_Swig.cmake Diff File

2145-support-for-installing-extension-from-file 026bbc6b

2013-06-05 20:28:21

pieper

Details Diff
COMP: update Swig version and fix md5 hashes per Brad's suggestion

Try to fix windows build errors like [1] by copying the version
info and hashes from the SimpleITK source [2].

[1] http://slicer.cdash.org/viewBuildError.php?buildid=106147
[2] https://github.com/SimpleITK/SimpleITK/commit/331990f42c2f5777ccc9c849025bb2db68709a68

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22083 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_Swig.cmake Diff File

2145-support-for-installing-extension-from-file 14ca1995

2013-06-05 17:57:39

pieper

Details Diff
BUG: 0003029 use 'setlocale' to force C over native language

It turns out that it is not enough to set Qt's locale and we must
also set the c standard library locale in order to avoid data
corruption when the decimalpoint is not period.

Many thanks to Marine Clogenson of EPFL for noticing and helping
figure out how to reproduce this issue!

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22082 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerCoreApplication.cxx Diff File

2145-support-for-installing-extension-from-file 92f217e8

2013-06-05 17:14:16

pieper

Details Diff
BUG: check in a new baseline for Multiresolution Affine cli test

This result is based on the module running with ITKv4 and shows
a slight shift compared to the old baseline, which is probably
due to improved subpixel indexing in the newer version of ITK.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22081 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/MultiResolutionAffineRegistration/Data/Baseline/MultiResolutionAffineRegistrationTest.nrrd Diff File

2145-support-for-installing-extension-from-file f7ae258f

2013-06-05 16:42:50

pieper

Details Diff
BUG: try to fix test failures on some platforms

This test was failing on the windows factory machines but not
on non-windows. Possibly this is due to the window size or another related
variable causing the painting to happen outside the visible
region of the MR in the slice view. This change makes sure the clicks
occur near the center of the slice view so as to avoid the
boundary case.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22080 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/sceneImport2428.py Diff File

2145-support-for-installing-extension-from-file 80be47d3

2013-06-05 16:26:52

pieper

Details Diff
ENH: add example of manipulating contents of web view

In this example the qt qpi is used to manipulate the DOM of a loaded
web page. In this case, we add a search string into a form, but the
concept could be generalized to allow exchange of data between slicer
and any web-based system that doesn't expose a clean web services api.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22079 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/PerformanceTests/PerformanceTests.py Diff File

2145-support-for-installing-extension-from-file 9ead17b2

2013-06-04 17:51:27

johan.andruejol

Details Diff
BUG: Delete unnecessary Q_ASSERT in unit aware widgets

These asserts were added with the slicer normal context of execution in
mind. In this case a scene should have a selection node at all time.
However, in tests that is not the case. Since the code is already
acounting for the fact that there might not be a selection node
(see updateWidgetFromUnitNode()), the asserts can just be removed.

See Issue 0003143

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22078 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLCoordinatesWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliderWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSpinBox.cxx Diff File

2145-support-for-installing-extension-from-file 563bd9d7

2013-06-04 17:23:22

pieper

Details Diff
ENH: add shortcuts for module navigation

Per discussion on developer hangout, added a shortcut:

Cmd/Control+F : search for module

Then I decided to add these as well:

Cmd/Control+Left : previous module
Cmd/Control+Right : next module

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22077 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerModuleSelectorToolBar.cxx Diff File

2145-support-for-installing-extension-from-file 68ce112e

2013-06-04 15:56:28

alexy

Details Diff
BUG: Fixed crash on missed fiber selection

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22076 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/TractographyDisplay/MRMLDM/vtkMRMLTractographyDisplayDisplayableManager.cxx Diff File

2145-support-for-installing-extension-from-file edb07a87

2013-06-04 15:31:29

johan.andruejol

Details Diff
BUG: Fix MRMLScene import and export

In the selection node, the unit didn't add a
NodeReferenceMRMLAttributeNames for each of its reference role. These
attributes are used when saving the mrml scene to describe what the
reference role is used for. Most notably, this can be used when importing
a scene.
However, since there wasn't any defined for the selection node, a saved
scene would look like this:
... selected="false" ="vtkMRMLUnitNodeApplicationLength" "vtkMRMLUnitNodeApplicationTime" activeVolumeID="NULL" ...
Which is an invalid format for the scene.

Adding a NodeReferenceMRMLAttributeNames is usually done in the class
constructor. In our case, we assume that we don't know what kind of unit
quantity can be added. Thus we don't know the ReferenceRoles we will need
at constructor time. So we add theses roles in the SetUnitNodeID().
The roles names are based on the quantity, and aren't actually used
anywhere.

To make sure this works, a test opening Slicer, saving a scene and loading
it again is added.

See Issue 0003145

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22075 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File
add - Applications/SlicerApp/Testing/Python/MRMLSceneImportAndExport.py Diff File
mod - Libs/MRML/Core/vtkMRMLSelectionNode.cxx Diff File

2145-support-for-installing-extension-from-file db75d3d5

2013-06-04 11:17:13

pieper

Details Diff
BUG: 0003029 force slicer to be in the C locale to avoid data truncation


Set the locale to be "C" to avoid issues related to reading and writing
of floating point numbers. For example, when the decimal point is set to be
a comma instead of a period, there can be truncation of data.
See these previous commits and the
+ // http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21856
+ // http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21865
+ // http://slicer-devel.65872.n3.nabble.com/Re-Rounding-to-integer-tt4027985.html
+ // http://slicer-devel.65872.n3.nabble.com/Re-slicer-users-Slicer4-can-t-really-use-it-yet-td4028040.html
+ // http://slicer-users.65878.n3.nabble.com/Slicer4-DICOM-many-problems-td4025919.html
+ // and issue 0003029

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22074 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerCoreApplication.cxx Diff File

2145-support-for-installing-extension-from-file d1b20980

2013-06-04 11:14:06

alexy

Details Diff
BUG: 3141. Added heck for NULL LUT.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22073 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLColorTableStorageNode.cxx Diff File

2145-support-for-installing-extension-from-file 80e14437

2013-06-03 15:45:21

johan.andruejol

Details Diff
BUG: Ensure backward compatibility in qMRMLNodeComboBox

Here is a quick summary of what happened:

What changed in r22052:
Rename the Q_Property from currentNodeId to currentNodeID
Rename QString currentNodeId() to QString currentNodeID()
Rename setCurrentNode(const QString nodeID)
to setCurrentNodeID(const QString nodeID)

What changed in r22059:
Add QString currentNodeId() as a deprecated function
(not invokable though)

What is broken after r22052 and r22059 ?:
In C++, the function setCurrentNode(const QString nodeID) is missing.
In Python:
The function currentNodeId() is missing (not wrapped due to a missing
Q_INVOKABLE).
Trickier, any code using the property currentNodeId = ... will break too.

What this commit intend to fix:
Add Q_INVOKABLE to currentNodeId() method for python wrapping.
Return the old property as deprecated.

Also adding warning in the deprecated function to warn other developers.

See Issue 0001694

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22072 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.h Diff File

2145-support-for-installing-extension-from-file 495bc7cc

2013-06-03 15:17:58

pieper

Details Diff
ENH: provide direct access to tensor arrays from python

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22071 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/util.py Diff File

2145-support-for-installing-extension-from-file 6a2c70ae

2013-05-31 12:46:45

alexy

Details Diff
ENH: moved Enable Tracks button to the top

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22070 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/TractographyInteractiveSeeding/Resources/UI/qSlicerTractographyInteractiveSeedingModuleWidget.ui Diff File

2145-support-for-installing-extension-from-file a682daef

2013-05-31 12:26:47

alexy

Details Diff
ENH: put more checks into fiber editing

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22069 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/TractographyDisplay/MRMLDM/vtkMRMLTractographyDisplayDisplayableManager.cxx Diff File
mod - Modules/Loadable/TractographyDisplay/Widgets/qSlicerTractographyDisplayModuleWidget.cxx Diff File
mod - Modules/Loadable/TractographyDisplay/Widgets/qSlicerTractographyDisplayModuleWidget.h Diff File

2145-support-for-installing-extension-from-file 2aba3246

2013-05-31 08:15:30

alexy

Details Diff
BUG: fixed fiber editing for multiple bundles

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22068 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/TractographyDisplay/MRMLDM/vtkMRMLTractographyDisplayDisplayableManager.cxx Diff File
mod - Modules/Loadable/TractographyDisplay/MRMLDM/vtkMRMLTractographyDisplayDisplayableManager.h Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 26 27 28 29 30 31 32 ... 40 ... 50 ... 55 56 57  Next  Last