Changesets: Slicer
|
2145-support-for-installing-extension-from-file 54b25f30 2013-06-21 08:17:59 Details Diff |
ENH: Adding function to create a new WidgetRepresentation for a module This can allow the user to "import" a module's GUI into another. This is particularly interesting for work-flow modules. The function getModuleGui can grab the existing GUI for the given module, but the widget representation can only exist in one place. So when using the GUI in another module with getModuleGui would cause one of the modules to be empty. From: Guillaume Sala <guillaume.sala@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22117 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Python/slicer/util.py | Diff File | ||
| mod - Base/QTCore/qSlicerAbstractCoreModule.cxx | Diff File | ||
| mod - Base/QTCore/qSlicerAbstractCoreModule.h | Diff File | ||
| mod - Base/QTCore/qSlicerAbstractModuleRepresentation.cxx | Diff File | ||
| mod - Base/QTGUI/qSlicerBaseQTGUIPythonQtDecorators.h | Diff File | ||
|
2145-support-for-installing-extension-from-file befb1cf7 2013-06-20 01:42:53 Details Diff |
COMP: Make sure extension fixup considers extension "support libraries" Before this commit, libraries that were not (python, cli or loadable module) related were systematically fixed with "@fixup_path@/@Slicer_LIB_DIR@". This commit changes this so that "support libraries" provided by an extension are properly fixed up. Note that the approach considered here will have to be revisited to ensure that extension depends on support libraries provided by other extension are properly fixed up. Co-authored-by: Francois Budin <fbudin@unc.edu> Signed-off-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22116 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerExtensionCPackBundleFixup.cmake.in | Diff File | ||
|
2145-support-for-installing-extension-from-file 8e71de80 2013-06-19 18:19:04 Details Diff |
COMP: Allow multiple configure with "ConfigurePrerequisites" component Following commit r22038 [1], the use of CMAKE_OSX_* variables set by Slicer has been simplified with the introduction of the "ConfigurePrerequisites" components. It turns out that the associated CMake logic was flawed and wasn't working as expected when the project was configured twice. This commit ensures the "Slicer_USE_*" variables associated with the components are reset before checking the variable "Slicer_FIND_COMPONENTS". It also ensures that the execution return if component "ConfigurePrerequisites" is defined and "Slicer_PREREQUISITES_CONFIGURED" is already set. Co-authored-by: Marine Clogenson <marine.clogenson@epfl.ch> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22115 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerConfig.cmake.in | Diff File | ||
|
2145-support-for-installing-extension-from-file 5f0b5d20 2013-06-19 16:28:00 Details Diff |
ENH: Expose _CPACK_PACKAGE_ICON for icns icon on mac packaging git-svn-id: http://svn.slicer.org/Slicer4/trunk@22114 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerCPack.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 51f5db34 2013-06-19 16:27:54 Details Diff |
BUG: Improve vtkMRMLCommandLineModuleNode python wrapping Python doesn't wrap enum type, making the SetStatus method unavailable in the scripted module. Using an int instead fixes this. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22113 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/CLI/vtkMRMLCommandLineModuleNode.cxx | Diff File | ||
| mod - Libs/MRML/CLI/vtkMRMLCommandLineModuleNode.h | Diff File | ||
|
2145-support-for-installing-extension-from-file 10def777 2013-06-19 16:27:48 Details Diff |
ENH: Add vtkSlicerVolumesLogic::CenterVolume() Note that the code is from qMRMLVolumeInfoWidget git-svn-id: http://svn.slicer.org/Slicer4/trunk@22112 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx | Diff File | ||
| mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.h | Diff File | ||
|
2145-support-for-installing-extension-from-file 7abe2b72 2013-06-19 16:27:40 Details Diff |
BUG: Zombie display node when turning a volume into labelmap When the current display node was removed, the slicer layer logic was creating a new node and adding it into the scene. Such node was not being removed of the scene when the new display node was set. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22111 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLVolumeInfoWidget.cxx | Diff File | ||
| mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx | Diff File | ||
|
2145-support-for-installing-extension-from-file 680b87cf 2013-06-19 16:27:33 Details Diff |
ENH: Make a Qt Designer plugin for qSlicerCLIProgressBar * Add qSlicerCLIProgressBar::statusVisibility * Add qSlicerCLIProgressBar::progressVisibility git-svn-id: http://svn.slicer.org/Slicer4/trunk@22110 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTCLI/CMakeLists.txt | Diff File | ||
| add - Base/QTCLI/DesignerPlugins/CMakeLists.txt | Diff File | ||
| add - Base/QTCLI/DesignerPlugins/qSlicerCLIProgressBarPlugin.cxx | Diff File | ||
| add - Base/QTCLI/DesignerPlugins/qSlicerCLIProgressBarPlugin.h | Diff File | ||
| add - Base/QTCLI/DesignerPlugins/qSlicerQTCLIAbstractPlugin.cxx | Diff File | ||
| add - Base/QTCLI/DesignerPlugins/qSlicerQTCLIAbstractPlugin.h | Diff File | ||
| add - Base/QTCLI/DesignerPlugins/qSlicerQTCLIPlugins.cxx | Diff File | ||
| add - Base/QTCLI/DesignerPlugins/qSlicerQTCLIPlugins.h | Diff File | ||
| mod - Base/QTCLI/qSlicerCLIProgressBar.cxx | Diff File | ||
| mod - Base/QTCLI/qSlicerCLIProgressBar.h | Diff File | ||
|
2145-support-for-installing-extension-from-file c342e908 2013-06-19 16:27:24 Details Diff |
ENH: Add loadedNodes return in qSlicerIOManager::openDialog * loadedNodes: It can be useful to know which nodes have been loaded by the dialog. * qSlicerStandardFileDialog supports "defaultFileName" property Conflicts: Base/QTGUI/qSlicerFileDialog.cxx Base/QTGUI/qSlicerFileDialog.h git-svn-id: http://svn.slicer.org/Slicer4/trunk@22109 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTGUI/qSlicerFileDialog.cxx | Diff File | ||
| mod - Base/QTGUI/qSlicerFileDialog.h | Diff File | ||
| mod - Base/QTGUI/qSlicerIOManager.cxx | Diff File | ||
| mod - Base/QTGUI/qSlicerIOManager.h | Diff File | ||
| mod - Base/QTGUI/qSlicerModelsDialog.cxx | Diff File | ||
| mod - Base/QTGUI/qSlicerModelsDialog.h | Diff File | ||
| mod - Base/QTGUI/qSlicerModelsDialog_p.h | Diff File | ||
|
2145-support-for-installing-extension-from-file 12fdccd4 2013-06-19 15:58:21 Details Diff |
BUG: Fix crash when saving data Commit r22095[1] intended to disable "unit" functionality by preventing the associated logic from being loaded. This commit comments the "unit" code associated with the selection node to fix crash happening when saving data. See http://www.na-mic.org/Bug/view.php?id=3176 Fixes 0003176 [1] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22095 Co-authored-by: Marine Clogenson <marine.clogenson@epfl.ch> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22108 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLSelectionNode.cxx | Diff File | ||
|
2145-support-for-installing-extension-from-file 3324342c 2013-06-19 14:37:48 hjohnson Details Diff |
ENH: Update BRAINSTools to remove outdated DWIConvertOld Old code was conflicting in Slicer, so it was removed. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22107 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_BRAINSTools.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 8593bfbd 2013-06-19 00:37:31 Details Diff |
STYLE: Update ModuleWizard help message to consider template renaming Following r21776, the superbuild extension template has been renamed. This commit fixes the Wizard accordingly. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22106 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Utilities/Scripts/ModuleWizard.py | Diff File | ||
|
2145-support-for-installing-extension-from-file 43808ca4 2013-06-19 00:32:00 Details Diff |
BUG: Update ModuleWizard to support *.cmake file This will allow to successfully use the wizard against the SuperBuild extension template. Co-authored-by: Marine Clogenson <marine.clogenson@epfl.ch> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22105 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Utilities/Scripts/ModuleWizard.py | Diff File | ||
|
2145-support-for-installing-extension-from-file 5238d9d2 2013-06-19 00:16:58 Details Diff |
COMP: Refactor DWIConvert and improve scanner support // ------------------ From Kent Williams Source: http://slicer-devel.65872.n3.nabble.com/ANNOUNCE-New-DWIConvert-version-td4028665.html I'm sure the thronging multitudes who live or die by Diffusion Tensor Imaging will be dancing in the streets. DWIConvert, the program for convertion Diffusion Weighted Image datasets from DICOM to NRRD and FSL image formats has been extensively refactored. My primary goal was to make the program easier to enhance and maintain. What was a very long and convoluted single function is now split out into a set of classes, one per Scanner Manufacturer. All the scanner-independent code is isolated from the scanner-specific code. Along the way it has been enhanced in a couple of ways: 1. Some fixes to accomodate the surprisingly varied output of Siemens and GE scanners. 2. Addition of a HITACHI scanner type. The HITACHI scanner code has only been tested on one example dataset; I don't know how many scanners they make or if different models/software versions encode Gradient Vectors differently. From some web documentation, it seems they follow the Supplement 49 standard for diffusion data, and the user who requested Hitachi scanner support said that the code worked fine for him. If you happen to run across another scanner that is not yet supported, the HITACHI converter would be a good starting point for adding a new device. In the course of debugging this new version, I first verified that it passed the included regression tests. Then, I did an exhaustive comparison of the new version's output with the over 3700 DWI DICOM datasets we have already converted for the PredictHD Research project. So I have high confidence that the new version is reliable enough for production work. // ---------------- Updating BRAINSTools also fixes various bugs and issues. For a complete list, see https://github.com/BRAINSia/BRAINSTools/compare/bc4adf7465300b7553a64e35035d05ee8a6407da...8fa5dd3c6d898461df184546faa165baeacbf0aa From: Kent Williams <norman-k-williams@uiowa.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22104 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_BRAINSTools.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 16072a01 2013-06-18 09:02:59 Details Diff |
COMP: Removed warning of no tests, because there are in expertregistration... git-svn-id: http://svn.slicer.org/Slicer4/trunk@22103 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/ExpertAutomatedRegistration/Testing/CMakeLists.txt | Diff File | ||
|
2145-support-for-installing-extension-from-file 765b0d43 2013-06-18 08:52:06 Details Diff |
COMP: Removed warning of unused parameter via itkNotUsed macro git-svn-id: http://svn.slicer.org/Slicer4/trunk@22102 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageToImageRegistrationHelper.txx | Diff File | ||
|
2145-support-for-installing-extension-from-file c0fce9cf 2013-06-16 19:23:46 Details Diff |
ENH: Do not default to CDash extension upload if Midas upload failed. By uploading the extension package on CDash in case the midas one failed was confusing the user. Indeed, after checking the dashboard, the small package submission was visible but not associated with a midas url. This commit return an explicit error message and abort the build process providing the user with hint on how to resolve the issue. The message that will be disable will be similar to: // ------------------ CMake Error at /home/jchris/Projects/Slicer-AHM/Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake:231 (message): Upload of [22100-linux-amd64-MyExtension-local0-2013-06-16.tar.gz] failed ! Check that: (1) you have been granted permission to upload (2) your email and api key are correct // ------------------ git-svn-id: http://svn.slicer.org/Slicer4/trunk@22101 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 883aa037 2013-06-12 19:25:07 Details Diff |
BUG: Fix CLI extension test fixing SEM_LAUNCH_COMMAND Following commit r21737 [1], CLIs tests have been updated to make use SEM_LAUNCH_COMMAND so that their code is decoupled from Slicer specific variables. This commit ensure that SEM_LAUNCH_COMMAND is updated to consider additional settings so that environment is properly set when running CLI modules test bundled in extension. [1] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21737 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22100 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Extensions/CMake/SlicerBlockAdditionalLauncherSettings.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 4863e54b 2013-06-12 17:17:34 Details Diff |
ENH: update the slicer.modules.<module>Widget attribute on reload This way the attribute can be used consistently to access the gui of the scripted module before or after it has been reloaded. Also add an optional cleanup method, which module guis can use, for example, to remove any observers to vtk objects or clean up other references. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22099 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Extensions/Testing/ScriptedLoadableExtensionTemplate/ScriptedLoadableModuleTemplate/ScriptedLoadableModuleTemplate.py | Diff File | ||
|
2145-support-for-installing-extension-from-file 79b07967 2013-06-11 16:03:08 Details Diff |
COMP: Optimize visual studio service pack check In commit r22096, the CMake module "CMakeDetermineVSServicePack" was used. In addition to invoke some extra "try_compile" statement increasing the configure time, it was failing complaining dll mspdb80.dll or mdpdb100.dll were missing. This commit fixes the problem by directly using "CMAKE_CXX_COMPILER_VERSION" Thanks to Brad Lowekamp for his help elaborating this set of patches. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22098 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerBlockPlatformCheck.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file a8a5917f 2013-06-11 15:38:06 Details Diff |
BUG: Fixes calls to slicer.util.moduleNames() In commit r19334 [1], the moduleNames() function has been renamed to "loadedModuleNames" but the corresponding function in slicer.util hasn't been renamed. This commit fixes slicer.util.moduleNames() so that it calls "loadedModuleNames" function. Fixes 0002591 [1]http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=19334 From: Christopher Mullins <christopher.mullins@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22097 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Python/slicer/util.py | Diff File | ||
|
2145-support-for-installing-extension-from-file d5638b89 2013-06-11 15:38:04 Details Diff |
ENH: Check required Visual Studio compiler version Configuration will abort if: 1) Visual Studio smaller than 2008 is detected 2) Visual Studio 2008 without service pack 1 is detected From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22096 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerBlockPlatformCheck.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 0bc8ba11 2013-06-10 16:51:52 Details Diff |
BUG: Disable units module Considering Na-mic week is happening next week, we decided to force the "units" module to be ignored. Waiting the underlying issues are resolved, this commit will prevent issue 0003152 from occurring. See http://www.na-mic.org/Bug/view.php?id=3152 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22095 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTApp/qSlicerApplicationHelper.cxx | Diff File | ||
|
2145-support-for-installing-extension-from-file 131f7ca8 2013-06-10 11:36:22 Details Diff |
STYLE: RobustStatisticsSegmenter - Better default parameters See 0003149 - http://na-mic.org/Mantis/view.php?id=3149 From: Yi Gao <yi.gao@gatech.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22094 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/RobustStatisticsSegmenter/RobustStatisticsSegmenter.xml | Diff File | ||
|
2145-support-for-installing-extension-from-file de7d5119 2013-06-10 11:36:21 Details Diff |
STYLE: Explanation related to commit r22092 gp_item_default_embedded_path is used to compute default_embedded_path [1] which is then used to set embedded_item[2]. Then, embedded_item is used to compute gp_resolve_embedded_item [3] Looking at the implementation of gp_resolve_embedded_item [4], we can see that properly computing embedded_item is important to set variable resolved_embedded_item used to determine if item should be copied or not into the bundle. [5] Note also that the version of BundleUtilities.cmake and GetPrerequisites used in Slicer have been updated [6] to support @rpath. Associated CMake topic is [7], it is also currently being discussed on CMake developer list [8] That is why the code within the function gp_item_default_embedded_path_override has been implemented. [1] http://cmake.org/gitweb?p=stage/cmake.git;a=blob;f=Modules/BundleUtilities.cmake;h=6c49174ce4ec3611310e8b4b67ee9fcc0763d59b;hb=2f770aad1f77ada793291d55048472f692bb4535#l374 [2] http://cmake.org/gitweb?p=stage/cmake.git;a=blob;f=Modules/BundleUtilities.cmake;h=6c49174ce4ec3611310e8b4b67ee9fcc0763d59b;hb=2f770aad1f77ada793291d55048472f692bb4535#l385 [3] http://cmake.org/gitweb?p=stage/cmake.git;a=blob;f=Modules/BundleUtilities.cmake;h=6c49174ce4ec3611310e8b4b67ee9fcc0763d59b;hb=2f770aad1f77ada793291d55048472f692bb4535#l423 [4] http://cmake.org/gitweb?p=stage/cmake.git;a=blob;f=Modules/GetPrerequisites.cmake;h=528c540392f12d9dcb51ad608d29a632b6ac5a8e;hb=2f770aad1f77ada793291d55048472f692bb4535#l476 [5] http://cmake.org/gitweb?p=stage/cmake.git;a=blob;f=Modules/BundleUtilities.cmake;h=6c49174ce4ec3611310e8b4b67ee9fcc0763d59b;hb=2f770aad1f77ada793291d55048472f692bb4535#l428 [6] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22023 [7] http://cmake.org/gitweb?p=stage/cmake.git;a=shortlog;h=refs/heads/tweak-bundleutilities-for-rpath [8] http://comments.gmane.org/gmane.comp.programming.tools.cmake.user/46454 From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22093 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerCPackBundleFixup.cmake.in | Diff File | ||
