Changesets: Slicer

2145-support-for-installing-extension-from-file d2a97a6d

2013-11-07 10:33:02

jcfr

Details Diff
STYLE: Avoid confusion creating enum for custom SaveDataDialog role.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22686 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerSaveDataDialog.cxx Diff File
mod - Base/QTGUI/qSlicerSaveDataDialog_p.h Diff File

2145-support-for-installing-extension-from-file 13099732

2013-11-06 14:56:48

lassoan

Details Diff
BUG: Fixed volume rendering presets issue (presets were not displayed)

The scene model RowCache was temporarily outdated during node insertion. If the cache was accessed during node insertion, the qMRMLSceneModel::indexFromNode method indicated that the node doesn't exist yet.
Fixed by adding an entry to the cache with the node-to-be-added, which results in not using the cache to determine if the node exists or not but uses the traditional way of iterating through all the items.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22685 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLSceneModel.cxx Diff File

2145-support-for-installing-extension-from-file 2ef602d7

2013-11-06 14:43:35

jcfr

Details Diff
COMP: Ensure custom qt style plugins are fixed-up on MacOSX

This is a follow-up of commit r22238 ensuring the style plugins
are considered as candidate by the fixup script.

See 0003253

Signed-off-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22684 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerCPackBundleFixup.cmake.in Diff File

2145-support-for-installing-extension-from-file 8ecf0edf

2013-11-05 09:24:15

pieper

Details Diff
ENH: clarify name of attribute (Markup not Seed)

There are different conventions in different parts of the code,
but Seed is consistently the vtk widget layer, and Markup is the
Slicer nomenclature.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22683 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsFiducialDisplayableManager2D.cxx Diff File

2145-support-for-installing-extension-from-file a2f32ab8

2013-11-05 09:24:10

pieper

Details Diff
ENH: give Markups option to be visible only in selected views

Port change from r21740 from Annotations to Markups

ENH: give annotations option to be visible only in selected views

This uses the same convention used in dislay nodes for other
displayable managers (e.g. VolumeRendering), except that it uses the
sliceNode since it is the 2D analog to the 3D view Node (at some point
perhaps there should be a generic superclass). Here, since we are only
using the ID string it doesn't matter what type the node it.

This feature allows custom UIs, for example where some annotations only
show up in one view while others show up everywher. In particular, this
is helpful for annotations representing volume-specific anatomical
landmark locations.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21740 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22682 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager2D.cxx Diff File

2145-support-for-installing-extension-from-file 5ab938ef

2013-11-04 23:48:42

jcfr

Details Diff
COMP: OpenIGTLink - Fix MacOSX build error related to missing strnlen()

$ git shortlog ee594372eb8c9a25da1dbff2bd081cb70ce9554a..3ac531115f55e74265e7de7ff508312dbfb16695
Junichi Tokuda (4):
BUG: Implement igtl::Strnlen() for platforms that do not have strnlen. See issue 0000025.
STYLE: Increment the patch number.
COMP: Fix compiler warnings for Mac OS X Mavericks.
Merge pull request 0000027 from tokjun/25-missing-strnlen

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Junichi Tokuda <tokuda@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22681 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_OpenIGTLink.cmake Diff File

2145-support-for-installing-extension-from-file 9d2c53a1

2013-11-04 16:18:41

jcfr

Details Diff
COMP: vtkITK - Update GetJacobian() to make transform ITKv4 compliant

This patch is necessary to compile Slicer with a system ITKv4 library.

For more info see the ITKv4 migration guide.
http://itk.org/migrationv4/index.php?action=artikel&cat=3&id=110&artlang=en

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Dominique Belhachemi <domibel@debian.org>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22680 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/vtkITKBSplineTransform.cxx Diff File

2145-support-for-installing-extension-from-file 29a04b80

2013-11-04 16:04:45

jcfr

Details Diff
BUG: OpenIGTLink - Fixes issue 0003454 - could not receive LBMETA messages.

// -------------------------
OpenIGTLink updates:

Bonny Biswas (2):
ENH: Added set/get methods for coordinate system in ImageMessage classes
BUG: LPS coordinate system value in ImageMessage does not match protocol

Isaiah Norton (2):
ENH: add StringEchoServer example
ENH: add PointListServer example

Junichi Tokuda (41):
ENH: start implementing session manager
ENH: MessageHandler and SessionManager classes are implemented and now working. Template-based MessageHandler class has been removed.
STYLE: adding comment in the source code for SessionManagerServer example program.
ENH: implement session manager with pseudo non-blocking messaging (receive only)
Merge pull request 0000003 from lchauvin/patch-1
Merge pull request 0000004 from lchauvin/patch-1
ENH: added the second argument for Process() in the message handler class to share data between the message handler class and other classes/functions outside the class.
Solve conflict.
ENH: Adding CapabilityMessage class
ENH: Adding the capability message type and examples.
ENH: Merging the fixes in the master branch to the development branch.
BUG: Fixed the compile error caused by the last commit.
STYLE: Merging the master repository with improved comments for Doxygen.
STYLE: Merge changes in the master repository.
STYLE: Merge updates in the master repository.
STYLE: Merge master repository.
ENH: Add igtlCreateDefaultQueryMessageClass() macro to help defining a class for query message.
ENH: Create HeaderOnlyMessageBase as a base class for query message types.
BUG: merge labonny's changes
Merge pull request 0000013 from perim/master
BUG: Fix Issue 0000014 Linker error in VS2012.
STYLE: Fix wrong statement in help (coordinate -> string)
Merge pull request 0000018 from ihnorton/add_pointlistserver_example
ENH: Add a class for GET_STATUS message type.
ENH: Add TrajectoryMessage example.
ENH: Merge changes in master.
STYLE: Fixed revision number
COMP: Fix warning 'converting to non-pointer type int from NULL'.
STYLE: Update version number.
ENH: Merge github.com:tokjun/OpenIGTLink.git.
BUG: Avoid * ((igtl_uint16 *) ptr) = <value> to address issue 0000020. Need testing.
STYLE: Format README using Markdown
STYLE: Rename README to README.md
BUG: Address issue 0000021.. replace this->m_DefaultBodyType = this->DefaultBodyType() with this->m_DefaultBodyType = ""
BUG: Reset changes in Example/Status/StatusClient
BUG: Fixing Issue 0000020. 'signed' is explicitly specified for igtl_int8. Tested on Ubuntu + armv7l.
STYLE: Use C-style comments in .c files.
Merge pull request 0000022 from tokjun/master
ENH: Add LBMETA message to ImageDatabaseServer example.
BUG: Fixed bug in LabelMetaMessage. It could not extract owner image information from a LBMETA message.
Merge pull request 0000024 from tokjun/23-LBMETA-example

Laurent Chauvin (3):
Modified GetMode method
Add igtlMessageHandlerMacro.h to the list of files
ENH: Removed the sleep

Per Inge Mathisen (3):
Fix wrong use of delete operator
Fix wrong bitwise and operator
Fix compile warnings under clang

// -------------------------
OpenIGTLinkIF updates:

Isaiah Norton (1):
COMP: partially fix 0000009, and a leak

Junichi Tokuda (3):
Merge pull request 0000010 from ihnorton/issue9_partial_fix
ENH: Implement LableMetaList function. This commit requires OpenIGTLink library commit 661d4bd.
Merge pull request 0000012 from tokjun/0003454-lbmeta

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22679 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_OpenIGTLink.cmake Diff File
mod - SuperBuild/External_OpenIGTLinkIF.cmake Diff File

2145-support-for-installing-extension-from-file 63a1a0e6

2013-11-04 15:43:07

jcfr

Details Diff
ENH: Update VTK - Add support for color lookup table annotation.

Kevin Wang (1):
Update vtkScalarsToColors classes to support color lookup table annotation.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22678 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_VTK.cmake Diff File

2145-support-for-installing-extension-from-file 72406d08

2013-11-03 18:07:51

jcfr

Details Diff
STYLE: Simplify vtkSlicerModelsLogic code using vtkNew

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22677 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Models/Logic/vtkSlicerModelsLogic.cxx Diff File

2145-support-for-installing-extension-from-file 598f1038

2013-11-03 18:07:48

jcfr

Details Diff
STYLE: Avoid confusion renaming SceneView API: "Nodes" into "StoredScene"

The following renaming have been done:
- ivar Nodes -> StoredScene
- method "UpdateSnapshotScene" -> "UpdateStoredScene"
- method "GetNodes" -> "GetStoredScene"

Also remove the unused parameter from "UpdateStoredScene"

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22676 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/SlicerMRBTest.py Diff File
mod - Base/QTGUI/qSlicerSaveDataDialog.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneAddSingletonTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeImportSceneTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeStoreSceneTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSceneViewNode.h Diff File
mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.cxx Diff File

2145-support-for-installing-extension-from-file f3b94810

2013-11-03 18:07:42

jcfr

Details Diff
COMP: MRML Scene ivar "ActiveScene" is not unused anymore.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22675 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File

2145-support-for-installing-extension-from-file 681693d6

2013-11-03 18:07:39

jcfr

Details Diff
COMP: Remove redundant Scene methods: GetClassNameList, GetNodeClasses

The method "GetNodeClassesList" fulfills the same goal.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22674 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/Testing/volumes.tcl Diff File
mod - Libs/MRML/Core/Testing/testVolume.tcl Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File

2145-support-for-installing-extension-from-file 9fccc8bd

2013-11-03 18:07:34

jcfr

Details Diff
COMP: Simplify MRML Scene API removing SceneModifiedTime methods.

Along with the methods "GetSceneModifiedTime" and "IncrementSceneModifiedTime",
the ivar SceneModifiedTime has been introduced in r5772.

Considering the Modified time of the scene is in fact returned by the
method "vtkMRMLScene::GetMTime()", having an other method named
"GetSceneModifiedTime" is rather confusing.

Since internally the method "GetSceneModifiedTime" was using the MTime
of the underlying node collection, the existing call to the method
have been changed into "GetNodes()->GetMTime()".

This commit is a follow-up of r18562 where the method "GetCurrentScene()"
has been renamed into "GetNodes()". For reference, the method
"GetCurrentScene()" has itself been introduced in r8315.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22673 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLHierarchyNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File
mod - Libs/MRML/Logic/vtkMRMLModelHierarchyLogic.cxx Diff File

2145-support-for-installing-extension-from-file a1956645

2013-10-31 13:03:51

lassoan

Details Diff
BUG: Prevent LevelTracingEffect crash when the user clicks on a pixel at the edge of the image (http://na-mic.org/Mantis/view.php?id=3470)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22671 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/LevelTracingEffect.py Diff File

2145-support-for-installing-extension-from-file c9f4958b

2013-10-31 00:51:14

jcfr

Details Diff
STYLE: Move vtkMRMLScene method definitions into implementation file.

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22670 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File

2145-support-for-installing-extension-from-file 121af10b

2013-10-31 00:51:11

jcfr

Details Diff
ENH: Optimized performance of observations management in vtkMRMLScene

Use a std::map< std::string, std::set<std::string> > instead of two
separate ReferencedIDs and ReferencingNodes vectors to make lookup,
insertion, and deletion much faster (especially scene close takes much
shorter time now).
Store both referenced and referring nodes by ID. It is simpler, safer,
and most of the time the node pointers were validated anyway using
scene->GetNodeFromID(node->GetID().

Also, use set instead of vector for storing unique IDs for improving
performance of scene loading (especially when the same scene is loaded
twice and a lot of IDs have to be generated).

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22669 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeStoreSceneTest.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File
mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Logic/vtkSlicerVolumeRenderingLogic.cxx Diff File

2145-support-for-installing-extension-from-file 6b31883f

2013-10-31 00:51:06

jcfr

Details Diff
STYLE: Simplify code using vtkNew to register node with MRML scene

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22668 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File

2145-support-for-installing-extension-from-file 6439e288

2013-10-31 00:51:03

jcfr

Details Diff
ENH: Improved performance of qMRMLSceneModel

The indexFromNode method is called millions of times when there are a few hundred nodes and it browses through the whole model to find the requested node. Add a cache that stores the last search result and use it as a search hint.
New rows are always added to the cache, so the cache alone can be used to determine if a node is not yet in the model.

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22667 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLSceneModel.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSceneModel_p.h Diff File

2145-support-for-installing-extension-from-file 54645f97

2013-10-31 00:51:00

jcfr

Details Diff
ENH: Optimized qMRMLSceneModel::nodeIndex performance

qMRMLSceneModel::nodeIndex is called tens of millions of times, therefore it's optimum performance is critical.
Find MRML nodes by object pointer instead of ID comparison to improve the performance.

Also, always do lazyupdate for qMRMLSceneModel if scene is closing to unsubscribe from all events at once the scene is closed.

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22666 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLSceneModel.cxx Diff File

2145-support-for-installing-extension-from-file 35060e47

2013-10-31 00:50:56

jcfr

Details Diff
ENH: vtkEventBroker performance improvement

Use a set instead of a vector to allow faster finding and deletion of observations

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22665 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkEventBroker.cxx Diff File
mod - Libs/MRML/Core/vtkEventBroker.h Diff File
mod - Libs/MRML/Core/vtkObserverManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelSliceDisplayableManager.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLEventBrokerWidget.cxx Diff File

2145-support-for-installing-extension-from-file 2123ad72

2013-10-31 00:50:52

jcfr

Details Diff
BUG: Fixed references to nodes in qSlicerTractographyDisplayWidget

Crash happened at the end of SceneClose in py_test_tractography_display test because old (invalid) display node was still used.

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22664 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/TractographyDisplay/Widgets/qSlicerTractographyDisplayWidget.cxx Diff File

2145-support-for-installing-extension-from-file 8d37eaf3

2013-10-31 00:50:49

jcfr

Details Diff
ENH: Add BatchUpdateThreshold to Model hierarchy logic

Only use batch processing for show/hide of model hierarchies if the
total number of nodes in the selected branch is larger than a given threshold.

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22663 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkMRMLModelHierarchyLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLModelHierarchyLogic.h Diff File

2145-support-for-installing-extension-from-file c0a0b502

2013-10-31 00:50:46

jcfr

Details Diff
ENH: Don't batch process when show/hide only a few child nodes

When there are many child nodes in a hierarchy then show/hide is much more efficient if batch processing is enabled.
However, if there are few nodes only then a full refresh at the end of a batch processing takes longer than doing the update on each node separately.
Count the number of child nodes and if there are less than 30 then update each node separately.

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22662 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLTreeView.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLTreeView_p.h Diff File

2145-support-for-installing-extension-from-file 1d35a855

2013-10-31 00:50:42

jcfr

Details Diff
ENH: Update CTK to integrate Andras Lasso VTK connection optimization.

Andras Lasso (3):
ENH: Use a hashmap to avoid linear search for existing vtk connections
BUG: Fixed ctkVTKObjectEventsObserverPrivate::findConnection behavior for wildcards
ENH: qvtkConnect and qvtkDisconnect performance improvement

Jean-Christophe Fillion-Robin (1):
Merge branch 'vtkconnect-performance-improvement-consolidated'

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22661 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File
 First  Prev  1 2 3 ... 7 8 9 10 11 12 13 ... 20 ... 30 ... 40 ... 50 ... 55 56 57  Next  Last