Changesets: Slicer

Search Browse Back to Index

2145-support-for-installing-extension-from-file 712b4f7c

2013-10-02 15:28:04

fedorov

Details Diff 		ENH: allow dynamic update of the slice viewer label

This feature is helpful to inform the user of the slice viewer content without
using extra screen space. Resolves issue 3427


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22568 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File

2145-support-for-installing-extension-from-file be71a46f

2013-10-02 00:26:05

jcfr

Details Diff 		BUG: Fix qSlicerExtensionsManagerModelTest.testExtractExtensionArchive

By using QFile static function each time permission are set/get, we
ensure that the permissions of the file are fully re-stated [1]. Indeed,
internally it create a QFile object for each call.

Doing so fix the test ensuring the call to:

QFile(this->Tmp.absolutePath()).permissions() & QFile::WriteUser)

returns the expected value just after permission has been set.

This is a know Qt issue. See https://bugreports.qt-project.org/browse/QTBUG-7211

[1] http://en.wikipedia.org/wiki/Stat_%28system_call%29

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22564 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/Testing/Cxx/qSlicerExtensionsManagerModelTest.cxx Diff File

2145-support-for-installing-extension-from-file 4f856fc4

2013-10-01 19:16:39

jcfr

Details Diff 		BUG: Fix qSlicerUtilsTest1

Following Qt 4.8.1, setting permission on a folder with a parent folder
not being executable leads to an error.

As it should always have:

$ mkdir bar/foo
$ chmod u-x bar
$ chmod u-x bar/foo
chmod: cannot access ‘bar/foo’: Permission denied

This commit implement the correct behavior by setting flags in the
right order depending if Executable but is passed or not.

Since it is not possible to change permission of directory without executable
bit set to off, if flag "with executable bit off" is recursively set to
path /a/b/c/d, permission should be set to d, c, b and then a.

[1] and probably 4.8.0 but this hasn't been tested.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22563 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerUtils.cxx Diff File

2145-support-for-installing-extension-from-file 26da822a

2013-10-01 19:16:37

jcfr

Details Diff 		COMP: Fix [-Wconversion-null] in qSlicerScriptedFileWriter.cxx

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22562 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerScriptedFileWriter.cxx Diff File

2145-support-for-installing-extension-from-file 8a13abd0

2013-10-01 15:56:32

jcfr

Details Diff 		COMP: Fix [-Wunused-but-set-variable] in vtkSlicerVolumeRenderingLogic

After checking with the author of the class, it makes sense to remove the
code related to the unused "gradientRange" variable.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22559 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/VolumeRendering/Logic/vtkSlicerVolumeRenderingLogic.cxx Diff File

2145-support-for-installing-extension-from-file ebfc6e14

2013-10-01 15:56:30

jcfr

Details Diff 		COMP: Fix "-Wunused-but-set-variable" in vtkMRMLModelDisplayableManager

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22558 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File

2145-support-for-installing-extension-from-file 73229447

2013-10-01 15:32:17

jcfr

Details Diff 		BUG: Fix crash if Alt+Tab is pressed when transforms module is active.

$ git shortlog 90000c32..f64b68acd
Andras Lasso (1):
Prevent reentrant calling of ctkProxyStyle::ensureBaseStyle()

Jean-Christophe Fillion-Robin (1):
Merge pull request 0000372 from lassoan/371-ensure-base-style-infinite-recursion-crash

Fixes 0003129

From: Andras Lasso <lasso@cs.queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22541 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

2145-support-for-installing-extension-from-file b94ba061

2013-10-01 15:25:03

jcfr

Details Diff 		BUG: Fix leak in vtkMRMLCameraDisplayableManagerTest1

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22540 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLCameraDisplayableManagerTest1.cxx Diff File

2145-support-for-installing-extension-from-file ed4e7921

2013-10-01 15:25:00

jcfr

Details Diff 		ENH: Improve readability using vtkNew where possible

In addition to be shorter, it simply conveys the idea of locally
instantiating an object.

Indeed, vtkNew allow to instantiate an object on the heap and deleting it
when it goes out of scope if its reference count has been incremented by
either assigning the object to a smart pointer or calling Register.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22539 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/vtkSlicerApplicationLogic.cxx Diff File
mod - Base/Logic/vtkSlicerFiducialsLogic.cxx Diff File
mod - Base/Logic/vtkSlicerGlyphSource2D.cxx Diff File
mod - Base/Logic/vtkSlicerTransformLogic.cxx Diff File
mod - Base/QTCLI/vtkSlicerCLIModuleLogic.cxx Diff File
mod - Base/QTCore/qSlicerCoreIOManager.cxx Diff File
mod - Base/QTCore/qSlicerSlicer2SceneReader.cxx Diff File
mod - Base/QTCore/qSlicerXcedeCatalogIO.cxx Diff File
mod - Libs/MRML/CLI/vtkMRMLCommandLineModuleNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLCameraNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayableHierarchyNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLFiducialListNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLGridTransformNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLLayoutNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLModelStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNRRDStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLROIListNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSceneViewStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSliceNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeArchetypeStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeHeaderlessStorageNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLVolumeNode.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelSliceDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLVolumeGlyphSliceDisplayableManager.cxx Diff File
mod - Libs/MRML/Logic/vtkImageResliceMask.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLayerLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLinkLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLogic.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLLinearTransformSlider.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLMatrixWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLVolumeInfoWidget.cxx Diff File
mod - Libs/vtkITK/vtkITKArchetypeDiffusionTensorImageReaderFile.cxx Diff File
mod - Libs/vtkITK/vtkITKImageWriter.cxx Diff File
mod - Libs/vtkTeem/vtkSeedTracts.cxx Diff File
mod - Modules/CLI/ACPCTransform/ACPCTransform.cxx Diff File
mod - Modules/CLI/DWIToDTIEstimation/DWIToDTIEstimation.cxx Diff File
mod - Modules/CLI/DiffusionWeightedVolumeMasking/DiffusionWeightedVolumeMasking.cxx Diff File
mod - Modules/CLI/ExecutionModelTour/ExecutionModelTour.cxx Diff File
mod - Modules/CLI/FiberBundleLabelSelect/FiberBundleLabelSelect.cxx Diff File
mod - Modules/CLI/ModelMaker/ModelMaker.cxx Diff File
mod - Modules/CLI/PETStandardUptakeValueComputation/PETStandardUptakeValueComputation.cxx Diff File
mod - Modules/CLI/TractographyLabelMapSeeding/TractographyLabelMapSeeding.cxx Diff File
mod - Modules/Loadable/Annotations/GUI/qSlicerAnnotationModulePropertyDialog.cxx Diff File
mod - Modules/Loadable/Annotations/Logic/vtkSlicerAnnotationModuleLogic.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationLinesStorageNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationSnapshotStorageNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationROIDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationGlyphSource2D.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation2D.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationRulerRepresentation3D.cxx Diff File
mod - Modules/Loadable/Colors/Logic/vtkSlicerColorLogic.cxx Diff File
mod - Modules/Loadable/Data/qSlicerSceneWriter.cxx Diff File
mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.cxx Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager2D.cxx Diff File
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager3D.cxx Diff File
mod - Modules/Loadable/Markups/VTKWidgets/vtkMarkupsGlyphSource2D.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File
mod - Modules/Loadable/Models/Logic/vtkSlicerModelsLogic.cxx Diff File
mod - Modules/Loadable/Reformat/qSlicerReformatModuleWidget.cxx Diff File
mod - Modules/Loadable/SceneViews/Logic/vtkSlicerSceneViewsModuleLogic.cxx Diff File
mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx Diff File
mod - Modules/Scripted/EditorLib/Logic/vtkImageSlicePaint.cxx Diff File

2145-support-for-installing-extension-from-file 8e0ba984

2013-10-01 15:24:47

jcfr

Details Diff 		ENH: Improve readability of MRML tests using vtkNew where possible

Simplify code removing tests for null object already being done
in the helper macro "EXERCISE_BASIC_OBJECT_METHODS"

For example, the following should not be needed:

vtkNew<vtkFoo> foo;
if (foo.GetPointer() == 0)
{
std::cerr << "Failed to instantiate vtkFoo" << std::endl;
}

Instead, the following should be used:

EXERCISE_BASIC_OBJECT_METHODS(foo.GetPointer())

Remove use of unnecessary vtkSmartPointer to check return value. Indeed,
since the operator "==" of the vtkSmartPointer is overloaded to compare with
the pointed object, there is no need to used a smart pointer. [1]

// ---------
vtkSmartPointer<vtkMRMLDisplayableNode> pnode = node1->GetDisplayableNode();
std::cout << "GetDisplayableNode returned "
<< (pnode == NULL ? "null" : "not null")
<< std::endl;
// ---------

has been changed into

// ---------
vtkMRMLDisplayableNode* pnode = node1->GetDisplayableNode();
std::cout << "GetDisplayableNode returned "
<< (pnode == NULL ? "null" : "not null")
<< std::endl;
// ---------

[1] https://github.com/Kitware/VTK/blob/0e0674a3695fdeaf01ce87dfc04e32111b7402e0/Common/vtkSmartPointerBase.h#L104

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22538 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/Testing/vtkDataIOManagerLogicTest1.cxx Diff File
mod - Base/Logic/Testing/vtkSlicerApplicationLogicTest1.cxx Diff File
mod - Base/QTCore/Testing/Cxx/qSlicerCoreIOManagerTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLBSplineTransformNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLCameraNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLClipModelsNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLColorNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLColorTableNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLColorTableStorageNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDiffusionImageVolumeNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDiffusionTensorVolumeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDiffusionTensorVolumeNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableHierarchyNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableHierarchyNodeTest2.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableHierarchyNodeTest3.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLFiberBundleNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLFiberBundleTubeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLFreeSurferModelStorageNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLGlyphableVolumeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLHierarchyNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLHierarchyNodeTest3.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLModelHierarchyNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLModelNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLNRRDStorageNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLProceduralColorNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLROIListNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLROINodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLScalarVolumeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLScalarVolumeNodeTest2.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneImportIDModelHierarchyParentIDConflictTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneTest2.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeStoreSceneTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSelectionNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSnapshotClipNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLTensorVolumeNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLUnitNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLVectorVolumeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLVolumeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLVolumeHeaderlessStorageNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLVolumeNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkObserverManagerTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.h Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLSliceViewDisplayableManagerFactoryTest.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLAbstractLogicSceneEventsTest.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLApplicationLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLColorLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLDisplayableHierarchyLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLLayoutLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLLayoutLogicTest2.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLModelHierarchyLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest2.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest3.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest4.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest5.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorListViewEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorListViewTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorModelTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorPickerWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorPickerWidgetTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorPickerWidgetTest2.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorPickerWidgetTest3.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorTableViewEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorTableViewTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLModelTreeViewTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNavigationViewEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNavigationViewTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest3.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest4.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest5.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest6.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest7.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest8.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLROIWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLScalarInvariantComboBoxEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLScalarInvariantComboBoxTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSceneCategoryModelTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSceneColorTableModelTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetTest2.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLTreeViewEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeInfoWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeInfoWidgetTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeThresholdWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeThresholdWidgetTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeThresholdWidgetTest2.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLWindowLevelWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLWindowLevelWidgetTest1.cxx Diff File
mod - Libs/vtkITK/Testing/VTKITKBSplineTransform.cxx Diff File
mod - Libs/vtkTeem/Testing/vtkDiffusionTensorMathematicsTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationDisplayNodeTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationLinesStorageNodeTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationNodesUndoTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationRulerNodeTest1.cxx Diff File
mod - Modules/Loadable/CropVolume/Testing/vtkMRMLCropVolumeParametersNodeTest1.cxx Diff File
mod - Modules/Loadable/Markups/Testing/Cxx/vtkMRMLMarkupsDisplayNodeTest1.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Testing/Cxx/vtkMRMLVolumePropertyNodeTest1.cxx Diff File

2145-support-for-installing-extension-from-file d3f2322f

2013-10-01 15:24:35

jcfr

Details Diff 		ENH: Update qMRMLLayoutManagerTest2 to check for reference count

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22537 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest2.cxx Diff File

2145-support-for-installing-extension-from-file 12ccdd8e

2013-10-01 15:24:33

jcfr

Details Diff 		STYLE: Update "removeSliceView" to be consistent with other remote methods

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22536 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLLayoutManager.cxx Diff File

2145-support-for-installing-extension-from-file ca0427a3

2013-10-01 15:24:31

jcfr

Details Diff 		STYLE: Re-organize qMRMLLayoutManagerTest(1|2|3|4) for easier readability

Factor out code into convenience functions:
- checkViewArrangement
- checkNumberOfItems

Use vtkNew when possible

There is no need to explicitly delete the layout manager since
it was a QWidget instantiated on the stack as a parent.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22535 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest2.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest3.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest4.cxx Diff File

2145-support-for-installing-extension-from-file 48bbb6d4

2013-10-01 15:24:29

jcfr

Details Diff 		BUG: Fix qMRMLLayoutManagerTest2

Ensure ModelDisplayableManager properly delete resources when
a new scene is set.

Ensure the slicer logic set the scene on layers when a new
scene is set a second time.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22534 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.h Diff File
mod - Libs/MRML/Logic/vtkMRMLSliceLogic.cxx Diff File

2145-support-for-installing-extension-from-file 701cfdea

2013-10-01 15:24:27

jcfr

Details Diff 		BUG: qMRMLLayoutManagerTest(s) - Fix (Selection|Interaction)Node warnings

This commit will fix the following warnings:

147: Warning: In /home/jchris/Projects/Slicer/Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx, line 583
147: vtkMRMLThreeDReformatDisplayableManager (0x2c92750): CreateIfPossible - MRMLScene does NOT contain any InteractionNode
147:
147: Warning: In /home/jchris/Projects/Slicer/Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx, line 591
147: vtkMRMLThreeDReformatDisplayableManager (0x2c92750): CreateIfPossible - MRMLScene does NOT contain any SelectionNode

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22533 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest2.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest3.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLLayoutManagerTest4.cxx Diff File

2145-support-for-installing-extension-from-file 958f930e

2013-09-30 22:35:00

fedorov

Details Diff 		COMP: reverting previous change as it caused compile error on Win

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22532 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/CropVolume/Logic/vtkSlicerCropVolumeLogic.cxx Diff File

2145-support-for-installing-extension-from-file 63ef0e4b

2013-09-30 20:16:35

fedorov

Details Diff 		ENH: adding 3x3 layout

see issue 2384


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22531 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Resources/UI/qSlicerAppMainWindow.ui Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLLayoutNode.h Diff File
mod - Libs/MRML/Logic/vtkMRMLLayoutLogic.cxx Diff File
add - Libs/MRML/Widgets/Resources/Icons/LayoutThreeByThreeSliceView.png Diff File
mod - Libs/MRML/Widgets/Resources/qMRMLWidgets.qrc Diff File

2145-support-for-installing-extension-from-file b36d2e33

2013-09-30 19:35:48

fedorov

Details Diff 		BUG: fix the numbering of slice viewer labels

In the situations when Yellow/Green/Red viewers are present, the additional viewers should be numbered starting from 4.


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22530 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkMRMLLayoutLogic.cxx Diff File

2145-support-for-installing-extension-from-file ee7d3420

2013-09-30 19:25:21

fedorov

Details Diff 		STYLE: fix the grey slice viewers labels to be distinctive

Per comment from Jim, see issue 2384


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22529 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkMRMLLayoutLogic.cxx Diff File

2145-support-for-installing-extension-from-file c1323ba7

2013-09-30 19:15:15

fedorov

Details Diff 		COMP: convert to integer explicitly to avoid ambiguity

Fixes 0003420


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22528 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/CropVolume/Logic/vtkSlicerCropVolumeLogic.cxx Diff File

2145-support-for-installing-extension-from-file 872207e5

2013-09-27 18:56:55

alexy

Details Diff 		BUG: 3388. Fixed crash in test when referenceRole=0

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22527 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File

2145-support-for-installing-extension-from-file f50fd0ee

2013-09-27 15:18:25

jcfr

Details Diff 		BUG: Fix copy/paste in python console / Update CTK projects

$ git shortlog 0e21d85e..90000c3

Jean-Christophe Fillion-Robin (1):
Merge pull request 0000366 from finetjul/294-fix-ctkconsole-copy-paste

Julien Finet (5):
Fix copy/paste in ctkConsole
Add private implementation to ctkCoordinatesWidget
Merge branch '355-ctkcoordinateswidget-pimpl'
Add ctkCoordinatesWidget_p.h
Merge branch '355-ctkcoordinateswidget-pimpl'

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22526 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

2145-support-for-installing-extension-from-file 59616c95

2013-09-27 15:18:24

jcfr

Details Diff 		COMP: Fix "unused-but-set-variable" warning in qMRMLItemDelegate

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22525 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLItemDelegate.cxx Diff File

2145-support-for-installing-extension-from-file 1c2a7d51

2013-09-27 14:43:01

alexy

Details Diff 		BUG: 3413. Fixed crash on writing a custom reference.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22524 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File

2145-support-for-installing-extension-from-file ad3ac24d

2013-09-27 14:19:55

alexy

Details Diff 		BUG: 3388. Added observer events parameter to the vtkMRMLNode::AddNodeReferenceRole() method, so that the events can be set only once in subclasses. Added observed events to DisplayableNode and TransformableNode. Simplified and unified reference implementation in TransformableNode

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22523 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDisplayableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.cxx Diff File
 First  Prev  1 2 3 ... 10 11 12 13 14 15 16 ... 20 ... 30 ... 40 ... 50 ... 55 56 57  Next  Last