Changesets: Slicer

Search Browse Back to Index

1683-launcher-with-output 1d452e19

2012-10-13 10:03:06

pieper

Details Diff 		ENH: avoid updating Qt while scene is batch processing

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21172 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File

1683-launcher-with-output d9be5bad

2012-10-13 09:34:19

pieper

Details Diff 		BUG: avoid over-responding to mrml scene changes in per-structure volumes

Use the specific methods for node added and remove events rather
than the generic modified events. This avoids creating/destroying
Qt classes while the scene is being torn down and avoids a
crash in the ThresholdThreading test.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21171 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/HelperBox.py Diff File

1683-launcher-with-output 3e2d5801

2012-10-12 17:10:53

millerjv

Details Diff 		BUG: 2632. GrowCut crashes with input volume of type char.

The intensity image is assigned to the first input on the
vtkITKGrowCutImageFilter which forces the output segmentation
image to have the same pixel type. But the output segmetentation
is assumed at the ITK level to be same pixel type as the gesture
image.

Overrode ExecuteInformation() so information from the second
input is propagated to the output image, so the gesture image
and output segmentation image have the same pixel type.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21170 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/vtkITKGrowCutSegmentationImageFilter.cxx Diff File
mod - Libs/vtkITK/vtkITKGrowCutSegmentationImageFilter.h Diff File

1683-launcher-with-output bb3db37f

2012-10-12 16:52:53

jcfr

Details Diff 		COMP: Export qSlicerBaseQTCLIPythonD library so that extensions can link it

See http://slicer-devel.65872.n3.nabble.com/Build-error-in-SlicerRT-extension-cannot-open-input-file-qSlicerBaseQTCLIPythonD-lib-tc4026390.html

Thanks to Csaba for reporting the issue.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21169 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/CMakeLists.txt Diff File

1683-launcher-with-output 75410017

2012-10-12 15:56:56

jcfr

Details Diff 		COMP: Ensure extension description file are generated in top level build dir

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21168 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerExtensionCPack.cmake Diff File

1683-launcher-with-output 0fc6ebed

2012-10-12 15:00:03

sankhesh

Details Diff 		BUG: 2321 Should not check on Mac machines

The linker ld for OSX does not have --as-needed and --no-as-needed
flags.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21167 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

1683-launcher-with-output 314459f4

2012-10-12 13:21:35

pieper

Details Diff 		BUG: include entire scalar range in threshold

Because the ctk range widget rounds the values for display, it
can have the effect of truncating the values such that the
selected range does not include the highest
value(s) in the volume. Adding 1 to the max value avoids this
problem with no anticipated downsides.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21166 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/EditOptions.py Diff File

1683-launcher-with-output 1ab67dc2

2012-10-12 12:11:14

jcfr

Details Diff 		BUG: Fix crash introduced by commit r21160

The problem is that Interactor member is not initialized for Displayable
manager that don't have at list on Interactor event to observe.

Before the change, the interactor was returned using
GetRenderWindow()->GetInteractor()

After the change, this->Interactor is returned.

This commit ensures that Interactor variable is set when the Render
is also set.

See https://github.com/Slicer/Slicer/commit/1264dac8ca9aaeba54627b8f8a37333c0f5f8a49#L0R648

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21165 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module e1e149b3

2012-05-08 18:18:00

jcfr

Details Diff 		BUG: Expose DCMTK_DIR to built-in slicer module. Fixes 0001999

See http://www.na-mic.org/Bug/view.php?id=1999
mod - CMakeLists.txt Diff File

1999-expose-dcmtk-dir-to-built-in-module 1b0fc65f

2012-05-08 14:32:42

jcfr

Details Diff 		ENH: Remember extension catalog login implementing cookies persistence. Fixes 0001946

See http://www.na-mic.org/Bug/view.php?id=1946

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20036 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/CMakeLists.txt Diff File
mod - Base/QTCore/Testing/Cxx/CMakeLists.txt Diff File
add - Base/QTCore/Testing/Cxx/qSlicerPersistentCookieJarTest.cxx Diff File
add - Base/QTCore/qSlicerPersistentCookieJar.cxx Diff File
add - Base/QTCore/qSlicerPersistentCookieJar.h Diff File
mod - Base/QTGUI/qSlicerExtensionsInstallWidget.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module ed3d1362

2012-05-08 14:06:24

benjamin.long

Details Diff 		BUG: QtTesting - Fix the extension .xml when selecting a file to record.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20035 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/qSlicerAppMainWindowCore.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module c0a32a1f

2012-05-07 23:02:19

finetjul

Details Diff 		BUG: vtkMRMLSceneViewNode destructor should clear the internal scene...

and not clear the nodes.
Some nodes (e.g. vtkMRMLDisplayableNode) require to be removed from the
scene correclty in order to be correctly destructed. Indeed,
vtkMRMLDisplayableNode::~vtkMRMLDisplayableNode removes all display node
IDs which require to call on the scene.
RemoveReferencedNodeID() can only work if the nodes have been correctly
cleaned up.
This change has revealed some issues in the scene view node scene
references. A failing test has been created: references().
The problem is that vtkMRMLSceneViewNode doesn't update its references at
the right time. And when it does (UpdateScene), the references are wrong.
See 0001995 for more details.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20034 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeRestoreSceneTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeStoreSceneTest.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File
mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module f6593214

2012-05-07 23:02:14

finetjul

Details Diff 		BUG: Ensure nodes to remove are still valid when Restoring scene

When removing nodes one by one in vtkMRMLSceneViewNode::RestoreScene, it is
possible that the removal of a node removes another node. If that other
node is later removed by RestoreScene it must stay valid (not destructed)
to query if it has already been removed from the scene. In that case, the
node is not removed from the scene.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20033 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDisplayNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx Diff File
mod - Modules/Loadable/Models/Logic/vtkSlicerModelsLogic.h Diff File
mod - Modules/Loadable/Models/Testing/Cxx/CMakeLists.txt Diff File
add - Modules/Loadable/Models/Testing/Cxx/vtkSlicerModelsLogicAutoRemoveTest.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module bd5f97c8

2012-05-07 18:15:12

jcfr

Details Diff 		ENH: Add mechanism allowing to trigger continuous build of extension only after Slicer build is finished. Fixes 0001986

The driver script associated with Slicer create a file BUILD_IN_PROGRESS
located in <Slicer_DIR>, if this file exists, the extensions driver script
skips the build.

See http://www.na-mic.org/Bug/view.php?id=1986

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20032 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerDashboardDriverScript.cmake Diff File
mod - Extensions/CMake/SlicerExtensionsDashboardDriverScript.cmake Diff File

1999-expose-dcmtk-dir-to-built-in-module ad10bf42

2012-05-07 15:21:48

alexy

Details Diff 		BUG: fixed null scene case


git-svn-id: http://svn.slicer.org/Slicer4/trunk@20031 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLViewDisplayableManager.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module 3c89ca46

2012-05-06 21:28:53

finetjul

Details Diff 		ENH: Add failing test in vtkMRMLSceneViewNode

vtkMRMLSceneViewNode::RestoreScene must be fixed to never use the vtkMRMLSceneViewNode::Nodes into the scene but only use copies.
See issue 0001993

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20030 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/CMakeLists.txt Diff File
add - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeRestoreSceneTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeStoreSceneTest.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module fe010c23

2012-05-04 18:14:35

jcfr

Details Diff 		COMP: Allows a debug build of slicer to import pyd modules built in release mode. Fixed 0001747

* This applies to windows build of python

See http://www.na-mic.org/Bug/view.php?id=1747

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20029 3bd1e089-480b-0410-8dfb-8563597acbee
add - SuperBuild/python_distutils_msvc9compiler.py.in Diff File
mod - SuperBuild/python_patch_step_win.cmake.in Diff File

1999-expose-dcmtk-dir-to-built-in-module d7e9d644

2012-05-04 17:58:15

jcfr

Details Diff 		BUG: Associate package name with the date of the last commit. Fixes 0001974

See http://www.na-mic.org/Bug/view.php?id=1974

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20028 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

1999-expose-dcmtk-dir-to-built-in-module 1145bd44

2012-05-04 17:38:36

jcfr

Details Diff 		BUG: In extensions driver script, CTEST_CHECKOUT_COMMAND now supports "path to CMake command" containing spaces

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20027 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerExtensionsDashboardDriverScript.cmake Diff File

1999-expose-dcmtk-dir-to-built-in-module 7b5b1161

2012-05-04 14:13:16

pieper

Details Diff 		ENH: add Vector to Scalar volume converter

Allow users to easily switch convert data loaded as stacks of bmp or
jpg files into scalar volumes for use with the Editor, VolumeRenderer
and other modules

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20026 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/Scripts/CMakeLists.txt Diff File
add - Modules/Scripted/Scripts/VectorToScalarVolume.py Diff File

1999-expose-dcmtk-dir-to-built-in-module c96a4793

2012-05-04 14:05:56

finetjul

Details Diff 		STYLE: Update vtkMRMLScalarVolumeNode::[Get/Set]LabelMap[On/Off]() documentation

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20025 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScalarVolumeNode.h Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.h Diff File

1999-expose-dcmtk-dir-to-built-in-module 17fb7020

2012-05-04 13:57:01

pieper

Details Diff 		ENH: update ModuleWizard documents to include new examples

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20024 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Utilities/Scripts/ModuleWizard.py Diff File

1999-expose-dcmtk-dir-to-built-in-module a29cbf33

2012-05-04 11:50:00

pieper

Details Diff 		BUG: avoid colons in filenames for windows

Explicitly specify the date format for the temp file
since ISODate includes a colon and that is not valid
on windows.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20013 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/qSlicerAppMainWindowCore.cxx Diff File
mod - Base/QTCore/qSlicerSceneBundleIO.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module 3b81eb59

2012-05-04 11:49:58

pieper

Details Diff 		BUG: correctly detect/add .mrb file extension

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20012 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/qSlicerAppMainWindowCore.cxx Diff File

1999-expose-dcmtk-dir-to-built-in-module c469f2df

2012-05-04 07:14:45

pieper

Details Diff 		COMP: fix vtkArchive build on windows

Use conditional offset type since size_t doesn't match
libarchive's offset type on win32 and win64

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20011 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkArchive.cxx Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 52 53 54 55 56 57  Next  Last