Changesets: Slicer

Search Browse Back to Index

1683-launcher-with-output 31025fd3

2012-10-16 11:22:49

jcfr

Details Diff 		COMP: Fix NUMBER_HANDLES macro redefinition error adding "static const int" member

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21197 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation2D.h Diff File

1683-launcher-with-output f1af61b4

2012-10-16 10:54:51

jcfr

Details Diff 		STYLE: Update comment associated with vtkMRMLAbstractDisplayableManager::SetRenderer

This is a follow-up of commit r21186. It explains why "SetAndObserveInteractor"
has to be called after calling "AdditionalInitializeStep".

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21196 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx Diff File

1683-launcher-with-output b777dbf4

2012-10-16 08:27:52

pieper

Details Diff 		BUG: include & in the list of valid characters for PercentEncode

Also update the test to be more helpful in diagnosing.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21195 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/SlicerMRBTest.py Diff File
mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.cxx Diff File

1683-launcher-with-output 2a16829d

2012-10-16 08:27:49

pieper

Details Diff 		BUG: fix boundary case in percent encoding logic

A and 0 were being incorrectly percent encoded.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21194 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.cxx Diff File

1683-launcher-with-output 779a77f1

2012-10-15 18:54:26

sankhesh

Details Diff 		BUG: 2609 Case-insensitive alphabetical insertion of modules in menu

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21193 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerModulesMenu.cxx Diff File

1683-launcher-with-output 1298f087

2012-10-15 18:35:55

jcfr

Details Diff 		COMP: Waiting the support of Java based module is updated. Disable it.

It prevent Slicer from being built on some linux system.

See http://www.na-mic.org/Bug/view.php?id=2633

Fixes 0002633

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21192 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/CMakeLists.txt Diff File

1683-launcher-with-output 9bbd0780

2012-10-15 18:28:52

jcfr

Details Diff 		COMP: Install pyconfig.h required to install distribute in an installed tree

It will fix the following error:

error: invalid Python installation: unable to open /home/jchris/Projects/Slicer4-Superbuild-Debug/Slicer-build/_CPack_Packages/linux-amd64/TGZ/Slicer-4.1.0-2012-10-15-linux-amd64/lib/Python/include/python2.6/pyconfig.h (No such file or directory)
Something went wrong during the installation.

occurring when install distribute applying the following steps:

1) curl -O http://python-distribute.org/distribute_setup.py
2) ./Slicer --launch /usr/bin/python2.6 distribute_setup.py

Note: A different error occurs when "distribute_setup.py" is executed
directly using Slicer executable:

Traceback (most recent call last):
File "<string>", line 1, in <module>
File "setup.py", line 8, in <module>
os.chdir(os.path.dirname(os.path.abspath(__file__)))
NameError: name '__file__' is not defined

This is tracked by issue 0002649

See http://www.na-mic.org/Bug/view.php?id=2636

Fixes 0002636

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21191 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerBlockInstallPython.cmake Diff File

1683-launcher-with-output 2311bdec

2012-10-15 16:23:04

jcfr

Details Diff 		BUG: Check for invalid filepath in GetModuleHomeDirectory

See http://www.na-mic.org/Bug/view.php?id=2641

Fixes 0002461

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21190 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/Testing/vtkSlicerApplicationLogicTest1.cxx Diff File
mod - Base/Logic/vtkSlicerApplicationLogic.cxx Diff File

1683-launcher-with-output e8c24c30

2012-10-15 16:07:57

millerjv

Details Diff 		COMP: whitespace, indentation, quieting the filter

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21189 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/itkGrowCutSegmentationImageFilter.h Diff File
mod - Libs/vtkITK/itkGrowCutSegmentationImageFilter.txx Diff File

1683-launcher-with-output 51f04f1b

2012-10-15 15:58:22

jcfr

Details Diff 		COMP: Ensure extension metadata including "=" are properly handled

Note that this is a sub-optimal solution, ideally parameter to the ctest
script should be passed either configuring a file and passing the path
to that file or using the -D syntax supported in recent version of
ctest (>= 2.8.9).

See http://www.na-mic.org/Bug/view.php?id=2643

Fixes 0002643

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21188 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake Diff File
mod - Extensions/CMake/SlicerBlockUploadExtension.cmake Diff File

1683-launcher-with-output 47277174

2012-10-15 15:20:14

millerjv

Details Diff 		BUG: Shift-MouseMove with Crosshairs (cross-referencing) would blink crosshair

When using Crosshair in cross-referencing mode (as opposed to navigator mode) and
using Shift-MouseMove to jump the slices, the crosshair on the other slices would
sometimes disappear or blink.

This is caused by the crosshair being turned off when it is not on the current slice.

The crosshair was not always on the current slice because the CrosshairDisplayableManager
could receive the MouseMove event BEFORE the InteractorStyle (which handles the jump slice
behavior). Hence the crosshair was built for one slice but since the slicenode had not been
updated, it wasn't on the slice being display (yet) and was turned off.

Set the priority of the MouseMoveEvent to -1 for the CrosshairDisplayableManager so that
the InteractorStyle receives the event first, which allows the slice to jump to the proper
RAS before the crosshair is drawn.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21187 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLCrosshairDisplayableManager.cxx Diff File

1683-launcher-with-output abe717ed

2012-10-15 12:04:59

millerjv

Details Diff 		BUG: r21160 fixed crosshairs but broke 3D viewer. r21165 fixed 3D viewer but brok crosshairs. This patch fixes both.

Moved the code introduced in r21165 down a few lines.

If the interactor is cached earlier, then the events registered in
AdditionalInitializationStep() don't get observed (which the Crosshairs depend
on).

I don't understand why moving the lines fixes the issue. In both r21165 and
in this patch, the events added in AdditionalInitializeStep() are only cached
locally and are not actually assigned to the interactor at that time.

But there must be some observer side effect that by observing the interactor,
another event is triggered, which causes the events/observers to be lost.
Perhaps another interactor gets puts in place? Or not in place?

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21186 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx Diff File

1683-launcher-with-output 1585de50

2012-10-15 11:27:08

fedorov

Details Diff 		ENH: the test is simplified: the crash happens trying to quit Slicer after initializing the node selectors in the first step of the wizard (see issue 0002590)


git-svn-id: http://svn.slicer.org/Slicer4/trunk@21185 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/slicerCloseCrashBug2590.py Diff File

1683-launcher-with-output 6b20f676

2012-10-15 09:33:39

pieper

Details Diff 		BUG: fix for 0002605 - special characters in data bundle filenames

Since data bundles must sometimes make filenames on-the-fly
based on the node names, add a step to ensure filenames
do not contain special characters (like colon or slash).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21184 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/SlicerMRBTest.py Diff File
mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLApplicationLogic.h Diff File

1683-launcher-with-output 34a25034

2012-10-15 00:27:21

finetjul

Details Diff 		COMP: Annotations displayable manager depends on annotation logic

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21183 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/CMakeLists.txt Diff File

1683-launcher-with-output 0b03225e

2012-10-14 18:36:38

fedorov

Details Diff 		BUG: update the code to use the new ROI visibility API


git-svn-id: http://svn.slicer.org/Slicer4/trunk@21182 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_ChangeTrackerPy.cmake Diff File

1683-launcher-with-output 02e92b72

2012-10-14 13:11:05

finetjul

Details Diff 		ENH: Expose Annotations displayable managers to other modules

By moving the displayable managers into their own library,
it is then possible for modules to use and link to it.
The Annotations VTKWidgets had to be moved as well.

Issue 0002606

Conflicts:
Modules/Loadable/Annotations/CMakeLists.txt

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21181 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/CMakeLists.txt Diff File
add - Modules/Loadable/Annotations/MRMLDisplayableManager/CMakeLists.txt Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationAngleDisplayableManager.h Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationBidimensionalDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationBidimensionalDisplayableManager.h Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationClickCounter.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationClickCounter.h Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationDisplayableManager.h Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationDisplayableManagerHelper.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationDisplayableManagerHelper.h Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationFiducialDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationFiducialDisplayableManager.h Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationROIDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationROIDisplayableManager.h Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationRulerDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationRulerDisplayableManager.h Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationSplineDisplayableManager.h Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationStickyDisplayableManager.h Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationTextDisplayableManager.cxx Diff File
mod - Modules/Loadable/Annotations/MRMLDisplayableManager/vtkMRMLAnnotationTextDisplayableManager.h Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationDisplayableManagerTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationDisplayableManagerTest2.cxx Diff File
add - Modules/Loadable/Annotations/VTKWidgets/CMakeLists.txt Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationBidimensionalRepresentation.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationBidimensionalRepresentation.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationBidimensionalWidget.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationBidimensionalWidget.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationGlyphSource2D.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationGlyphSource2D.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation2D.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIRepresentation2D.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIWidget.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIWidget.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIWidget2D.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationROIWidget2D.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationRulerRepresentation.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationRulerRepresentation.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationRulerRepresentation3D.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationRulerRepresentation3D.h Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationRulerWidget.cxx Diff File
mod - Modules/Loadable/Annotations/VTKWidgets/vtkAnnotationRulerWidget.h Diff File

1683-launcher-with-output e1e9af67

2012-10-14 13:10:27

finetjul

Details Diff 		COMP: Fix compilation warnings in vtkMRML

Unused variable for vtkMRMLModelSliceDisplayableManagerTest
Automatic cast for vtkMRMLFreeSurferModelOverlayStorageNode

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21180 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLFreeSurferModelOverlayStorageNode.cxx Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLModelSliceDisplayableManagerTest.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLThreeDReformatDisplayableManager.cxx Diff File

1683-launcher-with-output ba60678d

2012-10-14 13:10:15

finetjul

Details Diff 		ENH: Add qMRMLAnnotationTreeView into Qt designer plugin

It can then be used when designing your module with Qt Designer

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21179 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/Widgets/DesignerPlugins/CMakeLists.txt Diff File
add - Modules/Loadable/Annotations/Widgets/DesignerPlugins/qMRMLAnnotationTreeViewPlugin.cxx Diff File
add - Modules/Loadable/Annotations/Widgets/DesignerPlugins/qMRMLAnnotationTreeViewPlugin.h Diff File
mod - Modules/Loadable/Annotations/Widgets/DesignerPlugins/qSlicerAnnotationModuleWidgetsPlugin.h Diff File

1683-launcher-with-output e6f23615

2012-10-14 12:46:52

pieper

Details Diff 		ENH: re-enable all atlas tests for the general testing case

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21178 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/AtlasTests.py Diff File

1683-launcher-with-output 06af7339

2012-10-14 12:46:49

pieper

Details Diff 		BUG: avoid calling non-test method during unittest

The python unittest framework considers any test* method to be
a test and calls it with no arguments. By renaming the helper
method to be perform_ rather than test_ we let the test
succeed.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21177 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/AtlasTests.py Diff File

1683-launcher-with-output f8ea709b

2012-10-13 16:37:48

pieper

Details Diff 		BUG: fix scene view crashes in 2514

The layout node in the layout logic was not cleared when a scene
was restored, which meant that it was out of date with respect
to the current scene and led to a crash. Now we explicitly unreference
it when a scene restore begins and then re-access it after
the scene has been restored.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21176 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Logic/vtkMRMLLayoutLogic.cxx Diff File
mod - Libs/MRML/Logic/vtkMRMLLayoutLogic.h Diff File

1683-launcher-with-output 5ba3f39d

2012-10-13 16:32:24

alexy

Details Diff 		ENH: reduced number of Modified events in Interactive Tractography module

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21175 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLTransformableNode.cxx Diff File
mod - Modules/Loadable/TractographyDisplay/MRML/vtkMRMLFiberBundleNode.cxx Diff File
mod - Modules/Loadable/TractographyFiducialSeeding/Logic/vtkSlicerTractographyFiducialSeedingLogic.cxx Diff File

1683-launcher-with-output 73f9a47e

2012-10-13 15:30:54

pieper

Details Diff 		BUG: fix for issue 0002514

Make sure the widgets exist before updating the layout.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21174 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLLayoutManager.cxx Diff File

1683-launcher-with-output e2693f82

2012-10-13 10:03:09

pieper

Details Diff 		ENH: provide feedback during the editor test

Make sure qt has had time to process events before teardown of the
userinterface - otherwise pythonqt may hold references to QStandardItem
instances (and perhaps other objects) that Qt has destroyed.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21173 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/Testing/ThresholdThreadingTest.py Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 51 52 53 54 55 56 57  Next  Last