View Issue Details

IDProjectCategoryView StatusLast Update
0001986Slicer4Core: Extensionspublic2017-06-07 23:27
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.1.1Fixed in VersionSlicer 4.2.0 
Summary0001986: Mechanism allowing to trigger continuous build of extension after Slicer build is finished
Description

The build system allowing to build extension in a continuous fashion checks for
two things:

  • update associated with ExtensionsIndex git repository
  • update associated with <Slicer_DIR>/vtkSlicerVersionConfigure.h

Currently in case a new commit associated with Slicer is pushed, the build of extension will happen after slicer is configure and before it finished to build.

This will cause problem.

Two solutions:

1) Always build the extension within a build of Slicer without decoupling Slicer and extensions build directories. Doing so is easier but implies that Slicer will have to be continuously build both as a single project and also as part of the extensions build process.

2) Setup a mechanism allowing to know if the slicer build is in progress or if it is terminated. Doing so is a little more complex but has the advantage of build Slicer only once.

TagsNo tags attached.

Activities

jcfr

jcfr

2012-05-04 14:29

administrator   ~0004173

Last edited: 2012-05-04 14:29

Will be working to implement solution 0000002

jcfr

jcfr

2012-05-07 14:16

administrator   ~0004189

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=20032

jcfr

jcfr

2012-05-08 22:21

administrator   ~0004213

Dashboard confirms that the issue has been solved. See http://slicer.cdash.org/index.php?project=Slicer4&amp;date=2012-05-08#Extensions-Continuous

jcfr

jcfr

2017-06-07 23:27

administrator   ~0014554

Fix committed to 1999-expose-dcmtk-dir-to-built-in-module branch.

Related Changesets

Slicer: 1999-expose-dcmtk-dir-to-built-in-module bd5f97c8

2012-05-07 18:15:12

jcfr

Details Diff
ENH: Add mechanism allowing to trigger continuous build of extension only after Slicer build is finished. Fixes 0001986

The driver script associated with Slicer create a file BUILD_IN_PROGRESS
located in <Slicer_DIR>, if this file exists, the extensions driver script
skips the build.

See http://www.na-mic.org/Bug/view.php?id=1986

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20032 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerDashboardDriverScript.cmake Diff File
mod - Extensions/CMake/SlicerExtensionsDashboardDriverScript.cmake Diff File

Issue History

Date Modified Username Field Change
2012-05-04 14:27 jcfr New Issue
2012-05-04 14:27 jcfr Status new => assigned
2012-05-04 14:27 jcfr Assigned To => jcfr
2012-05-04 14:29 jcfr Note Added: 0004173
2012-05-04 14:29 jcfr Note Edited: 0004173
2012-05-07 14:16 jcfr Note Added: 0004189
2012-05-07 14:16 jcfr Status assigned => resolved
2012-05-07 14:16 jcfr Fixed in Version => Slicer 4.x AHM Summer 2012
2012-05-07 14:16 jcfr Resolution open => fixed
2012-05-08 15:02 jcfr Target Version => Slicer 4.1.1
2012-05-08 22:21 jcfr Note Added: 0004213
2012-05-08 22:21 jcfr Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 1999-expose-dcmtk-dir-to-built-in-module bd5f97c8
2017-06-07 23:27 jcfr Note Added: 0014554