View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001999 | Slicer4 | Core: Building (CMake, Superbuild) | public | 2012-05-08 14:17 | 2017-06-07 23:27 |
Reporter | kentwilliams | Assigned To | jcfr | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Slicer 4.2.0 | Fixed in Version | Slicer 4.2.0 | ||
Summary | 0001999: Expose DCMTK_DIR to Slicer built-in module | ||||
Description | It should be possible for build-in module to simply do find_package(DCMTK) See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2012/008677.html | ||||
Tags | No tags attached. | ||||
Kent, Would be great if you could check if the following topic fix the problem. See https://github.com/jcfr/Slicer/compare/1999-expose-dcmtk-dir-to-built-in-module From the mailing list - See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2012/008679.html: After checkout out branch [1a] (you can have an idea of the change looking find_package(DCMTK REQUIRED) Indeed, using CMake 2.8.8 the REQUIRED keyword should be properly Add a comment on issue [3] with your feedback. Thanks [1a] |
|
Can't this be closed now? |
|
Assuming Slicer has been built with DICOM support ... Calling "find_package(Slicer)", then "include(${Slicer_USE_FILE})" should be sufficient to make DCMTK CMake module available. That said, nothing would prevent you from calling find_package(DCMTK) again since .. DCMTK_DIR is defined within SlicerConfig.cmake See https://github.com/Slicer/Slicer/blob/master/CMake/SlicerConfig.cmake.in#L223 |
|
Closing resolved issues that have not been updated in more than 3 months |
|
Fix committed to 1999-expose-dcmtk-dir-to-built-in-module branch. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-05-08 14:17 | jcfr | New Issue | |
2012-05-08 14:17 | jcfr | Status | new => assigned |
2012-05-08 14:17 | jcfr | Assigned To | => jcfr |
2012-05-08 14:27 | jcfr | Reporter | jcfr => kentwilliams |
2012-05-09 10:11 | jcfr | Target Version | => Slicer 4.2.0 AHM Summer 2012 |
2012-05-09 10:13 | jcfr | Note Added: 0004258 | |
2012-05-09 10:13 | jcfr | Status | assigned => feedback |
2012-07-31 12:48 | pieper | Note Added: 0005474 | |
2012-08-22 11:26 | jcfr | Note Added: 0005716 | |
2012-08-22 11:26 | jcfr | Status | feedback => resolved |
2012-08-22 11:26 | jcfr | Fixed in Version | => Slicer 4.2.0 - Feature freeze Sept 1st 2012 |
2012-08-22 11:26 | jcfr | Resolution | open => fixed |
2014-03-06 04:50 | jcfr | Note Added: 0010709 | |
2014-03-06 04:52 | jcfr | Status | resolved => closed |
2017-06-07 23:27 | jcfr | Changeset attached | => Slicer 1999-expose-dcmtk-dir-to-built-in-module e1e149b3 |
2017-06-07 23:27 | jcfr | Note Added: 0014552 |