View Issue Details

IDProjectCategoryView StatusLast Update
0001999Slicer4Core: Building (CMake, Superbuild)public2017-06-07 23:27
Reporterkentwilliams Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0001999: Expose DCMTK_DIR to Slicer built-in module
Description

It should be possible for build-in module to simply do find_package(DCMTK)

See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2012/008677.html

TagsNo tags attached.

Activities

jcfr

jcfr

2012-05-09 10:13

administrator   ~0004258

Kent, Would be great if you could check if the following topic fix the problem. See https://github.com/jcfr/Slicer/compare/1999-expose-dcmtk-dir-to-built-in-module

From the mailing list - See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2012/008679.html:

After checkout out branch [1a] (you can have an idea of the change looking
at [1b]), I suggest you to simply use:

find_package(DCMTK REQUIRED)

Indeed, using CMake 2.8.8 the REQUIRED keyword should be properly
considered. See [2]

Add a comment on issue [3] with your feedback.

Thanks
Jc

[1a]
https://github.com/jcfr/Slicer/tree/1999-expose-dcmtk-dir-to-built-in-module
[1b]
https://github.com/jcfr/Slicer/compare/1999-expose-dcmtk-dir-to-built-in-module
[2] http://cmake.org/gitweb?p=cmake.git;a=commit;h=c91a54d
[3] http://www.na-mic.org/Bug/view.php?id=1999

pieper

pieper

2012-07-31 12:48

administrator   ~0005474

Can't this be closed now?

jcfr

jcfr

2012-08-22 11:26

administrator   ~0005716

Assuming Slicer has been built with DICOM support ...

Calling "find_package(Slicer)", then "include(${Slicer_USE_FILE})" should be sufficient to make DCMTK CMake module available.

That said, nothing would prevent you from calling find_package(DCMTK) again since .. DCMTK_DIR is defined within SlicerConfig.cmake

See https://github.com/Slicer/Slicer/blob/master/CMake/SlicerConfig.cmake.in#L223
and https://github.com/Slicer/Slicer/blob/master/CMake/SlicerGenerateSlicerConfig.cmake#L100

jcfr

jcfr

2014-03-06 04:50

administrator   ~0010709

Closing resolved issues that have not been updated in more than 3 months

jcfr

jcfr

2017-06-07 23:27

administrator   ~0014552

Fix committed to 1999-expose-dcmtk-dir-to-built-in-module branch.

Related Changesets

Slicer: 1999-expose-dcmtk-dir-to-built-in-module e1e149b3

2012-05-08 18:18:00

jcfr

Details Diff
BUG: Expose DCMTK_DIR to built-in slicer module. Fixes 0001999

See http://www.na-mic.org/Bug/view.php?id=1999
mod - CMakeLists.txt Diff File

Issue History

Date Modified Username Field Change
2012-05-08 14:17 jcfr New Issue
2012-05-08 14:17 jcfr Status new => assigned
2012-05-08 14:17 jcfr Assigned To => jcfr
2012-05-08 14:27 jcfr Reporter jcfr => kentwilliams
2012-05-09 10:11 jcfr Target Version => Slicer 4.2.0 AHM Summer 2012
2012-05-09 10:13 jcfr Note Added: 0004258
2012-05-09 10:13 jcfr Status assigned => feedback
2012-07-31 12:48 pieper Note Added: 0005474
2012-08-22 11:26 jcfr Note Added: 0005716
2012-08-22 11:26 jcfr Status feedback => resolved
2012-08-22 11:26 jcfr Fixed in Version => Slicer 4.2.0 - Feature freeze Sept 1st 2012
2012-08-22 11:26 jcfr Resolution open => fixed
2014-03-06 04:50 jcfr Note Added: 0010709
2014-03-06 04:52 jcfr Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 1999-expose-dcmtk-dir-to-built-in-module e1e149b3
2017-06-07 23:27 jcfr Note Added: 0014552