View Issue Details

IDProjectCategoryView StatusLast Update
0001747Slicer4Core: Building (CMake, Superbuild)public2017-06-07 23:27
Reporterpieper Assigned Tojcfr  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0001747: windows build/run issues as of svn 19350
Description

I tried a fresh build with visual studio 2008 express using all the prerequisites listed on our build page. (win32 build in debug mode).

Everything built except the MultiVolumeExplore, which gave the build error listed below.

At run time, I get the runtime error shown in the attached image. This may be an independent issue but it occurs during the mutlivolume load.

The machine in question is an amazon virtual instance so I can give access to anyone who needs to use it for debugging.

I'm assigning this to Andrey, but perhaps he'll need to work with Jc on it.

Steps To Reproduce

The machine in question is an amazon virtual instance so I can give access to anyone who needs to use it for debugging.

Additional Information

1>------ Build started: Project: vtkSlicerMultiVolumeExplorerModuleMRML, Configuration: Debug Win32 ------
1>Linking...
1>LINK : fatal error LNK1104: cannot open file 'z.lib'
1>Build log was saved at "file://d:\pieper\Slicer-superbuild\Slicer-build\Modules\Loadable\MultiVolumeExplorer\MRML\vtkSlicerMultiVolumeExplorerModuleMRML.dir\Debug\BuildLog.htm"
1>vtkSlicerMultiVolumeExplorerModuleMRML - 1 error(s), 0 warning(s)

TagsNo tags attached.

Relationships

parent of 0001868 closedjcfr crash on exit and other issues 

Activities

2012-02-23 05:16

 

fedorov

fedorov

2012-02-23 06:08

developer   ~0003703

I will look at it later today, using Steve's amazon machine.

fedorov

fedorov

2012-02-23 13:01

developer   ~0003707

Library issue is fixed in this commit: (tested by Steve on Windows 2008)

http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=19354

The issue of vtk.numpy_support is still there, but it's outside my domain. From Steve's explanation, hopefully it will not cause issues on Windows release build.

pieper

pieper

2012-02-27 02:45

administrator   ~0003731

The issue with numpy on windows debug builds still exists so I'm switching this over to Jc.

jcfr

jcfr

2012-04-02 07:56

administrator   ~0003952

From Jc Email - March 27:

It could be a Debug vs Release issue specific to numpy.

What happen if you do the following:

./Slicer --disable-cli-modules --disable-loadable-modules --disable-scripted-loadable-modules --no-main-window --show-python-interactor

Then:
import numpy.core.numeric
numpy.core.numeric.multiarray.file

The last command should something similar to:
'C:\D\N\Slicer-build-0\python-build\lib\site-packages\numpy\core\numeric\multiarray.pyd'

I did the test on a Release build of Slicer build on either 32 or 64bit and it works as expected.

Using the method described here, it should provide you with an easy mechanism to track down the issue.

From a regular "cmd.exe" terminal, you could also run the following test:

ctest -C Debug -R SlicerPythonSimpleNUMPYTest -V

or

ctest -C Release -R SlicerPythonSimpleNUMPYTest -V

Hth
Jc

See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2012/008170.html

jcfr

jcfr

2012-04-02 07:57

administrator   ~0003953

From Jc email - March 27:

Hi Folks,

With the help of Daniel and Steve :), it resumes the problem is probably related to the fact manifest associated with the pyd module are not properly managed.

The following topic [1] contains the required change.

To apply locally the change in your source tree, you have two options:

1) If you are using git-svn:
cd Slicer
git stash # In case you have local changes
git remote add jcfr git://github.com/jcfr/Slicer.git
git checkout -b patch-python-msvc9compiler jcfr/patch-python-msvc9compiler

2) if you are using SVN:
Download the patch available here [2]
Apply it using for example tortoiseSVN

In both case, before configuring and rebuilding, make sure to delete from Slicer-Superbuild:

  • NUMPY*
  • python*
  • CLAPACK*
  • tcl*

Let us know how it goes, if you are able to successfully:
import numpy.core.numeric
numpy.core.numeric.multiarray

I will then integrate the change to master.

Hth
Jc

[1] https://github.com/jcfr/Slicer/compare/patch-python-msvc9compiler
[2] http://lcorneliussen.de/utils/git-svn/github.com/jcfr/Slicer/tree/patch-python-msvc9compiler

See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2012/008173.html

jcfr

jcfr

2012-04-02 08:01

administrator   ~0003954

Steve> When you have chance, you could try the solution described in the the following note: http://na-mic.org/Mantis/view.php?id=1747#c3953

pieper

pieper

2012-04-26 09:49

administrator   ~0004088

I did a rebuild of the indicated package after merting jcfrSlicer/patch-python-msvc9compiler and was able to import numpy with no problem :) Let's merge this into the trunk. Thanks!

jcfr

jcfr

2012-04-26 12:06

administrator   ~0004089

Last edited: 2012-04-26 12:07

Extra. Thanks for checking :) ((also thanks github))

jcfr

jcfr

2012-05-04 14:15

administrator   ~0004172

Integrated to Slicer trunk - See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20029

jcfr

jcfr

2012-07-27 15:36

administrator   ~0005341

Dear issue reporter,

Good news :) Slicer developers SOLVED the problem you reported - YOU now need to VERIFY and CLOSE this issue.

jcfr

jcfr

2017-06-07 23:27

administrator   ~0014555

Fix committed to 1999-expose-dcmtk-dir-to-built-in-module branch.

Related Changesets

Slicer: 1999-expose-dcmtk-dir-to-built-in-module fe010c23

2012-05-04 18:14:35

jcfr

Details Diff
COMP: Allows a debug build of slicer to import pyd modules built in release mode. Fixed 0001747

* This applies to windows build of python

See http://www.na-mic.org/Bug/view.php?id=1747

git-svn-id: http://svn.slicer.org/Slicer4/trunk@20029 3bd1e089-480b-0410-8dfb-8563597acbee
add - SuperBuild/python_distutils_msvc9compiler.py.in Diff File
mod - SuperBuild/python_patch_step_win.cmake.in Diff File

Issue History

Date Modified Username Field Change
2012-02-23 05:16 pieper New Issue
2012-02-23 05:16 pieper Status new => assigned
2012-02-23 05:16 pieper Assigned To => fedorov
2012-02-23 05:16 pieper File Added: rdesktop - ec2-50-19-196-139.compute-1.amazonaws.com_186.png
2012-02-23 06:08 fedorov Note Added: 0003703
2012-02-23 06:08 fedorov Status assigned => acknowledged
2012-02-23 13:01 fedorov Note Added: 0003707
2012-02-23 13:01 fedorov Status acknowledged => feedback
2012-02-27 02:45 pieper Note Added: 0003731
2012-02-27 02:45 pieper Assigned To fedorov => jcfr
2012-02-27 02:45 pieper Status feedback => assigned
2012-02-27 02:45 pieper Steps to Reproduce Updated
2012-02-27 02:45 pieper Additional Information Updated
2012-04-02 07:56 jcfr Note Added: 0003952
2012-04-02 07:57 jcfr Note Added: 0003953
2012-04-02 08:01 jcfr Note Added: 0003954
2012-04-02 08:01 jcfr Assigned To jcfr => pieper
2012-04-02 08:01 jcfr Status assigned => feedback
2012-04-06 10:09 pieper Relationship added parent of 0001868
2012-04-26 09:49 pieper Note Added: 0004088
2012-04-26 09:49 pieper Status feedback => resolved
2012-04-26 12:06 jcfr Note Added: 0004089
2012-04-26 12:07 jcfr Note Edited: 0004089
2012-05-04 14:15 jcfr Note Added: 0004172
2012-07-27 15:36 jcfr Note Added: 0005341
2012-07-28 10:17 pieper Status resolved => closed
2012-07-28 10:17 pieper Resolution open => fixed
2012-08-21 10:01 jcfr Fixed in Version => Slicer 4.2.0 - Feature freeze Sept 1st 2012
2012-08-21 10:01 jcfr Target Version => Slicer 4.2.0 - Feature freeze Sept 1st 2012
2017-06-07 23:27 jcfr Changeset attached => Slicer 1999-expose-dcmtk-dir-to-built-in-module fe010c23
2017-06-07 23:27 jcfr Note Added: 0014555
2017-06-07 23:27 jcfr Assigned To pieper => jcfr