Changesets: Slicer

Search Browse Back to Index

2145-support-for-installing-extension-from-file 623f3827

2013-07-05 11:32:50

pieper

Details Diff 		BUG: 0002990 use conventional layout if saved layout not available

When a module or extension creates a custom layout the number (say, 100)
is saved in the settings file and slicer tries to restore that
on the next start up. However these layouts can be transient creations
and won't be available at startup. This patch improves handling of
that case - rather than printing a warning and showing a blank screen, the
program now starts with the regular layout which leads to less
user confusion.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22142 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLLayoutManager.cxx Diff File

2145-support-for-installing-extension-from-file 606e0714

2013-07-04 18:22:43

pieper

Details Diff 		ENH: put a space between the number and suffix in sample data status

e.g. use 411.0 bytes instead of 411.0bytes. It just looks better.

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22141 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/SampleData/SampleData.py Diff File

2145-support-for-installing-extension-from-file b67da503

2013-07-04 18:22:41

pieper

Details Diff 		BUG: fixed issue in SampleData's logging.

Before, when downloaded file's size was larger than the transfer block size, the logger would report being >100% done. This has been fixed.

From: Luis G. Torres <lgtorres42@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22140 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/SampleData/SampleData.py Diff File

2145-support-for-installing-extension-from-file 3c9e6466

2013-07-04 18:20:40

finetjul

Details Diff 		ENH: Disable scrolling everywhere there is an active scrollarea

Don't do it only for comboboxes.
Closes 0001820, 0001462

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22139 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Main.cxx Diff File
mod - Base/QTGUI/qSlicerSaveDataDialog.cxx Diff File
mod - Base/QTGUI/qSlicerStyle.cxx Diff File
mod - Base/QTGUI/qSlicerStyle.h Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.cxx Diff File
mod - Modules/Loadable/Data/Resources/UI/qSlicerDataModuleWidget.ui Diff File

2145-support-for-installing-extension-from-file f017f3a0

2013-07-04 17:32:11

pieper

Details Diff 		BUG: 0002749 fix undo/redo for change label effect

The logic superclass handles undo/redo, but the instance of the undoRedo
needs to be explicitly set.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22138 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/ChangeLabelEffect.py Diff File

2145-support-for-installing-extension-from-file 46928332

2013-07-04 15:48:16

finetjul

Details Diff 		ENH: Redesign foreground and labelmap opacity slider layout

Closes r1821, r1563

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22137 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Resources/UI/qMRMLSliceControllerWidget.ui Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget_p.h Diff File

2145-support-for-installing-extension-from-file 405ece58

2013-07-04 10:51:17

naucoin

Details Diff 		ENH: add the ability to add custom actions and trigger them

Added a list of actions that are added after the default none,
add, remove, rename actions that the combo box supplies. When
the new action is selected, it is triggered so a module can
add a connection to listen for the triggered signal on the action
and activate a local slot.
Added a test to exercise trying to add duplicate or conflicting
actions.
Use the foreach construct to iterate over the user actions.
From development on new Markups module.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22136 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/CMakeLists.txt Diff File
add - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest8.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.h Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox_p.h Diff File

2145-support-for-installing-extension-from-file 55d68c9a

2013-07-04 09:22:07

finetjul

Details Diff 		ENH: Don't scroll comboboxes that are inside a scroll area

Using the mouse in a scroll area could inadvertently change combobox
current index (on mouse over).
For conveniency, all the qMRMLNodeComboBoxes won't scroll in scrollarea by
default.
Closes 0001820, 0001462

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22135 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerSaveDataDialog.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLNodeComboBox.cxx Diff File
mod - Modules/Loadable/Data/Resources/UI/qSlicerDataModuleWidget.ui Diff File
mod - SuperBuild/External_CTK.cmake Diff File

2145-support-for-installing-extension-from-file 1d11ece1

2013-07-04 09:22:04

finetjul

Details Diff 		BUG: Make SCM test more robust

If the variable is empty, there is a CMake error that it can't compare
strings.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22134 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtensions.cmake Diff File

2145-support-for-installing-extension-from-file 73a3041e

2013-07-03 18:12:40

jcfr

Details Diff 		COMP: Adding option for SimpleITK as a shared library

SimpleITK has large internal libraries, which take an extremely long
time to link on windows when they are static. Creating shared
SimpleITK internal libraries can reduce linking time. Also the size
of the debug libraries are monstrous. Using shared libraries for
debug, reduce disc requirements, and can improve linking
times. However, these shared libraries take longer to load than the
monolithic target from static libraries.

This commits updates the build system:
1) Propagate SimpleITK_DIR into Slicer config.
2) Add SimpleITK lib path to runtime library path for build.
3) Add SimpleITK to be installed as a cmake project.
4) Add CMake variable Slicer_USE_SimpleITK_SHARED to turn on SimpleITK
as a shared library.

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22133 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerBlockCTKAppLauncherSettings.cmake Diff File
mod - CMake/SlicerBlockInstallCMakeProjects.cmake Diff File
mod - CMake/SlicerConfig.cmake.in Diff File
mod - CMake/SlicerGenerateSlicerConfig.cmake Diff File
mod - CMakeLists.txt Diff File
mod - SuperBuild.cmake Diff File
mod - SuperBuild/External_SimpleITK.cmake Diff File

2145-support-for-installing-extension-from-file b6232a92

2013-07-03 17:43:46

jcfr

Details Diff 		STYLE: ITK_EXPORT had no use

The defintion of ITK_EXPORT was empty in all cases

This has been identified since 2003 as not being necessary
for builds. see https://issues.itk.org/jira/browse/ITK-3110

On Windows builds that need exports, they must
be unique per library, and that is not controlled by CMake now.

The PrintSelfCheck.tcl was the only remenant need for
This patch, and that is no longer being used, so that
file as been removed.

The ITK_EXPORT define was set to nothing and had no
known remaining purpose. It was removed to make the
over all code easier to understand. There was,
understandably, a bit of confusion about the
need for this being pervasive in the code.

It is currently backwards compatible to have
this in code, but at some future point it will
be removed.

From: Hans Johnson <hans-johnson@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22132 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/itkConstrainedValueMultiplicationImageFilter.h Diff File
mod - Libs/vtkITK/itkGrowCutSegmentationImageFilter.h Diff File
mod - Libs/vtkITK/itkLevelTracingImageFilter.h Diff File
mod - Libs/vtkITK/itkLevelTracingImageFilter.txx Diff File
mod - Libs/vtkITK/itkNewOtsuThresholdImageCalculator.h Diff File
mod - Libs/vtkITK/itkNewOtsuThresholdImageFilter.h Diff File
mod - Modules/CLI/DWIJointRicianLMMSEFilter/itkComputeRestrictedHistogram.h Diff File
mod - Modules/CLI/DWIJointRicianLMMSEFilter/itkLMMSEVectorImageFilter.h Diff File
mod - Modules/CLI/DWIJointRicianLMMSEFilter/itkOtsuStatistics.h Diff File
mod - Modules/CLI/DWIJointRicianLMMSEFilter/itkOtsuThreshold.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkComputeRestrictedHistogram.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkComputeStatisticsWherePositiveFilter.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkExtractVolumeFilter.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkLMMSEVectorImageFilter.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkLMMSEVectorImageFilterStep.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkMaskedMeanImageFilter.h Diff File
mod - Modules/CLI/DWIRicianLMMSEFilter/itkVectorImageCastFilter.h Diff File
mod - Modules/CLI/DWIUnbiasedNonLocalMeansFilter/itkComputeRestrictedHistogram.h Diff File
mod - Modules/CLI/DWIUnbiasedNonLocalMeansFilter/itkOtsuStatistics.h Diff File
mod - Modules/CLI/DWIUnbiasedNonLocalMeansFilter/itkOtsuThreshold.h Diff File
mod - Modules/CLI/DWIUnbiasedNonLocalMeansFilter/itkUNLMFilter.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarity3DTransform.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkAnisotropicSimilarityLandmarkBasedTransformInitializer.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageRegionMomentsCalculator.h Diff File
mod - Modules/CLI/ExpertAutomatedRegistration/ITKRegistrationHelper/itkImageRegionMomentsCalculator.txx Diff File
mod - Modules/CLI/MRIBiasFieldCorrection/itkBSplineControlPointImageFilter.h Diff File
mod - Modules/CLI/MRIBiasFieldCorrection/itkImageToVTKImageFilter.h Diff File
mod - Modules/CLI/MRIBiasFieldCorrection/itkN3MRIBiasFieldCorrectionImageFilter.h Diff File
mod - Modules/CLI/MRIBiasFieldCorrection/itkN4MRIBiasFieldCorrectionImageFilter.h Diff File
mod - Modules/CLI/MRIBiasFieldCorrection/itkVTKImageToImageFilter.h Diff File
mod - Modules/CLI/MultiResolutionAffineRegistration/itkDecomposedAffine3DTransform.h Diff File
mod - Modules/CLI/MultiResolutionAffineRegistration/itkEulerAnisotropicSimilarity3DTransform.h Diff File
mod - Modules/CLI/MultiResolutionAffineRegistration/itkEulerSimilarity3DTransform.h Diff File
mod - Modules/CLI/MultiResolutionAffineRegistration/itkFixedRotationSimilarity3DTransform.h Diff File
mod - Modules/CLI/MultiResolutionAffineRegistration/itkSlicerBoxSpatialObject.h Diff File
mod - Modules/CLI/N4ITKBiasFieldCorrection/SlicerITKv3BSplineControlPointImageFilter.h Diff File
mod - Modules/CLI/N4ITKBiasFieldCorrection/SlicerITKv3N4MRIBiasFieldCorrectionImageFilter.h Diff File
mod - Modules/CLI/ResampleDTIVolume/Testing/itkDifferenceDiffusionTensor3DImageFilter.h Diff File
mod - Modules/CLI/ResampleDTIVolume/dtiprocessFiles/itkHFieldToDeformationFieldImageFilter.h Diff File

2145-support-for-installing-extension-from-file 08723a92

2013-07-02 21:14:26

alexy

Details Diff 		BUG: 3203. Fixed no pass label specified case. XML change is a workaround the bug 3202.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22131 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/FiberBundleLabelSelect/FiberBundleLabelSelect.cxx Diff File
mod - Modules/CLI/FiberBundleLabelSelect/FiberBundleLabelSelect.xml Diff File

2145-support-for-installing-extension-from-file bc782fd6

2013-07-02 14:40:10

jcfr

Details Diff 		COMP: Ensure NoExtensionSupport component can be specified

Before this commit, the UploadOnly targets were added also if extension
support was explicitly disabled.

This commit ensure that in any given extension, extension support can now
be disabled by either specifying the "NoExtensionSupport" component or by
setting the variable Slicer_DONT_USE_EXTENSION
(or Slicer_USE_NOEXTENSIONSUPPORT) to True.

The message indicating that extension support is disabled has been updated
to be more explicit.

Co-authored-by: Julien Finet <julien.finet@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22130 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerExtensionCPack.cmake Diff File
mod - CMake/UseSlicer.cmake.in Diff File

2145-support-for-installing-extension-from-file 4035fabb

2013-07-02 13:13:42

jcfr

Details Diff 		COMP: Compare Slicer bitness against extension bitness

On platform (i.e. Windows with Visual Studio) where it is possible to use
either a 32 or 64 bits generator, it is important to compare bitness
of Slicer project against project depending on Slicer (i.e. extension)
to ensure there are no mismatch.

The check could be disabled setting the variable Slicer_SKIP_CMAKE_SIZEOF_VOID_P_CHECK
to False before calling "find_package(Slicer)"

In case of mismatch, the configure will be aborted displaying a message
similar to this one:

// --------------------
CMake Error at C:/D/N/Slicer-1-build/Slicer-build/SlicerConfig.cmake:475 (message):
Mismatch between bitness of 'Foo' and 'Slicer' project !

Slicer_CMAKE_SIZEOF_VOID_P:8

CMAKE_SIZEOF_VOID_P:4

Reconfigure 'Foo' project using a compatible Generator.

Generator used to configure Slicer was: Visual Studio 9 2008 Win64

See http://www.cmake.org/cmake/help/v2.8.11/cmake.html#opt:-Ggenerator-name
// --------------------

Co-authored-by: Julien Finet <julien.finet@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22129 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerConfig.cmake.in Diff File

2145-support-for-installing-extension-from-file 291b3663

2013-06-28 18:49:43

finetjul

Details Diff 		COMP: Propagate CTK renaming: ctkSpinBox to ctkDoubleSpinBox

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22128 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/qSlicerCLIModuleUIHelper.cxx Diff File
mod - Libs/MRML/Widgets/Resources/UI/qMRMLModelInfoWidget.ui Diff File
mod - Libs/MRML/Widgets/Resources/UI/qMRMLScreenShotDialog.ui Diff File
mod - Libs/MRML/Widgets/Resources/UI/qMRMLSliceInformationWidget.ui Diff File
mod - Libs/MRML/Widgets/Resources/UI/qMRMLTransformSliders.ui Diff File
mod - Libs/MRML/Widgets/Resources/UI/qMRMLVolumeInfoWidget.ui Diff File
mod - Libs/MRML/Widgets/Resources/UI/qMRMLWindowLevelWidget.ui Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeInfoWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/qMRMLCoordinatesWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLItemDelegate.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLItemDelegate.h Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget_p.h Diff File
mod - Libs/MRML/Widgets/qMRMLSpinBox.h Diff File
mod - Modules/Loadable/Annotations/Resources/UI/qSlicerAnnotationModulePropertyDialog.ui Diff File
mod - Modules/Loadable/CropVolume/Resources/UI/qSlicerCropVolumeModuleWidget.ui Diff File
mod - Modules/Loadable/Measurements/Resources/UI/qSlicerMeasurementsAngleWidget.ui Diff File
mod - Modules/Loadable/Measurements/Resources/UI/qSlicerMeasurementsRulerWidget.ui Diff File
mod - Modules/Loadable/Reformat/Resources/UI/qSlicerReformatModuleWidget.ui Diff File
mod - Modules/Scripted/EditorLib/WandEffect.py Diff File
mod - SuperBuild/External_CTK.cmake Diff File

2145-support-for-installing-extension-from-file b002bc29

2013-06-27 20:08:45

finetjul

Details Diff 		COMP: Export ExternalData.cmake macro in UserSlicer.cmake

SlicerMacroSimpleTest needs ExternalData.cmake to be loaded.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22127 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/UseSlicer.cmake.in Diff File

2145-support-for-installing-extension-from-file 038c773b

2013-06-27 14:22:44

finetjul

Details Diff 		COMP: Build SlicerBaseCLI only if VTK is found.

This CMakeLists can be configured by projects others than Slicer
(e.g. TubeTK) that may not have VTK.
This time (see r22122 and r22125), the condition on SlicerBaseCLI_SRC
is correct.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22126 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/CLI/CMakeLists.txt Diff File

2145-support-for-installing-extension-from-file 103a6b64

2013-06-27 13:14:42

pieper

Details Diff 		BUG: Revert "COMP: Build SlicerBaseCLI only if VTK is found."

This reverts commit 0692c63d8a06c912258e1f368a9a7c318cc0621a.

This revert is needed bacause CLIs in slicer builds failed to find
SlicerBaseCLI for linking (checked on Mac).

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22125 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/CLI/CMakeLists.txt Diff File

2145-support-for-installing-extension-from-file 8d5a00f2

2013-06-27 13:14:40

pieper

Details Diff 		BUG: cast output to int16_t after watershed

Previously the output was being casted to uint16. Some editor effects,
such as the SaveIslandEffect don't behave correctly with this
unexpected image type. The output of the watershed effect is now
converted to int16 if needed.

From: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22124 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/WatershedFromMarkerEffect.py Diff File

2145-support-for-installing-extension-from-file 0d3f0824

2013-06-27 13:14:38

pieper

Details Diff 		PERF: try to import SimpleITK at file scope

Repeatedly importing a library at function scope is less efficient
then at the module level.

From: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22123 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/WatershedFromMarkerEffect.py Diff File

2145-support-for-installing-extension-from-file 0692c63d

2013-06-27 10:34:13

finetjul

Details Diff 		COMP: Build SlicerBaseCLI only if VTK is found.

This CMakeLists can be configured by projects others than Slicer
(e.g. TubeTK) that may not have VTK.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22122 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/CLI/CMakeLists.txt Diff File

2145-support-for-installing-extension-from-file d79a5f5a

2013-06-23 19:05:34

fedorov

Details Diff 		BUG: refer to mandatory parameters by index, no with flags (fixes 3184)


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22121 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/N4ITKBiasFieldCorrection/N4ITKBiasFieldCorrection.xml Diff File
mod - Modules/CLI/N4ITKBiasFieldCorrection/Testing/CMakeLists.txt Diff File

2145-support-for-installing-extension-from-file 7bad10fe

2013-06-21 17:40:55

pieper

Details Diff 		BUG: gracefully handle case where SimpleITK is not available

On continuous builds and local developer builds SimpleITK is not
enabled by default, so we need to test for it and avoid raising
an error that prevents the module from loading.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22120 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/WatershedFromMarkerEffect.py Diff File

2145-support-for-installing-extension-from-file 91a18b9a

2013-06-21 14:45:05

pieper

Details Diff 		ENH: Adding new editor effect to perform WatershedFromMarker

From: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22119 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/CMakeLists.txt Diff File
mod - Modules/Scripted/EditorLib/EditBox.py Diff File
add - Modules/Scripted/EditorLib/Resources/Icons/WatershedFromMarkerEffect.png Diff File
add - Modules/Scripted/EditorLib/WatershedFromMarkerEffect.py Diff File
mod - Modules/Scripted/EditorLib/__init__.py Diff File

2145-support-for-installing-extension-from-file 7a022632

2013-06-21 10:29:17

finetjul

Details Diff 		COMP: Pass Slicer_PLATFORM_CHECK to inner build

Otherwise, if Slicer_PLATFORM_CHECK is OFF at the superbuild level,
the variable is not defined in the inner build, and automatically set to
ON by SlicerBlockPlatformCheck.cmake

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22118 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 24 25 26 27 28 29 30 ... 40 ... 50 ... 55 56 57  Next  Last