View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003029Slicer4Module DICOMpublic2013-03-25 23:562017-06-07 23:27
Reportersvcauter Assigned Topieper  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003029: Image spacing not read correctly in Slicer 4.2.2
Description

When I import DICOM images in Slicer 4.2.2 or 4.2.1 (stable releases) using the DICOM module, the image spacing is always 1, 1, 1. I have the same problem with all my DICOM datasets. However, when using Slicer 4.2.0, the image spacing is correct. I use Debian GNU/Linux 7.0 64-bit.

TagsNo tags attached.

Relationships

related to 0003066 closedpieper The module will not start. 

Activities

pieper

pieper

2013-03-26 03:50

administrator   ~0008241

Hi -

By any chance are you using a non-English language for the system? can you test with your LC_NUMERIC environment variable set to C.

Something locale-dependent crept in or so and we're not sure how to fix it.
svcauter

svcauter

2013-03-28 00:09

reporter   ~0008258

Yes, and setting LC_NUMERIC to C indeed solves the problem. Thanks!
jcfr

jcfr

2013-04-02 10:18

administrator   ~0008292

Following commit r21856, internalization has been disabled. See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21856
pieper

pieper

2013-04-24 08:08

administrator   ~0008476

@svcauter - could you try one of the recent nightly builds to confirm the issue is fixed without the need to change the LC_NUMERIC flag? Then we can close the issue. Thanks.
pieper

pieper

2013-06-05 14:11

administrator   ~0008715

I was able to reproduce this issue and confirmed the fix with this change:

http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22082
pieper

pieper

2013-06-06 03:25

administrator   ~0008717

Fix confirmed to work by Marine.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file db75d3d5

2013-06-04 11:17:13

pieper

Details Diff 		BUG: 0003029 force slicer to be in the C locale to avoid data truncation


Set the locale to be "C" to avoid issues related to reading and writing
of floating point numbers. For example, when the decimal point is set to be
a comma instead of a period, there can be truncation of data.
See these previous commits and the
+ // http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21856
+ // http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21865
+ // http://slicer-devel.65872.n3.nabble.com/Re-Rounding-to-integer-tt4027985.html
+ // http://slicer-devel.65872.n3.nabble.com/Re-slicer-users-Slicer4-can-t-really-use-it-yet-td4028040.html
+ // http://slicer-users.65878.n3.nabble.com/Slicer4-DICOM-many-problems-td4025919.html
+ // and issue 0003029

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22074 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerCoreApplication.cxx Diff File

Slicer: 2145-support-for-installing-extension-from-file 14ca1995

2013-06-05 17:57:39

pieper

Details Diff 		BUG: 0003029 use 'setlocale' to force C over native language

It turns out that it is not enough to set Qt's locale and we must
also set the c standard library locale in order to avoid data
corruption when the decimalpoint is not period.

Many thanks to Marine Clogenson of EPFL for noticing and helping
figure out how to reproduce this issue!

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22082 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerCoreApplication.cxx Diff File

Issue History

Date Modified Username Field Change
2013-03-25 23:56 svcauter New Issue
2013-03-25 23:56 svcauter Status new => assigned
2013-03-25 23:56 svcauter Assigned To => pieper
2013-03-26 03:50 pieper Note Added: 0008241
2013-03-28 00:09 svcauter Note Added: 0008258
2013-04-02 10:18 jcfr Note Added: 0008292
2013-04-02 10:18 jcfr Status assigned => resolved
2013-04-02 10:18 jcfr Fixed in Version => Slicer 4.3.0
2013-04-02 10:18 jcfr Resolution open => fixed
2013-04-16 04:05 pieper Relationship added related to 0003066
2013-04-24 08:08 pieper Note Added: 0008476
2013-06-05 14:11 pieper Note Added: 0008715
2013-06-06 03:25 pieper Note Added: 0008717
2013-06-06 03:25 pieper Status resolved => closed
2014-03-06 06:16 jcfr Target Version => Slicer 4.3.0
2017-06-07 23:27 pieper Changeset attached => Slicer 2145-support-for-installing-extension-from-file 14ca1995
2017-06-07 23:27 pieper Changeset attached => Slicer 2145-support-for-installing-extension-from-file db75d3d5