Changesets: Slicer
|
2145-support-for-installing-extension-from-file 53bb3da7 2013-05-17 18:05:07 Details Diff |
STYLE: Do not check for version of CMake before including "BundleUtilities" Since minimum required CMake version for Slicer is 2.8.9, this message is not needed anymore. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22017 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerCPackBundleFixup.cmake.in | Diff File | ||
| mod - CMake/SlicerExtensionCPackBundleFixup.cmake.in | Diff File | ||
|
2145-support-for-installing-extension-from-file 3c9209df 2013-05-17 18:05:05 Details Diff |
ENH: Simplify logic by appending path to CLI factory only if they exist. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22016 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTCLI/qSlicerCLIModuleFactoryHelper.cxx | Diff File | ||
|
2145-support-for-installing-extension-from-file c6232cfb 2013-05-17 18:05:04 Details Diff |
ENH: Move MacOSX configuration code for CLI factory to a better place. As a slight improvement, the path is also appended only if it exists. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22015 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTCLI/qSlicerCLIExecutableModuleFactory.cxx | Diff File | ||
| mod - Base/QTCLI/qSlicerCLIModuleFactoryHelper.cxx | Diff File | ||
|
2145-support-for-installing-extension-from-file 043d5b76 2013-05-17 18:05:02 Details Diff |
COMP: On MacOSX, do not create duplicate of MRMLIDIOPlugin and MGHIOPlugin This fix MacOSX warning "/path/to/plugin is already loaded" Both MRMLIDIOPlugin and MGHIOPlugin were copied so that it exists both a "dylib" and a "so" version of the file. This was initially committed on the 2007-09-27 to work around a limitation of ITK preventing it from loading plugin having ".dylib" extension. See Slicer3 r4454 [1] Then 2 months later, on the 2007-11-19, a fix has been pushed in ITK so that plugin having extension "dylib" are considered. See ITK commit 28b4a6ba [2] This commit account for the ITK fix by removing the code in charge of copying the plugin. Lessons learned: When implementing a hack, it is a good practice to report a bug upstream to track the limitation and also reference the bug in a comment starting with either "# HACK" for CMake file or "// HACK" for c/cpp files. It would give a hint to developer re-factoring the code. [1] http://viewvc.slicer.org/viewvc.cgi/Slicer3?view=revision&revision=4454 [2] https://github.com/Kitware/ITK/commit/28b4a6ba git-svn-id: http://svn.slicer.org/Slicer4/trunk@22014 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerCPackBundleFixup.cmake.in | Diff File | ||
| mod - Libs/MGHImageIO/CMakeLists.txt | Diff File | ||
| mod - Libs/MRML/IDImageIO/CMakeLists.txt | Diff File | ||
|
2145-support-for-installing-extension-from-file 3b0eb163 2013-05-17 12:08:45 Details Diff |
COMP: LibArchive-* dirs should be deleted to avoid build errors Forcing "HAVE_LIBXML_XMLREADER_H" to a "notfound" value as it is done in commit r22012 has no effect on an existing build tree. This is confirmed by http://slicer.cdash.org/viewBuildError.php?buildid=98584 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22013 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_LibArchive.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 6a750196 2013-05-17 11:42:21 Details Diff |
COMP: Revert "BUG: LibXml2 is required for building." Commit r22008 explicitly disable the search of library not needed to build LibArchive. Then, commit r22009 has been pushed to re-enable the lookup of LibXml2. The original intent of commit r22009 was to fix a build error occurring when configuring LibArchive in an existing build tree with option -DCMAKE_DISABLE_FIND_PACKAGE_LibXml2:BOOL=OFF. Since it is required to delete the LibArchive build tree so that the variable "HAVE_LIBXML_XMLREADER_H" is not set by a previous lookup of LibXml2, this new commit is reverted. Forcing the value "HAVE_LIBXML_XMLREADER_H" to a "notfound" value will also ensure that re-build of existing tree won't cause problem. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22012 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_LibArchive.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file a78005e2 2013-05-17 09:34:19 Details Diff |
ENH: add an attribute indicating the layout name of the view of anno manip When a widget is actively moving a fiducial, the viewer should not be modified by external commands, such as chaning the slice node since that will reset the widget. To avoid this, the added attribute allows other code to know which view is the one in which the widget is active, and can thereby keep it out of any other updates. (See Landmark registration project for an example gitub.com/pieper/LandmarkRegistration) git-svn-id: http://svn.slicer.org/Slicer4/trunk@22011 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationFiducialDisplayableManager.cxx | Diff File | ||
|
2145-support-for-installing-extension-from-file 5068888b 2013-05-17 08:46:50 Details Diff |
ENH: added mode for enabling/disabling Fiber editing in TractographyDisplay module and vtkMRMLTractographyDisplayDisplayableManager git-svn-id: http://svn.slicer.org/Slicer4/trunk@22010 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLInteractionNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLInteractionNode.h | Diff File | ||
| mod - Modules/Loadable/TractographyDisplay/MRMLDM/vtkMRMLTractographyDisplayDisplayableManager.cxx | Diff File | ||
| mod - Modules/Loadable/TractographyDisplay/MRMLDM/vtkMRMLTractographyDisplayDisplayableManager.h | Diff File | ||
| mod - Modules/Loadable/TractographyDisplay/Widgets/Resources/UI/qSlicerTractographyEditorROIWidget.ui | Diff File | ||
| mod - Modules/Loadable/TractographyDisplay/Widgets/qSlicerTractographyEditorROIWidget.cxx | Diff File | ||
| mod - Modules/Loadable/TractographyDisplay/Widgets/qSlicerTractographyEditorROIWidget.h | Diff File | ||
|
2145-support-for-installing-extension-from-file 39a0bfb3 2013-05-16 22:00:10 hjohnson Details Diff |
BUG: LibXml2 is required for building. Previous patch turned this off, but it is required for building libarchive. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22009 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_LibArchive.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file a072bd92 2013-05-16 17:43:59 Details Diff |
COMP: Ensure LibArchive is not built against unexpected library LibArchive does a wide search of the build system for any possible supported archival libraries (BZip2, LibXml2, Expat, Lzma). This can add unnecessary requirements for end users, so disable all the optional components that are not needed by Slicer. Thanks to Hans Johnson for suggesting this change. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22008 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_LibArchive.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 5b075804 2013-05-16 17:24:35 Details Diff |
BUG: self-initialization of variable git-svn-id: http://svn.slicer.org/Slicer4/trunk@22007 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_EMSegment.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 21be7b4e 2013-05-16 15:02:54 Details Diff |
BUG: 2528. Fixed the cause of the crash because of invalid LUT in vtkMRMLDiffusionTensorDisplayPropertiesNode git-svn-id: http://svn.slicer.org/Slicer4/trunk@22006 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLDiffusionTensorDisplayPropertiesNode.cxx | Diff File | ||
| mod - Modules/Loadable/Volumes/Widgets/Resources/UI/qSlicerScalarVolumeDisplayWidget.ui | Diff File | ||
|
2145-support-for-installing-extension-from-file d86048c7 2013-05-16 14:37:18 naucoin Details Diff |
BUG: Calculate ruler distance so it's up to date When adding a ruler node programatically to the scene, with initialised end point coordinates, the distance wasn't getting updated. Removed the local variable that saved the distance and changed GetDistanceMeasurement to calculate it when called. Still writes out the distance to MRML but does not read it back in as it will be re-calculated. Issue 0003123 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22005 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationRulerNode.cxx | Diff File | ||
| mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationRulerNode.h | Diff File | ||
| mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationRulerDisplayableManager.cxx | Diff File | ||
|
2145-support-for-installing-extension-from-file ccdfdd31 2013-05-16 11:17:33 Details Diff |
BUG: 0002326 make save dialog name match node name With this change, the file save name will be made to match the name of the node. This way when a user has specified a meaningful name in the GUI it will be transferred to the filename as well for consistency. http://www.na-mic.org/Bug/view.php?id=2326#c8637 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22004 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTGUI/qSlicerSaveDataDialog.cxx | Diff File | ||
|
2145-support-for-installing-extension-from-file 3b71eaee 2013-05-16 00:41:10 Details Diff |
COMP: Fix DiffusionTensorImagingTutorial The XML file has been updated to account for the changes added by previous updated related to introduction of ctkSpinBox (r21902) and Editor layout re-organization. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22003 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/Data/Input/DiffusionTensorImagingTutorial.xml | Diff File | ||
|
2145-support-for-installing-extension-from-file 23495997 2013-05-15 23:12:16 Details Diff |
COMP: Exclude some extensions from git hook line lengths check Extensions: *.ui, *.xml and *.xml.in git-svn-id: http://svn.slicer.org/Slicer4/trunk@22002 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Utilities/SetupForDevelopment.sh | Diff File | ||
|
2145-support-for-installing-extension-from-file fdf22951 2013-05-15 22:57:54 Details Diff |
COMP: Fix qMRMLDisplayNodeWidgetEventTranslatorPlayerTest1 Following r21905, the widget UI has been re-organized. The XML file has been updated to account for the change previously introduced. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22001 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/Testing/qMRMLDisplayNodeWidgetEventTranslatorPlayerTest1.xml | Diff File | ||
|
2145-support-for-installing-extension-from-file a5466dec 2013-05-15 18:25:07 Details Diff |
BUG: Fix OtsuThresholdImageFilterTest Based on discussion during May 14 Slicer developer hangout, the test failure was due to the transition to ITKv4. The update of the baseline has been done with the following command: cp /home/jchris/Projects/Slicer-TR-Superbuild-Release/Slicer-build/Testing/Temporary/OtsuThresholdImageFilterTest.raw.gz /home/jchris/Projects/Slicer-TR/Modules/CLI/OtsuThresholdImageFilter/Data/Baseline/ git-svn-id: http://svn.slicer.org/Slicer4/trunk@22000 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/OtsuThresholdImageFilter/Data/Baseline/OtsuThresholdImageFilterTest.raw.gz | Diff File | ||
|
2145-support-for-installing-extension-from-file 6365c74f 2013-05-15 15:29:15 naucoin Details Diff |
BUG: set LUT range widget to trigger setting range on LUT Updating the GUI element will trigger a signal to update the look up table on the color node. Renamed a method from setNumberOfColors to updateNumberOfColors as it wasn't taking an argument. TODO: set up an observation on the look up table on the color node Issue 0003115 git-svn-id: http://svn.slicer.org/Slicer4/trunk@21999 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Colors/qSlicerColorsModuleWidget.cxx | Diff File | ||
| mod - Modules/Loadable/Colors/qSlicerColorsModuleWidget.h | Diff File | ||
|
2145-support-for-installing-extension-from-file 93592784 2013-05-15 15:13:19 Details Diff |
COMP: Do not compile zlib using WINAPI calling convention Following commit r21963, windows 32-bit couldn't be be built because of missing symbol error associated with python, vtk and itk. Ensuring ZLIB_WINAPI was defined systematically by configuring it inside "zlibDllConfig.h" was solving python link error but was then causing further link error while building ITK, VTK (conflicting calling convention __fastcall vs __stdcall) Since originally the flag has been added to be able to compile LibArchive and since now LibArchive supports zlib build with or without ZLIB_WINAPI, there is NOW no need to force the flag. git-svn-id: http://svn.slicer.org/Slicer4/trunk@21998 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_zlib.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 673354a1 2013-05-14 18:29:23 Details Diff |
COMP: Fix unused CMake variable warning related to DOCUMENTATION_* variable git-svn-id: http://svn.slicer.org/Slicer4/trunk@21997 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMakeLists.txt | Diff File | ||
| mod - SuperBuild.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 06ee4a65 2013-05-14 18:29:21 Details Diff |
COMP: Fix CMake warning related to WITH_MEMCHECK CMake variable Commented the variable waiting the build system is updated to support running of the test using valgrind. git-svn-id: http://svn.slicer.org/Slicer4/trunk@21996 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMakeLists.txt | Diff File | ||
| mod - SuperBuild.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 69f00925 2013-05-14 18:29:20 Details Diff |
COMP: Remove unused Slicer superbuild boolean variable The variable "Slicer_BUILD_Extensions" originally introduced by commit r21550 is not used. git-svn-id: http://svn.slicer.org/Slicer4/trunk@21995 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 33091ada 2013-05-14 18:29:18 Details Diff |
COMP: Fix unused CMake variable Teem_VTK_TOOLKITS_IPATH warning Following r21963, Teem_VTK_MANGLES is set to OFF. For that reason, the variable Teem_VTK_TOOLKITS_IPATH is not required anymore. git-svn-id: http://svn.slicer.org/Slicer4/trunk@21994 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_teem.cmake | Diff File | ||
|
2145-support-for-installing-extension-from-file 5427f71a 2013-05-14 17:36:03 naucoin Details Diff |
BUG: Set the color range when changing number of colors When copying a color table node and reducing the number of colors in it, the color table range wasn't updated. This led to problems in the Editor module when the selected drawing integer wasn't matched up to the expected color. Now when the number of colors is set on a user editable color node, the range is set on the color look up table and on the GUI slider at the same time. Also updated the number of colors spin box to only trigger a reset of the number of colors on the node on the editingFinished signal as othewise cutting down a table from 300 to 50 colors could empty out the table and refill it with black rather than creating a subset of the original table. Issue 0003115 git-svn-id: http://svn.slicer.org/Slicer4/trunk@21993 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Colors/qSlicerColorsModuleWidget.cxx | Diff File | ||
| mod - Modules/Loadable/Colors/qSlicerColorsModuleWidget.h | Diff File | ||
