View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003145 | Slicer4 | Core: MRML | public | 2013-06-04 07:05 | 2017-06-07 23:27 |
| Reporter | Franklin King | Assigned To | johan.andruejol | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | Slicer 4.2.2-1 | ||||
| Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.4.0 | ||
| Summary | 0003145: New Units code leading to mrml xml issues | ||||
| Description | Loading a scene results in the following error: ERROR: In ....\VTK\IO\vtkXMLParser.cxx, line 483 which seems to be referring to: selected="false" ="vtkMRMLUnitNodeApplicationLength" "vtkMRMLUnitNodeApplicationTime" activeVolumeID="NULL" Working scenes lack vtkMRMLUnitNodeApplicationLength and vtkMRMLUnitNodeApplicationTime. | ||||
| Tags | No tags attached. | ||||
| has duplicate | 0003146 | closed | johan.andruejol | MRML scene with units are unvalid. |
 |
Fixed in revision 22705, see |
 |
Closing resolved issues that have not been updated in more than 3 months |
|
Slicer: 2145-support-for-installing-extension-from-file edb07a87 2013-06-04 15:31:29 Details Diff |
BUG: Fix MRMLScene import and export In the selection node, the unit didn't add a NodeReferenceMRMLAttributeNames for each of its reference role. These attributes are used when saving the mrml scene to describe what the reference role is used for. Most notably, this can be used when importing a scene. However, since there wasn't any defined for the selection node, a saved scene would look like this: ... selected="false" ="vtkMRMLUnitNodeApplicationLength" "vtkMRMLUnitNodeApplicationTime" activeVolumeID="NULL" ... Which is an invalid format for the scene. Adding a NodeReferenceMRMLAttributeNames is usually done in the class constructor. In our case, we assume that we don't know what kind of unit quantity can be added. Thus we don't know the ReferenceRoles we will need at constructor time. So we add theses roles in the SetUnitNodeID(). The roles names are based on the quantity, and aren't actually used anywhere. To make sure this works, a test opening Slicer, saving a scene and loading it again is added. See Issue 0003145 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22075 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt | Diff File | ||
| add - Applications/SlicerApp/Testing/Python/MRMLSceneImportAndExport.py | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLSelectionNode.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-06-04 07:05 | Franklin King | New Issue | |
| 2013-06-04 07:05 | Franklin King | Status | new => assigned |
| 2013-06-04 07:05 | Franklin King | Assigned To | => alexy |
| 2013-06-04 07:14 | jcfr | Assigned To | alexy => johan.andruejol |
| 2013-06-04 07:15 | jcfr | Target Version | => Slicer 4.3.0 |
| 2013-06-04 07:16 | jcfr | Relationship added | has duplicate 0003146 |
| 2013-06-04 13:13 | johan.andruejol | Note Added: 0008705 | |
| 2013-06-04 13:13 | johan.andruejol | Status | assigned => resolved |
| 2013-06-04 13:13 | johan.andruejol | Resolution | open => fixed |
| 2014-03-06 05:15 | jcfr | Note Added: 0011081 | |
| 2014-03-06 05:16 | jcfr | Status | resolved => closed |
| 2014-03-06 05:55 | jcfr | Fixed in Version | => Slicer 4.4.0 |
| 2017-06-07 23:27 | johan.andruejol | Changeset attached | => Slicer 2145-support-for-installing-extension-from-file edb07a87 |
