Changesets: Slicer

Search Browse Back to Index

2145-support-for-installing-extension-from-file 83742aec

2013-07-15 11:24:37

finetjul

Details Diff 		ENH: Add vtkMRMLUnitNode::GetDisplayStringFromValue

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22192 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLSelectionNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSelectionNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLUnitNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLUnitNode.h Diff File
mod - Modules/Loadable/Annotations/Logic/vtkSlicerAnnotationModuleLogic.cxx Diff File

2145-support-for-installing-extension-from-file 93a9f7c1

2013-07-15 11:24:29

finetjul

Details Diff 		BUG: Fix modules depending on units

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22191 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/CMakeLists.txt Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModule.cxx Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModule.h Diff File
mod - Modules/Loadable/Volumes/qSlicerVolumesModule.cxx Diff File

2145-support-for-installing-extension-from-file 399899cc

2013-07-15 11:24:21

finetjul

Details Diff 		ENH: Improve qMRMLUnitWidget interface

QFlags were added to this widget so one can choose what properties are
visible or not. This is what is done in the qSlicerUnitsSettingsPanel to
hide the advanced properties of the unit to the user. By default, the user
can only modify the precision property.
If he choose to show more properties, a warning stating that only display
values are changed when modifying an unit is shown along with the other
properties.

Style wise, the groupbox title now has its first letter in uppercase to
follow the GUI conventions and a horizontale line in the
qMRMLUnitNodeWidget between the precision and the rest of the properties.

See Issue 0003137

From: Johan Andruejohl <johan.andruejohl@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22190 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Units/Logic/vtkSlicerUnitsLogic.cxx Diff File
mod - Modules/Loadable/Units/Resources/UI/qSlicerUnitsSettingsPanel.ui Diff File
mod - Modules/Loadable/Units/Widgets/Resources/UI/qMRMLUnitWidget.ui Diff File
mod - Modules/Loadable/Units/Widgets/qMRMLSettingsUnitWidget.h Diff File
mod - Modules/Loadable/Units/Widgets/qMRMLUnitWidget.cxx Diff File
mod - Modules/Loadable/Units/Widgets/qMRMLUnitWidget.h Diff File
mod - Modules/Loadable/Units/qSlicerUnitsSettingsPanel.cxx Diff File
mod - Modules/Loadable/Units/qSlicerUnitsSettingsPanel.h Diff File

2145-support-for-installing-extension-from-file a53e2f39

2013-07-15 11:24:11

finetjul

Details Diff 		BUG: Restore the selection node units on scene close

Re-enable Units module.
Closes 0003176, 0003152

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22189 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTApp/qSlicerApplicationHelper.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLUnitNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLUnitNode.h Diff File
mod - Modules/Loadable/Units/Logic/vtkSlicerUnitsLogic.cxx Diff File
mod - Modules/Loadable/Units/Logic/vtkSlicerUnitsLogic.h Diff File

2145-support-for-installing-extension-from-file 7435bb67

2013-07-15 11:24:02

finetjul

Details Diff 		ENH: Add support for node reference templates

In vtkMRMLSelectionNode, the exact name of the reference roles of a unit is
not known until the unit is set and observed. (it's a dynamic number of
unit reference roles). By using a special key '/' in the reference role
(e.g. "unit/"), it is possible to have multiple reference roles
(e.g. "unit/length", "unit/time"...).
Issue 0002727

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22188 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLSelectionNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLSelectionNode.h Diff File

2145-support-for-installing-extension-from-file db4456a6

2013-07-15 11:23:55

finetjul

Details Diff 		BUG: Copy NodeReferenceMRMLAttributeNames in vtkMRMLNode::Copy()

Issue 0002727

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22187 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File

2145-support-for-installing-extension-from-file 1c0a42cd

2013-07-15 11:23:48

finetjul

Details Diff 		STYLE: Use static member variables for reference roles and attribute name

Issue 0002727

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22186 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLDisplayableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayableNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLStorableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLStorableNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.h Diff File

2145-support-for-installing-extension-from-file 53e57712

2013-07-13 15:46:46

jcfr

Details Diff 		COMP: Ensure external module can directly find Slicer

Following commit r22063, extensions bundled using Slicer_EXTENSION_SOURCE_DIRS
didn't have to use the "if(NOT Slicer_SOURCE_DIR)" safeguard.

This commit move inclusion of external modules from the CLI, Loadable
and Scripted sub-directories into a single "Modules/Remote" folder
included after Slicer_DIR so that external module can also directly call
"find_package(Slicer)"

Thanks to Brad Lowekamp for reporting the issue.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22185 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File
mod - Modules/CLI/CMakeLists.txt Diff File
mod - Modules/Loadable/CMakeLists.txt Diff File
add - Modules/Remote/CMakeLists.txt Diff File
mod - Modules/Scripted/CMakeLists.txt Diff File

2145-support-for-installing-extension-from-file 80e86b65

2013-07-13 04:30:18

jcfr

Details Diff 		BUG: Fix TranslatorPlayer tests to account for ctkSpinBox renaming

Commit r22128 updated CTK to propagate renaming of ctkSpinBox
into ctkDoubleSpinBox, this commit also fixes the test that were
using ctkSpinBox.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22184 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Data/Input/DiffusionTensorImagingTutorial.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLLinearTransformSliderEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLROIWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLRangeWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeInfoWidgetEventTranslatorPlayerTest1.xml Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLWindowLevelWidgetEventTranslatorPlayerTest1.xml Diff File

2145-support-for-installing-extension-from-file 92e3f03b

2013-07-13 04:13:16

jcfr

Details Diff 		BUG: Fix vtkMRMLCameraDisplayableManagerTest1

Following r22159 fixing issue 0001798, the "useDepthPeeling" view node
property has been introduced, this commit updates the mrml input file
used by the test with this new property.

Related to 0001798

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22183 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/Testing/Data/vtkMRMLCameraDisplayableManagerTest1.mrml Diff File

2145-support-for-installing-extension-from-file 644d3cca

2013-07-13 03:55:59

jcfr

Details Diff 		BUG: Turn off projections when annotations are not visible

Projections of annotations were not "hidden" with annotation.

This fix ensure the widget representing an annotation's projection
is "hidden" when an annotation visibility is turned off.

This commit is a follow-up of r22176 ensuring projections are deleted
when an annotation is deleted.

Fixes 0003214

From: Laurent Chauvin <lchauvin@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22182 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationDisplayableManager.cxx Diff File

2145-support-for-installing-extension-from-file 89bf5bed

2013-07-13 03:55:55

jcfr

Details Diff 		COMP: In test driver on windows, log VTK messages on standard output

Before this commit, VTK message were logged into a GUI windows
preventing them from being captured and interpreted by the testing
harness.

Fixes 0003221

Co-authored-by: Csaba Pinter <pinter@cs.queensu.ca>

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22181 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerMacroConfigureModuleCxxTestDriver.cmake Diff File

2145-support-for-installing-extension-from-file e5c53cee

2013-07-13 01:36:57

jcfr

Details Diff 		COMP: Fix unused variable warnings

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22180 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationDisplayableManager.h Diff File
mod - Modules/Loadable/TractographyDisplay/MRMLDM/vtkMRMLTractographyDisplayDisplayableManager.cxx Diff File
mod - Modules/Loadable/Units/Testing/Cxx/vtkSlicerUnitsLogicTest1.cxx Diff File
mod - SuperBuild/External_CTK.cmake Diff File

2145-support-for-installing-extension-from-file fc14ea6e

2013-07-13 01:06:14

jcfr

Details Diff 		COMP: Simplify passing of SimpleITK external project arguments

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22179 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_SimpleITK.cmake Diff File

2145-support-for-installing-extension-from-file 996071ce

2013-07-13 01:06:11

jcfr

Details Diff 		COMP: External_SimpleITK - Fix unused CMake variable warnings

CMake Warning:
Manually-specified variables were not used by the project:

BUILD_EXAMPLES
PYTHON_FRAMEWORKS

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22178 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_SimpleITK.cmake Diff File

2145-support-for-installing-extension-from-file cd57fdfd

2013-07-13 00:54:23

jcfr

Details Diff 		BUG: Ensure projections do not appear as selectable

Projections are not selectable and shouldn't be, however they
were displayed as if they were selectable, so it could be confusing
for the user. This fix ensure projections are properly displayed to
not look like selectable.

Fixes 0003222

From: Laurent Chauvin <lchauvin@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22177 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationDisplayableManager.cxx Diff File

2145-support-for-installing-extension-from-file 362e81e7

2013-07-13 00:39:41

jcfr

Details Diff 		BUG: Turn off projections when annotations are deleted

Projections of annotations were not deleted with annotation.
This fix ensure the widget representing an annotation's projection is
deleted when the corresponding annotation is deleted.

Partially fixes 0003214

From: Laurent Chauvin <lchauvin@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22176 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationDisplayableManagerHelper.cxx Diff File

2145-support-for-installing-extension-from-file 5b7644a4

2013-07-13 00:17:13

jcfr

Details Diff 		ENH: Add toolbar for the Extensions Manager and Error log

Fixes 0003151

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Chrystel Juan <chrystel.juan@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22175 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Resources/UI/qSlicerAppMainWindow.ui Diff File
mod - Applications/SlicerApp/qSlicerAppMainWindow.cxx Diff File

2145-support-for-installing-extension-from-file b87cf4dc

2013-07-12 19:25:05

pohl

Details Diff 		BUG: warning message was incorrectly labeled as error

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22174 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_EMSegment.cmake Diff File

2145-support-for-installing-extension-from-file 985e9443

2013-07-12 19:11:19

pohl

Details Diff 		BUG: warning was displayed via vtkErrorMacro

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22173 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLLabelMapVolumeDisplayNode.cxx Diff File

2145-support-for-installing-extension-from-file fc4820aa

2013-07-12 16:06:13

jcfr

Details Diff 		BUG: Update OpenIGTLinkIF GIT_TAG to fix issues 0003224 and 0003225

Issue 3224: std::list increment assertion failure on Windows
Issue 3225: vtkMRMLIGTLConnectorNode: bug in unregistering incoming MRML node

See https://github.com/openigtlink/OpenIGTLinkIF/compare/f9b65b1ffd2992862025f3c6ec5fe30e6f5dd395...533af932a1c899a0872c35b41113075f7da1ac1b

Co-authored-by: Isaiah Norton <inorton@bwh.harvard.edu>
Co-authored-by: Adam Rankin <rankin@cs.queensu.ca>

From: Junichi Tokuda <tokuda@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22172 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_OpenIGTLinkIF.cmake Diff File

2145-support-for-installing-extension-from-file d0310bc0

2013-07-12 15:56:45

jcfr

Details Diff 		COMP: Update ITKv4 to fix Gcc 4.2.1 Apple compiler seg fault

Following r22163, ITKv4 hash tag has been updated to point to the release
branch. This introduced the regression documented in [1]

This commit fixes the problem by including the ITK commit f49a7db7. For
sake of completeness, the corresponding message is also reported below.

[1] https://itk.icts.uiowa.edu/jira/browse/ITK-3172


// --------------------
BUG: Disable aligned attribute to fix Apple GCC 4.2.1 seg
fault

Commit 2f96c578 fixed the configure test checking if aligned
attributes were supported by the compiler. Then commit e906441e
disabled the test for Gcc 4.1 to prevent a similar error.

This commit ensures that the configure test also excludes Apple
Gcc 4.2.1 (without llvm support) by forcing the configure test to
be in "Debug" mode.

When this issue was first encountered by Brad, the problem was occurring
in Debug mode and he narrowed it down to the block of code in the try_compile
and tried to use it as a detector. Slicer appears to have encountered the
same issue in release mode, but the bug detector only detects it in Debug
mode.

Co-authored-by: Bradley Lowekamp <blowekamp@mail.nih.gov>
// --------------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22171 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_ITKv4.cmake Diff File

2145-support-for-installing-extension-from-file a12652fe

2013-07-12 12:47:38

jcfr

Details Diff 		BUG: Fix launcher settings to allow loading of extension in unix build tree

This commit restores the correct loading of extension installed in a Slicer
build tree. It contains a fix related to ITKv4 transition and fix related
to transition from DCMTK static libraries to shared libraries (r21914)

Following the transition to ITKv4, the libraries (*.so) were built in the
lib directory [1] whereas in ITKv3, the libraries were built in the bin
directory [2].

[1] https://github.com/Kitware/ITK/blob/1839b74bacfd455dd917b086466c882ed29606ba/CMakeLists.txt#L164-174
[2] https://github.com/Kitware/ITK/blob/v3.20.1/CMakeLists.txt#L93-99

Following the transition to using DCMTK shared libraries (r21914 [3]), a
follow-up commit (r21942 [4]) has been pushed to ensure Slicer could be
started from a build tree on windows.

[3] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21914
[4] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21942

In both case (ITKv4 and DCMTK), Slicer could be started successfully from
a build tree on Windows (thanks to the launcher settings), and started
successfully on Unix system (thanks to rpath). On the other hand, since
the launcher settings were incorrect on unix system, the loading of
installed extensions (having rpath stripped) in a unix build tree was
failing.

Fixes 0003218

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22170 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMake/SlicerBlockCTKAppLauncherSettings.cmake Diff File

2145-support-for-installing-extension-from-file 05ee8f8b

2013-07-12 08:48:58

fedorov

Details Diff 		PERF: disable parsing GE private tag identifying B-value in DWI acquisitions, since it can be present in non-DWI series, and parsing it involves running dcmdump


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22169 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_MultiVolumeImporter.cmake Diff File

2145-support-for-installing-extension-from-file 7390f260

2013-07-11 08:17:09

finetjul

Details Diff 		ENH: Make volume property file reading more robust

* nextHigher does no longer produce denormalized values, it's error prone
* ensure values are are unique when reading from file
Issue 0003220

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22168 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/VolumeRendering/Logic/vtkSlicerVolumeRenderingLogic.cxx Diff File
mod - Modules/Loadable/VolumeRendering/MRML/vtkMRMLVolumePropertyNode.cxx Diff File
mod - Modules/Loadable/VolumeRendering/MRML/vtkMRMLVolumePropertyNode.h Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 22 23 24 25 26 27 28 ... 30 ... 40 ... 50 ... 55 56 57  Next  Last