View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003214Slicer4Module Annotationspublic2013-07-10 05:312017-06-07 23:27
Reporterkotwicz Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.0 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003214: Hiding and deleting fiducials does not affect their 2d projections
Description

Toggling the visibility of a fiducial does not hide it's 2d projection
Deleting a fiducial does not delete it's 2d projection

TagsNo tags attached.

Activities

Lchauvin

Lchauvin

2013-07-10 11:16

developer   ~0008995

Oh sorry. I have the fix on my laptop.
I will try to push it really soon.
kotwicz

kotwicz

2013-07-10 11:34

reporter   ~0008998

Ok great thanks a lot! there a couple other issues related to fiducials... if you have time to look at them i would really appreciate that

http://www.na-mic.org/Bug/view.php?id=3217
http://www.na-mic.org/Bug/view.php?id=3216
http://www.na-mic.org/Bug/view.php?id=3196
Lchauvin

Lchauvin

2013-07-10 11:41

developer   ~0009000

No problem.

However, I don't really have lot of time to work on it.
And Nicole is working on a new Annotation module, so I won't put too much effort for now developing based on Annotation module, if it changes soon, I will have to update and if architecture is different, I will have to do it from scratch almost.

I hope I could do it in the future, but I cannot promise it as of today.
Lchauvin

Lchauvin

2013-07-10 12:05

developer   ~0009003

I submitted the pull request to put the fix on Slicer repository.
Lchauvin

Lchauvin

2013-07-11 08:29

developer   ~0009012

https://github.com/lchauvin/Slicer/tree/3214-projections-not-deleted-with-annotations
jcfr

jcfr

2013-07-12 20:41

administrator   ~0009035

Partially fixed by r22176
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22176

Deleting a fiducial successfully removed the corresponding projection but hiding a fiducial does NOT hide the projection.
Lchauvin

Lchauvin

2013-07-12 23:09

developer   ~0009037

I updated the code to hide projection when fiducial/ruler is hidden.
jcfr

jcfr

2013-07-12 23:56

administrator   ~0009039

Fixed in r22182
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22182
kotwicz

kotwicz

2013-07-16 09:36

reporter   ~0009066

maybe something to add to this issue... when AddViewNodeID is called on a fiducial display node it does not affect it's projection.
jcfr

jcfr

2013-07-16 09:38

administrator   ~0009069

@kotwicz: If the problem originally described by the issue is resolved. Make sure to close it. Additonally, if there are other problems you would like to see resolved, make sure to create different issue(s). Thanks
jcfr

jcfr

2017-06-07 23:27

administrator   ~0014634

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 362e81e7

2013-07-13 00:39:41

jcfr

Details Diff 		BUG: Turn off projections when annotations are deleted

Projections of annotations were not deleted with annotation.
This fix ensure the widget representing an annotation's projection is
deleted when the corresponding annotation is deleted.

Partially fixes 0003214

From: Laurent Chauvin <lchauvin@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22176 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationDisplayableManagerHelper.cxx Diff File

Slicer: 2145-support-for-installing-extension-from-file 644d3cca

2013-07-13 03:55:59

jcfr

Details Diff 		BUG: Turn off projections when annotations are not visible

Projections of annotations were not "hidden" with annotation.

This fix ensure the widget representing an annotation's projection
is "hidden" when an annotation visibility is turned off.

This commit is a follow-up of r22176 ensuring projections are deleted
when an annotation is deleted.

Fixes 0003214

From: Laurent Chauvin <lchauvin@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22182 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Annotations/MRMLDM/vtkMRMLAnnotationDisplayableManager.cxx Diff File

Issue History

Date Modified Username Field Change
2013-07-10 05:31 kotwicz New Issue
2013-07-10 05:31 kotwicz Status new => assigned
2013-07-10 05:31 kotwicz Assigned To => nicole
2013-07-10 08:54 nicole Assigned To nicole => Lchauvin
2013-07-10 11:16 Lchauvin Note Added: 0008995
2013-07-10 11:17 Lchauvin Status assigned => confirmed
2013-07-10 11:34 kotwicz Note Added: 0008998
2013-07-10 11:41 Lchauvin Note Added: 0009000
2013-07-10 12:05 Lchauvin Note Added: 0009003
2013-07-11 08:29 Lchauvin Note Added: 0009012
2013-07-12 20:41 jcfr Note Added: 0009035
2013-07-12 20:57 jcfr Target Version => Slicer 4.3.0
2013-07-12 23:09 Lchauvin Note Added: 0009037
2013-07-12 23:56 jcfr Note Added: 0009039
2013-07-12 23:56 jcfr Status confirmed => resolved
2013-07-12 23:56 jcfr Fixed in Version => Slicer 4.3.0
2013-07-12 23:56 jcfr Resolution open => fixed
2013-07-16 09:36 kotwicz Note Added: 0009066
2013-07-16 09:38 jcfr Note Added: 0009069
2013-07-17 12:18 kotwicz Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 644d3cca
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 362e81e7
2017-06-07 23:27 jcfr Note Added: 0014634
2017-06-07 23:27 jcfr Assigned To Lchauvin => jcfr