View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003137Slicer4Core: GUIpublic2013-05-29 15:142017-06-07 23:27
Reporterpieper Assigned Tojohan.andruejol  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003137: fix styling of Units settings
Description

See attached image for details.

TagsNo tags attached.

Relationships

related to 0003152 closedfinetjul Slicer crashes with "Close Scene" and "Application Settings Cancel" 

Activities

2013-05-29 15:15

 

UnitStyling.png (75,279 bytes)
UnitStyling.png (75,279 bytes)
finetjul

finetjul

2013-05-29 16:12

administrator   ~0008688

b) Instead of an "Advanced" group box that "breaks" the layout, have all the properties in the same layout. But create a QFlags "PropertyVisibility" property that controls the visibility of each property. At the panel level, add at the top right an "advanced" checkbox that switches the quantities PropertyVisibility values from ShowPrecision to ShowAll and that show/hide a "warning" label located at the bottom of the panel.
c) Style guide says labels should have uppercase only on the first word:
http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Style_Guide#Text
finetjul

finetjul

2013-07-15 07:25

administrator   ~0009047

Fixed in r22190
jcfr

jcfr

2014-03-06 05:18

administrator   ~0011112

Closing resolved issues that have not been updated in more than 3 months

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 399899cc

2013-07-15 11:24:21

finetjul

Details Diff 		ENH: Improve qMRMLUnitWidget interface

QFlags were added to this widget so one can choose what properties are
visible or not. This is what is done in the qSlicerUnitsSettingsPanel to
hide the advanced properties of the unit to the user. By default, the user
can only modify the precision property.
If he choose to show more properties, a warning stating that only display
values are changed when modifying an unit is shown along with the other
properties.

Style wise, the groupbox title now has its first letter in uppercase to
follow the GUI conventions and a horizontale line in the
qMRMLUnitNodeWidget between the precision and the rest of the properties.

See Issue 0003137

From: Johan Andruejohl <johan.andruejohl@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22190 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Units/Logic/vtkSlicerUnitsLogic.cxx Diff File
mod - Modules/Loadable/Units/Resources/UI/qSlicerUnitsSettingsPanel.ui Diff File
mod - Modules/Loadable/Units/Widgets/Resources/UI/qMRMLUnitWidget.ui Diff File
mod - Modules/Loadable/Units/Widgets/qMRMLSettingsUnitWidget.h Diff File
mod - Modules/Loadable/Units/Widgets/qMRMLUnitWidget.cxx Diff File
mod - Modules/Loadable/Units/Widgets/qMRMLUnitWidget.h Diff File
mod - Modules/Loadable/Units/qSlicerUnitsSettingsPanel.cxx Diff File
mod - Modules/Loadable/Units/qSlicerUnitsSettingsPanel.h Diff File

Issue History

Date Modified Username Field Change
2013-05-29 15:14 pieper New Issue
2013-05-29 15:14 pieper Status new => assigned
2013-05-29 15:14 pieper Assigned To => johan.andruejol
2013-05-29 15:15 pieper File Added: UnitStyling.png
2013-05-29 16:12 finetjul Note Added: 0008688
2013-07-15 07:25 finetjul Note Added: 0009047
2013-07-15 07:25 finetjul Status assigned => resolved
2013-07-15 07:25 finetjul Fixed in Version => Slicer 4.3.0
2013-07-15 07:25 finetjul Resolution open => fixed
2013-07-15 07:27 finetjul Relationship added related to 0003152
2014-03-06 05:18 jcfr Note Added: 0011112
2014-03-06 05:20 jcfr Status resolved => closed
2014-03-06 06:15 jcfr Target Version => Slicer 4.3.0
2017-06-07 23:27 finetjul Changeset attached => Slicer 2145-support-for-installing-extension-from-file 399899cc