View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003221 | Slicer4 | Core: Base Code | public | 2013-07-10 12:06 | 2017-06-07 23:27 |
Reporter | pinter | Assigned To | jcfr | ||
Priority | normal | Severity | feature | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.2.2-1 | ||||
Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.3.0 | ||
Summary | 0003221: Enable logging of VTK messages on standard output by default | ||||
Description | Add this feature to the test driver | ||||
Additional Information | The code snippet that does this is: // Direct vtk messages on standard output | ||||
Tags | No tags attached. | ||||
Please, try the following topic: https://github.com/jcfr/Slicer/tree/3221-test-driver-window-enable-vtk-message-log The VTK message are systematically redirected to standard error. In case a module doesn't depend on VTK, passing the option "WITHOUT_VTK_OUTPUT_WINDOW_REDIRECT" allow to avoid the inclusion of vtkOutputWindow related code. We could also adopt the opposite approach where by default there are no redirection, and it has to be explicitly enabled by passing the option "WITH_VTK_OUTPUT_WINDOW_REDIRECT". I think the current approach makes more sens, that way we are sure all messages will be parsed by CTest and reported on CDash. What do you think ? |
|
This has been integrated into r22181 [1], please re-open if this is still an issue. [1] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22181 |
|
Note: Has to be made sure that the WITH_GENERIC_TESTS option is added to the slicerMacroBuildQtModule macro call in the module CMakeLists file, instead of using the old SlicerMacroConfigureGenericCxxModuleTests macro in the test CMakeLists |
|
Fix committed to 2145-support-for-installing-extension-from-file branch. |
|
Slicer: 2145-support-for-installing-extension-from-file 89bf5bed 2013-07-13 03:55:55 Details Diff |
COMP: In test driver on windows, log VTK messages on standard output Before this commit, VTK message were logged into a GUI windows preventing them from being captured and interpreted by the testing harness. Fixes 0003221 Co-authored-by: Csaba Pinter <pinter@cs.queensu.ca> From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22181 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - CMake/SlicerMacroConfigureModuleCxxTestDriver.cmake | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2013-07-10 12:06 | pinter | New Issue | |
2013-07-10 12:06 | pinter | Status | new => assigned |
2013-07-10 12:06 | pinter | Assigned To | => jcfr |
2013-07-12 23:46 | jcfr | Note Added: 0009038 | |
2013-07-12 23:46 | jcfr | Status | assigned => feedback |
2013-07-18 03:50 | jcfr | Note Added: 0009119 | |
2013-07-18 03:50 | jcfr | Status | feedback => resolved |
2013-07-18 03:50 | jcfr | Fixed in Version | => Slicer 4.3.0 |
2013-07-18 03:50 | jcfr | Resolution | open => fixed |
2013-07-18 03:51 | jcfr | Target Version | => Slicer 4.3.0 |
2013-08-15 12:31 | pinter | Note Added: 0009479 | |
2013-08-15 12:31 | pinter | Status | resolved => closed |
2017-06-07 23:27 | jcfr | Changeset attached | => Slicer 2145-support-for-installing-extension-from-file 89bf5bed |
2017-06-07 23:27 | jcfr | Note Added: 0014635 |