Changesets: Import 2017-06-07 23:51:09
|
master c74b2f93 2014-03-11 10:33:48 Details Diff |
BUG: 0003429 bounds check on biomdal analysis git-svn-id: http://svn.slicer.org/Slicer4/trunk@22942 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkImageBimodalAnalysis.cxx | Diff File | ||
|
master 94be8ae4 2014-03-11 10:33:46 Details Diff |
BUG: helper method does not have access to slicer module Before this change, calling the method from a module gave this error: "/Applications/Slicer-2014-02-07.app/Contents/bin/Python/slicer/util.py", line 383, in resetSliceViews manager = slicer.app.layoutManager().resetSliceViews() NameError: global name 'slicer' is not defined Importing slicer in each method seems wrong so, TODO: explore importing at the top of util.py git-svn-id: http://svn.slicer.org/Slicer4/trunk@22941 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Python/slicer/util.py | Diff File | ||
|
master abb090d1 2014-03-11 09:47:09 Details Diff |
BUG: Properly pass OpenSSL libraries to python project. Fixes 0003620 In attempt to fix 0003620, commit r22939 completely removed the transformation of list OPENSSL_LIBRARIES assuming the macro 'ExternalProject_Include_Dependencies' would proceed to the required updates. It turns out that since the variable is directly passed as CMAKE_ARGS to the python project, the list has to be explicitly transformed. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22940 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_python.cmake | Diff File | ||
|
master c2ad10ef 2014-03-10 19:44:48 Details Diff |
BUG: Properly pass OpenSSL libraries to Slicer project. Fixes 0003620 Following commit r22922 which was updating the macro ExternalProjectDependency, list passed to external projects are automatically separated by a list separator if one of the value contain ${CMAKE_CFG_INTDIR}. Since on the unix, none of the value in the list was having ${CMAKE_CFG_INTDIR}, the variable OPENSSL_LIBRARIES was set to /path/to/libssl.so^^/path/to/libcrypto.so where was /path/to/libssl.so;/path/to/libcrypto.so was expected. This commit simply removes the explicit list transformation to let the build system take the appropriate decision. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22939 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_OpenSSL.cmake | Diff File | ||
|
master 02ca2b51 2014-03-10 18:29:18 Details Diff |
BUG: Update CTK to fix wrong location of fiducials after switching layout. Jean-Christophe Fillion-Robin (1): Emit ctkVTKSlicerView::resized after vtkRenderWindow size is set. Fixes 0001914 - See http://na-mic.org/Mantis/view.php?id=1914 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22938 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_CTK.cmake | Diff File | ||
|
master 58453b94 2014-03-10 18:27:24 naucoin Details Diff |
ENH: default value of HideFromEditors flag set to 0 This change will cause new mrml nodes to not be hidden from editors by default, developers subclassing vtkMRMLNode will need to specify the following in constructors to over ride this behaviour: this->HideFromEditors = 1; MRML Core nodes that should be hidden in the Data module were updated to stay hidden. From the Slicer Roadmap for 4.4: https://www.slicer.org/slicerWiki/index.php/Roadmap#4.4 Issue 0002906 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22937 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLCrosshairNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLDisplayNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLInteractionNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLScriptedModuleNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLSelectionNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLSliceCompositeNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLStorageNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLUnitNode.cxx | Diff File | ||
|
master e947a3dc 2014-03-10 18:24:59 Details Diff |
COMP: Fix LibArchive, curl, OpenSSL and python custom build tree detection. The external projects now check for the same variables that will also be used to configure Slicer. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22936 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_LibArchive.cmake | Diff File | ||
| mod - SuperBuild/External_OpenSSL.cmake | Diff File | ||
| mod - SuperBuild/External_curl.cmake | Diff File | ||
| mod - SuperBuild/External_python.cmake | Diff File | ||
|
master 9da185b5 2014-03-10 18:24:57 Details Diff |
COMP: Update Teem external project to accept custom location. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22935 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_teem.cmake | Diff File | ||
|
master 06570812 2014-03-10 18:24:55 Details Diff |
COMP: Update CTK to include Python wrapping fix. $ git shortlog --no-merges 7466ab0a..cb01e8c Andreas Fetzer (3): Proper pointer inizialization Fixed wrong resourceUri for certain xnatObjects Added download function to ctkXnatTreeBrowser Daniel Knorr (3): Changed TreeModel functionality of CanFetchMore() and FetchMore(), to add children which have been fetched already. Previously these children were not added to the model, they were fetc Deleted the no more necessary ctkXnatProjectsListModel. Added a virtual method to ctkXnatObject for getting the child type. Overwrited this method in ctkXnatDataModel and ctkXnatProject. Changed the ctkXNATBrowser models to generic ctkXnatListModel. Litte Changes to ctkXnatTreeModel. Jean-Christophe Fillion-Robin (3): Update VTK external project to 5.10 head to fix clang compilation error BUG: Fix PythonQt light wrapping so that header in subfolder can be wrapped. Update ExternalProjectDependency system based on commontk/Artichoke@c3eb170 Miklos Espak (32): Login dialog added qRestAPI upgrade Fix for compiler warnings ctkXnatConnection* moved from ctkXnatObject to ctkXnatServer XNAT tree model and example application Null check for ctkXnatSettings in login dialog, refactorings qRestAPI hash update to get library dirs fix Scan resource download CTK naming conventions for getters Resource URIs constructed incrementally Reconstruction support is back SSL errors suppressed for connecting sites with self-signed certificate Clean-up ctkXnatTreeModel::xnatObject(QModelIndex) Fix about CTK naming convention for getters API clean-up, documentation comments ctkXnatScanResourceFile and ctkXnatReconstructionResourceFile unified to a single ctkXnatFile class Unit test added for CTKXNATCore XML Schema type property for ctkXnatObject Schema type stored in ctkXnatObject Shared/weak pointers removed in favour of explicit memory handling ctkXnatObject::addChild renamed to add XNAT Core refactorings and basic support for creating objects Existance test support ctkXnatAPI class (former qXnatAPI from the qRestAPI project) Parent can be passed to ctkXnatObject constructors Unit test for XNAT object deletion XNAT save function save the properties XML schema type used for XNAT objects Unit test for XNAT object parent-child relationship XNAT resourceUri fixes Uses of obsolete class ctkXnatSessionFactory are removed Nicolas Toussaint (8): make the experiment level available in the new API make the scan-folder and scans levels available in the new API all levels are taken into account now, with the right labels implement default methods for Objects for isFile() etc xnat: adding the missing methods, still missing some implementations xnat: download functionality almost on track xnat: working on the download feature download file functionality restored Sascha Zelzer (33): Explicitly include the Qt use file again. Added qRestAPI as an external project. Moved the XNAT clases from the org.commontk.xnat plug-in. Moved the XNAT classes into a Core subdirectory. Added XNATWidgets library stub. Removed unused XNAT files and simplified QtScript dependency. Added initial ctkXNATBrowser application. ctkXnatObject redesign. No QObjects, using QSharedPointer. Qt list model for ctkXnatObject instances. Will be renamed. Prototype application for querying XNAT servers. Use Qt style for passing pimpl pointers to super-class constructors. Don't clear the CTK_EXTERNAL_LIBRARY_DIRS variable. Improved error and exception handling. Removed warnings. Renamed XNAT classes. Moved the ctkXnatLoginProfile class to XNAT/Core. ctkXnatSession now requires a ctkXnatLoginProfile in its constructor. Moved fetch() methods to subclasses and use QMetaType to create instances. Added http session support. Removed debugging messages. Re-structured XNAT exception hierarchy. Added ctkXnatSession documentatioin. Make schema type customizable per object again. Updated qRestAPI commit hash Use new qRestAPI hash We need to explictily open the session. The password for the ctk account has expired. Removed obsolete ctkXNATBrowser application. Use Qt naming convention for getters. Added doxygen groups and fixed some formatting issues. Use the proper CTK testing infrastructure. Add cmd line option for generating a GUI from XML Use a qRestAPI version compatible with Qt 4.6.2 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22934 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_CTK.cmake | Diff File | ||
|
master 62cfda52 2014-03-10 13:27:25 Details Diff |
COMP: Update VTK to include tweak to vtkImageHistogramStatistics $ git shortlog 4e0ca685..c88dfed Andinet Enquobahrie (2): ENH: Add NumberOfVoxels statistics measure ENH: Add mode statistical measure Co-authored-by: Andinet Enquobahrie <andinet.enqu@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22933 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_VTK.cmake | Diff File | ||
|
master 85d3d475 2014-03-10 11:21:53 Details Diff |
BUG: SlicerAbstractCoreModule - Properly delete representations Representation instances must both be deleted and removed from the associated representation list. Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> From: Linus Sherrill <linus.sherrill@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22932 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTCore/qSlicerAbstractCoreModule.cxx | Diff File | ||
|
master df54cbe0 2014-03-07 18:28:20 naucoin Details Diff |
BUG: add missing .h file Missed in svn 22930 Issue 0003326 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22931 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.h | Diff File | ||
|
master a5937799 2014-03-07 16:02:31 naucoin Details Diff |
ENH: Add slice intersections toggle to Markups Added a check box inside the jump slices group box. It's available to toggle when jump slices is on. It updates when entering the module, but isn't listening to the slice composite nodes to update when the Navigation menu and/or MRML updates happen. Added test. Issue 0003326 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22930 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.cxx | Diff File | ||
| mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.h | Diff File | ||
| mod - Modules/Loadable/Markups/Resources/UI/qSlicerMarkupsModule.ui | Diff File | ||
| mod - Modules/Loadable/Markups/Testing/Cxx/vtkSlicerMarkupsLogicTest1.cxx | Diff File | ||
| mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx | Diff File | ||
|
master 88bc8e03 2014-03-07 12:57:38 naucoin Details Diff |
ENH: save the last sceneview thumbnail type Keep track of the last scene view and screen snapshot thumbnail type and use it for the next one that's being captured. For the scene views, base the next scene view name on the last one instead of always going back to the default SceneView. Issue 0001760 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22929 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLScreenShotDialog.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLScreenShotDialog.h | Diff File | ||
| mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleDialog.cxx | Diff File | ||
|
master 72e3fcc2 2014-03-06 18:06:13 naucoin Details Diff |
STYLE: remove outdated documentation Removed references to the Diffusion Editor since it is not in Slicer4. Issue 0001875 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22928 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Volumes/qSlicerVolumesModule.cxx | Diff File | ||
|
master 17f0a796 2014-03-06 18:01:10 Details Diff |
ENH: 0002921 add summary dialog after running test This was already being generated when running all tests, but now do it even for a single test button click. git-svn-id: http://svn.slicer.org/Slicer4/trunk@22927 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/SelfTests/SelfTests.py | Diff File | ||
|
master bf1b4b60 2014-03-06 18:01:05 Details Diff |
BUG: avoid spurious python warning when a volume has no display node git-svn-id: http://svn.slicer.org/Slicer4/trunk@22926 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/DataProbe/DataProbe.py | Diff File | ||
|
master 6bbaa31f 2014-03-06 17:03:20 naucoin Details Diff |
STYLE: fix method documentation Replace the \a with \arg to make a list with line breaks. Issue 0003512 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22925 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/VolumeRendering/Logic/vtkSlicerVolumeRenderingLogic.h | Diff File | ||
|
master 33b0a439 2014-03-05 18:44:07 Details Diff |
STYLE: Define and use Superclass typedef in qMRMLItemDelegate git-svn-id: http://svn.slicer.org/Slicer4/trunk@22924 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Widgets/qMRMLItemDelegate.cxx | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLItemDelegate.h | Diff File | ||
|
master 646d58ed 2014-03-05 18:44:05 Details Diff |
STYLE: In driver script, rename 'setIfNotDefined' into 'setOnlyIfNotDefined' git-svn-id: http://svn.slicer.org/Slicer4/trunk@22923 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerDashboardDriverScript.cmake | Diff File | ||
|
master 9763f55a 2014-03-05 18:44:03 Details Diff |
COMP: Update ExternalProjectDependency based on commontk/Artichoke@c3eb170 [Artichoke] $ git shortlog da5367b..c3eb170 Jean-Christophe Fillion-Robin (2): Ensure a list of same labels can be associated with multiple variables Simplify API removing requirement to explicitly set 'CMAKE_CMD' parameter [CTK] $ git shortlog --no-merges 7466ab0..ff2ae72 Andreas Fetzer (3): Proper pointer inizialization Fixed wrong resourceUri for certain xnatObjects Added download function to ctkXnatTreeBrowser Daniel Knorr (3): Changed TreeModel functionality of CanFetchMore() and FetchMore(), to add children which have been fetched already. Previously these children were not added to the model, they were fetche Deleted the no more necessary ctkXnatProjectsListModel. Added a virtual method to ctkXnatObject for getting the child type. Overwrited this method in ctkXnatDataModel and ctkXnatProject. Changed the ctkXNATBrowser models to generic ctkXnatListModel. Litte Changes to ctkXnatTreeModel. Jean-Christophe Fillion-Robin (2): Update VTK external project to 5.10 head to fix clang compilation error Update ExternalProjectDependency system based on commontk/Artichoke@c3eb170 Miklos Espak (32): Login dialog added qRestAPI upgrade Fix for compiler warnings ctkXnatConnection* moved from ctkXnatObject to ctkXnatServer XNAT tree model and example application Null check for ctkXnatSettings in login dialog, refactorings qRestAPI hash update to get library dirs fix Scan resource download CTK naming conventions for getters Resource URIs constructed incrementally Reconstruction support is back SSL errors suppressed for connecting sites with self-signed certificate Clean-up ctkXnatTreeModel::xnatObject(QModelIndex) Fix about CTK naming convention for getters API clean-up, documentation comments ctkXnatScanResourceFile and ctkXnatReconstructionResourceFile unified to a single ctkXnatFile class Unit test added for CTKXNATCore XML Schema type property for ctkXnatObject Schema type stored in ctkXnatObject Shared/weak pointers removed in favour of explicit memory handling ctkXnatObject::addChild renamed to add XNAT Core refactorings and basic support for creating objects Existance test support ctkXnatAPI class (former qXnatAPI from the qRestAPI project) Parent can be passed to ctkXnatObject constructors Unit test for XNAT object deletion XNAT save function save the properties XML schema type used for XNAT objects Unit test for XNAT object parent-child relationship XNAT resourceUri fixes Uses of obsolete class ctkXnatSessionFactory are removed Nicolas Toussaint (8): make the experiment level available in the new API make the scan-folder and scans levels available in the new API all levels are taken into account now, with the right labels implement default methods for Objects for isFile() etc xnat: adding the missing methods, still missing some implementations xnat: download functionality almost on track xnat: working on the download feature download file functionality restored Sascha Zelzer (33): Explicitly include the Qt use file again. Added qRestAPI as an external project. Moved the XNAT clases from the org.commontk.xnat plug-in. Moved the XNAT classes into a Core subdirectory. Added XNATWidgets library stub. Removed unused XNAT files and simplified QtScript dependency. Added initial ctkXNATBrowser application. ctkXnatObject redesign. No QObjects, using QSharedPointer. Qt list model for ctkXnatObject instances. Will be renamed. Prototype application for querying XNAT servers. Use Qt style for passing pimpl pointers to super-class constructors. Don't clear the CTK_EXTERNAL_LIBRARY_DIRS variable. Improved error and exception handling. Removed warnings. Renamed XNAT classes. Moved the ctkXnatLoginProfile class to XNAT/Core. ctkXnatSession now requires a ctkXnatLoginProfile in its constructor. Moved fetch() methods to subclasses and use QMetaType to create instances. Added http session support. Removed debugging messages. Re-structured XNAT exception hierarchy. Added ctkXnatSession documentatioin. Make schema type customizable per object again. Updated qRestAPI commit hash Use new qRestAPI hash We need to explictily open the session. The password for the ctk account has expired. Removed obsolete ctkXNATBrowser application. Use Qt naming convention for getters. Added doxygen groups and fixed some formatting issues. Use the proper CTK testing infrastructure. Add cmd line option for generating a GUI from XML Use a qRestAPI version compatible with Qt 4.6.2 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22922 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/ExternalProjectDependency.cmake | Diff File | ||
| mod - SuperBuild/External_OpenSSL.cmake | Diff File | ||
|
master ac265f6c 2014-03-04 11:13:37 naucoin Details Diff |
BUG: disable selecting new fiducial if jump slices on When new fiducials are added to a list, by default that row in the GUI table was selected. If jump slices is checked, that would result in the slices jumping to the coordinates of the new fiducial, which is at the origin when it's first added. The calculated coordinates are set by a second call (and produce a second event) in the displayable manager that was not triggering a second jump to the correct coordinates. Disable jumping to the newly added fiducial location when jump slices is on, this limits the jumping to user clicks in the table. Issue 0003556 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22921 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx | Diff File | ||
|
master 99d66a01 2014-03-03 23:40:37 Details Diff |
BUG: fix interactive plotting feature The feature was broken by the changes in SliceLayerLogic API: https://github.com/Slicer/Slicer/commit/40f74cdf870f213847f77b86351032c7869762d3#diff-228dc8288779dec5ad07baedef604899 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22920 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master e395c8ca 2014-03-03 18:26:58 naucoin Details Diff |
ENH: adjust the scale slider widgets to volume slice spacing On entry to the Markups module, check for a background volume in the red slice viewer, get the slice spacing and adjust the scale slider maximum values by a scale factor times the maximum slice spacing. Round the max scale to the nearest 10 when resetting it from volume spacing. Also ensure that if the module is entered with scale values on the display node that are larger than the slider maximums that the sliders are adjusted. Also works for the default settings being larger than slider maximums. Set the scale factor to 10 to allow for large markups on widely spaced volumes. Issue 0003547 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22919 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx | Diff File | ||
| mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.h | Diff File | ||
|
master 441c13d3 2014-03-03 11:21:23 Details Diff |
BUG: Ensure node name is set when vtkSlicerCLIModuleLogic::CreateNode Similarly to node created from the UI, node created with the help of the logic will also have their name set with the module title as basename. For example, with the title of the module is: General Registration (BRAINS) Note name will be: General Registration (BRAINS) General Registration (BRAINS)_1 General Registration (BRAINS)_2 ... git-svn-id: http://svn.slicer.org/Slicer4/trunk@22918 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTCLI/vtkSlicerCLIModuleLogic.cxx | Diff File | ||
