View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003429 | Slicer4 | Core: GUI | public | 2013-10-03 06:56 | 2017-06-10 08:51 |
Reporter | DMeier | Assigned To | pieper | ||
Priority | high | Severity | crash | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.3.0 | ||||
Target Version | Slicer 4.4.0 | Fixed in Version | Slicer 4.4.0 | ||
Summary | 0003429: Slicer 4.3 crashes when dragging 3 images to import. | ||||
Description | Attached 3 nrrd images. Slicer 4.3.0 crashes when importing the 3 image, order does not seem to matter. Each of the 3 images loaded individually seem to work, but not in combination. | ||||
Tags | No tags attached. | ||||
2013-10-03 06:56
|
T10_defect_Xf1_noResample.nrrd (3,173,280 bytes) |
2013-10-03 07:07
|
T10_defect-crop.nrrd (3,173,164 bytes) |
2013-10-03 07:20
|
T10_defect_s2.nrrd (1,703,206 bytes) |
issue is probably related to image with full dynamic range and datatype "unsigned short". Sample image "T10_defect_s2.nrrd" has intensities in the full range 0-65535, the other two do not. Loading that image when others are already present seems to trigger the crash. |
|
Unable to reproduce on Ubuntu 13.10 using Slicer r22924. |
|
Reminder sent to: nicole, pieper @Steve, @Nicole: When you have a chance could you check if it works on your MacOSX ? |
|
No crash for me loading these on the nightly build from 2014-03-03 on mac. @Dominik could you see it it still crashes for you on the nightly? |
|
Just checked: selecting all three and dragging them into my debug build of today's code caused a crash: Exception Type: EXC_BAD_ACCESS (SIGSEGV) VM Regions Near 0x121489000: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread |
|
Interesting - there have been a number of crashes reported in vtkImageBimodalAnalysisExecute. Looks like that code hasn't changed since 2008 (according to git blame) so I wonder what else has changed. |
|
Actually just eyeballing the code now I see how it could be wrong. Line 113 can be accessing beyond the end of the array since width is 5 and max could be at the end of the histogram. I suggest putting in a check if x+k >= max0. @Jc this one is assigned to you - do you want to fix this or should I? |
|
@Steve: Would appreciate if you could take this one :) Thanks |
|
Fixed in r22942. @Dominik if you could confirm with tomorrows nightly build and close the bug that would be great. |
|
Tested on a debug build, no crash. |
|
Confirmed by Dominik on the nightly build. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2013-10-03 06:56 | DMeier | New Issue | |
2013-10-03 06:56 | DMeier | Status | new => assigned |
2013-10-03 06:56 | DMeier | Assigned To | => kikinis |
2013-10-03 06:56 | DMeier | File Added: T10_defect_Xf1_noResample.nrrd | |
2013-10-03 07:02 | kikinis | Assigned To | kikinis => jcfr |
2013-10-03 07:07 | DMeier | File Added: T10_defect-crop.nrrd | |
2013-10-03 07:20 | DMeier | File Added: T10_defect_s2.nrrd | |
2013-10-03 07:22 | DMeier | Note Added: 0010125 | |
2013-10-04 01:03 | jcfr | Target Version | => Slicer 4.3.2 |
2014-03-06 10:15 | nicole | Target Version | Slicer 4.3.2 => Slicer 4.4.0 |
2014-03-06 12:54 | jcfr | Note Added: 0011290 | |
2014-03-06 12:54 | jcfr | Status | assigned => feedback |
2014-03-06 12:55 | jcfr | Note Added: 0011291 | |
2014-03-07 04:18 | pieper | Note Added: 0011310 | |
2014-03-07 05:26 | jcfr | Status | feedback => resolved |
2014-03-07 05:26 | jcfr | Fixed in Version | => Slicer 4.4.0 |
2014-03-07 05:26 | jcfr | Resolution | open => unable to reproduce |
2014-03-10 13:03 | nicole | Note Added: 0011406 | |
2014-03-10 15:09 | pieper | Note Added: 0011412 | |
2014-03-10 15:17 | pieper | Note Added: 0011413 | |
2014-03-10 15:18 | pieper | Status | resolved => acknowledged |
2014-03-10 18:06 | jcfr | Assigned To | jcfr => pieper |
2014-03-10 18:06 | jcfr | Status | acknowledged => assigned |
2014-03-10 18:06 | jcfr | Fixed in Version | Slicer 4.4.0 => |
2014-03-10 18:07 | jcfr | Note Added: 0011416 | |
2014-03-11 06:37 | pieper | Note Added: 0011418 | |
2014-03-11 06:37 | pieper | Status | assigned => resolved |
2014-03-11 06:37 | pieper | Fixed in Version | => Slicer 4.4.0 |
2014-03-11 06:37 | pieper | Resolution | unable to reproduce => fixed |
2014-03-11 07:46 | nicole | Note Added: 0011419 | |
2014-03-12 06:43 | pieper | Note Added: 0011424 | |
2014-03-12 06:43 | pieper | Status | resolved => closed |
2017-06-10 08:51 | pieper | Changeset attached | => Slicer master c74b2f93 |