Changesets: Import 2017-06-07 23:51:09
|
master 0a7b3092 2014-08-02 01:43:13 Details Diff |
COMP: Update Datastore to fix build introduced when trying to fix warning See Slicer/Slicer-DataStore@713f1f8 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23542 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master fe94c230 2014-08-02 01:43:11 Details Diff |
STYLE: Simplify qSlicerModelsModuleWidget introducing vtkNew smartpointer Using vtkNew avoid to manually manage reference and simplify the code. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23541 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Models/qSlicerModelsModuleWidget.cxx | Diff File | ||
|
master 28e7ddca 2014-08-01 19:09:51 Details Diff |
ENH: Show volume and model information in subject hierarchy Show extended information for volumes and models in their tooltips in subject hierarchy Fixes 0001424 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23540 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Models/SubjectHierarchyPlugins/qSlicerSubjectHierarchyModelsPlugin.cxx | Diff File | ||
| mod - Modules/Loadable/Models/SubjectHierarchyPlugins/qSlicerSubjectHierarchyModelsPlugin.h | Diff File | ||
| mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyVolumesPlugin.cxx | Diff File | ||
| mod - Modules/Loadable/Volumes/SubjectHierarchyPlugins/qSlicerSubjectHierarchyVolumesPlugin.h | Diff File | ||
|
master 9005eb2a 2014-08-01 18:37:46 Details Diff |
COMP: Fix MacOSX packaging explicitly setting VTK_LIBRARY_DIRS for VTK6 This is a regression that has probably been introduced by kitware/VTK@0c1471f1 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23539 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerCPack.cmake | Diff File | ||
|
master b247b0be 2014-08-01 17:23:13 Details Diff |
BUG: Minor fixes in subject hierarchy There was a double scrollbar in case of many nodes (one for the module panel, one for the tree view), which was not convenient or nice. The tree view scrollbar has been disabled, so now the same behavior can be seen as in the Data module. Parse local data plugin fixed so that data nodes do not stay around after creating subject hierarchy from them. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23538 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/SubjectHierarchy/Resources/UI/qSlicerSubjectHierarchyModule.ui | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyParseLocalDataPlugin.cxx | Diff File | ||
|
master e0098e02 2014-08-01 16:03:56 Details Diff |
BUG: Fixed SimpleITK to Slicer volume push Color node as not set when creating display node for volumes pushed from SimpleITK to Slicer, so it could not be displayed. See http://slicer-users.65878.n3.nabble.com/Multiplying-volume-voxel-values-by-scalar-using-SimpleITK-output-garbled-td4027804.html git-svn-id: http://svn.slicer.org/Slicer4/trunk@23537 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Python/sitkUtils.py | Diff File | ||
|
master 386b5697 2014-08-01 15:46:04 Details Diff |
BUG: Fixed extra spaces in names of DICOM volumes Spaces were added after each character of the name of a volume that was loaded from DICOM. This has now been fixed by encoding to Latin-1 (which conversion is used throughout the code). Fixes 0003688 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23536 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/DICOMPlugins/DICOMScalarVolumePlugin.py | Diff File | ||
|
master bec97d78 2014-08-01 15:17:40 Details Diff |
BUG: Fixed issues caused by LazyUpdate in subject hierarchy model Complete scene update triggered by LazyUpdate in subject hierarchy after batch processing caused a crash in certain conditions. This has been fixed by only triggering it at scene import, which is necessary. invalidateModels replaced with invalidateFilter, which his called when filtering needs to be refreshed, e.g. when removing nodes by plugins git-svn-id: http://svn.slicer.org/Slicer4/trunk@23535 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSceneSubjectHierarchyModel.cxx | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSceneSubjectHierarchyModel.h | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyTreeView.cxx | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyAbstractPlugin.h | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyCloneNodePlugin.cxx | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/qSlicerSubjectHierarchyModuleWidget.cxx | Diff File | ||
|
master 57744a3a 2014-08-01 11:08:03 Details Diff |
ENH: 0003753 make ResampleVolumeToReferenceVolume static Per request from Kevin who reports this was overlooked in the first version. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23534 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.h | Diff File | ||
|
master d8e9ff6d 2014-08-01 03:31:12 Details Diff |
COMP: Fix unused variable warning in qSlicerSubjectHierarchyAbstractPlugin This commit fixes regression introduced in r23489 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23533 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyAbstractPlugin.cxx | Diff File | ||
|
master 9547d8a5 2014-08-01 03:31:10 Details Diff |
COMP: Update DataStore to fix "No resources" warning $ git shortlog 4ac766c..6081f84 Jean-Christophe Fillion-Robin (1): Fix "No Resources" warning in Widgets library git-svn-id: http://svn.slicer.org/Slicer4/trunk@23532 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master a9035800 2014-08-01 02:29:54 Details Diff |
BUG: Fix IASEM extension tests ensuring ITKIOMRC factory is loaded git-svn-id: http://svn.slicer.org/Slicer4/trunk@23531 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/ITKFactoryRegistration/CMakeLists.txt | Diff File | ||
|
master 5e102153 2014-08-01 02:29:52 Details Diff |
COMP: Fix usage of PYTHONPATH in extension launcher settings Following r23036 environment variable specifying list of path are handled differently. This commit ensures that python paths associated with extension are also set consistently across Slicer application and extension settings. The additional extension launcher settings are used in macro "slicer_add_python_test" and "slicer_add_python_unittest" implemented in SlicerMacroPythonTesting.cmake module. Since the macro "slicer_add_python_unittest" is used to configure the generic tests from within the macro "slicerMacroBuildScriptedModule", this commit should also help fix failing tests from extension bundling scripted modules. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23530 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Extensions/CMake/SlicerBlockAdditionalLauncherSettings.cmake | Diff File | ||
|
master 86094a62 2014-08-01 02:29:49 Details Diff |
STYLE: Easier maintenance of extension build system scripts This commit updates the list of arguments to be alphabetically ordered and be spread across multiple lines instead being on one long line very hard to read. This has been done by simply changing the single space into a line return and sorting the list alphabetically using test editor functionality. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23529 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Extensions/CMake/MIDASAPIUploadExtension.cmake | Diff File | ||
| mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtension.cmake | Diff File | ||
| mod - Extensions/CMake/SlicerBlockBuildPackageAndUploadExtensions.cmake | Diff File | ||
| mod - Extensions/CMake/SlicerBlockUploadExtension.cmake | Diff File | ||
| mod - Extensions/CMake/SlicerFunctionGenerateExtensionDescription.cmake | Diff File | ||
|
master 0df79d5a 2014-07-31 22:12:59 Details Diff |
COMP: Revert back to VTK 6.1. See 0003741 It turns out that updating the version of XCode used on the factory (running Snow Leopard) from 3.2.6 to 4.2 avoids to get the rather obnoxious errors of the form: // --------------------- [ 53%] Built target vtkSlicerAtlasCreatorModuleLogic Linking CXX shared library ../../../../lib/Slicer-4.3/qt-loadable-modules/libvtkSlicerAtlasCreatorModuleLogicPythonD.dylib ld: warning: duplicate dylib /Users/kitware/Dashboards/Experimental/Slicer4-SB/python-install/lib/libpython2.7.dylib ld: two level namespace mach-o files can link with at most 253 dylibs, this link would use 257 dylibs collect2: ld returned 1 exit status // --------------------- This has been confirmed doing (1) a clean build of Slicer r23525 using: Slicer/VTK@169b37b CMake 2.8.12 (2) a clean build of CarreraSlice against the Slicer build tree obtain in (1) also using CMake 2.8.12 More particularly, this commit reverts r23512, r23513, r23514 and r23515 The code checking for the version of CMake and enabling the option VTK_ENABLE_KITS only available with kitware/VTK@a609ca has been removed. XCode before: * Xcode: 3.2.6 - uildVersion: 10M2518 * gcc-4.0: i686-apple-darwin10-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5494) * gcc-4.2: i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5666) (dot 3) * llvm-gcc: i686-apple-darwin10-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.6) * clang: Apple clang version 1.7 (tags/Apple/clang-77) (based on LLVM 2.9svn XCode after: * Xcode: 4.2 - Build version 4C199 * gcc-4.0: i686-apple-darwin10-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5494) * gcc-4.2: i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5666) (dot 3) * llvm-gcc: i686-apple-darwin10-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00) * clang: Apple clang version 3.0 (tags/Apple/clang-211.10.1) (based on LLVM 3.0svn) The XCode configuration details has been obtained using the following one-liner adapted from the one available on XcodeVersionInfo macports page [1]: // -------------------- echo -en " * Xcode: $(/usr/bin/xcodebuild -version |head -n1) - $(/usr/bin/xcodebuild -version |tail -1)\n\ $(test -x /usr/bin/gcc-3.3\ && echo " * gcc-3.3: $(/usr/bin/gcc-3.3 --version 2>/dev/null |head -1)\n")\ $(test -x /usr/bin/gcc-4.0\ && echo " * gcc-4.0: $(/usr/bin/gcc-4.0 --version 2>/dev/null |head -1)\n")\ $(test -x /usr/bin/gcc-4.2\ && echo " * gcc-4.2: $(/usr/bin/gcc-4.2 --version 2>/dev/null |head -1)\n")\ $((test -x /usr/bin/llvm-gcc-4.2 || test -x /Developer/usr/bin/llvm-gcc-4.2)\ && echo " * llvm-gcc: $((/usr/bin/llvm-gcc --version 2>/dev/null || /Developer/usr/bin/llvm-gcc --version 2>/dev/null) |head -1)\n")\ $((test -x /usr/bin/clang || test -x /Developer/usr/bin/clang)\ && echo " * clang: $((test -x /usr/bin/clang\ && /usr/bin/clang --version 2>&1 || /Developer/usr/bin/clang --version 2>&1) |head -1)\n")" // -------------------- Note also that running this on-liner using the freshly installed version of XCode return the following message: ** INTERNAL ERROR: Uncaught exception ** Exception: *** -[NSConcreteFileHandle writeData:]: Broken pipe Finally, for future reference, the package allowing to install xcode is named "xcode_4.2_for_snow_leopard.dmg" and the associated MD5 is "428b006e1c12eaa644a442a598c6f13f". It has been installed using the default option in the "/Developer" folder. [1] https://trac.macports.org/wiki/XcodeVersionInfo git-svn-id: http://svn.slicer.org/Slicer4/trunk@23528 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMakeLists.txt | Diff File | ||
| mod - SuperBuild/External_VTKv6.cmake | Diff File | ||
|
master 164350fd 2014-07-31 16:53:12 Details Diff |
BUG: Fix update issues in subject hierarchy when module active Subject hierarchy tree was not properly updated when reparenting programatically or importing/restoring scene when module was active. This has been fixed and some unnecessary code removed. More testing added to SubjectHierarchyGenericSelfTest. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23527 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Applications/SlicerApp/Testing/Python/SubjectHierarchyGenericSelfTest.py | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Logic/vtkSlicerSubjectHierarchyModuleLogic.cxx | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Logic/vtkSlicerSubjectHierarchyModuleLogic.h | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSceneSubjectHierarchyModel.cxx | Diff File | ||
| mod - Modules/Loadable/SubjectHierarchy/qSlicerSubjectHierarchyModuleWidget.cxx | Diff File | ||
|
master c2840941 2014-07-31 12:27:20 Details Diff |
ENH: Update to latest landmark registration Improved point placement through transforms git-svn-id: http://svn.slicer.org/Slicer4/trunk@23526 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master 8b1c991a 2014-07-30 18:49:51 naucoin Details Diff |
BUG: respect don't show again on fiducials conversion Define a new button with an AcceptRole to have it saved in the config file, following the pattern of the Delete pop up boxes. Issue 0003663 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23525 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx | Diff File | ||
|
master f62a3f64 2014-07-30 18:21:32 Details Diff |
BUG: Propagate ModifiedEvent to volume/modelNode When setting a raw (vs pipeline filter) input data to a mrml node, the node was not notified (ProcessMRMLEvents) whenever the data was changed because the trivial producer internally used is not forwarding events. Issue 0003780 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23524 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLModelNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLModelNode.h | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLVolumeNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLVolumeNode.h | Diff File | ||
|
master 69f38fb4 2014-07-30 18:21:16 Details Diff |
BUG: Set slice plane coordinates using plane source filter Triggering ModifiedEvent on the input polydata does not (yet) propagate onto the model node. Closes 0003780 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23523 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Logic/vtkMRMLSliceLogic.cxx | Diff File | ||
|
master 3ce14ce1 2014-07-30 17:25:05 Details Diff |
COMP: SimpleITK is now enabled by default. SimpleITK is a first class citizen in Slicer and is now enabled by default. git-svn-id: http://svn.slicer.org/Slicer4/trunk@23522 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMakeLists.txt | Diff File | ||
|
master e859329f 2014-07-30 17:03:39 Details Diff |
BUG: Update MultiVolumeExplorer - Fix frame scrolling This fixes an issue due to missing cast from float to int that disabled frame scrolling. See fedorov/MultiVolumeExplorer@f9222a25a From: Andrey Fedorov <fedorov@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@23521 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master 9d5873ee 2014-07-30 16:47:57 Details Diff |
COMP: Fix install of VTK6 python modules on MacOSX git-svn-id: http://svn.slicer.org/Slicer4/trunk@23520 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerBlockInstallExternalPythonModules.cmake | Diff File | ||
|
master c666cd7b 2014-07-30 16:47:55 Details Diff |
STYLE: Remove deprecated variable from CDash driver script Setting ADDITIONAL_{C|CXX}_FLAGS variables is not the conventional way of setting additional flags. Setting environment variable CFLAGS and CXXFLAGS is the recommended way. Remove variable "WITH_TESTING_EXTENSIONS". This is an advanced variable that shouldn't be enabled on contributed dashboards. Only the factories should eventually enable it. That said, the recommended way is to build a set of s4ext files as explained in [1] [1] http://wiki.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Build_ExtensionsIndex git-svn-id: http://svn.slicer.org/Slicer4/trunk@23519 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerDashboardScript.TEMPLATE.cmake | Diff File | ||
|
master d08e80b7 2014-07-30 16:47:54 Details Diff |
STYLE: Update comments in dashboard driver script git-svn-id: http://svn.slicer.org/Slicer4/trunk@23518 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - CMake/SlicerDashboardScript.TEMPLATE.cmake | Diff File | ||
