View Issue Details

IDProjectCategoryView StatusLast Update
0003663Slicer4Module Markupspublic2017-06-10 08:51
Reporterfedorov Assigned Tonicole  
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionFixed in VersionSlicer 4.4.0 
Summary0003663: "Delete fiducial" popup does not remember user preference
Description

It keeps asking me if I want to delete the fiducial, even though I already checked I don't want to see this popup.

TagsNo tags attached.

Activities

nicole

nicole

2014-05-05 13:15

administrator   ~0011703

Last edited: 2014-05-05 13:27

This functionality relies on the built in Slicer settings file, using the Markups/AlwaysDeleteMarkups don't show again settings key. Looking through my own .config directory, I'm not finding that string in any of the .ini files. I verified that the problem is reproducible on my current svn build.
I'll dig into CTK to check if ctkMessageBox changed with the recent version bumps.
(verified that the Delete All don't show also doesn't get remembered, but that ctkMessageBox setting is only otherwise used for converting annotation fiducials, and the application restart)

fedorov

fedorov

2014-05-05 13:19

developer   ~0011705

I didn't see any other similar issues, but I didn't look hard. I just report what I experienced in my usage scenarios.

nicole

nicole

2014-05-05 13:51

administrator   ~0011706

I double checked the Markups display settings that you can save as defaults are saved to the .ini file, so it's something particular to the ctkMessageBox that's not getting saved.

nicole

nicole

2014-05-05 14:00

administrator   ~0011707

For my reference, the don't show again was added in Aug 2013:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22332

dstoup

dstoup

2014-06-04 12:57

reporter   ~0012024

Last edited: 2014-06-04 12:59

I just looked into this issue further. The reason the selection is not persisted in the settings ini file is that the buttons used to create the deleteAllMsgBox are QMessageBox::Yes and QMessageBox::No, which have a buttonRole QDialogButtonBox::ButtonRole == YesRole. The preference is only persisted by the ctkMessageBox when the QDialogButtonBox::ButtonRole == AcceptRole.

The simplest fix is to change the buttons from Yes/No to something like Ok/Cancel, which have the correct ButtonRole. On could argue though, that this issue is a failing in CTK for being so restrictive. It seems that a YesRole should be as acceptable as an AcceptRole, but there is a bit more risk involved with that change, in my opinion.

I have a fix in code for either resolution.

nicole

nicole

2014-06-09 10:13

administrator   ~0012037

Integrated David's branch as svn 23315:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23315

I incorporated the same type of fix for the conversion of annotations, will integrate that as part of the Rulers xfer.

nicole

nicole

2014-07-30 15:01

administrator   ~0012307

Conversion pop up box fix:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23525

Related Changesets

Import 2017-06-07 23:51:09: master 8b1c991a

2014-07-30 18:49:51

naucoin

Details Diff
BUG: respect don't show again on fiducials conversion

Define a new button with an AcceptRole to have it saved
in the config file, following the pattern of the Delete
pop up boxes.

Issue 0003663



git-svn-id: http://svn.slicer.org/Slicer4/trunk@23525 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File

Issue History

Date Modified Username Field Change
2014-04-18 12:06 fedorov New Issue
2014-04-18 12:06 fedorov Status new => assigned
2014-04-18 12:06 fedorov Assigned To => nicole
2014-05-05 13:15 nicole Note Added: 0011703
2014-05-05 13:19 fedorov Note Added: 0011705
2014-05-05 13:27 nicole Note Edited: 0011703
2014-05-05 13:51 nicole Note Added: 0011706
2014-05-05 14:00 nicole Note Added: 0011707
2014-06-04 12:57 dstoup Note Added: 0012024
2014-06-04 12:59 dstoup Note Edited: 0012024
2014-06-09 10:13 nicole Note Added: 0012037
2014-06-09 10:13 nicole Status assigned => resolved
2014-06-09 10:13 nicole Fixed in Version => Slicer 4.4.0
2014-06-09 10:13 nicole Resolution open => fixed
2014-06-14 16:28 fedorov Status resolved => closed
2014-07-30 15:01 nicole Note Added: 0012307
2017-06-10 08:51 Changeset attached => Slicer master 8b1c991a