0003688: DICOMScalerVolumePlugin name parsing error caused by umlaut - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0003688	Slicer4	Module DICOM	public	2014-05-13 02:11	2018-03-02 11:07

Reporter	dougszumski	Assigned To	pieper
Priority	normal	Severity	crash	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	Slicer 4.3.1-2
Target Version		Fixed in Version	Slicer 4.4.0

Summary	0003688: DICOMScalerVolumePlugin name parsing error caused by umlaut
Description	In DICOMScalerVolumePlugin.py a unicode conversion error causes 3DSlicer to hang when one attempts to load a series of DICOM files. In this case it appears that the error is caused by the presence of an umlaut in the file name. This is an example filename which causes the crash (char at pos 6): "3: Schädel 0.75 B70f for contentTime of 150613.95926"
Additional Information	Trace: MultiVolumeImportPlugin::examine DICOMMultiVolumePlugin found 0 multivolumes! MultiVolumeImportPlugin:examineMultiseries DICOMMultiVolumePlugin found 0 multivolumes! Traceback (most recent call last): File "/home/doug/Downloads/Slicer-4.3.1-linux-amd64/lib/Slicer-4.3/qt-scripted-modules/DICOMLib/DICOMWidgets.py", line 315, in loadCheckedLoadables if not plugin.load(loadable): File "/home/doug/Downloads/Slicer-4.3.1-linux-amd64/lib/Slicer-4.3/qt-scripted-modules/DICOMScalarVolumePlugin.py", line 306, in load volumeNode = self.loadFilesWithArchetype(loadable.files, loadable.name) File "/home/doug/Downloads/Slicer-4.3.1-linux-amd64/lib/Slicer-4.3/qt-scripted-modules/DICOMScalarVolumePlugin.py", line 301, in loadFilesWithArchetype return(volumesLogic.AddArchetypeScalarVolume(files[0],name,0,fileList)) TypeError: argument 2: (unicode conversion error)
Tags	No tags attached.

dougszumski 2014-05-13 02:14 reporter ~0011749	Observed on Fedora 20, 3D Slicer 4.3.1 r22599 and Windows 7 Pro 3D Slicer 4.3.1 r22599.

pieper 2014-05-13 04:16 administrator ~0011751	Can you attach a file that replicates the issue?

pieper 2014-07-21 12:48 administrator ~0012214	Got some sample data from Chile that demonstrates the issue. It generates messages of this type: UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 2: ordinal not in range(128) I have a branch with some fixes, but the SubjectHierarchy code is not working for some reason: https://github.com/pieper/Slicer/tree/3688-unicode-dicom If I can share it I will attach a file here to reproduce the issue. It might be better to fix this issue at the ctkDICOMDatabase level.

pieper 2014-07-21 13:03 administrator ~0012215	Was able to make the data load with these two commits: http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23472 http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23473 This works for now, but the problem could easily come back again. Someone with better international language skills than me should probably have a look.

2014-07-21 14:27	one-unicode-issue-file.tar.gz (372,173 bytes)

pieper 2014-07-21 14:27 administrator ~0012216	It should be possible to replicate the issue with the attached 'one-unicode-issue-file.tar.gz' data.

Import 2017-06-07 23:51:09: master 7f862f31 2014-07-24 10:18:44 pinter Details Diff	BUG: Fixed accented character display of series and studies in subject hierarchy Fixes 0003688 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23483 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - Modules/Scripted/DICOM/DICOMLib/DICOMPlugin.py		Diff File
Import 2017-06-07 23:51:09: master 386b5697 2014-08-01 15:46:04 pinter Details Diff	BUG: Fixed extra spaces in names of DICOM volumes Spaces were added after each character of the name of a volume that was loaded from DICOM. This has now been fixed by encoding to Latin-1 (which conversion is used throughout the code). Fixes 0003688 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23536 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - Modules/Scripted/DICOMPlugins/DICOMScalarVolumePlugin.py		Diff File

Date Modified	Username	Field	Change
2014-05-13 02:11	dougszumski	New Issue
2014-05-13 02:11	dougszumski	Status	new => assigned
2014-05-13 02:11	dougszumski	Assigned To	=> pieper
2014-05-13 02:14	dougszumski	Note Added: 0011749
2014-05-13 04:16	pieper	Note Added: 0011751
2014-07-21 12:48	pieper	Note Added: 0012214
2014-07-21 13:03	pieper	Note Added: 0012215
2014-07-21 13:03	pieper	Status	assigned => resolved
2014-07-21 13:03	pieper	Fixed in Version	=> Slicer 4.4.0
2014-07-21 13:03	pieper	Resolution	open => fixed
2014-07-21 14:27	pieper	File Added: one-unicode-issue-file.tar.gz
2014-07-21 14:27	pieper	Note Added: 0012216
2017-06-10 08:51	pinter	Changeset attached	=> Slicer master 386b5697
2017-06-10 08:51	pinter	Changeset attached	=> Slicer master 7f862f31
2018-03-02 11:07	jcfr	Status	resolved => closed