0003780: Slices in 3D view are not updated when the volume node is changed

ID	Project	Category	View Status	Date Submitted	Last Update

0003780	Slicer4	Core: MRML	public	2014-07-27 17:28	2018-03-02 11:06

Reporter	lassoan	Assigned To	finetjul
Priority	normal	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Product Version
Target Version	Slicer 4.4.0	Fixed in Version	Slicer 4.4.0

Summary	0003780: Slices in 3D view are not updated when the volume node is changed
Description	When volume node is changed (e.g., image data is modified, window width/level is modified) then the 2D slice views are updated but the slices in the 3D window remain the same. This is a big problem for IGT applications as we cannot show live image in the 3D view. How to reproduce: Load MRHead sample Show the slice in the 3D view Drag the cursor in a 2D view to change the brightness/contrast => image brightness/contrast is changing in the 2D view => image brightness/contrast is NOT changing in the 3D view - ERROR! vtkMRMLModelDisplayableManager::ProcessMRMLNodesEvents is called when the volume node is changed but then requestRender is set to false because IsModelDisplayable(...) checks fail.
Tags	No tags attached.

jcfr 2014-07-28 05:07 administrator ~0012252	There is also the test "vtkMRMLVolumeNodeEventsTest.cxx" build in [1] that is capturing the problem and is not added to the test driver using the "simple_test" macro. [1] https://github.com/Slicer/Slicer/blob/6b2a3a940ee7d925ce6778ad557d7acd128e7482/Libs/MRML/Core/Testing/CMakeLists.txt#L94

finetjul 2014-07-30 14:33 administrator ~0012302 Last edited: 2014-07-30 14:52	Fixed in r23523, improved in r23524 See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23523 and http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23524 Ideal fix is in https://github.com/finetjul/Slicer/commits/3798-propagate-trivial-producer and https://github.com/finetjul/VTK/commit/524eeb0a2de101439b979a0d52fc08757789a6ff

jcfr 2014-07-30 14:52 administrator ~0012306	Thanks Julien. You rock ! Have a great vacation :)

lassoan 2014-07-31 10:05 developer ~0012323	Thank you, it works well now!

Import 2017-06-07 23:51:09: master f62a3f64 2014-07-30 18:21:32 finetjul Details Diff	BUG: Propagate ModifiedEvent to volume/modelNode When setting a raw (vs pipeline filter) input data to a mrml node, the node was not notified (ProcessMRMLEvents) whenever the data was changed because the trivial producer internally used is not forwarding events. Issue 0003780 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23524 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - Libs/MRML/Core/vtkMRMLModelNode.cxx	Diff File
	mod - Libs/MRML/Core/vtkMRMLModelNode.h	Diff File
	mod - Libs/MRML/Core/vtkMRMLVolumeNode.cxx	Diff File
	mod - Libs/MRML/Core/vtkMRMLVolumeNode.h	Diff File

Date Modified	Username	Field	Change
2014-07-27 17:28	lassoan	New Issue
2014-07-28 05:02	jcfr	Assigned To	=> finetjul
2014-07-28 05:02	jcfr	Status	new => assigned
2014-07-28 05:02	jcfr	Category	Core: GUI => Core: MRML
2014-07-28 05:02	jcfr	Target Version	=> Slicer 4.4.0
2014-07-28 05:07	jcfr	Note Added: 0012252
2014-07-30 14:33	finetjul	Note Added: 0012302
2014-07-30 14:33	finetjul	Status	assigned => resolved
2014-07-30 14:33	finetjul	Fixed in Version	=> Slicer 4.4.0
2014-07-30 14:33	finetjul	Resolution	open => fixed
2014-07-30 14:52	jcfr	Note Edited: 0012302
2014-07-30 14:52	jcfr	Note Added: 0012306
2014-07-31 10:05	lassoan	Note Added: 0012323
2014-07-31 10:15	jcfr	Relationship added	related to 0003786
2017-06-10 08:51	finetjul	Changeset attached	=> Slicer master f62a3f64
2018-03-02 11:06	jcfr	Status	resolved => closed