Changesets: Slicer

2145-support-for-installing-extension-from-file d48cf26f

2013-10-13 12:29:53

alexy

Details Diff
BUG: 3416. Added generic mechanism for persisting node references in .mrml files.
References stored in the form: references="role1:id1 id2 iid3;role2:id3;". Note that for backwards compatibility the reference nodes such as displayable, transformable etc. still read/write their references the old way. Only custom references will use new syntax.


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22610 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNode.h Diff File

2145-support-for-installing-extension-from-file 599b6e42

2013-10-09 17:11:54

naucoin

Details Diff
STYLE: updated tool tip for markups table

Add a tool tip to hint at the right click context menu.

Issue 0003397



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22609 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Resources/UI/qSlicerMarkupsModule.ui Diff File

2145-support-for-installing-extension-from-file af89f029

2013-10-09 16:42:18

naucoin

Details Diff
ENH: add copy to markups list right click option

Can now right click on a markup in the GUI and copy it
to another list, placing it at the end of the destination
list.
Updated the right click Move option to only offer at the
end of the list as that simplifies the UI and users can
move the markups with the move up/down buttons.
Updated test for logic copy.
Updated documentation for copy.

Issue 0003397



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22608 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Documentation/Markups.xml Diff File
mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.cxx Diff File
mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.h Diff File
mod - Modules/Loadable/Markups/Testing/Cxx/vtkSlicerMarkupsLogicTest2.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.h Diff File

2145-support-for-installing-extension-from-file 66b9cde9

2013-10-08 16:34:56

millerjv

Details Diff
BUG: Read vectors as scalars

3-vectors were read as Vectors and placed on PointData.
All other vector lengths are read as multi-component Scalars
on PointData.

This patch treats all vectors as scalars to be consistent.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22607 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkTeem/vtkNRRDReader.cxx Diff File

2145-support-for-installing-extension-from-file 9bb99237

2013-10-08 13:00:56

pohl

Details Diff
BUG: see comment in r17038 of slicer3 trunk

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22606 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_EMSegment.cmake Diff File

2145-support-for-installing-extension-from-file a1115337

2013-10-08 03:18:45

pieper

Details Diff
BUG: 0003438 Avoid hang when saving due to non-visible widget grab

If the OpenGL context of the window is not correctly initialized,
then VTK cannot get a copy of the pixels and goes into an
infinite loop checking the GL error. This CTK version includes
a patch from Andras avoids this problem.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22605 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTK.cmake Diff File

2145-support-for-installing-extension-from-file 4c203a3f

2013-10-06 18:52:17

alexy

Details Diff
BUG: fixed problems and test failures introduced by r22603.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22604 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableNodeTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File
mod - Libs/MRML/DisplayableManager/vtkMRMLModelDisplayableManager.cxx Diff File

2145-support-for-installing-extension-from-file 454d75d0

2013-10-05 10:04:57

alexy

Details Diff
BUG: 3436. Fixed node references to use predefined events. Made reference code similar between Diaplayable and Transformable references. This is also continuation of work on bug 3388.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22603 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLTransformableNodeOnNodeReferenceAddTest.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLDisplayableNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.h Diff File

2145-support-for-installing-extension-from-file ad796dd8

2013-10-04 14:33:25

naucoin

Details Diff
ENH: test getting displayable managers to 3D view

To match the test added in svn 22583, make sure that
the expected list of displayable managers is present on the
3D view.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22602 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/qMRMLThreeDViewTest1.cxx Diff File

2145-support-for-installing-extension-from-file a72ead07

2013-10-04 05:33:12

jcfr

Details Diff
ENH: Sync patch version to match latest stable release

See commit r22599 on Slicer-4-3 branch.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22600 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File

2145-support-for-installing-extension-from-file 4c3a6272

2013-10-03 23:10:03

jcfr

Details Diff
BUG: Attempt to fix random failure of qSlicerSslTest on windows

Execute the event loop just after queuing the request with the
networkAccessManager.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22597 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/Testing/Cxx/qSlicerSslTest.cxx Diff File

2145-support-for-installing-extension-from-file f8092a37

2013-10-03 18:06:24

jcfr

Details Diff
BUG: Fix vtkMRMLSceneViewNodeStoreSceneTest randomly failing on windows

Allocating a single "vtkMRMLScalarVolumeNode" wasn't enough to ensure
that the space previously used by 'vtkMRMLScalarVolumeNode1' wasn't
available again for the restored volume.

See inlined comment for more details.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22594 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeStoreSceneTest.cxx Diff File

2145-support-for-installing-extension-from-file 77055d9a

2013-10-03 17:25:30

naucoin

Details Diff
BUG: check returned displayable managers

Add list of expected displayable managers and fail test
if returned list doesn't match in size or if returned managers
are not in the list.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22593 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetTest2.cxx Diff File

2145-support-for-installing-extension-from-file ef7d57e7

2013-10-03 16:29:15

naucoin

Details Diff
BUG: adding a test to show layout switch bug

Fiducial display positions aren't updated correctly
on linux according to bug 1914. This test illustrates this in a
non failing test way so that cross platform behaviour can be
determined.

Issue 0001914


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22587 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File
add - Applications/SlicerApp/Testing/Python/FiducialLayoutSwitchBug1914.py Diff File

2145-support-for-installing-extension-from-file 3fc0d33a

2013-10-03 16:25:21

jcfr

Details Diff
BUG: Fix vtkMRMLModelHierarchyNodeTest1

Since calling GetID() on a newly instantiated node is expected to
return NULL and that attempting to print a NULL string on windows
results in a crash. The test was failing only on windows.

This commit remove the print statement in the test and also add test
test for GetID and GetNodeTagName to EXERCISE_BASIC_MRML_METHODS so that
the default value for every node is verified.

Since there is already a test printing the value if it fails, also
remove extra debug statement printing the number of children in
the hierarchy node.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22586 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/Testing/vtkMRMLModelHierarchyNodeTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.h Diff File

2145-support-for-installing-extension-from-file 66bfbbfa

2013-10-03 16:25:19

jcfr

Details Diff
STYLE: Split MRML Node EncodeString tests into two different tests

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22585 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.h Diff File

2145-support-for-installing-extension-from-file 9f6fdb38

2013-10-03 16:25:17

jcfr

Details Diff
STYLE: Improve readability of EXERCISE_BASIC_MRML_METHODS macro

This commit makes it easier to read through the different test
associated with the macro.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22584 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.h Diff File

2145-support-for-installing-extension-from-file 383bc7f1

2013-10-03 16:04:43

naucoin

Details Diff
ENH: add abiltiy to get displayable managers on 2d views

Added getDisplayableManagers on the slice view to mirror the
same call on the 3D view. Added testing.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22583 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetTest2.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceView.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceView.h Diff File

2145-support-for-installing-extension-from-file 050d6a40

2013-10-03 16:01:32

naucoin

Details Diff
STYLE: remove extra comma

Copy/paste error left an extra comma in the argument list.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22582 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Extensions/Testing/ScriptedLoadableExtensionTemplate/ScriptedLoadableModuleTemplate/ScriptedLoadableModuleTemplate.py Diff File

2145-support-for-installing-extension-from-file 28408cdb

2013-10-03 10:37:02

jcfr

Details Diff
STYLE: In SliceControllerWidget, consistently restore "blockSignal" state

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22574 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File

2145-support-for-installing-extension-from-file 5161c680

2013-10-03 10:36:59

jcfr

Details Diff
STYLE: Remove unused "SliceOrientation" ivar from SliceControllerWidget

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22573 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget_p.h Diff File

2145-support-for-installing-extension-from-file d3aa9f02

2013-10-03 10:36:56

jcfr

Details Diff
BUG: Fix qMRMLSliceControllerWidgetTest

Following r22568, the controller has been updated so that the abbreviated
slice name can be dynamically updated after the "LayoutLabel" has been
changed on the associated slice node.

This commit clean up the code removing un-needed ivar "SliceViewLabel" and
fix the test.

Finally, also set "sliceViewLabel" as a property so that is accessible
from python.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22572 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/Testing/qMRMLSliceControllerWidgetTest.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.cxx Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget.h Diff File
mod - Libs/MRML/Widgets/qMRMLSliceControllerWidget_p.h Diff File

2145-support-for-installing-extension-from-file 37da966b

2013-10-02 22:34:14

jcfr

Details Diff
BUG: Fix memory leaks in vtkMRMLModelSliceDisplayableManager

See inlined comment for details.

This commit will also avoid leaks (and by extension ensure they
pass when leaks detection is enabled) in the following tests:
py_NeurosurgicalPlanningTutorial
py_ThresholdThreadingTest
py_NeurosurgicalPlanningTutorial
py_ScenePerformance

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22571 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/DisplayableManager/vtkMRMLModelSliceDisplayableManager.cxx Diff File

2145-support-for-installing-extension-from-file d8f46c07

2013-10-02 22:34:11

jcfr

Details Diff
BUG: Prevent leaks when factory methods are used from python

There is currently no automatic/clean mechanism to release the object
created by factory methods.

The only "hack" that exists for now is to decrease the reference
count manually in your code:

For more details, see [1], [2], [3] and [4]

[1] http://wiki.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/MemoryManagement
[2] http://massmail.spl.harvard.edu/public-archives/slicer-devel/2011/007513.html
[3] http://www.vtk.org/Bug/view.php?id=12139
[4] http://www.vtk.org/pipermail/vtk-developers/2011-April/009757.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22570 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/ScenePerformance.py Diff File
mod - Base/Python/sitkUtils.py Diff File

2145-support-for-installing-extension-from-file d37c07e8

2013-10-02 22:34:08

jcfr

Details Diff
BUG: Fix vtkObserverManager warning happening after loading a file.

This commit ensured that the observer associated with MRMLNodesCallbackCommand
are removed also if the file is successfully loaded.

Warning: In /home/jchris/Projects/Slicer/Libs/MRML/Core/vtkObserverManager.cxx, line 59
vtkObserverManager (0x3b99ce0): The callback is not deleted because there
are still some observation. They seem to not have been registered into
the event broker.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22569 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Volumes/Logic/vtkSlicerVolumesLogic.cxx Diff File
 First  Prev  1 2 3 ... 9 10 11 12 13 14 15 ... 20 ... 30 ... 40 ... 50 ... 55 56 57  Next  Last