View Issue Details

IDProjectCategoryView StatusLast Update
0003397Slicer4Module Markupspublic2017-06-07 23:27
Reporterfedorov Assigned Tonicole  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003397: "Copy" fidicial across lists
Description

Currently, only "move" is available.

TagsNo tags attached.

Activities

nicole

nicole

2013-10-09 06:49

administrator   ~0010160

I have a first implementation, but wanted to double check: for the location of the markup in the destination list, is the bottom of the list okay, or would you suggest putting it at the top?
And you mentioned wanting to have the Move functionality simplified, I was going to change that to use the same destination location as Copy.

fedorov

fedorov

2013-10-09 06:52

developer   ~0010161

I think adding to the bottom makes sense. There is a function to move fiducials in the list, so this use case is covered. By the way, would it make sense to put "move" buttons in the same row as visible and delete? Not sure they belong to Advanced.

nicole

nicole

2013-10-09 09:38

administrator   ~0010162

Ron specified the location of the move buttons, and since they're at the top of the Advanced panel they're easy to have accessible while looking at the table.

nicole

nicole

2013-10-09 09:41

administrator   ~0010163

Checked into my github, if it looks good to you, will move it over to svn:
https://github.com/naucoin/Slicer/commits/3397-copy-fiducial-across-lists

fedorov

fedorov

2013-10-09 09:43

developer   ~0010164

Well, this GUI design approach relies on 2 assumptions:

1) the user knows "move" functionality exists
2) the user knows to look in the "Advanced" menu

Just something to keep in mind.

fedorov

fedorov

2013-10-09 10:21

developer   ~0010165

Looks good to me.

Regarding the GUI design and usability - all I can do is provide you feedback based on my experience and based on my interaction with clinical users. You guys decide what to do with this feedback.

nicole

nicole

2013-10-09 10:52

administrator   ~0010166

I do appreciate the feedback, and your point via email about use cases is one that I'm keeping in mind. I want to avoid the situation where one group drives the design so much that it becomes hard to use for other groups.
The constraints of the 4.x module panel make it a delicate balancing act as to what to show and what to hide for the default GUI - I want to show everything, Ron would only show one button. :-) I'm hoping that with enough help panel hints, tool tips, wiki pages, mailing list posts, and tutorials that at least one source of information will get to users who go looking for it so that the hidden options can be found without too much trouble. It's definitely a work in progress!

fedorov

fedorov

2013-10-09 10:56

developer   ~0010167

Ok. FYI, I am happy to meet with you and Ron to discuss the usability issues of the Markups module. If there are breakouts/discussion involving other groups, I am happy to present my case and see why it is not compatible with those of others.

nicole

nicole

2013-10-09 12:04

administrator   ~0010168

Will you be going to Project Week in SLC? I want to have a breakout there now that people have had a chance to use it.

nicole

nicole

2013-10-09 12:48

administrator   ~0010169

Checked in as svn 22608
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22608

jcfr

jcfr

2013-10-21 06:07

administrator   ~0010202

Last edited: 2013-10-21 06:07

Backported to Slicer-4-3 branch.

See:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22624
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22625

jcfr

jcfr

2014-03-06 05:00

administrator   ~0010879

Closing resolved issues that have not been updated in more than 3 months

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file af89f029

2013-10-09 16:42:18

naucoin

Details Diff
ENH: add copy to markups list right click option

Can now right click on a markup in the GUI and copy it
to another list, placing it at the end of the destination
list.
Updated the right click Move option to only offer at the
end of the list as that simplifies the UI and users can
move the markups with the move up/down buttons.
Updated test for logic copy.
Updated documentation for copy.

Issue 0003397



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22608 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Documentation/Markups.xml Diff File
mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.cxx Diff File
mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.h Diff File
mod - Modules/Loadable/Markups/Testing/Cxx/vtkSlicerMarkupsLogicTest2.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.h Diff File

Slicer: 2145-support-for-installing-extension-from-file 599b6e42

2013-10-09 17:11:54

naucoin

Details Diff
STYLE: updated tool tip for markups table

Add a tool tip to hint at the right click context menu.

Issue 0003397



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22609 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/Resources/UI/qSlicerMarkupsModule.ui Diff File

Issue History

Date Modified Username Field Change
2013-09-15 17:40 fedorov New Issue
2013-09-15 17:40 fedorov Status new => assigned
2013-09-15 17:40 fedorov Assigned To => nicole
2013-10-09 06:49 nicole Note Added: 0010160
2013-10-09 06:52 fedorov Note Added: 0010161
2013-10-09 09:38 nicole Note Added: 0010162
2013-10-09 09:41 nicole Note Added: 0010163
2013-10-09 09:43 fedorov Note Added: 0010164
2013-10-09 10:21 fedorov Note Added: 0010165
2013-10-09 10:52 nicole Note Added: 0010166
2013-10-09 10:56 fedorov Note Added: 0010167
2013-10-09 12:04 nicole Note Added: 0010168
2013-10-09 12:48 nicole Note Added: 0010169
2013-10-09 12:48 nicole Status assigned => resolved
2013-10-09 12:48 nicole Fixed in Version => Slicer 4.3.2
2013-10-09 12:48 nicole Resolution open => fixed
2013-10-21 06:07 jcfr Target Version => Slicer 4.3.2
2013-10-21 06:07 jcfr Note Added: 0010202
2013-10-21 06:07 jcfr Note Edited: 0010202
2014-03-06 05:00 jcfr Note Added: 0010879
2014-03-06 05:01 jcfr Status resolved => closed
2014-03-06 10:16 nicole Target Version Slicer 4.3.2 => Slicer 4.4.0
2014-03-06 10:17 nicole Fixed in Version Slicer 4.3.2 => Slicer 4.4.0
2017-06-07 23:27 Changeset attached => Slicer 2145-support-for-installing-extension-from-file 599b6e42
2017-06-07 23:27 Changeset attached => Slicer 2145-support-for-installing-extension-from-file af89f029