Changesets: Import 2017-06-07 23:51:09

Search Browse Back to Index

master ea356afb

2016-06-03 01:16:11

jcfr

Details Diff 		BUG: slicer.util.GetNodes: Support multiple node with same name. Fix 0004186

If multiple nodes share the same name, only the last node with that name
will be returned. A new parameter has been added to return a dictionary
containing, for each node name, a list of nodes, to avoid returning only
the last node with a specific name.

From: Francois Budin <francois.budin@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25155 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/tests/test_slicer_util_getNodes.py Diff File
mod - Base/Python/slicer/util.py Diff File

master 9f256ff2

2016-06-03 01:16:09

jcfr

Details Diff 		STYLE: getNodes test: Improve error reporting using specific assert

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25154 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/tests/test_slicer_util_getNodes.py Diff File

master 45052523

2016-06-03 01:16:07

jcfr

Details Diff 		BUG: slicer.util.getNodes/getNode: Keep dict entry ordered. See 0004201

Since method "getNode()" allows to specify an index parameter
corresponding to the index in the scene, it is importent to keep
the dictionary entries ordered.

co-authored-by: Francois Budin <francois.budin@gmail.com>

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25153 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/tests/test_slicer_util_getNodes.py Diff File
mod - Base/Python/slicer/util.py Diff File

master 56122369

2016-06-03 01:16:05

jcfr

Details Diff 		COMP: vtkSlicerTablesLogic: Fix -Wconversion-null warning

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25152 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Tables/Logic/vtkSlicerTablesLogic.cxx Diff File

master 380bf1fb

2016-06-02 23:44:09

jcfr

Details Diff 		STYLE: Improve documentation of GetFirstNode()

GetFirstNode third parameter "byHideFromEditor" was not explained
in the doxygen documentation. It did not seem intuitive to have
a parameter that is a pointer when one might expect to specify a
boolean. The new doxygen string explains that this is a 3-state
variable that is either disregarded if the pointer is set to 0,
or the function only returns a node that matches the given value
(hidden from editor or not).

From: Francois Budin <francois.budin@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25151 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLScene.h Diff File

master 8305abca

2016-06-02 23:40:03

jcfr

Details Diff 		BUG: Fix LandmarkRegistration test updating slicer.util.getNode. See 0004201

This commit fixes a regression introduced in r25140 (BUG: slicer.util.getNodes:
Return MRML nodes by default. Fixes 0004201)

The method "getNode()" should *NOT* return a node if an empty pattern
is provided.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25150 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File
mod - Base/Python/slicer/tests/test_slicer_util_getNodes.py Diff File
mod - Base/Python/slicer/util.py Diff File

master f2c4ec71

2016-06-02 02:49:25

jcfr

Details Diff 		ENH: Add option "--application-information"

By default, do not print application information to standard output, only
log it to file.

If the application is started with `--application-information`, information
will also be displayed in the terminal.

To remain consistent with existing option displaying information in
the terminal (e.g --home, --settings-path, ...), the option has been
named "--application-information".

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25149 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Cpp/CMakeLists.txt Diff File
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File
mod - Base/QTCore/qSlicerCoreCommandOptions.cxx Diff File
mod - Base/QTCore/qSlicerCoreCommandOptions.h Diff File
mod - Base/QTGUI/qSlicerApplication.cxx Diff File
mod - Base/QTGUI/qSlicerApplication.h Diff File

master 4d968d53

2016-06-02 02:49:22

jcfr

Details Diff 		STYLE: Fix typo in displayApplicationInformation function name.

"In native-speaker norms, information is a non-count noun, so the
convention is that information is both singular and plural."
Source: http://english.stackexchange.com/questions/117552/why-does-information-not-have-a-plural-form

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25148 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File
mod - Base/QTGUI/qSlicerApplication.h Diff File

master ad49b576

2016-06-01 23:36:07

jcfr

Details Diff 		ENH: Add configure time check that CMake supports HTTPS

Some build targets require downloading files using the HTTPS protocol. Before
this commit, targets such as 'python-source' would fail during the build process
with errors like:

CMake Error at python-source-prefix/src/python-source-stamp/download-python-source.cmake:27 (message):
error: downloading
'https://www.python.org/ftp/python/2.7.11/Python-2.7.11.tgz' failed

status_code: 1
status_string: "Unsupported protocol"
log: Protocol "https" not supported or disabled in libcurl

This commit adds a configure-time check that CMake supports HTTPS. Now,
developers are made aware of the problem before building. If https is
supported it displays:

-- Checking if CMake supports https
-- Checking if CMake supports https - ok

If CMake doesn't support HTTPS, the configuration step now fails with a
descriptive error message and a suggested solution:

CMake Error at CMake/SlicerCheckCMakeHTTPS.cmake:21 (message):
error: This CMake does not support the HTTPS protocol. Ensure that CMake
is compiled with CMAKE_USE_OPENSSL enabled.

Fixes http://www.na-mic.org/Bug/view.php?id=4098

From: Max Smolens <max.smolens@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25147 3bd1e089-480b-0410-8dfb-8563597acbee
add - CMake/SlicerCheckCMakeHTTPS.cmake Diff File
mod - SuperBuild.cmake Diff File

master a501a57a

2016-06-01 23:24:43

jcfr

Details Diff 		BUG: Remove duplicate file browse button for CLI UIs. Fixes 0002763

The regression was originally introduced in commontk/CTK@0de5ad0
where ctkPathLineEdit was enhanced with a browse button visible
by default.

From: Tim Thirion <tim.thirion@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25146 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/qSlicerCLIModuleUIHelper.cxx Diff File

master f7e724f7

2016-06-01 23:12:42

jcfr

Details Diff 		ENH: Add SlicerCreateRulerCrashIssue4199 test. See 0004199

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25145 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File
add - Applications/SlicerApp/Testing/Python/SlicerCreateRulerCrashIssue4199.py Diff File

master 3bbcc1ed

2016-06-01 23:12:40

jcfr

Details Diff 		ENH: Add SlicerRestoreSceneViewCrashIssue3445 test. See 0003445

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25144 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File
add - Applications/SlicerApp/Testing/Python/SlicerRestoreSceneViewCrashIssue3445.py Diff File

master a3f241ec

2016-06-01 23:12:38

jcfr

Details Diff 		BUG: Remove invalid assert while populating the scene. Fixes 0003445, 0004199

This commit fixes a regression introduced in r25049 (COMP: qMRMLSceneModel:
Fix -Woverloaded-virtual and add comment.)

The assert was checking whether the index of the current node
matches the row count. However, while inserting nodes, the
logic adds a parent node if there isn't one. This insertion of
parent node increments the RowCache size. Next time the assert
was encountered, it would fail.

From: Sankhesh Jhaveri <sankhesh.jhaveri@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25143 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLSceneModel.cxx Diff File

master e1467b2a

2016-06-01 15:24:56

jcfr

Details Diff 		BUG: Fix display of CPU properties in application info. Fixes 0004176

Instead of explicitly computing the frequency and displaying the number
of cores, this commit updates the function "qSlicerApplication::displayApplicationInformations"
to:

* display the model name: The model name provides CPU vendor specific model and clock
frequency in GHz.

* the number of logical processors.

Since the processor has a variable frequency (e.g. from 2.90GHz to 3.8 GHz
for the Intel E3-1535M), calling "GetProcessorClockFrequency()"
was returning a different result for each call.

Before:
CPU ......................: GenuineIntel 3.579 MHz, 1 cores

After:
CPU ......................: GenuineIntel Intel(R) Xeon(R) CPU E3-1535M v5 @ 2.90GHz, 1 cores, 8 logical processors

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Sankhesh Jhaveri <sankhesh.jhaveri@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25142 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerApplication.cxx Diff File

master f9533462

2016-06-01 15:24:55

jcfr

Details Diff 		ENH: vtkSystemInformation: Add API to retrieve processor model name

vtkSystemInformation can now be queried for CPU model name along
with vendor. This reports the actual model type along with the
clock frequency on most systems.

See 0004176

From: Sankhesh Jhaveri <sankhesh.jhaveri@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25141 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Logic/vtkSystemInformation.cxx Diff File
mod - Base/Logic/vtkSystemInformation.h Diff File

master c32a44f7

2016-06-01 12:28:14

jcfr

Details Diff 		BUG: slicer.util.getNodes: Return MRML nodes by default. Fixes 0004201

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25140 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/CMakeLists.txt Diff File
add - Base/Python/slicer/tests/test_slicer_util_getNodes.py Diff File
mod - Base/Python/slicer/util.py Diff File

master d391d007

2016-06-01 11:39:13

jcfr

Details Diff 		BUG: Fix SubjectHierarchy generic tests

This commit fixes a regression introduced in r25128 (STYLE: Simplify
import of Logic/MRML/DisplayableManager python modules)

$ ctest -R py_SubjectHierarchy
Test project /home/jcfr/Projects/Slicer-Release/Slicer-build
Start 592: py_SubjectHierarchyGenericSelfTest
1/2 Test 0000592: py_SubjectHierarchyGenericSelfTest ....... Passed 7.27 sec
Start 593: py_SubjectHierarchyCorePluginsSelfTest
2/2 Test 0000593: py_SubjectHierarchyCorePluginsSelfTest ... Passed 5.37 sec

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25139 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/SubjectHierarchyCorePluginsSelfTest.py Diff File
mod - Applications/SlicerApp/Testing/Python/SubjectHierarchyGenericSelfTest.py Diff File
mod - Modules/Scripted/DICOMLib/DICOMPlugin.py Diff File

master b523eb1b

2016-05-31 18:09:49

jcfr

Details Diff 		PERF: Improve startup time by 0000012:0000025% delaying import of SimpleITK

Startup time reduced from 5.1s to 3.8s (cold cache)

Stats obtained after averaging values obtained after 5 runs clearing
the file cache between runs. The following command was used:

~/Projects/Slicer/Applications/SlicerApp/Testing/Python/MeasureStartupTimes.py --drop-cache -n5 --normal ./Slicer

With a warm cache, it improve the startup time by 0000021:0000032% (4s -> 2.7s)

Results have been gathered on Ubuntu 15.10 on a workstation with the
following specs: 64GB / M.2 PCIe NVMe SSD / Quad Core 3.80GHz

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25138 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 276fc561

2016-05-31 17:21:10

jcfr

Details Diff 		BUG: Ensure extension python wrapped modules can be loaded

This commit fixes a regression introduced in r25128 (STYLE: Simplify
import of Logic/MRML/DisplayableManager python modules)

Reported-by: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25137 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerLoadableModule.cxx Diff File

master 5e2d1ee7

2016-05-31 13:39:39

lassoan

Details Diff 		BUG: Fixed missing slicer namespace in SlicerApplicationLogHandler

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25136 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/slicerqt.py Diff File

master 85d8cf01

2016-05-31 03:44:59

jcfr

Details Diff 		BUG: Update EMSegment to include simpler import of python modules

This commit updates EMSegment to include updates required after
commit r25128 (STYLE: Simplify import of Logic/MRML/DisplayableManager
python modules)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25135 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master ab4521d4

2016-05-31 02:11:46

jcfr

Details Diff 		PERF: Speedup loading of modules including Editor effects

Loading time improved by 0000041:0000045% (2.6s -> 1.4s, warm cache)
for the following modules:

* Editor
* ThresholdThreadingTest
* SlicerMRBMultipleSaveRestoreTest
* SlicerMRBMultipleSaveRestoreLoopTest
* NeurosurgicalPlanningTutorialMarkupsSelfTest

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25134 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/WatershedFromMarkerEffect.py Diff File

master 837364a3

2016-05-31 02:11:45

jcfr

Details Diff 		PERF: Speedup loading of SlicerMRBTest removing unneeded EditorLib import

Improve the loading time of the SlicerMRBTest module by 0000030:0000050% (2.6s -> 1.2s, warm cache)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25133 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/SlicerMRBTest.py Diff File

master ade6b71a

2016-05-31 02:11:43

jcfr

Details Diff 		ENH: MeasureStartupTimes: Add --display-slicer-output option

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25132 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/MeasureStartupTimes.py Diff File

master a3f80903

2016-05-31 02:11:41

jcfr

Details Diff 		ENH: MeasureStartupTimes: Add --reuse-module-list option

Add convenience option allowing to reuse existing 'Modules.json' file,
it allows to more quickly get feedback without having to wait for
the function "collect_modules" to complete.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25131 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Applications/SlicerApp/Testing/Python/MeasureStartupTimes.py Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 34 35 36 37 38 39 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last