Changesets: Import 2017-06-07 23:51:09

Search Browse Back to Index

master 2cc5425d

2014-09-17 08:40:40

jcfr

Details Diff 		ENH: Do not set workaround to associate scalar with input tensor field.

This is not required when using VTK6.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23692 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/TractographyInteractiveSeeding/Logic/vtkSlicerTractographyInteractiveSeedingLogic.cxx Diff File

master f0395951

2014-09-17 08:40:38

jcfr

Details Diff 		STYLE: Remove commented code from Tractography seeding modules

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23691 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/TractographyLabelMapSeeding/TractographyLabelMapSeeding.cxx Diff File
mod - Modules/Loadable/TractographyInteractiveSeeding/Logic/vtkSlicerTractographyInteractiveSeedingLogic.cxx Diff File

master bf136622

2014-09-17 08:40:36

jcfr

Details Diff 		BUG: Re-organize tractography seeding pipeline to work with VTK6. See 0003845

This commit fixes pipeline incorrectly setup in r23121 by using output
port instead pipeline information (InputROIPipelineInfo)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23690 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkTeem/vtkSeedTracts.cxx Diff File
mod - Libs/vtkTeem/vtkSeedTracts.h Diff File
mod - Modules/CLI/TractographyLabelMapSeeding/TractographyLabelMapSeeding.cxx Diff File
mod - Modules/Loadable/TractographyInteractiveSeeding/Logic/vtkSlicerTractographyInteractiveSeedingLogic.cxx Diff File

master 7cb842a1

2014-09-17 08:40:33

jcfr

Details Diff 		STYLE: Remove unused code from vtkSeedTracts

Extent from the input tensor field was not used.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23689 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkTeem/vtkSeedTracts.cxx Diff File

master 21091f7a

2014-09-17 08:40:32

jcfr

Details Diff 		ENH: Remove unused and outdated tcl scripts.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23688 3bd1e089-480b-0410-8dfb-8563597acbee
rm - Testing/BigArrayTest.tcl Diff File
rm - Testing/BigImageTest.tcl Diff File
mod - Testing/ImageFlipTest.tcl Diff File
rm - Testing/ModelRender.tcl Diff File
rm - Testing/MultiColumnListTest.tcl Diff File

master 06257c75

2014-09-16 17:11:52

lassoan

Details Diff 		ENH: Added helper methods to ScriptedLoadableModuleLogic for managing parameter nodes

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23687 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/ScriptedLoadableModule.py Diff File

master c512510f

2014-09-16 03:24:05

jcfr

Details Diff 		BUG: Fix qMRMLVolumePropertyNodeWidgetTest1

This commit fixes the failing test by ensuring the vtkRenderingContextOpenGL
module is initialized.

The following error was occurring on all three platforms:

// ----------
Generic Warning: In /path/to/VTKv6/Rendering/Context2D/vtkContextDevice2D.cxx, line 27
Error: no override found for 'vtkContextDevice2D'.
// ----------

For more details, see:
http://www.vtk.org/Wiki/VTK/Build_System_Migration#How_Implementation_Modules_Are_Initialized
http://www.vtk.org/Wiki/VTK/VTK_6_Migration/Factories_now_require_defines


Finally, let's also note that the test executable was compiled with:

-DvtkRenderingContext2D_AUTOINIT="1(vtkRenderingContextOpenGL)"
-DvtkRenderingCore_AUTOINIT="4(vtkInteractionStyle,vtkRenderingFreeType,vtkRenderingFreeTypeOpenGL,vtkRenderingOpenGL)"
-DvtkRenderingFreeType_AUTOINIT="1(vtkRenderingFreeTypeFontConfig)"
-DvtkRenderingVolume_AUTOINIT="1(vtkRenderingVolumeOpenGL)"

and was linked against vtkRenderingContextOpenGL.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23686 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/VolumeRendering/Testing/Cxx/qMRMLVolumePropertyNodeWidgetTest1.cxx Diff File

master f847a4dd

2014-09-15 23:50:18

jcfr

Details Diff 		COMP: Update ModelToLabelMap and remove unused dependency to ITKDeprecated

In r23660, the dependency to AnalyzeImageIO headers has been removed.
This commit also removes the now unneeded dependency to "ITKDeprecated".

Thanks to "Gib Bogle <g.bogle@auckland.ac.nz>" for reporting the problem.

Co-authored-by: Bradley Lowekamp <blowekamp@mail.nih.gov>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23685 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/ModelToLabelMap/CMakeLists.txt Diff File

master 4dd6d3c0

2014-09-15 23:28:40

jcfr

Details Diff 		BUG: Fix OtsuThresholdImageFilterTest on Windows

This commit ensures that "SEM_LAUNCH_COMMAND" variable will be defined
for both CLIs and remote modules.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23684 3bd1e089-480b-0410-8dfb-8563597acbee
mod - CMakeLists.txt Diff File
mod - Modules/CLI/CMakeLists.txt Diff File

master ec73ff9d

2014-09-15 23:18:00

jcfr

Details Diff 		BUG: Update EMSegment to fix EMSeg_SlicerCommonInterfaceTestGeneral test

This commit ensures the ITK IO factory associated with
executable vtkSlicerCommonInterfaceTest are registered.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23683 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master eea9a841

2014-09-15 22:57:09

jcfr

Details Diff 		COMP: Remove unused dependency to ITKDeprecated from ResampleDTIVolume

The dependency was probably added by "mistake" when the module
"Utilities/Maintenance/WhatModulesITK.py" was used to create the list of
dependent modules (r23413). Since the header "itkSemaphore.h" was
specified in the code but was commented, "WhatModulesITK" reported its
associated module ITKDeprecated as required.

This commit removes the commented code and updates the CMakeLists.txt

Thanks to "Gib Bogle <g.bogle@auckland.ac.nz>" for reporting the problem.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23682 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/CLI/ResampleDTIVolume/CMakeLists.txt Diff File
mod - Modules/CLI/ResampleDTIVolume/itkDiffusionTensor3DInterpolateImageFunctionReimplementation.h Diff File

master 4dcdb416

2014-09-15 20:51:29

lassoan

Details Diff 		BUG: Fixed ExtensionWizard immediate scripted module loading

Problem was that settingsList returned a tuple, which is not mutable and therefore rawSearchPaths.append failed.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23681 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/ExtensionWizard/ExtensionWizard.py Diff File

master 06693909

2014-09-15 18:00:44

pieper

Details Diff 		BUG: 0003846 fixes crash when trying to use label map seeding

With the change to VTKv6 some member variables can be null, probably
due to the tensor pipeline not being correctly initialized.

This avoids the crash, but issue 0003846 is not fixed (tractography
does not work).

From: Steve Pieper <pieper@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23680 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkTeem/vtkSeedTracts.cxx Diff File

master f76d94f0

2014-09-15 15:34:18

jcfr

Details Diff 		COMP: Update BRAINStools to include fixes for shadowed declarations.

$ git shortlog 868c290d..6f9986
Jean-Christophe Fillion-Robin (2):
Revert "COMP: Fix unused variable warning in BRAINSFitHelperTemplate"
Revert "COMP: Fix shadowed declaration warning"

Kent Williams (2):
COMP: Removed deprecated V3 filters
COMP: Remove shadow declaration warnings

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23679 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 7fea3f2c

2014-09-15 11:49:04

jcfr

Details Diff 		COMP: Update BRAINSTools - Remove ITKv3 compatibility / Tweak BRAINSFit.xml

See 0003829

$ git shortlog slicer-2014-08-27-6b15c2b..slicer-2014-09-15-411dee9
David Welch (2):
ENH: Modified atlas xml name
ENH: Added print statement to diagnose missing sentinal file

Hans Johnson (6):
BUG: Uniformly apply modify_qsub_args for configuring qsub_args.
BUG: Fixed logic for set notation.
PERF: Fixed job submission logic to speed job start.
BUG: Add consistent use-sentinal file.
ENH: Added missing __init__.py file for SEMTools module.
ENH: Per requests of the slicer community, defaults changed.

Jean-Christophe Fillion-Robin (2):
Revert "COMP: fine-tune VTK dependencies"
Revert "COMP: move find_package(VTK) down to individual project directories"

Kent Williams (3):
COMP: Allow BRAINSTransformConvert without output transform file
COMP: Remove global declarations from GenericTransformImage.h
COMP: remove ITKV3_COMPATIBILITY entireley

Regina Kim (3):
ENH: Allow template building to only do new files
ENH: Add code for identifying the brain stem
BUG: ATLAS_DIRECTORY to ATLAS_INSTALLING_DIRECTORY

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23678 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild.cmake Diff File

master 9f942aa1

2014-09-14 20:52:48

jcfr

Details Diff 		BUG: Ensure volume node without default storage node can be saved.

This commit allows volume to be saved from python using
"slicer.util.saveNode()".

More specifically, this commit (1) factors out the code allowing to
create and add the default storage node to the scene and (2) ensures a
call to "qSlicerCoreIOManager::saveNodes" work when there are no storage
node associated with a volume node.

This is needed because within the "saveNodes" function, calling the
function "qSlicerNodeWriter::extensions(node)" expects a storage node
to be present.

Thanks to Julien Finet for reviewing.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23677 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerCoreIOManager.cxx Diff File
mod - Base/QTCore/qSlicerCoreIOManager.h Diff File
mod - Base/QTGUI/qSlicerNodeWriter.cxx Diff File

master 11a9576c

2014-09-14 07:28:09

jcfr

Details Diff 		ENH: Added icon loading for scripted module base class

Python scripted modules that use the ScriptedLoadableModule base class
now load their icon from Resources/Icons/<ModuleName>.png.
If the icon file does not exist then the default icon is kept.
Modules can override the icon setting in the module __init__ function to
use any other custom icon.

Updated extension wizard template and extension test.

Updated one more module (VectorToScalarVolume) to use
ScriptedLoadableModule base class.

From: Andras Lasso <lasso@queensu.ca>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23676 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/Python/slicer/ScriptedLoadableModule.py Diff File
mod - Extensions/Testing/ScriptedLoadableExtensionTemplate/ScriptedLoadableModuleTemplate/CMakeLists.txt Diff File
mod - Modules/Scripted/VectorToScalarVolume/VectorToScalarVolume.py Diff File
mod - Utilities/Templates/Modules/Scripted/CMakeLists.txt Diff File

master 7a3a55a7

2014-09-12 23:07:33

jcfr

Details Diff 		ENH: Fixed color scalar bar by using vtkPVScalarBarActor

* Color scalar bar was enhanced and the bugs were fixed by adding Paraview vtkPVScalarBarActor to module's logic
* Replaced vtkScalarBarActor with vtkPVScalarBarActor
* Made the logic sensitive to dicom volume. (for none dicom volumes the
color scalar bar would occupy 100% of the view's width)
* Change the format of foreground volume and label opacities to percentage
(e.g. from 0.4 to 40%)

From: Alireza Mehrtash <mehrtash@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23675 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/DataProbe/CMakeLists.txt Diff File
mod - Modules/Scripted/DataProbe/DataProbeLib/SliceViewAnnotations.py Diff File
add - Modules/Scripted/DataProbe/Logic/CMakeLists.txt Diff File
add - Modules/Scripted/DataProbe/Logic/vtkPVScalarBarActor.cxx Diff File
add - Modules/Scripted/DataProbe/Logic/vtkPVScalarBarActor.h Diff File

master 4ddf3c33

2014-09-12 23:07:29

jcfr

Details Diff 		STYLE: Display a warning message if no writers is found when using saveNodes

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23674 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCore/qSlicerCoreIOManager.cxx Diff File

master 404f01a1

2014-09-12 23:07:26

jcfr

Details Diff 		COMP: Slicer welcome: Fix location of qrc files in UI file.

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23673 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SlicerWelcome/Resources/UI/qSlicerWelcomeModuleWidget.ui Diff File

master 262acf03

2014-09-12 01:30:49

jcfr

Details Diff 		ENH: Update AddMarkup/Fiducial API to optionally accept the label.

When calling the AddMarkup/AddFiducial method, a default
label is associated. That said, it is not uncommon to create markup
or fiducial with a custom label.

For example, within a python script, before this commit, the following
could be done to add a fiducial and set its label:

fiducialIndex = markups.AddFiducial(x, y, z)
markups.SetNthMarkupLabel(fiducialIndex, "Foo")

The first issue is that the event 'MarkupAddedEvent' was triggered before the
label was set. Since when the markup is added an hypothetical callback
could retrieve other data structure based on the label, it is more
complex to do the book-keeping if the callback can't make use of the
label.

This commit ensures that callback connected to "MarkupAddedEvent" will
be able to get the custom label value.

The second issue is that the "Markup" structure is not wrapped in python.
That means it is not possible to pre-initialize a markup structure
before adding it using "AddMarkup(Markup markup)"

Note that ideally, it should be possible to pass other properties
to initialize the markup in python or c++ before the "MarkupAddedEvent"
is invoked. This commit is a trade-off between changing the Markup
structure into a more heavy weight vtkObject (so that it is wrapped) and
not being able to set the label before "MarkupAddedEvent" is invoked.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23672 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsFiducialNode.cxx Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsFiducialNode.h Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.h Diff File

master f163743f

2014-09-12 01:05:44

jcfr

Details Diff 		ENH: Change 'AddMarkup' to also return the markupIndex on success.

This commit updates the function 'AddMarkup' to behave similarly
to 'AddMarkupWithNPoints' function.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23671 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.h Diff File

master ff74aefa

2014-09-11 16:33:00

naucoin

Details Diff 		BUG: fix crash when showing transformed markups

The module widget was getting the world coordinates by passing in a 3
element array, not a 4 element array. On some machines this was
triggering a crash. This fix avoids that by properly passing
a four element point array and then reassigning the values to
the three element array for display.

Issue 0003756

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23670 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/qSlicerMarkupsModuleWidget.cxx Diff File

master f2f1a3e8

2014-09-11 16:04:24

jcfr

Details Diff 		BUG: Consistently invoke MarkupAddedEvent specifying the markup index.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23669 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File

master 8156cafa

2014-09-11 15:40:59

naucoin

Details Diff 		BUG: fixing fiducial projections

Turning them on for the first time was causing a null pointer crash in the
VTK 6 rendering pipeline. The glyph source hadn't been updated and the points
were undefined in the default circle glyph.

Also call the displayable manager superclass on scene close to ensure that the
fiducial projections are removed from the render window.

Issue 0003821

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23668 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsFiducialDisplayableManager2D.cxx Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 92 93 94 95 96 97 98 ... 100 ... 110 ... 120 ... 130 ... 133 134 135  Next  Last