View Issue Details

IDProjectCategoryView StatusLast Update
0003845Slicer4Core: Diffusion and Tractography (Any modules)public2017-06-10 08:51
Reporterpieper Assigned Toalexy  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
PlatformallOSOS Version
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003845: label map tractography is broken (probably a vtk6 issue)
Description

The label map seeding tractography function is broken

Steps To Reproduce

Run the NeurosurgicalPlanningTutorialMarkupsSelfTest.

Change to the Anterior view in the 3D Viewer. See that tracts which should be present are missing. See the attached image to see the missing tracts.

TagsNo tags attached.

Relationships

related to 0003846 closedpieper slicer crashes when trying to do label map seeding 
related to 0003349 closedjcfr Fix pipeline for glyphing 

Activities

2014-09-15 14:07

 

neurosurgery-regression.png (700,278 bytes)
neurosurgery-regression.png (700,278 bytes)
pieper

pieper

2014-09-15 14:25

administrator   ~0012515

Last edited: 2014-09-15 14:26

When running the CLI you get error messages that do not appear in the 4.3.1 release version.

Tractography Label Map Seeding standard output:

0 / 50
0.769231 / 50
1.53846 / 50
2.30769 / 50
3.07692 / 50
3.84615 / 50
4.61538 / 50
5.38462 / 50
6.15385 / 50
6.92308 / 50
7.69231 / 50
8.46154 / 50
9.23077 / 50
10 / 50
10.7692 / 50
11.5385 / 50
12.3077 / 50
13.0769 / 50
13.8462 / 50
14.6154 / 50
15.3846 / 50
16.1538 / 50
16.9231 / 50
point -7.573 91.278 37.7412 outside of tensor dataset
point -5.573 89.278 37.7412 outside of tensor dataset
point -7.573 89.278 37.7412 outside of tensor dataset
17.6923 / 50
point -9.573 101.278 39.7412 outside of tensor dataset
point -9.573 99.278 39.7412 outside of tensor dataset
point -11.573 99.278 39.7412 outside of tensor dataset
point -7.573 97.278 39.7412 outside of tensor dataset
point -9.573 97.278 39.7412 outside of tensor dataset
point -11.573 97.278 39.7412 outside of tensor dataset
point -7.573 95.278 39.7412 outside of tensor dataset
point -9.573 95.278 39.7412 outside of tensor dataset
point -11.573 95.278 39.7412 outside of tensor dataset
point -7.573 93.278 39.7412 outside of tensor dataset
point -9.573 93.278 39.7412 outside of tensor dataset
point -11.573 93.278 39.7412 outside of tensor dataset
point -5.573 91.278 39.7412 outside of tensor dataset
point -7.573 91.278 39.7412 outside of tensor dataset
point -9.573 91.278 39.7412 outside of tensor dataset
point -11.573 91.278 39.7412 outside of tensor dataset
point -13.573 91.278 39.7412 outside of tensor dataset
point -5.573 89.278 39.7412 outside of tensor dataset
point -7.573 89.278 39.7412 outside of tensor dataset
point -9.573 89.278 39.7412 outside of tensor dataset
point -11.573 89.278 39.7412 outside of tensor dataset
point -13.573 89.278 39.7412 outside of tensor dataset
point -3.573 87.278 39.7412 outside of tensor dataset
...

(many more)

jcfr

jcfr

2014-09-17 01:59

administrator   ~0012517

This is fixed by the following topic: https://github.com/jcfr/Slicer/compare/3845-fix-tractography-label-map-seeding

pieper

pieper

2014-09-17 03:10

administrator   ~0012518

Awesome Jc! Will test this morning.

jcfr

jcfr

2014-09-17 04:07

administrator   ~0012520

Thanks.

I tested both the CLI label map and interactive tractography seeding.

While it works, the interactive seeding is slower that with 4.3.1. Now optimizing, will push an updated topic shortly.

pieper

pieper

2014-09-17 04:26

administrator   ~0012522

Confirmed that your branch works.

Tested:

commit 754cf24bfb3c320c1f047ab503cbdcc638c59cfa
Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Date: Wed Sep 17 05:44:15 2014 -0400

BUG: Update diffusion tensor reader to force origin/spacing. Fixes 0003845

This commit fixes a regression introduced in r23122 and forces the
origin/spacing for VTK 6 similarly to what was done for VTK 5.
jcfr

jcfr

2014-09-17 04:56

administrator   ~0012523

Thanks Steve for testing.

The topic has been integrated.

Fixed in r23689 -> r23695

http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=23689
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=23690
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=23691
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=23692
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=23693
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=23694
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=23695

pieper

pieper

2014-09-17 06:19

administrator   ~0012524

Thanks!

Related Changesets

Import 2017-06-07 23:51:09: master a31d8b56

2014-09-17 08:40:45

jcfr

Details Diff
BUG: Update diffusion tensor reader to force origin/spacing. Fixes 0003845

This commit fixes a regression introduced in r23122 and forces the
origin/spacing for VTK 6 similarly to what was done for VTK 5.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23695 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/vtkITK/vtkITKArchetypeDiffusionTensorImageReaderFile.cxx Diff File

Issue History

Date Modified Username Field Change
2014-09-15 14:07 pieper New Issue
2014-09-15 14:07 pieper Status new => assigned
2014-09-15 14:07 pieper Assigned To => alexy
2014-09-15 14:07 pieper File Added: neurosurgery-regression.png
2014-09-15 14:10 pieper Relationship added related to 0003846
2014-09-15 14:25 pieper Note Added: 0012515
2014-09-15 14:26 pieper Note Edited: 0012515
2014-09-15 19:26 jcfr Relationship added related to 0003349
2014-09-17 01:59 jcfr Note Added: 0012517
2014-09-17 03:10 pieper Note Added: 0012518
2014-09-17 04:07 jcfr Note Added: 0012520
2014-09-17 04:26 pieper Note Added: 0012522
2014-09-17 04:56 jcfr Note Added: 0012523
2014-09-17 04:56 jcfr Status assigned => resolved
2014-09-17 04:56 jcfr Fixed in Version => Slicer 4.4.0
2014-09-17 04:56 jcfr Resolution open => fixed
2014-09-17 06:19 pieper Note Added: 0012524
2014-09-17 06:19 pieper Status resolved => closed
2015-11-30 17:51 jcfr Category Module TractographyLabelMapSeeding => Module: Any Tractography modules
2016-02-29 14:04 jcfr Category Module Tractography (any modules) => Core: Diffusion & Tractography
2016-02-29 14:05 jcfr Category Core: Diffusion & Tractography => Core: Diffusion & Tractography (Any modules)
2016-06-20 14:14 jcfr Category Core: Diffusion & Tractography (Any modules) => Core: Diffusion and Tractography (Any modules)
2017-06-10 08:51 jcfr Changeset attached => Slicer master a31d8b56