View Issue Details

IDProjectCategoryView StatusLast Update
0003829Slicer4Core: Extensionspublic2018-03-02 11:06
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.5.0-1Fixed in VersionSlicer 4.5.0-1 
Summary0003829: Ensure Extensions are not using ITKV3 Compatibility header
Description

On the factory-south-linu, in the extension index build directory (associated with ExtensionsIndex 6d18a60 of Sept 8, 2014), after removing -build and -prefix directories, running the following one-liner returns the list of extension referencing ITKV3Compatibility headers:

//---------
cd /home/kitware/Dashboards/Nightly/S-0-E-b

ITK_SRC=/home/kitware/Dashboards/Nightly/Slicer-0-build/ITKv4

for f in $(ls -1 $ITK_SRC/Modules/Compatibility/V3Compatibility/include/*.h); do p=$(echo $(basename $f) | cut -d"." -f1); printf "\n"; printf '%.s-' {1..80}; printf "\n"; printf "Searching $p\n"; ack-grep $p; printf "... done\n"; done
//---------

Extension that should be updated are:

  • ChangeTracker/Metrics/DemonsJacobian (because of itkDeformationFieldJacobianDeterminantFilter)

  • MABMIS (because of itkDivideByConstantImageFilter, itkInverseDeformationFieldImageFilter)

  • PkModeling and DTIProcess (because of itkImageToVectorImageFilter)

  • DTIPrep (because of itkKernelFunction)

DISCLAIMER: Since we removed the -build directory ... we didn't search the source code checked out by Superbuild extension.

The detailed listing:


Searching itkAddConstantToImageFilter
... done


Searching itkDeformationFieldJacobianDeterminantFilter
ChangeTracker/Metrics/DemonsJacobian/ChangeTrackerDemonsRegistrationJacobianMetric.cxx
17:#include <itkDeformationFieldJacobianDeterminantFilter.h>
... done


Searching itkDeformationFieldSource
... done


Searching itkDivideByConstantImageFilter
MABMIS/IGR3D_MABMIS_Testing.cxx
45:#include "itkDivideByConstantImageFilter.h"

MABMIS/IGR3D_MABMIS_Training.cxx
45:#include "itkDivideByConstantImageFilter.h"

MABMIS/itkMABMISDeformationFieldFilter.h
14:#include "itkDivideByConstantImageFilter.h"
... done


Searching itkExponentialDeformationFieldImageFilter
... done


Searching itkGradientToMagnitudeImageFilter
... done


Searching itkImageToVectorImageFilter
PkModeling/CLI/itkConcentrationToQuantitativeImageFilter.h
16:#include "itkImageToVectorImageFilter.h"

PkModeling/CLI/itkSignalIntensityToS0ImageFilter.h
14:#include "itkImageToVectorImageFilter.h"

PkModeling/CLI/itkSignalIntensityToConcentrationImageFilter.h
16:#include "itkImageToVectorImageFilter.h"

DTIProcess/Applications/dwiAtlas/DWIOperation.cxx
20:#include <itkImageToVectorImageFilter.h>

DTIProcess/Applications/dwiAtlas/SphericalHarmonicsInterpolationFilter.h
24:#include <itkImageToVectorImageFilter.h>
... done


Searching itkInverseDeformationFieldImageFilter
MABMIS/IGR3D_MABMIS_Testing.cxx
48:#include "itkInverseDeformationFieldImageFilter.h"

MABMIS/IGR3D_MABMIS_Training.cxx
48:#include "itkInverseDeformationFieldImageFilter.h"
... done


Searching itkIterativeInverseDeformationFieldImageFilter
... done


Searching itkKernelFunction
DTIPrep/src/UnivariateEntropyMultiImageMetric.h
24:#include "itkKernelFunction.h"
... done


Searching itkMultiplyByConstantImageFilter
SegmentationAidedRegistration/SegmentationAidedRegistration/lib/utilities.hxx
17:#include "itkMultiplyByConstantImageFilter.h"
244: itkMultiplyByConstantImageFilter_t;
246: typename itkMultiplyByConstantImageFilter_t::Pointer mul = itkMultiplyByConstantImageFilter_t::New();

SegmentationAidedRegistration/SegmentationAidedRegistration/lib/utilities.h
15:#include "itkMultiplyByConstantImageFilter.h"

ErodeDilateLabel/DilateLabel/DilateLabel.cxx
35:#include "itkMultiplyByConstantImageFilter.h"

ErodeDilateLabel/ErodeLabel/ErodeLabel.cxx
35:#include "itkMultiplyByConstantImageFilter.h"

LASegmenter/CLILASegmenter/lib/utilities.hxx
31:#include "itkMultiplyByConstantImageFilter.h"
354: itkMultiplyByConstantImageFilter_t;
356: typename itkMultiplyByConstantImageFilter_t::Pointer mul = itkMultiplyByConstantImageFilter_t::New();

DTIProcess/PrivateLibrary/tensorscalars.cxx
16:#include <itkMultiplyByConstantImageFilter.h>

MABMIS/IGR3D_MABMIS_Testing.cxx
46:#include "itkMultiplyByConstantImageFilter.h"

MABMIS/IGR3D_MABMIS_Training.cxx
46:#include "itkMultiplyByConstantImageFilter.h"

MABMIS/itkMABMISDeformationFieldFilter.h
15:#include "itkMultiplyByConstantImageFilter.h"
... done


Searching itkOtsuThresholdImageCalculator
DTIProcess/Applications/dwiAtlas/dwiAtlas.cxx
59:#include <itkOtsuThresholdImageCalculator.h>

DTIProcess/Applications/dtiestim.cxx
48:#include <itkOtsuThresholdImageCalculator.h>
... done


Searching itkSubtractConstantFromImageFilter
... done


Searching itkTransformToDeformationFieldSource
... done

TagsNo tags attached.

Relationships

child of 0003825 closedjcfr Large tiff files not supported 

Activities

jcfr

jcfr

2014-09-15 08:08

administrator   ~0012513

BRAINSTools dependency to ITKV3Compatibility removed in r23678
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=23678

jcfr

jcfr

2015-05-11 20:23

administrator   ~0013041

Brad Lowekamp contributed patches to most of the extension during Winter project week 2015.
See http://www.na-mic.org/Wiki/index.php/2015_Winter_Project_Week:RemoveITKv3Compatibility

Issue History

Date Modified Username Field Change
2014-09-09 14:11 jcfr New Issue
2014-09-09 14:11 jcfr Status new => assigned
2014-09-09 14:11 jcfr Assigned To => jcfr
2014-09-09 14:11 jcfr Status assigned => acknowledged
2014-09-09 14:11 jcfr Target Version => Slicer 4.5.0-1
2014-09-09 14:11 jcfr Description Updated
2014-09-09 14:11 jcfr Relationship added child of 0003825
2014-09-09 14:13 jcfr Summary Ensure Estension are not using ITKV3 Compatibility code => Ensure Extensions are not using ITKV3 Compatibility code
2014-09-09 14:13 jcfr Description Updated
2014-09-09 14:18 jcfr Summary Ensure Extensions are not using ITKV3 Compatibility code => Ensure Extensions are not using ITKV3 Compatibility header
2014-09-09 14:19 jcfr Description Updated
2014-09-09 14:20 jcfr Description Updated
2014-09-09 14:25 jcfr Description Updated
2014-09-15 08:08 jcfr Note Added: 0012513
2015-05-11 20:23 jcfr Note Added: 0013041
2015-05-11 20:23 jcfr Status acknowledged => resolved
2015-05-11 20:23 jcfr Fixed in Version => Slicer 4.5.0-1
2015-05-11 20:23 jcfr Resolution open => fixed
2018-03-02 11:06 jcfr Status resolved => closed