Changesets: Import 2017-06-07 23:51:09
|
master a2defef9 2015-08-25 12:56:41 Details Diff |
ENH: update MultiVolumeExplorer git hash MultiVolumeExplorer has been refactored to facilitate reuse in other modules and to simplify user interface. Refactoring done by Christian Herz! git-svn-id: http://svn.slicer.org/Slicer4/trunk@24504 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild.cmake | Diff File | ||
|
master 3813945f 2015-08-21 08:37:31 Details Diff |
BUG: Fixed CastScalarVolume for unsigned char, int, long input git-svn-id: http://svn.slicer.org/Slicer4/trunk@24503 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/CastScalarVolume/CastScalarVolume.cxx | Diff File | ||
|
master 12ffd98a 2015-08-18 23:22:15 Details Diff |
BUG: Fixed crash caused in Model display node widget Slicer crashed when updated a filter pipeline that generated a polydata that was used by the model node. There was an infinite loop (and stack overflow) caused by automatically selecting the first scalar attribute when the polydata is regenerated by the pipeline. Fixed by allowing having 'none' selected as displayed scalar in the model widget and therefore avoiding automatic scalar selection when scalars are added to the data set and so avoiding infinite loop. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24502 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLModelDisplayNode.h | Diff File | ||
| mod - Modules/Loadable/Models/Widgets/qMRMLModelDisplayNodeWidget.cxx | Diff File | ||
| mod - SuperBuild/External_CTK.cmake | Diff File | ||
|
master 7259b58a 2015-08-18 10:32:27 Details Diff |
BUG: Fix running DataProbe self test This commit fixes the following error when running the DataProbe self test from the SelfTests module: Starting the test Traceback (most recent call last): File "C:/dev/SN/Slicer-build/lib/Slicer-4.4/qt-scripted-modules/SelfTests.py", line 168, in run result = self.selfTests[test]() File "C:/dev/SN/Slicer-build/lib/Slicer-4.4/qt-scripted-modules/DataProbe.py", line 46, in runTest tester.runTest() File "C:/dev/SN/Slicer-build/lib/Slicer-4.4/qt-scripted-modules/DataProbe.py", line 611, in runTest self.test_DataProbe1() File "C:/dev/SN/Slicer-build/lib/Slicer-4.4/qt-scripted-modules/DataProbe.py", line 637, in test_DataProbe1 if not os.path.exists(filePath) or os.stat(filePath).st_size == 0: NameError: global name 'os' is not defined From: Max Smolens <max.smolens@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24501 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/DataProbe/DataProbe.py | Diff File | ||
|
master 14bc3745 2015-08-14 20:10:09 Details Diff |
BUG: Fixed crash when opening save dialog with node names starting with "#:" Where # is not a drive letter, but a number, for example in case of DICOM series numbers. This commit fixes the scenario described in issue 3991, with the additional condition that the node was loaded from file. Re 0003991 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24500 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTGUI/qSlicerSaveDataDialog.cxx | Diff File | ||
|
master d3ecc7d7 2015-08-14 17:33:34 Details Diff |
BUG: Fixed inverse TPS transform saving Basis function type check failed when trying to save inverse transforms git-svn-id: http://svn.slicer.org/Slicer4/trunk@24499 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkITKTransformConverter.h | Diff File | ||
|
master c3993e57 2015-08-13 18:21:47 Details Diff |
BUG: Fix running self tests for scripted modules generated by Extension Wizard An error occurs when running the self tests for certain scripted modules through the SelfTests module GUI. For example, running the SurfaceToolbox self test results in: NameError: name 'SurfaceToolboxTest' is not defined The affected modules are those that inherit from ScriptedLoadableModule. That includes all modules generated by Extension Wizard; see the template. This commit fixes how ScriptedLoadableModule finds and instantiates the self test. Additionally, for consistency with the above change, this commit changes how the ScriptedLoadableModuleWidget runs the self test when the user clicks "Reload and Test". From: Max Smolens <max.smolens@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24498 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/Python/slicer/ScriptedLoadableModule.py | Diff File | ||
|
master 968cf935 2015-08-13 14:05:37 Details Diff |
ENH: Made transforms module translate-rotate first icon nicer The rotate icon is reused from another Slicer icon and a similar color and style translate icon is added git-svn-id: http://svn.slicer.org/Slicer4/trunk@24497 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Transforms/Resources/Icons/RotateFirst.png | Diff File | ||
| mod - Modules/Loadable/Transforms/Resources/Icons/TranslateFirst.png | Diff File | ||
| mod - Modules/Loadable/Transforms/Resources/UI/qSlicerTransformsModuleWidget.ui | Diff File | ||
|
master 2ffc0380 2015-08-12 21:09:18 Details Diff |
ENH: Improved transform copy-paste Added [] characters to the characters that are removed when pasting a transform (numpy arrays have a lot of them). Added tooltip to Copy and Paste buttons. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24496 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.cxx | Diff File | ||
|
master d21bacd7 2015-08-12 00:35:17 Details Diff |
ENH: SimpleMarkupsWidget: Add property to control place mode behavior This commit adds a boolean property named "EnterPlaceModeOnNodeChange" to control behavior of entering place mode when active node is changed. By default the property is enabled. From: Adam Rankin <adam.rankin@gmail.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24495 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/Markups/Widgets/qSlicerSimpleMarkupsWidget.cxx | Diff File | ||
| mod - Modules/Loadable/Markups/Widgets/qSlicerSimpleMarkupsWidget.h | Diff File | ||
|
master 237fac92 2015-08-11 23:13:48 Details Diff |
COMP: Update ITK to fix Slicer MacOSX extension packaging. Fixes 0004029 // ------------------ commit 0905a43149320d8c2993e83ecf6c8a9d6b2b4232 Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Date: Tue Aug 11 22:53:36 2015 -0400 COMP: Fix Slicer MacOSX extension packaging setting CMP0042 policy to OLD Most likely because the version of CMake used on the factory has been updated from CMake 2.8.12 to CMake 3.0.2, Slicer extension packaging was failing. Waiting the packaging of extension on MacOSX is improved to directly leverage CMake 3.x to set @rpath appropriately for both build and install tree, this commit reverts the policy to OLD. // ------------------ git-svn-id: http://svn.slicer.org/Slicer4/trunk@24494 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_ITKv4.cmake | Diff File | ||
|
master a1b0691e 2015-08-11 19:09:33 naucoin Details Diff |
ENH: check for data that will get deleted on scene view restore Added a flag to the scene view node restore call that will cancel if any nodes come up as being in the main Slicer scene but not in the scene view scene about to be restored. Added a method to add nodes to the scene view scene that are in the main Slicer scene but not in the scene view. Updated the GUI for restoring scenes via the tool bar and the Scene Views module to pop up message boxes to give the user options to discard the data, add it to the scene view, or cancel the restore. Updated the test to include a failure case when removing nodes is not allowed. Unify scene view node to use SafeDownCast instead of a mix of dynamic_cast and SafeDownCast. Issue 0003956 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24493 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLSceneViewNode.cxx | Diff File | ||
| mod - Libs/MRML/Core/vtkMRMLSceneViewNode.h | Diff File | ||
| mod - Libs/MRML/Widgets/qMRMLSceneViewMenu.cxx | Diff File | ||
| mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.cxx | Diff File | ||
| mod - Modules/Loadable/SceneViews/Logic/vtkSlicerSceneViewsModuleLogic.cxx | Diff File | ||
| mod - Modules/Loadable/SceneViews/Logic/vtkSlicerSceneViewsModuleLogic.h | Diff File | ||
| mod - Modules/Loadable/SceneViews/Testing/Python/AddStorableDataAfterSceneViewTest.py | Diff File | ||
|
master 9c268ea2 2015-08-11 18:44:51 Details Diff |
BUG: fix creating new extension Wrong variable was being checked for directory existence. Creates new directory in selected target. This commit fixes a regression introduced in r24452 (BUG: Fixed extension creation in version-controlled repository ) see - https://github.com/Slicer/Slicer/pull/320 From: Steve Pieper <pieper@bwh.harvard.edu> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24492 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Scripted/ExtensionWizard/ExtensionWizard.py | Diff File | ||
|
master b99ff999 2015-08-11 18:44:45 naucoin Details Diff |
BUG: Update CTK (update message box don't show again) Among other changes it updates ctkMessageBox to include the text on the button that will be the default if the don't show again option is checked. > git shortlog 7081550..e0c8fd5 --no-merges Andreas Fetzer (1): Fixed another qt 5.5 build error Nicole Aucoin (1): ENH: Give more information for not showing the message box again Issue 0003965 git-svn-id: http://svn.slicer.org/Slicer4/trunk@24491 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_CTK.cmake | Diff File | ||
|
master dc4de1de 2015-08-10 19:21:09 Details Diff |
COMP: Fix build error in External_DCMTK.cmake Reported-by: Erich Bremer <erich.bremer@stonybrook.edu> Thanks: Steve Pieper <pieper@bwh.harvard.edu> This commit fixes a regression introduced in r24483 (BUG: fix support for DCMTK DICOM dictionaries) where a line continuation character is used. It turns out that this character caused parsing issue with older version of CMake (< v3.0.0) //------------------------------- CMake Error at SuperBuild/External_DCMTK.cmake:99 (set): Syntax error in cmake code at /home/erich/MyProjects/trunk/SuperBuild/External_DCMTK.cmake:100 when parsing string DCMDICTHOME=<APPLAUNCHER_DIR>/${Slicer_SHARE_DIR}/dicom.dic<PATHSEP>\ <APPLAUNCHER_DIR>/${Slicer_SHARE_DIR}/private.dic syntax error, unexpected cal_SYMBOL, expecting $end (89) Call Stack (most recent call first): CMake/ExternalProjectDependency.cmake:593 (include) SuperBuild/External_ITKv4.cmake:14 (ExternalProject_Include_Dependencies) CMake/ExternalProjectDependency.cmake:593 (include) CMake/ExternalProjectDependency.cmake:639 (ExternalProject_Include_Dependencies) SuperBuild.cmake:323 (ExternalProject_Include_Dependencies) CMakeLists.txt:670 (include) //------------------------------- git-svn-id: http://svn.slicer.org/Slicer4/trunk@24490 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_DCMTK.cmake | Diff File | ||
|
master b32f835e 2015-08-10 10:48:49 Details Diff |
BUG: FiberBundleLabelSelect 1) Fixing the bug from ADD operation for ‘Label to include’ 2) Fixing the module so that it takes both VTK and VTP when being used as CLI MANTIS issue link: http://www.na-mic.org/Bug/view.php?id=4025 From: zhangfanmark <zhangfanmark@gmail.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24489 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/CLI/FiberBundleLabelSelect/FiberBundleLabelSelect.cxx | Diff File | ||
|
master 3107a89e 2015-08-08 11:45:28 Details Diff |
BUG: Fixed unitended volume rendering display node sharing issue Problem: When a volume rendering display node does not exist the VR widget picks up the first available node (because None option is not enabled in the selector widget) Fix: allow None option to prevent assigning the same display nodes to multiple volumes. Problem: vtkMRMLVolumeRenderingDisplayNode is abstract, therefore adding a node from the widget always fails. Fix: disable add node option in the display node selector widget git-svn-id: http://svn.slicer.org/Slicer4/trunk@24488 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/VolumeRendering/Resources/UI/qSlicerVolumeRenderingModuleWidget.ui | Diff File | ||
|
master 495c9d4d 2015-08-08 11:41:18 Details Diff |
BUG: Fixed volume rendering not visible when non-volume-rendered volume is frequently changing in the scene The issue caused volume rendering result not visible when a live 2D ultrasound image was kept updating in the scene through OpenIGTLink. Fix: VR displayable manager is notified about the change of all volume nodes that have a VR display node, but we now only request render if the currently volume-rendered volume node is changed. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24487 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/VolumeRendering/MRMLDM/vtkMRMLVolumeRenderingDisplayableManager.cxx | Diff File | ||
|
master 83f96216 2015-08-05 14:39:13 Details Diff |
STYLE: Replaced assert to logging error in labelmap volume display node git-svn-id: http://svn.slicer.org/Slicer4/trunk@24486 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLLabelMapVolumeDisplayNode.cxx | Diff File | ||
|
master 9efd5856 2015-08-05 11:56:12 Details Diff |
BUG: Fix Extension Wizard to write icon files correctly on Windows On Windows, slicerExtensionWizard creates invalid icon files for extensions and modules. This happens because the script treats all template files as text when opening them to replace the template key, including the PNG icon files. This changes the script to open and write files in binary mode. Fixes 0004027. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24485 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Utilities/Scripts/SlicerWizard/TemplateManager.py | Diff File | ||
|
master 63c09f04 2015-08-04 18:18:42 Details Diff |
BUG: Update VTK - Re-enable GPU VR on Mac fixing a Slicer/VTK rebase mistake This commit (1) reverts Slicer specific commit disabling the failing color transfer function improvements and include the fix done by Cory. (2) re-enable GPU volume rendering on MacOSX fixing a rebase mistake introduced in r24461 (ENH: Update VTK to master (soon to be v6.3.0) and also update CTK) // -------------- $ git log --no-merges d645b35..716b0f5 commit 716b0f56fc4bd4b9fcca05f386ec375bcd674122 Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Date: Tue Aug 4 17:49:39 2015 -0400 Fix error preventing GPU volume rendering from working on MacOSX This commit fixes error introduced when rebasing commit Slicer/VTK@add058e (Enable GPU Raycast volume mapper for recent NVIDIA drivers on Mac OS X) commit 74733a0e7d5dd55f5eb52ca411c06ecbb3431ed2 Author: Cory Quammen <cory.quammen@kitware.com> Date: Thu Jul 23 22:45:26 2015 -0400 Fix crash where vtkColorTransferFunction has 0 nodes Thanks to Jean-Christophe Fillion-Robin for pointing this out. See https://github.com/Slicer/Slicer/commit/f59a689a0f6d2912538ed72dad16efc70601f0ed#commitcomment-9407867 for reference. A basic test for vtkColorTransferFunction is added that crashes prior to this patch and succeeds with this patch. Tested-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> commit 7b51a097aead0c872f199a2039d010f28c96e2f5 Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com> Date: Tue Aug 4 15:08:41 2015 -0400 Re-enable "6657: Add out-of-range colors to color maps" This reverts commit Slicer/VTK@d645b35. Thanks: Cory Quammen <cory.quammen@kitware.com> // -------------- git-svn-id: http://svn.slicer.org/Slicer4/trunk@24484 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - SuperBuild/External_VTKv6.cmake | Diff File | ||
|
master 4d3e2d41 2015-08-03 23:52:36 Details Diff |
BUG: fix support for DCMTK DICOM dictionaries See issue 4013, followup on commit 24473. Dictionaries passed to DCMTK in DCMDICPATH override embedded dictionaries, and standard dictionary needs to be specified together with the private one, as shown in example here: http://support.dcmtk.org/redmine/projects/dcmtk/wiki/Howto_Dictionaries This commit installs dicom.dic and initializes the environment variable. git-svn-id: http://svn.slicer.org/Slicer4/trunk@24483 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Base/QTCore/qSlicerCoreApplication.cxx | Diff File | ||
| mod - CMake/SlicerBlockInstallDCMTKResources.cmake | Diff File | ||
| mod - SuperBuild/External_DCMTK.cmake | Diff File | ||
|
master 8be42874 2015-08-03 23:43:54 Details Diff |
BUG: Ensure volume rendering is updated when volume geometry is modified. Fixes 0004023 From: Adam Rankin <adam.rankin@gmail.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24482 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Modules/Loadable/VolumeRendering/MRMLDM/vtkMRMLVolumeRenderingDisplayableManager.cxx | Diff File | ||
|
master 2014474a 2015-08-03 23:43:52 Details Diff |
STYLE: Remove erroneous comments in vtkMRMLVolumeNode.cxx This commit removes incorrect comment originally introduced in r23524 (BUG: Propagate ModifiedEvent to volume/modelNode) From: Adam Rankin <adam.rankin@gmail.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24481 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLVolumeNode.cxx | Diff File | ||
|
master 4505f8ac 2015-08-03 23:43:50 Details Diff |
STYLE: Remove obsolete comments in vtkMRMLVolumeNode.h Clean-up comment that became obsolete following refactoring done in r3955 (ENH: made Volume and Model nodes derived from vtkMRMLDisplayableNode) From: Adam Rankin <adam.rankin@gmail.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@24480 3bd1e089-480b-0410-8dfb-8563597acbee |
||
| mod - Libs/MRML/Core/vtkMRMLVolumeNode.h | Diff File | ||
