View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004023Slicer4Core: Renderingpublic2015-07-29 11:252018-03-02 11:07
Reporterrankin Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.4.0 
Target VersionFixed in VersionSlicer 4.5.0-1 
Summary0004023: Volume rendering does not account for IJKtoRAS matrix within a vtkMRMLScalarVolumeNode
Description

As per summary.

To reproduce:

Load sample data (I used MRHead)
Volume Rendering -> GPU (CPU same issue) -> Turn on 3d view
Volumes -> (expand) Volume Information -> Modify Image Origin in any way
Volume rendering is not updated

Additional Information

After changing the Image Origin under Volumes, and returning to Volume Rendering module and "wiggling" the shift slider, the volume rendering updates the position of the MRHead in 3 space, which leads me to believe it's a Modified issue, and not a transform ignored issue

TagsNo tags attached.

Activities

rankin

rankin

2015-07-29 12:13

reporter   ~0013201

I have created a fix but I am not sure if it is the correct way to fix it.

How can I upload my proposed solution for people to analyze?

Essentially the function
vtkMRMLVolumeRenderingDisplayNode::SetAndObserveVolumeNodeID
did not actually observe the volume node.

I added the observation and forwarding of the modified event in
vtkMRMLVolumeRenderingDisplayNode::ProcessMRMLEvents

2015-07-29 12:13

 

vtkMRMLVolumeRenderingDisplayNode.cxx (14,594 bytes)
rankin

rankin

2015-07-29 12:14

reporter   ~0013202

Last edited: 2015-07-29 13:57

<removed>

Better solution incoming
rankin

rankin

2015-07-29 12:34

reporter   ~0013203

Last edited: 2015-07-29 13:56

<removed>

Better solution incoming
jcfr

jcfr

2015-08-03 20:15

administrator   ~0013211

Fixed in r24482

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=24482

Related Changesets

Import 2017-06-07 23:51:09: master 8be42874

2015-08-03 23:43:54

jcfr

Details Diff 		BUG: Ensure volume rendering is updated when volume geometry is modified.

Fixes 0004023

From: Adam Rankin <adam.rankin@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24482 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/VolumeRendering/MRMLDM/vtkMRMLVolumeRenderingDisplayableManager.cxx Diff File

Issue History

Date Modified Username Field Change
2015-07-29 11:25 rankin New Issue
2015-07-29 11:25 rankin Status new => assigned
2015-07-29 11:25 rankin Assigned To => jcfr
2015-07-29 12:13 rankin Note Added: 0013201
2015-07-29 12:13 rankin File Added: vtkMRMLVolumeRenderingDisplayNode.cxx
2015-07-29 12:14 rankin Note Added: 0013202
2015-07-29 12:34 rankin Note Added: 0013203
2015-07-29 13:56 rankin Note Edited: 0013203
2015-07-29 13:57 rankin Note Edited: 0013202
2015-08-03 20:15 jcfr Note Added: 0013211
2015-08-03 20:15 jcfr Status assigned => resolved
2015-08-03 20:15 jcfr Fixed in Version => Slicer 4.4.1
2015-08-03 20:15 jcfr Resolution open => fixed
2015-09-09 08:29 jcfr Fixed in Version Slicer 4.4.1 => Slicer 4.5.0-1
2017-06-10 08:51 jcfr Changeset attached => Slicer master 8be42874
2018-03-02 11:07 jcfr Status resolved => closed